Commit Graph

14230 Commits

Author SHA1 Message Date
Yunfan Li
7e8c2d2887 Fix continuous integration workflow 2024-09-12 22:52:49 +08:00
Yunfan Li
9973151927 Merge branch 'master' into Playerbot 2024-09-12 22:49:08 +08:00
Grimdhex
4254827b2c Revert "chore(Debug/Scripting): improve debug errors during the unloading scripts (#19643)" (#19951)
This reverts commit db7183a573.

*wrongly use to catch sigsegv
*null check isn't necessary: https://en.cppreference.com/w/cpp/memory/new/operator_delete
2024-09-12 08:05:12 -03:00
Grimdhex
20b443e011 refactor(Scripts/TempestKeep): remove an dev residual from Kael'Thas revamp (#19950)
refactor(Scripts/TempestKeep): remove an dev rest from my last PR with Keal'Thas
2024-09-12 07:58:18 -03:00
Grimdhex
5ae1473e30 fix(Scripts/BlackTemple): Ajust Judgment timers and pass all the script to std::chrono (#19945)
fix(Scripts/BT): ajust Judgment timers and pass all the script to std::chrono
2024-09-12 06:11:56 -03:00
Saqra1
321ac4a8c2 fix(Core/Spell): Summoning Portal position (#19705)
* fix(Core/Spell): Summoning Portal position

Summoning Portal is created in front of the caster but it is still too
close to them. Move it away a bit.

* Cleanup unused SpellInfo correction

Spell 61994 was stopped being used for summons in favor of 23598 on:
67010623a0
2024-09-11 12:37:56 -03:00
Saqra1
4734582e58 fix(Core/Spell): Refreshment Table position (#19704)
Refreshment Table game object should be created at the same position its
Refreshment Portal was created.
2024-09-11 11:53:07 -03:00
Benjamin Jackson
edd7e10dfc fix(Core/Spells): Resolve a case of triggered spells prolonging combat. (#19819)
* Init.

* Expand trigger info check.

* Enclose evaluation in parentheses.

Maybe workflow will be happy?
2024-09-11 11:52:15 -03:00
Stefano Borzì
d17c179c03 chore: remove unused hooks (#19919) 2024-09-11 11:50:59 -03:00
Stefano Borzì
a971f373a0 fix: default bgarenas visibility distance default value (#19938)
* fix: default bgarenas visibility distance default value

* chore: update worldserver.conf.dist
2024-09-11 11:50:45 -03:00
Grimdhex
56d2cc7b4c refactor(Cote/Unit): cleanup - part2 (#19821)
* fix(Core/AI): remove an unused variable

* Move variables at the end of each sections

* reorder several methods

* remove few inline defintions

* few codestyle fixes
2024-09-11 11:50:24 -03:00
github-actions[bot]
30e77ae880 chore(DB): import pending files
Referenced commit(s): 0ac7ab03bb
2024-09-11 14:20:11 +00:00
Grimdhex
06cf2cdf42 fix(DB/SAI): Missings spells for few creatures in Blade's Edge Mountains (#19617)
*timer estimations done on retail
2024-09-11 11:19:51 -03:00
Mershl
0ac7ab03bb fix(Scripts/UBRS): increase Drakkisath's conflagrate interval from 10s..13s to 18s..25s, avoiding near infinite CC chains (#19806)
fix(Scripts/UBRS): increase Drakkisath's conflagrate interval from 10..13s to 18s..25s, avoids infinite CC chains (conflagrate is a 10s CC)
2024-09-11 11:19:14 -03:00
Stefano Borzì
f6e9bd51fd feat(ScriptMgr): add OnArenaStart hook (#19922) 2024-09-11 11:18:36 -03:00
Saqra1
c42b3ee258 fix(Core/Pet): Control Infernal without enslave (#19784)
Check SummonProperties Category(Control) too to decide the type of
controls a Guardian should have.

Don't enslave Warlock's Infernal
2024-09-11 11:18:13 -03:00
github-actions[bot]
c1296d0b14 chore(DB): import pending files
Referenced commit(s): eb0cfb79cc
2024-09-11 08:44:17 +00:00
Mattia
eb0cfb79cc fix(DB/Creature) Black Temple - Shadowmoon Blood Mages dont use Blood… (#19812)
* fix(DB/Creature) Black Temple - Shadowmoon Blood Mages dont use Blood Siphon ability

* SQL query refactored

* fix: backticks added
2024-09-11 05:43:19 -03:00
Benjamin Jackson
00e35a201e fix(Core/AI): Reduce movement leash extension interval. (#19923)
* Init.

* Use GetGameTime() instead of system call.

Co-Authored-By: Anton Popovichenko <walkline.ua@gmail.com>

* Update leash timer if rooted.

* Remove unnecessary checks, add extension for fanning.

More parity with VMaNGOS implementation.

---------

Co-authored-by: Anton Popovichenko <walkline.ua@gmail.com>
2024-09-11 03:25:32 -03:00
github-actions[bot]
cbd74ae663 chore(DB): import pending files
Referenced commit(s): 56e03c495d
2024-09-09 10:46:15 +00:00
Andrew
56e03c495d fix(Scripts/BlackTemple): Shade of Akama should despawn on evade and Akama despawns before dying (#19894)
* fix(Scripts/BlackTemple): Shade of Akama should despawn on evade and Akama despawns before dying

* Create rev_1725714358950337100.sql

* Update boss_shade_of_akama.cpp
2024-09-09 12:45:23 +02:00
天鹿
fafd351e44 fix(Core/AI): creature leashing behavior. (#19897)
* Update Unit.cpp

* Update TargetedMovementGenerator.cpp

* Update Unit.cpp

* Update Unit.cpp
2024-09-09 07:07:11 -03:00
Benjamin Jackson
b47b5d2c51 fix(Core/AI): Initialize movement leash timer to five seconds. (#19898)
Init.

https: //github.com/vmangos/core/commit/c8510cbbd4dccbdac9900cc507910ef3ae0e6c43

Co-authored-by: ratkosrb <35845488+ratkosrb@users.noreply.github.com>
2024-09-08 21:44:09 -03:00
Benjamin Jackson
cdc00b42bd fix(Core/AI): Add back leash update. (#19916)
Init.
2024-09-08 20:49:28 +02:00
Stefano Borzì
0dd5c6e3b4 feat(Battlegrounds): make it compatible with custom arena type (#18679)
* feat(Battlegrounds): make it compatible with custom arena type

* fix(BattlegroundQueue.cpp): ignore bg for arena condition

* feat(Scripting): add OnQueueUpdateValidity hook

* fix: codestyle
2024-09-08 20:05:58 +02:00
kissingers
cf95c1dfbd fix(Scripts/ZulAman): Nalorakk sometimes not move when player close (#19893)
* Fix nalorakk sometimes not move when player close

* init _phase

* Revert "Fix nalorakk sometimes not move when player close"

This reverts commit b42cd4634bb4ffd225eaa7480428c6ba6b4817c6.
2024-09-07 15:39:31 +02:00
Andrew
7eee1345d0 fix(Scripts/BlackTemple): Gurtogg Bloodboil shouldnt cast bloodboil o… (#19886)
fix(Scripts/BlackTemple): Gurtogg Bloodboil shouldnt cast bloodboil on phase 2 and shouldnt chase immune targets
2024-09-07 07:05:43 -03:00
天鹿
dc4c874206 fix(Scripts/BlackTemple): blade_of_azzinoth...and Possible crash (#19891)
* Update boss_illidan.cpp

* Update boss_illidan.cpp
2024-09-07 07:05:18 -03:00
Yunfan Li
6f5b504e4c Merge branch 'master' into Playerbot 2024-09-07 14:27:11 +08:00
天鹿
e7448f2986 fix(Scripts/Commands): .gps formatting transport offset (#19890)
* Update cs_misc.cpp

* Update PlayerUpdates.cpp
2024-09-07 01:03:41 -03:00
天鹿
dd2167b00b fix(Core/AI): Creature SetInCombatState Leashing. (#19889)
* Update Unit.cpp

* Update pit_of_saron.cpp

* Update Unit.cpp
2024-09-07 01:03:19 -03:00
Andrew
78d40e4078 fix(Scripts/BlackTemple): Remove Shear from Illidan following wrath p… (#19881)
fix(Scripts/BlackTemple): Remove Shear from Illidan following wrath patch changes
2024-09-06 20:41:36 -03:00
Jelle Meeus
89b08dd5dc fix(Scripts/Commands): .gps formatting transport offset (#19888)
fix transport offset
2024-09-06 19:43:12 -03:00
Benjamin Jackson
632d7f5f9e fix(Core/Unit): Add leash extension with damage dealt. (#19880)
Init.
2024-09-06 17:02:53 -03:00
Ben Carter
6e5cd04591 fix(docker): Modules SQL do not get updated or populated for docker set ups (#19870)
* Added modules to dbimport so sql cab accessed by loader

* updated dbimport tools config option to enable module sql to be updated and populated

* Updated casting around GetOption and changed default to all
2024-09-06 12:37:00 -03:00
天鹿
9dae87595d fix(Core/Creature): Creature Scale. (#19722)
Update Creature.cpp
2024-09-05 11:56:17 -03:00
github-actions[bot]
d1f77ae60c chore(DB): import pending files
Referenced commit(s): fa490c21e9
2024-09-05 13:17:25 +00:00
Gultask
fa490c21e9 fix(Scripts/BlackTemple): Rewrite Illidan Stormrage Fight (#19574)
* Create rev_1722993051676997100.sql

* akama done

* Update boss_illidan.cpp

* maiev

* sssssssssllllll

* blerg

im sick irl

* door handel

* Update boss_illidan.cpp

* minions

* Update boss_illidan.cpp

* unneeded

* Update boss_illidan.cpp

* Update boss_illidan.cpp

* meow

* Update boss_illidan.cpp

* Update boss_illidan.cpp

* Update boss_illidan.cpp

* demon_phase

missing:
tear of azzinoth
trap + frenzy
flying phase wipe + animation

* akama's ending not working still

* Update boss_illidan.cpp

* Update boss_illidan.cpp

flying animation
akama isn't returning to complete the ending

* akama ending fixed

* cleanup

* Update boss_illidan.cpp

* Update boss_illidan.cpp
2024-09-05 10:16:26 -03:00
天鹿
19264bea0b Fix(Core/Misc): Acore::StringFormat to fmt format (#19867)
Update MMapMgr.cpp
2024-09-05 06:54:44 -03:00
Yunfan Li
414805e692 Merge branch 'master' into Playerbot 2024-09-04 23:46:34 +08:00
Stefano Borzì
e5e514bbbe feat(Core/Scripting): add OnBeforeArenaCheckWinConditions hook for mod-arena-replay compatibility (#19856) 2024-09-04 10:33:38 -03:00
Benjamin Jackson
bf18b9bdfb fix(Core/AI): Improve creature leashing behavior. (#19751)
* Init.

https: //github.com/vmangos/core/commit/7d2f1e2923734ea1b983eeaa0208cfd158d4af02
Co-Authored-By: ratkosrb <35845488+ratkosrb@users.noreply.github.com>

* Hackfix for pets.

* Whoops.

* Correct evade uses.

* Conflict.

* Actually fix grace timer.

* Add visibility distance check.

Creatures should always fail combat checks in the open world if they're outside of visibility distance, might not be the case for worldbosses.

---------

Co-authored-by: ratkosrb <35845488+ratkosrb@users.noreply.github.com>
2024-09-03 21:08:56 +02:00
Benjamin Jackson
1edac37ac3 refactor(Core): Make more use of helpers. (#19835)
* Init.

* Reword.

* Update codestyle script.

Co-Authored-By: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* Add gameobject type ID check, reorder checks.

* Add helper/codestyle check for unit type.

* `IsUnit()` -> `IsCreature()`

* Add `IsUnit()` method.

* Use type mask.

https: //github.com/TrinityCore/TrinityCore/commit/cc71da35b5dc74abf71f8691161525a23d870bb5
Co-Authored-By: Giacomo Pozzoni <giacomopoz@gmail.com>
Co-Authored-By: Ovahlord <18347559+Ovahlord@users.noreply.github.com>

* Replace instances of `isType` with `IsUnit`.

---------

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
Co-authored-by: Ovahlord <18347559+Ovahlord@users.noreply.github.com>
2024-09-03 14:41:31 -03:00
Benjamin Jackson
e3e4133e88 fix(Core/Handlers): Only remove emote if player is moving. (#19740)
Init.
2024-09-03 13:12:32 -03:00
github-actions[bot]
b0ddca234d chore(DB): import pending files
Referenced commit(s): 9999a80c96
2024-09-03 16:08:30 +00:00
Anton Popovichenko
9999a80c96 feat(Core/Achievements): Add possibility to complete achievements and update achievement criteria for offline players. (#19851) 2024-09-03 13:05:23 -03:00
Grimdhex
221dbd3fdb chore(Apps/Codestyle): add new codestyle checks for pointers and range loops (#19841)
* chore(Apps/Codestyle): add new codestyle checks for pointers and range loops

* revert a typo
2024-09-03 13:02:38 -03:00
sudlud
c929b95172 fix(Conf): sync default values with core defaults (#19708)
fix(Conf): sync values with core defaults
2024-09-03 08:02:28 -03:00
Kitzunu
9af86553c5 chore(Core/Misc): update floor and ceil to std (#19837) 2024-09-03 08:01:00 -03:00
Kitzunu
de2bcbdabf refactor(Core/Misc): Acore::StringFormat to fmt format (#19838)
refactor(Core/Utilities): Acore::StringFormat to fmt format

* closes https://github.com/azerothcore/azerothcore-wotlk/issues/10356
2024-09-03 07:59:37 -03:00