Nathan Handley
df33a57b78
feat(Core/Unit): New helper IsClass and script hook OnPlayerIsClass ( #18243 )
...
* Class Comparison Logic Encapsulation - Parity
* Add Context to IsClass
* Add Unit IsClass script hook
* Replace additional getClass with IsClass
* Update CanUseItem to replace getClass with IsClass
* Add separate context for pet vs ability
* Change Create to Init since not all referenced contexts are creation
* Align spacing in ClassContext
* Drop context on LFGManager max power
* Update IsClass context that wraps around Missle Barrage
* Rename context for swapping weapons
* Be more specific than CLASS_CONTEXT_TALENT
* Remove duplicate context
* Moved IsClass Hook to Player
* Removed unused parameter in virtual base function
* Added maybe_unused to IsClass virtual in order to compile
To match the override signature, the virtual base needs to include the parameter in question, so using [maybe_unused] to signal to the compiler to allow it
* Remove extra blank line
* Add ABILITY_REACTIVE context
* Add context for PET_CHARM
* Remove explicit nullopt check per review
* Code Readability - Change if to if else in pet
Due to the return pattern, this doesn't change functionality in any way
* Add OnPlayer to disambiguate
---------
Co-authored-by: NathanHandley <nathanhandley@protonmail.com >
2024-02-10 12:25:00 -03:00
Nathan Handley
425a490a7b
feat(Core/Unit): New helper HasActivePowerType and script hook OnPlayerHasActivePowerType ( #18293 )
...
* Create HasActivePower for script intercept
* Replace relevant player-related getPowerType() comparators with HasActivePowerType
* Change OnPlayerHasActivePowerType to regular bool instead of optional
---------
Co-authored-by: NathanHandley <nathanhandley@protonmail.com >
2024-02-09 06:27:02 -03:00
Kalimist
1324f420f2
Fix(Core/CharacterHandler): Incorrect behavior using an equipment set… ( #18253 )
...
* Fix(Core/CharacterHandler): Incorrect behavior using an equipment set if it will result in a full inventory.
* Fixing the error message to -Equiment swap failed - inventory is full- like the Blizzlike error message
2024-02-03 14:34:33 +01:00
sudlud
1785df7117
fix(Core/Player): Fix Player not starting at full health ( #18136 )
...
* fix(Core/Player): Fix Player not starting at full health
* remove first call to UpdateMaxHealth() and SetFullHealth()
2024-01-14 11:07:52 -03:00
Kitzunu
bceb6173c2
fix(Core/Player): Sometimes Player whisper is sent as boss whisper ( #18128 )
...
* fix(Core/Player): Sometimes Player emot is sent as boss whisper
* actually change it to whisper as it is boss whisper
* Update Player.cpp
2024-01-07 12:14:20 -03:00
Kitzunu
6202835cff
fix(Core/LFG): Hide XP from max players ( #18103 )
...
* Cherry-pick Player::IsMaxLevel from TrinityCore
* Correctly hide XP reward for max level players in LFG
* Closes #18101
2024-01-03 19:47:26 +01:00
Andrew
f9f71fff36
fix(Core/Player): Check if the player can summon the warlock pet on B… ( #18064 )
...
fix(Core/Player): Check if the player can summon the warlock pet on BG ress
2024-01-01 14:56:32 +01:00
IntelligentQuantum
9f1abf1214
chore(Core/Entities): remove useless includes ( #17994 )
2023-12-12 01:36:35 -03:00
avarishd
f476c8a6c9
feat(Core/Hooks): Add OnPlayerJustDied hook ( #17973 )
...
feat(Core/Hooks): Add OnPlayerJustDied
2023-12-10 19:06:23 -03:00
Tristan 'Natrist' Cormier
ac676f87ab
chore(Core/Player): remove unused AnticheatSetSkipOnePacketForASH() function ( #17947 )
2023-12-09 01:09:52 +01:00
Winfidonarleyan
eb1ecc38a5
feat(Core/Scripting): move all script objects to separated files ( #17860 )
...
* feat(Core/Scripts): move all script objects to separated files
* Apply 5bfeabde81
* try gcc build
* again
2023-12-02 21:13:20 +01:00
Kitzunu
5bfeabde81
chore(Core/Misc): rename spellInfo pointers ( #17914 )
...
* Rename all
2023-12-02 06:03:15 -03:00
Tristan 'Natrist' Cormier
4c94f62144
chore(Core/Account): move AccountMgr::IsGMAccount() to class WorldSession ( #17845 )
2023-11-28 21:44:48 +01:00
Kitzunu
f440a7479f
fix(Core/Groups): Create the group at first invite ( #17869 )
...
* cherry-pick commit (132538db1d )
* cherry-pick commit (250e8d998b )
* part https://github.com/azerothcore/azerothcore-wotlk/issues/11070
Co-authored-by: Treeston <14020072+Treeston@users.noreply.github.com >
2023-11-26 20:34:45 +01:00
Winfidonarleyan
e90d7a2f92
chore(Core/Misc): sort includes ( #17776 )
...
* chore(Cleanup): sort includes
* fix build
* fix build again
2023-11-18 17:51:26 +01:00
Kitzunu
bbadc32bea
Revert Visibility Notifier changes ( #17682 )
...
* Revert "fix(Core/Grid): Implement missing GridUnload setting (#17569 )"
This reverts commit 79b39f9655 .
* Revert "fix(Core/Grid): Address bugs and performance issues introduced by visibility notifier implementation (#17480 )"
This reverts commit 60e27511c5 .
* Revert "fix(Core): GridCleanUpDelay Log (#17436 )"
This reverts commit 90b16ca065 .
* Revert "feat(Core/Grids): Implement visibility notifier (#15919 )"
This reverts commit 2779833768 .
2023-11-12 00:48:49 +01:00
KJack
f417a166bc
feat(Core/Scripts): added OnAfterSpecSlotChanged hook ( #17637 )
2023-11-07 23:46:08 +07:00
Kitzunu
f757e93da5
refactor(Core/Misc): Make DeathState enum class ( #17607 )
2023-10-28 10:54:03 +02:00
AG
60e27511c5
fix(Core/Grid): Address bugs and performance issues introduced by visibility notifier implementation ( #17480 )
...
* Bug fixes
- Corrected std::chrono from seconds to milliseconds
- Got rid of leftover code that caused objects to not show up on time
* Removed logic to set gameobject as active
- More alignement with TC.
- Reduces CPU usage drastically
* Revert back to using time_t instead of std chrono
* Invoke SetNoCreate() method to reduce CPU usage drastically
* Remove setActive from static and motion transports
* Fix performance issues
* Added SetFarVisible to WG and some dungeon scripts
- Also removed setActive(true) from creatures in Wintergrasp. As for gameobjects they are set to active upon being damaged/destroyed and removed from active on rebuild (reset)
* Removed comments related to VISIBILITY_COMPENSATION
* Fix log
* Deleted unused files + corrected a check
* Added missing header
* Removed unused parameter
* Removed another unsued parameter
* Changed vector to set for i_visibleNow
- Changed vector to set for i_visibleNow in VisibleNotifer
- Adjusted HaveAtClient to accept Object*
- Adjusted SendUpdateToPlayer to send createobject packet only if not known to client
2023-10-23 05:37:11 -03:00
Hasn
5bf64a164a
fix(Core/Player) Stop small durability loss from still occuring when DurabilityLoss options in worldserver.conf are set to 0 ( #17407 )
...
Fix durability loss even when "DurabilityLoss"-settings in
worldserver.conf are zeroed
2023-10-21 08:10:34 -03:00
Kitzunu
a4e4d6ddb2
feat(Core/Player): Implement commentator tag ( #17449 )
...
* feat(Core/Player): Implement commentator tag
* remove redundant session check
2023-10-08 09:07:17 +02:00
Andrew
2873736145
feat(Core/Player): Move SaveSkills() to the public scope ( #17418 )
2023-10-05 03:38:10 -03:00
AG
2779833768
feat(Core/Grids): Implement visibility notifier ( #15919 )
...
* Cherry-picked from TrinityCore (unable to find author)
2023-09-28 22:28:28 +02:00
Ludwig
f633eb8592
fix(Core/Achivement): Implement ACHIEVEMENT_FLAG_AVERAGE ( #17263 )
2023-09-21 18:56:28 +02:00
Tralenor
0796df57ac
feat(Core/Player): Addition of a Hook in CanFlyInZone check ( #16590 )
...
---------
Co-authored-by: tmoos <tmoos@meteomatics.com >
Co-authored-by: Winfidonarleyan <dowlandtop@yandex.com >
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
2023-09-20 22:40:08 +02:00
Ludwig
8ba8f0fe9e
fix(Core/Achievement): Implement ACHIEVEMENT_CRITERIA_TYPE_OWN_RANK ( #17180 )
...
* fix(Core): Implement ACHIEVEMENT_CRITERIA_TYPE_OWN_RANK
* fix(Core): LoadAchievementCriteriaData(): Add ACHIEVEMENT_CRITERIA_TYPE_OWN_RANK
- fixes minor oversight of ACHIEVEMENT_CRITERIA_TYPE_OWN_RANK implementation
- this enables DB achievement_criteria_data check for ACHIEVEMENT_CRITERIA_TYPE_OWN_RANK
2023-09-14 22:27:39 +02:00
Skjalf
8d08a861aa
feat(Core/Scripting): Implement OnAllowedToLootContainerCheck() hook ( #17209 )
...
* chore(Core/Loot): Move OnAllowedForPlayerLootCheck() hook call up
* Revert "chore(Core/Loot): Move OnAllowedForPlayerLootCheck() hook call up"
This reverts commit f841ef9da313976179fb788d9573ff8ced05ecb9.
* feat(Core/Scripting): Implement OnAllowedToLootContainerCheck() hook
* Update GlobalScript.cpp
2023-09-08 01:52:02 -03:00
Kitzunu
1ed1cd0c73
fix(Core/Player): Allow to swap bags when they are filled ( #17086 )
2023-09-05 06:35:15 -03:00
Francesco Borzì
5d01b700fd
refactor(Core): remove unused imports ( #17094 )
2023-08-28 13:39:43 +02:00
pvp100
856d17ac36
fix(Core/MiscHandler): Dungeon requirements Message ( #16701 )
...
* fix(DB/Gameobject): fix towercanno error location in Flamewatch Tower
adjusted wintergrasp towercanno position
* fix(Core/MiscHandler): dungeon access requirements message parameter
requirements level variable always 0
requirements item cannot get from locale
Co-authored-by: aviar <aviar@sina.com >
* revert: random edits
---------
Co-authored-by: aviar <aviar@sina.com >
Co-authored-by: Stefano Borzì <stefanoborzi32@gmail.com >
2023-08-25 09:16:47 -03:00
Angelo Venturini
dbc39a2817
fix(Core/Spells): Implement ENCHANT_PROC_ATTR_WHITE_HIT ( #16771 )
...
Co-authored-by: Ariel Silva<ariel-@users.noreply.github.com >
2023-07-17 08:19:24 -03:00
Tereneckla
e78ff51336
fix(Core/Player): don't dismiss warlock pets on logout ( #16766 )
...
Update Player.cpp
2023-07-15 17:12:28 -03:00
wenzuowei
3a3dc6446b
fix(Core/Gossip): Fix gossip menu for locale clients ( #16531 )
...
* fix(Core/Gossip): Fix gossip menu for locale clients
* using gossip_menu_option texts by default
---------
Co-authored-by: wzw1990 <>
2023-07-12 08:04:39 -03:00
Tereneckla
718b0000ba
fix(Core/Reputation): remove reputation splitting for being partied ( #16660 )
...
remove rate for party
2023-07-02 15:02:14 -03:00
Walter Pagani
7f9cdda17b
chore(Core/ScriptMgr): Hooks used in mod-aoe-loot ( #16589 )
...
* Creating the necessary hooks for the loot aoe
* update hook
* Typing error
* Method name and add documentation
* codestyle
* Misc. fixes
2023-06-24 08:23:23 -03:00
Žan Skamljič
ee3ab6fe2a
chore(Core/ScriptMgr): Add Hooks for profession skill gains ( #16526 )
2023-06-19 16:12:20 -03:00
Kitzunu
a6980e654a
fix(Core/Player): Logic ( #16305 )
2023-05-24 13:59:43 -03:00
Kitzunu
be48e3c249
fix(Core/Player): Instance.IgnoreRaid kicking people out ( #16306 )
...
* closes https://github.com/azerothcore/azerothcore-wotlk/issues/16201
2023-05-18 22:11:53 +02:00
Tereneckla
acc68ef1e2
fix(Core/Player): Double health regen from spirit ( #15955 )
...
Update Player.cpp
2023-05-13 15:26:43 -03:00
NinjaPleezAC
dfa5da00b1
fix(Core/Player): Apply equip effect auras with -1 duration ( #14809 )
...
Enforces a -1 duration value to auras applied from equip effects.
Current reliance on the DurationEntry of the auras causes at least one aura to incorrectly expire.
Closes AzerothCore issue #5649
Closes https://github.com/chromiecraft/chromiecraft/issues/531
2023-05-13 14:50:07 -03:00
AnchyDev
444793346d
feat(Core/Hooks): Add parameter to detect XP origin for OnGiveXP hook. ( #16109 )
...
Added enum parameter to detect where XP originated from.
2023-05-05 22:39:36 -03:00
M'Dic
7e58650cf5
revert(Core): ChrRace.dbc full implementation ( #16114 )
...
* revert (core): ChrRace.dbc full implementation
we revert this due to several issues arrising. Although the dbc reading is done in full and correctly. Azerothcore relied on the original handling (althought not propper) for so long that there is
* revert
* Update remove_charrace_dbc.sql
* Update remove_charrace_dbc.sql
* Update remove_charrace_dbc.sql
2023-04-29 08:23:11 -03:00
M'Dic
e5665c32f8
update (core\store): sLFGDungeonStore update ( #15325 )
...
* update (core\store): sLFGDungeonStore update
update (core\store): sLFGDungeonStore update
Co-Authored-By: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
* update (core\store): sLFGDungeonStore update
Co-Authored-By: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
---------
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
2023-04-29 12:25:49 +02:00
M'Dic
3eae4c5713
fix(core/dbc): improve ChrRace DBC handling ( #14843 )
...
Cherry pick of https://github.com/TrinityCore/TrinityCore/pull/24508
Co-authored-by: HelloKitty <5829095+HelloKitty@users.noreply.github.com >
2023-04-28 01:29:33 +02:00
天鹿
df77b5f4f7
chore(core): cleanup code p3 ( #16073 )
...
* Update MMapMgr.cpp
* Update UpdateFetcher.cpp
* Update AuctionHouseMgr.cpp
* Update AuctionHouseMgr.h
* Update BattlegroundAV.cpp
* Update ChannelMgr.cpp
* Update ThreatMgr.h
* Update Player.h
* Update PlayerSettings.cpp
* Update ObjectMgr.cpp
* Update Guild.cpp
* Update Guild.h
* Update Map.cpp
* Update World.cpp
* Update boss_nefarian.cpp
* Update boss_prince_malchezaar.cpp
* Update boss_venoxis.cpp
* Update zone_elwynn_forest.cpp
* Update zulfarrak.cpp
* Update boss_novos.cpp
2023-04-24 08:13:07 -03:00
ZhengPeiRu21
1e26cdbee9
fix(Core): Save bonus talent points to DB ( #14099 )
...
* fix(Core): Save bonus talent points to DB
* fix(Core): Save bonus talent points to DB
* Oxford comma in comment
2023-04-22 10:09:18 -03:00
Tereneckla
2e9cb71987
fix(Core/Player): Reduce Health Regeneration bonus while sitting to 33% ( #15954 )
...
Update Player.cpp
2023-04-21 15:18:23 -03:00
Tereneckla
67125caeb0
fix(Core/Player): Food healing does not increased by sitting down ( #15959 )
2023-04-21 14:54:44 -03:00
UltraNix
197b053eb4
fix(Scripts/ShadowLabirynth): Fixed Blackheart's Incite Chaos. ( #15583 )
2023-04-21 08:29:32 -03:00
Tereneckla
d5c89657a1
fix(Core/Player): Apply SPELL_AURA_MOD_HEALTH_REGEN_PERCENT to in combat health regen ( #15961 )
2023-04-21 07:49:08 -03:00