Benjamin Jackson
1edac37ac3
refactor(Core): Make more use of helpers. ( #19835 )
...
* Init.
* Reword.
* Update codestyle script.
Co-Authored-By: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
* Add gameobject type ID check, reorder checks.
* Add helper/codestyle check for unit type.
* `IsUnit()` -> `IsCreature()`
* Add `IsUnit()` method.
* Use type mask.
https: //github.com/TrinityCore/TrinityCore/commit/cc71da35b5dc74abf71f8691161525a23d870bb5
Co-Authored-By: Giacomo Pozzoni <giacomopoz@gmail.com >
Co-Authored-By: Ovahlord <18347559+Ovahlord@users.noreply.github.com >
* Replace instances of `isType` with `IsUnit`.
---------
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com >
Co-authored-by: Ovahlord <18347559+Ovahlord@users.noreply.github.com >
2024-09-03 14:41:31 -03:00
Grimdhex
221dbd3fdb
chore(Apps/Codestyle): add new codestyle checks for pointers and range loops ( #19841 )
...
* chore(Apps/Codestyle): add new codestyle checks for pointers and range loops
* revert a typo
2024-09-03 13:02:38 -03:00
Andrew
9ce2b23df3
refactor(Scripts/RuinsOfAhnQiraj): Clean up Ayamiss script ( #19742 )
2024-08-26 10:04:11 -03:00
Andrew
c5399509e6
refactor(Scripts/TempleOfAhnQiraj): Clean up Cthun script ( #19736 )
...
* refactor(Scripts/TempleOfAhnQiraj): Clean up Cthun script
* Update boss_cthun.cpp
* Update boss_cthun.cpp
2024-08-25 16:46:24 -03:00
Grimdhex
643362d697
refactor(Core/Object): adds consistency in the use of type object check ( #19671 )
2024-08-25 09:57:37 -03:00
Grimdhex
61f3a631c3
fix(Server): remove double blank lines at the end of several files ( #19735 )
2024-08-25 07:21:14 -03:00
Kitzunu
337135bf9e
refactor(Core/Misc): Use NpcFlag helpers ( #19676 )
...
* chore(Core/Misc): Use HasNpcFlag instead of HasFlag
* extend to all npcflag helpers
2024-08-19 10:17:02 +02:00
Andrew
b8de917800
fix(Scripts/Hyjal): Anetheron dont sleep main tank ( #19544 )
...
* fix(Scripts/Hyjal): Anetheron dont sleep main tank
* Update boss_anetheron.cpp
2024-08-06 09:00:25 -03:00
Benjamin Jackson
7569a3bf1b
fix(Scripts/HyjalSummit): Adjust Air Burst cast targetting. ( #19488 )
...
Init.
2024-08-01 19:57:32 -03:00
Francesco Borzì
2dd53e3521
refactor(Scripts): remove unused imports ( #19503 )
2024-07-29 14:44:52 -03:00
Francesco Borzì
dc3dfd3ab0
refactor(Scripts/Kalimdor): remove unused imports ( #19459 )
...
* refactor(Scripts/Kalimdor): remove unused imports
* chore: remove duplicate blank line
* chore: damn linking issue
* chore: wip
* chore: wip
* chore: wip
2024-07-26 19:58:11 -03:00
Benjamin Jackson
6c97e45e87
fix(Scripts/HyjalSummit): Adjust Doomfire Spirit movement logic. ( #19469 )
...
* Init.
Co-Authored-By: Tereneckla <Tereneckla@pm.me >
* Simplify code, add comment.
* Adjust scenario in which distance fails at all ranges.
* Remove unused variable.
* Account for deviation with distance check.
Co-Authored-By: Tereneckla <Tereneckla@pm.me >
* f
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
* Rewrite with initial teleport.
* Whitespace?
* Update function type.
* Drop Doomfire spawn timer.
Verified with le sniff. Teehee.
---------
Co-authored-by: Tereneckla <Tereneckla@pm.me >
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
2024-07-25 20:50:15 -03:00
Tereneckla
be256e7a78
fix(scripts/HyjalSummit): Make Doomfire Spirit move away from Archimonde at first ( #19467 )
...
Update boss_archimonde.cpp
2024-07-24 11:00:07 -03:00
Benjamin Jackson
c7d086862a
fix(Scripts/HyjalSummit): Adjust Azgalor's Rain of Fire timings. ( #19393 )
...
* Init.
* Bad number.
2024-07-12 20:07:25 -03:00
Benjamin Jackson
ccf5f06128
fix(Scripts/HyjalSummit): Correct Soul Charge color assignments. ( #19345 )
...
Init.
2024-07-09 14:15:34 -03:00
sudlud
37e3d89f91
fix(CI): linux-build: add -Werror parameter ( #19240 )
...
* fix(CI): linux-build: add -Werror parameter
* add KI
tzunu
* Revert "feat(CI): enable fail-fast for pch/nopch (#19058 )"
This reverts commit 564cbca7d3#19058 )""
This reverts commit d13df293624e0f50d9374272bfd05ab56242511d.
---------
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
2024-07-07 22:00:24 +02:00
Gultask
8279d9c272
fix(Scripts/HyjalSummit): Rage Winterchill Spells ( #19335 )
...
Update boss_rage_winterchill.cpp
2024-07-07 13:48:24 -03:00
Benjamin Jackson
d0cd435807
fix(Scripts/HyjalSummit): Add damage over time component to Doomfire debuff. ( #19317 )
...
* Init.
https: //github.com/mangostwo/server/commit/6a2e23cac09a88d7ec1221393ba96482d71187f6
Co-Authored-By: Miroslav Drbal [ApoC] <apoc@nymfe.net >
* Don't forget the query.
* Add spell attribute.
* Adjust tick script.
More dynamically calculates damage from ticks.
Co-Authored-By: avarishd <46330494+avarishd@users.noreply.github.com >
* Remove unnecessary `aurEff`
Co-Authored-By: avarishd <46330494+avarishd@users.noreply.github.com >
* #include
---------
Co-authored-by: Miroslav Drbal [ApoC] <apoc@nymfe.net >
Co-authored-by: avarishd <46330494+avarishd@users.noreply.github.com >
2024-07-06 20:02:35 +02:00
Benjamin Jackson
c3e22c0fe2
fix(Scripts/HyjalSummit): Couple Archimonde adjustments. ( #19193 )
...
* Init.
Co-Authored-By: cyberium <cyberium@users.noreply.github.com >
Co-Authored-By: killerwife <killerwife@users.noreply.github.com >
* Corrections.
* Adjust fear timer.
* Wrong spell.
* Whitespace.
* Use the much cooler and more hip scheduler.
* Correct teleport timers.
Matches up with sniffed 3.4.3 data.
* Swap magic number for constant.
Co-Authored-By: killerwife <killerwife@users.noreply.github.com >
* Adjust notation.
* Public.
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
* Kitzunu's fault.
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
---------
Co-authored-by: cyberium <cyberium@users.noreply.github.com >
Co-authored-by: killerwife <killerwife@users.noreply.github.com >
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
2024-07-04 14:31:22 -03:00
Kitzunu
5a4692e45a
chore(Core/Misc): #include cleanup ( #19255 )
2024-07-02 15:52:02 +02:00
Andrew
8b81b1dad1
fix(Scripts/Hyjal): Workaround bosses getting stuck in progress ( #19231 )
2024-06-30 05:39:29 -03:00
Jelle Meeus
a9c93cc94e
refactor(Scripts/Kalimdor): Spell Scripts registry macros ( #19185 )
...
* zone_dustwallow_marsh spell:spell_ooze_zap
* zone_dustwallow_marsh spell:spell_ooze_zap_channel_end
* zone_dustwallow_marsh spell:spell_energize_aoe
* zone_feralas spell:spell_gordunni_trap
* zone_durotar aura:spell_mount_check_aura
* zone_durotar spell:spell_voljin_war_drums
* zone_durotar spell:spell_voodoo
* boss_salramm aura:spell_boss_salramm_steal_flesh_aura
* instance_zulfarrak spell:spell_zulfarrak_summon_zulfarrak_zombies
* instance_zulfarrak spell:spell_zulfarrak_unlocking
2024-06-26 22:26:35 +02:00
Jelle Meeus
9ee95bf23e
fix(Scripts/Kalimdor) Thrall Warchief's Blessing, add level and reputation requirement, spike activation ( #19121 )
...
* activates pike
* add sql
2024-06-22 03:06:05 -03:00
Jelle Meeus
6d86fb3721
fix(Scripts/Spell): adjust Thrall's and Herald WCB timings, limit to Orgrimmar and Crossroads ( #19026 )
...
* update smartAI herald
* refactor _scheduler to scheduler
* adjust timings of WCB Thrall
* limit WCB to Orgrimmar and Crossroads
* add roar emote
* style, add second loop to delay crossroads cast
* limit shout range to area
* rename p to player
2024-06-20 22:14:19 +02:00
Andrew
24251bc061
fix(Scripts/Hyjal): Fix wave count not showing for Rage Winterchill waves
...
fix(Scripts/Hyjal): Fix wave count not showing for Rage Winterchill waves
2024-06-20 06:48:37 +02:00
Andrew
5f966e8e0c
chore(Scripts/Hyjal): Remove unneeded Archimonde spell scripts ( #19080 )
...
* chore(Scripts/Hyjal): Remove unneeded spell scripts
* use trigger flags
* Update boss_archimonde.cpp
* Update boss_archimonde.cpp
2024-06-17 21:37:43 +02:00
Andrew
95221c4d50
fix(Scripts/Hyjal): Archimonde should gain charges regardless of deat… ( #19069 )
...
* fix(Scripts/Hyjal): Archimonde should gain charges regardless of death cause
* Update instance_hyjal.cpp
* fix boss waves
2024-06-16 18:58:14 +02:00
Dan
9684eb437a
fix(Scripts/Hyjal): remove very scary call by reference and posis without initialization ( #19046 )
...
remove call by reference
2024-06-11 03:32:50 +02:00
Andrew
289758094c
chore(Scripts/Hyjal): Clean up redundancy ( #19035 )
2024-06-09 17:32:29 -03:00
Dan
8a988fd10a
fix(Scripts/Hyjal): Air Burst back to random target ( #19037 )
...
init
2024-06-09 17:32:16 -03:00
Dan
bbb0cb43eb
fix(Scripts/Hyjal): some Archimonde fixes ( #19031 )
...
* init
* update spellscript
* fix targetting
* Update boss_archimonde.cpp
2024-06-08 16:50:43 +02:00
amed80
eed20b4647
fix(Scripts/Hyjal): Change the spawn and the movement of Doomfire ( #19027 )
...
* Doomfire_spirit_speed
* Update boss_archimonde.cpp
* Rename
2024-06-08 13:07:39 +02:00
Benjamin Jackson
bb69f1c3ec
fix(Scripts/HyjalSummit): Assign Death Knight Soul Charge. ( #19020 )
...
Init.
Alphabetize and correct DK soul charge assign.
2024-06-07 12:32:02 +02:00
Andrew
79ec83d03e
fix(Scripts/Hyjal): Fix Azgalor Doom targetting tanks since its an AoE spell ( #19012 )
...
* fix(Scripts/Hyjal): Fix Azgalor Doom targetting tanks since its an AoE spell
* Update boss_azgalor.cpp
2024-06-06 00:12:19 +02:00
Andrew
218dce417e
chore(Scripts/Hyjal): Clean up unsafe calls and code style ( #19004 )
...
* chore(Scripts/Hyjal): Clean up unsafe calls and code style
* another one
2024-06-03 20:33:07 -03:00
Andrew
8ee980e4ba
fix(Scripts/Hyjal): Anetheron cast Carrion Swarm on non player targets ( #19005 )
2024-06-03 20:25:58 -03:00
Dan
8256d3cb55
fix(Scripts/Hyjal): archimonde enrage after 10 minutes ( #19003 )
...
init
2024-06-03 14:10:44 -03:00
Andrew
70fc43ff8d
fix(Script/Hyjal): Fix encounter states not reseting if bosses are de… ( #19000 )
...
* fix(Script/Hyjal): Fix encounter states not reseting if bosses are despawned while in combat
* Update instance_hyjal.cpp
2024-06-03 00:31:31 -03:00
Dan
ba8a152479
fix(Scripts/Hyjal): correctly despawn summoned creatures on Jaina/Thrall death ( #18997 )
...
* init
* change logic
despawning of bosses is not really done the normal way, but it's forced with a set amount of guids. So we simply need to register the summons as guids as well
* small fixes
* Delete creature_scripts.sql
* Update boss_azgalor.cpp
2024-06-02 17:07:42 +02:00
sudlud
8e9e134924
fix(Scripts/Hyjal): fix some build warnings for unused parameters ( #18986 )
2024-06-01 12:25:53 +02:00
Dan
0f5992045c
fix(Scripts/Hyjal): increase ranges on doomfire to make movement less inclined to stick close to the boss ( #18976 )
...
initial
2024-05-29 23:57:56 +02:00
Dan
9d672f8b62
fix(Scripts/Hyjal): remove summoned mobs on boss evade and reset waves ( #18975 )
...
init
2024-05-29 23:57:34 +02:00
Dan
fe6137b0a0
fix(Scripts/Hyjal): tweak movement of Doomfire ( #18970 )
...
initial
2024-05-29 08:04:13 +02:00
Andrew
2c246e49d0
fix(Scripts/Hyjal): Anetheron dont cast sleep on tank ( #18969 )
2024-05-28 19:39:21 -03:00
Andrew
9b363594e7
fix(Scripts/Hyjal): Fix Doom spawning Doomguards twice on expire ( #18968 )
2024-05-28 19:39:05 -03:00
Andrew
7692b709ac
fix(Scripts/Hyjal): Azgalor doom shouldnt target tank MKII ( #18964 )
2024-05-28 14:55:28 -03:00
Andrew
2a1d23e520
fix(Scripts/Hyjal): Implement Eternal Silence spell when going into t… ( #18960 )
...
fix(Scripts/Hyjal): Implement Eternal Silence spell when going into the Well of Eternity
2024-05-28 01:24:10 +02:00
Andrew
73e44859f0
fix(Scripts/Hyjal): Azgalor mark of doom spawn demons on target death ( #18959 )
2024-05-27 20:48:29 +02:00
Dan
3985db3006
fix(Scripts/Hyjal): Anetheron should not cast sleep on MT ( #18948 )
...
* init
* also talk when spell fails
2024-05-27 14:24:37 -03:00
Andrew
8200385efb
chore(Scripts/Hyjal): Update Mark of Kazrogal script ( #18958 )
2024-05-27 18:51:41 +02:00
