fix(CI): linux-build: add -Werror parameter (#19240)

* fix(CI): linux-build: add -Werror parameter

* add KI

tzunu

* Revert "feat(CI): enable fail-fast for pch/nopch (#19058)"

This reverts commit 564cbca7d3.

* Update midsummer.cpp - drop unused variable

* initialize variable

* Update core-build-nopch.yml - drop gcc12

* fix(Core/CalendarMgr): do not use element after delete, but before

* attempt to fix Socket.h error

* Revert "attempt to fix Socket.h error"

This reverts commit c1a59145ed3c49d0f76be2f81925434ea969db97.

* fix Socket.h error - attempt 2

* Update Socket.h

* Update Socket.h

* npc_shattrath_daily_quest: init variable templateID

* fix(Scripts/Karazhan): use size_t within loop in boss_shade_of_aran:Reset()

* boss_archimonde: drop unused variable

* Revert "fix(Scripts/Karazhan): use size_t within loop in boss_shade_of_aran:Reset()"

This reverts commit 1f71aaef256990c5cdc16561676be302c954ea9d.

* SmartScripts: SMART_TARGET_RANDOM_POINT: fix unintended fallthrough

* Revert "Revert "feat(CI): enable fail-fast for pch/nopch (#19058)""

This reverts commit d13df293624e0f50d9374272bfd05ab56242511d.

---------

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

.github/actions/linux-build/action.yml

@@ -101,6 +101,8 @@ runs:
           -DCMAKE_BUILD_TYPE="Release" \
           -DCMAKE_CXX_COMPILER_LAUNCHER="ccache" \
           -DCMAKE_C_COMPILER_LAUNCHER="ccache" \
+          -DCMAKE_C_FLAGS="-Werror" \
+          -DCMAKE_CXX_FLAGS="-Werror" \
           -DBUILD_TESTING="ON" \
           -DUSE_SCRIPTPCH=${{ inputs.pch == 'true' && 'ON' || '' }} \
           -DUSE_COREPCH=${{ inputs.pch == 'true' && 'ON' || '' }} \

.github/workflows/core-build-nopch.yml

@@ -23,10 +23,6 @@ jobs:
             compiler:
               CC: clang-15
               CXX: clang++-15
-          - os: ubuntu-22.04
-            compiler:
-              CC: gcc-12
-              CXX: g++-12
           - os: ubuntu-24.04
             compiler:
               CC: clang-18

src/server/game/AI/SmartScripts/SmartScript.cpp

@@ -1810,20 +1810,23 @@ void SmartScript::ProcessAction(SmartScriptHolder& e, Unit* unit, uint32 var0, u
                     break;
                 }
                 case SMART_TARGET_RANDOM_POINT:
-                if (me)
                 {
-                    float range = (float)e.target.randomPoint.range;
-                    Position srcPos = { e.target.x, e.target.y, e.target.z, e.target.o };
-                    Position randomPoint = me->GetRandomPoint(srcPos, range);
-                    me->GetMotionMaster()->MovePoint(
-                        e.action.moveToPos.pointId,
-                        randomPoint.m_positionX,
-                        randomPoint.m_positionY,
-                        randomPoint.m_positionZ,
-                        true,
-                        true,
-                        isControlled ? MOTION_SLOT_CONTROLLED : MOTION_SLOT_ACTIVE
-                    );
+                    if (me)
+                    {
+                        float range = (float)e.target.randomPoint.range;
+                        Position srcPos = { e.target.x, e.target.y, e.target.z, e.target.o };
+                        Position randomPoint = me->GetRandomPoint(srcPos, range);
+                        me->GetMotionMaster()->MovePoint(
+                            e.action.moveToPos.pointId,
+                            randomPoint.m_positionX,
+                            randomPoint.m_positionY,
+                            randomPoint.m_positionZ,
+                            true,
+                            true,
+                            isControlled ? MOTION_SLOT_CONTROLLED : MOTION_SLOT_ACTIVE
+                        );
+
+                    }
 
                     break;
                 }

src/server/game/Calendar/CalendarMgr.cpp

@@ -204,8 +204,8 @@ void CalendarMgr::RemoveEvent(CalendarEvent* calendarEvent, ObjectGuid remover)
     trans->Append(stmt);
     CharacterDatabase.CommitTransaction(trans);
 
-    delete calendarEvent;
     _events.erase(calendarEvent);
+    delete calendarEvent;
     return;
 }
 

src/server/scripts/Kalimdor/CavernsOfTime/BattleForMountHyjal/boss_archimonde.cpp

@@ -504,7 +504,7 @@ class spell_doomfire : public AuraScript
         int32 bp = GetSpellInfo()->Effects[EFFECT_1].CalcValue();
         float tickCoef = (static_cast<float>(aurEff->GetTickNumber() - 1) / aurEff->GetTotalTicks()); // Tick moved back to ensure proper damage on each tick
         int32 damage = bp - (bp*tickCoef);
-        SpellCastResult result = target->CastCustomSpell(target, SPELL_DOOMFIRE_DOT, &damage, &damage, &damage, true, nullptr, nullptr, target->GetGUID());
+        target->CastCustomSpell(target, SPELL_DOOMFIRE_DOT, &damage, &damage, &damage, true, nullptr, nullptr, target->GetGUID());
     }
 
     void Register() override

src/server/scripts/Outland/zone_shattrath_city.cpp

@@ -308,7 +308,7 @@ struct npc_shattrath_daily_quest : public NullCreatureAI
             {
                 Field *fields = result->Fetch();
                 int quest_id = fields[0].Get<int>();
-                uint32 templateID;
+                uint32 templateID = 0;
 
                 if (creature == NPC_SHATTRATH_DAILY_H)
                 {

src/server/scripts/Spells/spell_generic.cpp

@@ -5221,7 +5221,7 @@ class spell_gen_sober_up : public AuraScript
         if (!target && !target->ToPlayer())
             return;
 
-        SpellEffIndex InebriateEffIndex;
+        SpellEffIndex InebriateEffIndex = EFFECT_0;
         if (Player* player = target->ToPlayer())
         {
             switch (GetSpellInfo()->Id)

src/server/shared/Network/Socket.h

@@ -261,7 +261,7 @@ private:
 
         const uint8 addressFamily = readPointer[13];
         const uint16 len = (readPointer[14] << 8) | readPointer[15];
-        if (len+16 > packet.GetActiveSize())
+        if (static_cast<size_t>(len+16) > packet.GetActiveSize())
         {
             AsyncReadProxyHeader();
             return;