refactor(Scripts/Kalimdor): remove unused imports (#19459)

* refactor(Scripts/Kalimdor): remove unused imports

* chore: remove duplicate blank line

* chore: damn linking issue

* chore: wip

* chore: wip

* chore: wip

src/server/scripts/Kalimdor/BlackfathomDeeps/instance_blackfathom_deeps.cpp

@@ -15,7 +15,6 @@
  * with this program. If not, see <http://www.gnu.org/licenses/>.
  */
 
-#include "CreatureScript.h"
 #include "InstanceMapScript.h"
 #include "InstanceScript.h"
 #include "blackfathom_deeps.h"

src/server/scripts/Kalimdor/CavernsOfTime/BattleForMountHyjal/boss_archimonde.cpp

@@ -16,10 +16,10 @@
  */
 
 #include "CreatureScript.h"
+#include "GridNotifiers.h"
 #include "Player.h"
 #include "ScriptedCreature.h"
 #include "SpellAuraEffects.h"
-#include "SpellAuras.h"
 #include "SpellScript.h"
 #include "SpellScriptLoader.h"
 #include "hyjal.h"

src/server/scripts/Kalimdor/CavernsOfTime/BattleForMountHyjal/boss_azgalor.cpp

@@ -16,6 +16,7 @@
  */
 
 #include "CreatureScript.h"
+#include "GridNotifiers.h"
 #include "ScriptedCreature.h"
 #include "SpellScript.h"
 #include "SpellScriptLoader.h"

src/server/scripts/Kalimdor/CavernsOfTime/BattleForMountHyjal/boss_kazrogal.cpp

@@ -16,6 +16,7 @@
  */
 
 #include "CreatureScript.h"
+#include "GridNotifiers.h"
 #include "ScriptedCreature.h"
 #include "SpellAuraEffects.h"
 #include "SpellScript.h"

src/server/scripts/Kalimdor/CavernsOfTime/BattleForMountHyjal/hyjal.h

@@ -19,7 +19,6 @@
 #define DEF_HYJAL_H
 
 #include "CreatureAIImpl.h"
-#include "GridNotifiers.h"
 
 #define DataHeader "HY"
 

src/server/scripts/Kalimdor/CavernsOfTime/BattleForMountHyjal/instance_hyjal.cpp

@@ -18,7 +18,6 @@
 #include "Chat.h"
 #include "InstanceMapScript.h"
 #include "InstanceScript.h"
-#include "Opcodes.h"
 #include "Player.h"
 #include "WorldPacket.h"
 #include "hyjal.h"

src/server/scripts/Kalimdor/CavernsOfTime/TheBlackMorass/the_black_morass.cpp

@@ -18,8 +18,10 @@
 #include "the_black_morass.h"
 #include "CreatureScript.h"
 #include "MoveSplineInit.h"
+#include "PassiveAI.h"
 #include "ScriptedCreature.h"
 #include "SmartAI.h"
+#include "SpellScript.h"
 #include "SpellScriptLoader.h"
 
 enum medivhMisc

src/server/scripts/Kalimdor/CavernsOfTime/TheBlackMorass/the_black_morass.h

@@ -19,8 +19,6 @@
 #define DEF_THEBLACKMORASS_H
 
 #include "CreatureAIImpl.h"
-#include "PassiveAI.h"
-#include "SpellScript.h"
 
 #define DataHeader "TBM"
 

src/server/scripts/Kalimdor/Maraudon/instance_maraudon.cpp

@@ -15,7 +15,6 @@
  * with this program. If not, see <http://www.gnu.org/licenses/>.
  */
 
-#include "CreatureScript.h"
 #include "InstanceMapScript.h"
 #include "InstanceScript.h"
 #include "maraudon.h"

src/server/scripts/Kalimdor/RazorfenDowns/razorfen_downs.cpp

@@ -20,10 +20,16 @@
 #include "CellImpl.h"
 #include "CreatureScript.h"
 #include "GridNotifiers.h"
-#include "GridNotifiersImpl.h"
+#include "PassiveAI.h"
 #include "Player.h"
 #include "ScriptedCreature.h"
 
+/// @todo: this import is not necessary for compilation and marked as unused by the IDE
+//  however, for some reasons removing it would cause a damn linking issue
+//  there is probably some underlying problem with imports which should properly addressed
+//  see: https://github.com/azerothcore/azerothcore-wotlk/issues/9766
+#include "GridNotifiersImpl.h"
+
 /*######
 ## npc_belnistrasz for Quest 3525 "Extinguishing the Idol"
 ######*/

src/server/scripts/Kalimdor/RazorfenDowns/razorfen_downs.h

@@ -19,7 +19,6 @@
 #define DEF_RAZORFEN_DOWNS_H
 
 #include "CreatureAIImpl.h"
-#include "PassiveAI.h"
 
 #define DataHeader "RFD"
 

src/server/scripts/Kalimdor/RuinsOfAhnQiraj/boss_ossirian.cpp

@@ -19,7 +19,6 @@
 #include "GameObjectAI.h"
 #include "GameObjectScript.h"
 #include "MiscPackets.h"
-#include "Opcodes.h"
 #include "Player.h"
 #include "ScriptedCreature.h"
 #include "SpellInfo.h"

src/server/scripts/Kalimdor/WailingCaverns/instance_wailing_caverns.cpp

@@ -15,7 +15,6 @@
  * with this program. If not, see <http://www.gnu.org/licenses/>.
  */
 
-#include "CreatureScript.h"
 #include "InstanceMapScript.h"
 #include "InstanceScript.h"
 #include "wailing_caverns.h"

src/server/scripts/Kalimdor/WailingCaverns/wailing_caverns.h

@@ -20,8 +20,6 @@
 
 #define DataHeader "WC"
 
-#include "CreatureAI.h"
-
 enum DataTypes
 {
     TYPE_LORD_COBRAHN           = 0,

src/server/scripts/Kalimdor/ZulFarrak/instance_zulfarrak.cpp

@@ -16,10 +16,12 @@
  */
 
 #include "CreatureScript.h"
+#include "CellImpl.h"
 #include "GridNotifiers.h"
 #include "GridNotifiersImpl.h"
 #include "InstanceMapScript.h"
 #include "InstanceScript.h"
+#include "SpellScript.h"
 #include "SpellScriptLoader.h"
 #include "TemporarySummon.h"
 #include "zulfarrak.h"

src/server/scripts/Kalimdor/ZulFarrak/zulfarrak.cpp

@@ -17,6 +17,7 @@
 
 #include "zulfarrak.h"
 #include "Cell.h"
+#include "CellImpl.h"
 #include "CreatureScript.h"
 #include "GameObject.h"
 #include "GameObjectAI.h"
@@ -28,6 +29,13 @@
 #include "ScriptSystem.h"
 #include "ScriptedCreature.h"
 #include "ScriptedGossip.h"
+
+/// @todo: this import is not necessary for compilation and marked as unused by the IDE
+//  however, for some reasons removing it would cause a damn linking issue
+//  there is probably some underlying problem with imports which should properly addressed
+//  see: https://github.com/azerothcore/azerothcore-wotlk/issues/9766
+#include "GridNotifiersImpl.h"
+
 /* ScriptData
 SDName: Zulfarrak
 SD%Complete: 50
@@ -40,8 +48,6 @@ npc_sergeant_bly
 npc_weegli_blastfuse
 EndContentData */
 
-#include "GridNotifiersImpl.h"
-
 /*######
 ## npc_sergeant_bly
 ######*/

src/server/scripts/Kalimdor/ZulFarrak/zulfarrak.h

@@ -18,9 +18,7 @@
 #ifndef DEF_ZULFARRACK_H
 #define DEF_ZULFARRACK_H
 
-#include "CellImpl.h"
 #include "CreatureAIImpl.h"
-#include "SpellScript.h"
 
 #define DataHeader "ZF"
 

src/server/scripts/Kalimdor/zone_azshara.cpp

@@ -31,7 +31,6 @@ EndContentData */
 #include "Player.h"
 #include "ScriptedCreature.h"
 #include "ScriptedGossip.h"
-#include "SpellInfo.h"
 
 /*####
 # npc_rizzle_sprysprocket

src/server/scripts/Kalimdor/zone_dustwallow_marsh.cpp

@@ -18,7 +18,6 @@
 #include "CreatureScript.h"
 #include "Player.h"
 #include "ScriptedCreature.h"
-#include "ScriptedGossip.h"
 #include "SpellScript.h"
 #include "SpellScriptLoader.h"
 

src/server/scripts/Kalimdor/zone_feralas.cpp

@@ -18,7 +18,6 @@
 #include "Group.h"
 #include "Player.h"
 #include "ScriptedCreature.h"
-#include "ScriptedGossip.h"
 #include "SpellScript.h"
 #include "SpellScriptLoader.h"
 /* ScriptData

src/server/scripts/Kalimdor/zone_moonglade.cpp

@@ -31,7 +31,6 @@ npc_clintar_dreamwalker
 EndContentData */
 
 #include "Cell.h"
-#include "CellImpl.h"
 #include "CreatureScript.h"
 #include "GridNotifiers.h"
 #include "GridNotifiersImpl.h"