Commit Graph

3396 Commits

Author SHA1 Message Date
Johaine
ea3e6e8f3b fix(Scripts/Deadmines): Fix Factory Door in Deadmines being closable (#15201)
* fix(DB/SAI): Open Factory Door correctly (irreversibly)

Activate the Factory Door after the boss' death to open it instead of changing gameobject state only which can be reversed by another activation.

* fix(Script/Instance): Prevent Door being closed again after Server Restart

* Drop database name from update SQL

Other people might not use the standard database names

Co-authored-by: Gultask <100873791+Gultask@users.noreply.github.com>

---------

Co-authored-by: Gultask <100873791+Gultask@users.noreply.github.com>
2023-05-13 14:52:44 -03:00
Eddy Vega
eca5f79d6f fix(Scripts/Mechanar): Avoid Nether Charge despawn (#16190)
init
2023-05-13 14:51:33 -03:00
Dan
8e28b64ccf fix(Scripts/HellfireRamparts): modernise boss scripts for Hellfire Ramparts (#16250)
* first two bosses

* add vazruden+nazan

* dumb mistake fix

* remove double summon say from Omor

* new attempt at scheduling talking

* fix boolean condition for speaking

* debug

* revert debug

* initial

* diff comment
2023-05-13 14:50:46 -03:00
NinjaPleezAC
dfa5da00b1 fix(Core/Player): Apply equip effect auras with -1 duration (#14809)
Enforces a -1 duration value to auras applied from equip effects.
Current reliance on the DurationEntry of the auras causes at least one aura to incorrectly expire.

Closes AzerothCore issue #5649
Closes https://github.com/chromiecraft/chromiecraft/issues/531
2023-05-13 14:50:07 -03:00
Grimgravy
09c40a8cd3 fix(Scripts/VioletHold): Activation Crystals (#13176)
* fix(Scripts/Activation Crystals): Instance The Violet Hold

* update

* Update violet_hold.cpp
2023-05-13 14:48:26 -03:00
天鹿
2745a98ed1 fix(Core/mail): letter paper (#15039)
Mail paper
2023-05-13 14:46:50 -03:00
Skjalf
8d6392d60f fix(Scripts/Underbog): Rework Swamplord Muselek (#14724)
* fix(Scripts/Underbog): Rework Swamplord Muselek

* Update boss_swamplord_muselek.cpp

* update to bossai

* Update outland_script_loader.cpp

* Update boss_swamplord_muselek.cpp

* Update boss_swamplord_muselek.cpp

* prevent chase movement while walking backwards

* Update boss_swamplord_muselek.cpp
2023-05-13 14:44:20 -03:00
Tereneckla
6fe6f891fc Revert "fix(Core/Spells): Seal of Command, Seal of Vengeance and Seal… (#15938)
* Revert "fix(Core/Spells): Seal of Command, Seal of Vengeance and Seal of Corr… (#15193)"

This reverts commit 88401360ab.

* Keep Divine Storm in SPELLFAMILIY_PALADIN case

* Update SpellEffects.cpp
2023-05-13 14:41:27 -03:00
cTrinity
64a7c59b57 fix(Core/ObjectMgr.cpp): Wrong format occurred (invalid format string) (#16168)
* fix(Core/ObjectMgr.cpp): Wrong format occurred (invalid format string)

Wrong format occurred (invalid format string)

* fix(Core/ObjectMgr.cpp): Wrong format occurred (invalid format string)

* fix(Core/ObjectMgr.cpp): Wrong format occurred (invalid format string)

Co-authored-by: Angelo Venturini <nefertum.dev@protonmail.com>

---------

Co-authored-by: Angelo Venturini <nefertum.dev@protonmail.com>
2023-05-13 14:40:46 -03:00
avarishd
38509d2b3a fix(Core/Spells): Apply AURA_STATE_FAERIE_FIRE to Lambent Blood. (#16103) 2023-05-13 14:11:04 -03:00
Dan
154fa624f0 fix(Scripts/ShatteredHalls): fixes to Warbring O'mrogg combat scripts and timers (#16091)
* initial attempt at combat fix

with modernising

* fixes to scheduler

first Draft PR commit. Scheduler now works with boolean in capture list of lambda function.

* whitespaces

* debug

* debug2

* debug3

* debug4

* add omrogg equip query and debug5

* remove tabs

* Update data/sql/updates/pending_db_world/omroggequip.sql

Co-authored-by: Gultask <100873791+Gultask@users.noreply.github.com>

* grouped taskscheduler

* added more groups

* adjust timer

* better handling

* v2 (too many commits)

* fixed melee

* clean up debug info

removal of yells

* more debug

* attempt at fix

* some changes to scheduling

* final

* whitespaces and extra lines

* better formatting

* final whitespace fix

* context fix

* dumb fix

---------

Co-authored-by: Gultask <100873791+Gultask@users.noreply.github.com>
2023-05-13 14:01:22 -03:00
Gultask
64c7c99bda revert(Core/Player): Revert Delayed Damage System (#16246)
* Revert "fix(Core/Spells): Delayed Damage system (#16183)"

This reverts commit d282cce4af.

* Revert "fix: Crash on ProcessDelayedDamages (#16166)"

This reverts commit 3dbdea5e28.

* Revert "fix(core\player): Missing combat animation (#14199)"

This reverts commit a238e5e27b.
2023-05-13 13:50:27 -03:00
UltraNix
2a1d706a2f fix(Scripts/Underbog): Underbat's Tentacle Lash should be casted only … (#14566)
* fix(Scripts/Underbog: Underbat's Tentacle Lash should be casted only on targets behind the bat.

Fixes #13972

* buildfix.
2023-05-12 09:15:02 -03:00
Dan
79954c34d4 fix(Scripts/Outland): add missing C++ code and remove SAI scripts from Tavarok and Darkweaver Syth (#16178)
* initial

* whitespace1

* Update tavarok_darkweaver_sai_removal.sql

fix sql
2023-05-12 08:23:56 -03:00
Dan
11eab9c3a6 fix(Scripts/TheSlavePens): port SAI from bosses to C++ (#16169)
* fix

* add sql 1

* add sql 2

* remove extra lines

* remove dumb stuff

keywords in "comment" were messing up the statement

* same story

todo: get better at SQL

* better formatting + two sql statements together

* remove old sql query

* last fix

* fixes to header enum

* fix sql

to have a more universal format

* E e

* final sql fix
2023-05-12 08:20:31 -03:00
Angelo Venturini
d7bdf5f717 fix(Vehicle): Crash (#16184) 2023-05-10 10:32:15 -03:00
avarishd
3aedf2fbf8 fix(DB/SAI): Void Baron Galaxis encounter. (#15312)
* fix(DB/SAI): Void Baron Galaxis encounter.

* remove item cast + add void storm cloud
2023-05-10 06:29:51 -03:00
Gultask
fec1692716 fix(DB/SAI): Rework Trash SAI for Blood Furnace (#16123)
* init

* Update rev_1682710323496877200.sql
2023-05-10 06:29:01 -03:00
Skjalf
da2dafa64b fix(Scripts/ShadowLabyrinth): Improve Grandmaster Vorpil script (#16126)
fixed boss moving after teleporting and interrupting fire storm
void travelers will cast empowering shadow on vorpil
shadow nova animation now works
fixed spell cast order as described in the vorpil issue [Shadow Labyrinth] Grandmaster Vorpil #15928
vorpil will use draw shadows to summon players instead of having them manually summoned
2023-05-10 06:23:37 -03:00
Angelo Venturini
d282cce4af fix(Core/Spells): Delayed Damage system (#16183) 2023-05-07 08:58:38 -03:00
AnchyDev
444793346d feat(Core/Hooks): Add parameter to detect XP origin for OnGiveXP hook. (#16109)
Added enum parameter to detect where XP originated from.
2023-05-05 22:39:36 -03:00
Angelo Venturini
3dbdea5e28 fix: Crash on ProcessDelayedDamages (#16166) 2023-05-03 06:27:44 -03:00
Skjalf
590dcca82b chore(Scripts/BloodFurnace): Clean up unused code in Broggok script (#16145)
* chore(Scripts/BloodFurnace): Clean up unused code in Broggok script

* Update boss_broggok.cpp
2023-05-01 01:09:44 -03:00
Angelo Venturini
de06f4327a fix(Core/Instance): AhnQiraj crash (#16124) 2023-04-30 01:30:57 +02:00
M'Dic
1c7ac83a1c feat(Core/Unit): anticheat helper (#16115)
this covers a case with SPELL_AURA_CONTROL_VEHICLE being used. commonly in dk starter spot and northrend.
2023-04-30 01:27:15 +02:00
M'Dic
7e58650cf5 revert(Core): ChrRace.dbc full implementation (#16114)
* revert (core): ChrRace.dbc full implementation

we revert this due to several issues arrising. Although the dbc reading is done in full and correctly. Azerothcore relied on the original handling (althought not propper) for so long that  there is

* revert

* Update remove_charrace_dbc.sql

* Update remove_charrace_dbc.sql

* Update remove_charrace_dbc.sql
2023-04-29 08:23:11 -03:00
M'Dic
a238e5e27b fix(core\player): Missing combat animation (#14199) 2023-04-29 12:27:13 +02:00
M'Dic
e5665c32f8 update (core\store): sLFGDungeonStore update (#15325)
* update (core\store): sLFGDungeonStore update

update (core\store): sLFGDungeonStore update

Co-Authored-By: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* update (core\store): sLFGDungeonStore update

Co-Authored-By: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

---------

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2023-04-29 12:25:49 +02:00
Skjalf
2e98e7c42a fix(Scripts/ShadowLabyrinth): Fix Murmur combat bug caused by Suppres… (#16122)
fix(Scripts/ShadowLabyrinth): Fix Murmur combat bug caused by Suppression Blasts hitting npcs in combat with players
2023-04-28 22:56:00 -03:00
M'Dic
7b0efe01e5 chore(core/instance): Move to switch case (#16084)
This has just sloppy. Moved to Case switch with log error and else debug logging
2023-04-28 01:31:09 +02:00
M'Dic
3eae4c5713 fix(core/dbc): improve ChrRace DBC handling (#14843)
Cherry pick of https://github.com/TrinityCore/TrinityCore/pull/24508

Co-authored-by: HelloKitty <5829095+HelloKitty@users.noreply.github.com>
2023-04-28 01:29:33 +02:00
M'Dic
ab2c062f03 feat(core\dbc): item.dbc, sItemStore, item_dbc, item enforcement conf, subclass fix (#14675)
feat (core\log\db): item.dbc and enforcement

dbc enforcement partial pick from tc: 0c44bd33ee

Custom Item for testing by menevia16a (SPP DEV VEIL)

feat (core\log\db): item.dbc and enforcement

Update Item.sql

Update DBCStores.cpp

Update World.cpp

Update ObjectMgr.cpp

further replacement from template to dbc lookup

further logging and implementation

cherry pick tc fd26c3c87c

replace with db lookup

update (sql): Murder all the backticks

line break fixit

fix (item_template): fix incorrect subclass

fix incorrect subclass matching with dbc enforcement

update: log correction for sub class

update log correction for sub class

add subclass to dbc enforcement

add subclass dbc enforcement since it is part of the item.dbc item_dbc

update (log): additional log

Co-authored-by: blub <trinity.michael_vincent@gmx.eu>
Co-authored-by: Shocker <511388+shocker@users.noreply.github.com>
Co-authored-by: Veil <1913466+menevia16a@users.noreply.github.com>
Co-authored-by: Shocker <43253032+shockerqt@users.noreply.github.com>
2023-04-28 01:26:44 +02:00
daobashun
fa59b30184 fix(Scripts/IcecrownCitadel): Tirion Fordring attacks the Lich King empty-handed (#15823)
* Fixed Tirion Fordring's final stage attacking the Lich King empty-handed

* Tirion Fordring's uses text in BroadcastText to speak

* Code format changes

* Add data to the data table

* Update rev_1680658371591699800.sql

Change from INSERT to INSERT/INSERT

* Update and rename boss_the_lich_king.cpp to boss_the_lich_king.cpp的

Remove useless comments

* Rename boss_the_lich_king.cpp的 to boss_the_lich_king.cpp

The input method caused an unexpected rename

* Delete the extra rows

* Update boss_the_lich_king.cpp

Delete references that can be omitted
2023-04-26 23:04:37 -03:00
avarishd
a275a7c464 fix(Core/SmartScripts): Add Triggered Flags for CAST & INVOKER_CAST (#16045)
* cast/invoker_cast

* Update SmartScript.cpp

* {}
2023-04-25 06:21:16 -03:00
天鹿
df77b5f4f7 chore(core): cleanup code p3 (#16073)
* Update MMapMgr.cpp

* Update UpdateFetcher.cpp

* Update AuctionHouseMgr.cpp

* Update AuctionHouseMgr.h

* Update BattlegroundAV.cpp

* Update ChannelMgr.cpp

* Update ThreatMgr.h

* Update Player.h

* Update PlayerSettings.cpp

* Update ObjectMgr.cpp

* Update Guild.cpp

* Update Guild.h

* Update Map.cpp

* Update World.cpp

* Update boss_nefarian.cpp

* Update boss_prince_malchezaar.cpp

* Update boss_venoxis.cpp

* Update zone_elwynn_forest.cpp

* Update zulfarrak.cpp

* Update boss_novos.cpp
2023-04-24 08:13:07 -03:00
Gultask
c3948567e2 fix(Scripts/ShatteredHalls): Update Grand Warlock Netherkurse (#16063)
init
2023-04-23 09:06:08 -03:00
Skjalf
6e7493e8df fix(Scripts/ShadowLabirynth): Clean up script and fix doors (#16061)
* fix(Scripts/ShadowLabirynth): Clean up script and fix doors

* Update instance_shadow_labyrinth.cpp

* Update boss_ambassador_hellmaw.cpp
2023-04-23 08:32:39 -03:00
Skjalf
fc7d2aedb0 refactor(Scripts/ShadowLabirynth): Rework Grandmaster Vorpil (#16053) 2023-04-22 11:59:38 -03:00
Skjalf
ace0cee18c fix(Scripts/ShadowLabs): Fix Murmur Touch dealing damage twice (#16058) 2023-04-22 11:17:51 -03:00
ZhengPeiRu21
0667454dd9 feat: Allow Float Rep Values (#15818) 2023-04-22 10:42:00 -03:00
Timothy Vaccarelli
309f5c4adf fix(DB/SAI): Use SAI for Spitelash Naga in Azshara (#15808)
* Add SAI for Spitelash Naga in Azshara
2023-04-22 10:22:34 -03:00
Gultask
3dc7a89ad2 fix(DB/ShatteredHalls): Re-Construct Shattered Halls (#15990)
* init

* Legionnaire Gauntlet

* barracks pt1

* barracks done

* sewers

* Sparring Hall spawns

* Update rev_1680974634766349300.sql

* Update rev_1680974634766349300.sql

* Update rev_1680974634766349300.sql

* Update rev_1680974634766349300.sql

* Update rev_1680974634766349300.sql

* rest of spawns

* cleanup and linking

* errors and leftovers

* tweak

* Update data/sql/updates/pending_db_world/rev_1680974634766349300.sql

* more emotestates

* dont remove executioner
2023-04-22 10:12:11 -03:00
ZhengPeiRu21
1e26cdbee9 fix(Core): Save bonus talent points to DB (#14099)
* fix(Core): Save bonus talent points to DB

* fix(Core): Save bonus talent points to DB

* Oxford comma in comment
2023-04-22 10:09:18 -03:00
avarishd
8696e7be7f fix(DB/Creature): Tamed Kodo - Remove gosisp flag. (#15165)
* fix(DB/Creature): Tamed Kodo - Remove gosisp flag.

* fix worldserver warning (assigned gossip, but no flag)

also typo

* Use &~
2023-04-22 10:08:25 -03:00
UltraNix
790417b1b1 fix(Core/Spells): Fixed somed Druid idols not being modified by spell… (#15452)
fix(Core/Spells): Fixed somed Druid idols not being modified by spell power coefficients.

Fixes #14479
2023-04-22 10:08:01 -03:00
Dan
43cbe6a152 fix(Scripts/ManaTombs): Yor stomp added (#15986) 2023-04-22 10:05:32 -03:00
Tereneckla
2e9cb71987 fix(Core/Player): Reduce Health Regeneration bonus while sitting to 33% (#15954)
Update Player.cpp
2023-04-21 15:18:23 -03:00
avarishd
72f111dd65 fix(Scripts/Creature): Add Ravenclaw Apparition event. (#15200) 2023-04-21 15:06:08 -03:00
Eddy Vega
953b9aa8b7 fix(Scripts/Naxxramas): Improve Gothik's minions (#15979)
init
2023-04-21 15:03:04 -03:00
Tereneckla
67125caeb0 fix(Core/Player): Food healing does not increased by sitting down (#15959) 2023-04-21 14:54:44 -03:00