Commit Graph

219 Commits

Author SHA1 Message Date
Andrew
734bcb5d10 chore(Core/Creature): Fix typo (#20510) 2024-11-10 15:21:58 +01:00
Andrew
d73ebe2e38 fix(Core/SAI): Don't try to reposition Rooted inhabit type creatures (#20504) 2024-11-10 04:54:01 -03:00
@cgrahamseven
1c1a281eda fix(Core/SAI): rooted check blocks vehicles from casting quest credit (#20283)
spell

The quest SteamTank Surprise has a SmartAI entry in the db that causes
the tank to cast the kill credit spell on the player when they
successfully destroy a plague wagon. Currently, this spell cast is being
blocked by the rooted check handler for SMART_ACTION_CAST. The change
proposes that this rooted check should not apply to vehicles.

Closes AzerothCore issue #20237

Co-authored-by: cgrahamseven <chris.graham@protonmail.com>
2024-10-24 06:57:52 -03:00
Dan Costinas
87aeaf10fd fix(Core/SmartAI) : use explicit stack DS for ProcessAction instead of recursion (#16739)
* Use dequeue instead of recursion

* Remove to do comments

* Fix formatting

* Fix more formatting :(

* Use references instead of copies in the stack to correctly update event state

* formatting

* Revert FindLinkedEvent parameter name change and check for event type

* Fix event processing in SmartScript::UpdateTimer

* Use struct for defining SmartScriptFrame instead of tuple

* Fix emplace_back not working on default constructor on clang 15

* Fix const placement
2024-10-22 17:31:45 +02:00
Francesco Borzì
d8c56392fb refactor(src/server/game/AI): remove unused imports (#20095) 2024-10-01 08:04:00 +02:00
Kitzunu
386aea03ee chore(Core/Misc): Some cleanup (#19970)
* remove weird blanks

* update if

* ) ) to ))

* missed some ) )

* now switch

* .
2024-09-21 19:34:31 +02:00
Benjamin Jackson
1edac37ac3 refactor(Core): Make more use of helpers. (#19835)
* Init.

* Reword.

* Update codestyle script.

Co-Authored-By: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* Add gameobject type ID check, reorder checks.

* Add helper/codestyle check for unit type.

* `IsUnit()` -> `IsCreature()`

* Add `IsUnit()` method.

* Use type mask.

https: //github.com/TrinityCore/TrinityCore/commit/cc71da35b5dc74abf71f8691161525a23d870bb5
Co-Authored-By: Giacomo Pozzoni <giacomopoz@gmail.com>
Co-Authored-By: Ovahlord <18347559+Ovahlord@users.noreply.github.com>

* Replace instances of `isType` with `IsUnit`.

---------

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
Co-authored-by: Ovahlord <18347559+Ovahlord@users.noreply.github.com>
2024-09-03 14:41:31 -03:00
Gultask
8852f0c74c feat(Core/SmartScripts): Implement Scripted Spawn System (#19499)
* prespawn2

* pfta

* Update rev_1717715555182000500.sql

* Update rev_1717715555182000500.sql

* Update rev_1717715555182000500.sql

* Update rev_1717715555182000500.sql

* Update rev_1717715555182000500.sql

* Update rev_1717715555182000500.sql
2024-08-28 08:18:02 -03:00
Grimdhex
643362d697 refactor(Core/Object): adds consistency in the use of type object check (#19671) 2024-08-25 09:57:37 -03:00
Kitzunu
337135bf9e refactor(Core/Misc): Use NpcFlag helpers (#19676)
* chore(Core/Misc): Use HasNpcFlag instead of HasFlag

* extend to all npcflag helpers
2024-08-19 10:17:02 +02:00
Francesco Borzì
02a05fbd4c refactor(src/common): remove unused imports (#19506)
* refactor(src/common): remove unused imports

* fix: build

* chore: fix build

* chore: size_t -> std::size_t

* chore: fix fuckup from previous commit

* chore: fix build

* chore: fix build

* chore: fix build

* chore: fix build with std::size_t

* chore: fix build

* chore: fix build

* chore: fix build

* chore: fix build

* chore: fix build

* chore: fix build

* chore: fix build

* chore: fix build

* chore: fix build

* chore: fix build

* chore: fix build

* chore: fix build
2024-07-30 20:06:46 -03:00
Kitzunu
5da3e2e688 refactor(Core/SmartScripts): Change invoker to be WorldObject (#19408)
* refactor(Core/SmartScripts): Change invoker to be WorldObject

* avoid dangling else

* womp womp

* check for null

* null check

* Update SmartScript.cpp

* Avarishd broke it for sure

* remove redundant check

* reduce more redundant code

* who doesnt love redundancy
2024-07-27 07:32:55 -03:00
sudlud
37e3d89f91 fix(CI): linux-build: add -Werror parameter (#19240)
* fix(CI): linux-build: add -Werror parameter

* add KI

tzunu

* Revert "feat(CI): enable fail-fast for pch/nopch (#19058)"

This reverts commit 564cbca7d3.

* Update midsummer.cpp - drop unused variable

* initialize variable

* Update core-build-nopch.yml - drop gcc12

* fix(Core/CalendarMgr): do not use element after delete, but before

* attempt to fix Socket.h error

* Revert "attempt to fix Socket.h error"

This reverts commit c1a59145ed3c49d0f76be2f81925434ea969db97.

* fix Socket.h error - attempt 2

* Update Socket.h

* Update Socket.h

* npc_shattrath_daily_quest: init variable templateID

* fix(Scripts/Karazhan): use size_t within loop in boss_shade_of_aran:Reset()

* boss_archimonde: drop unused variable

* Revert "fix(Scripts/Karazhan): use size_t within loop in boss_shade_of_aran:Reset()"

This reverts commit 1f71aaef256990c5cdc16561676be302c954ea9d.

* SmartScripts: SMART_TARGET_RANDOM_POINT: fix unintended fallthrough

* Revert "Revert "feat(CI): enable fail-fast for pch/nopch (#19058)""

This reverts commit d13df293624e0f50d9374272bfd05ab56242511d.

---------

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2024-07-07 22:00:24 +02:00
Kitzunu
f42ed2efa5 feat(Core/SAI): SetData now has invoker (#19296)
* cherry-pick commit (cfc77fd843)

* cherry-pick commit (beb333738d)

* Move IsSmart function from headerfile

Co-authored-by: Treeston <14020072+Treeston@users.noreply.github.com>
Co-authored-by: Shauren <shauren.trinity@gmail.com>
2024-07-06 13:46:10 +02:00
Gultask
89a6996628 fix(Scripts/SmartAI): Rewrite ACTION_MOVE_TO_POS (#19190)
* init

* Update SmartScript.cpp

* combatReach

* Update SmartScript.cpp
2024-07-05 15:07:56 -03:00
Kitzunu
e878cedb7f feat(Core/SAI): implement new removeObjectFromWorld param for SMART_A… (#19275)
feat(Core/SAI): implement new removeObjectFromWorld param for SMART_ACTION_FORCE_DESPAWN
2024-07-04 14:20:41 -03:00
Benjamin Jackson
d6d49a9e45 refactor(Core/ObjectMgr): Implement display probabilities. (#19068)
* Init.

Cherry-picked from TC commits 9d210476e5 and c488fb219a

Co-Authored-By: Traesh <9392905+traesh@users.noreply.github.com>
Co-Authored-By: Shauren <shauren.trinity@gmail.com>

* Add brute data.

Needs validation against what existed before, i.e. Classic change prevention.

* Add validation info for brute data.

* Remove incomplete data queries.

* Requested changes.

* Whitespace.

* Requested change.

Table name.

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* Requested change.

Table name.

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* Resolve the funny merge conflicts.

I wonder why git blame doesn't work on a file with 20k lines in it that's odd huh champ.

* Remove unused parameter.

* Remove uses of unused parameter.

* Use unused parameter.

Hopefully?

* I will cry.

* Sobbing endlessly.

* Remove comment.

* Adjust table structure query.

Remove length parameters and allow null for build value.

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* Adjust column datatype and add check constraint.

---------

Co-authored-by: Traesh <9392905+traesh@users.noreply.github.com>
Co-authored-by: Shauren <shauren.trinity@gmail.com>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2024-06-16 18:12:16 +02:00
Walter Pagani
03f6dde549 fix(Core/SmartAI) fatal error: unused parameter pathId (#18795)
fix. fatal error: unused parameter pathId
2024-04-24 08:22:24 -03:00
Gultask
6f154d0a6b feat(Core/SmartAI): Add support for waypoint_data in SAI (#18706)
* Create rev_1712670662273633900.sql

* eol?

* doesn't like a comment at the end, ok, ok

* init

* mack

* Update SmartScript.cpp

* kurzel

* random paths and garg

* Update rev_1712889530436412200.sql

* brend & marge

* Update rev_1712889530436412200.sql

* movement actions

* Update SmartScriptMgr.h
2024-04-18 10:31:41 -03:00
skelUA
0c964dadae fix (Core/Scripting): SMART_EVENT_NEAR_PLAYERS (#18514)
* FIX SMART_EVENT_NEAR_PLAYERS

* FIX SMART_EVENT_NEAR_PLAYERS (fix build)
2024-03-20 01:38:57 -03:00
skelUA
da453b2a8d fix(Core/SmartScripts): LOS check spell for SmartScipts (#18501)
* Fix spell 35329 (Vibrant Blood)

* [PATCH] Flight of the Wintergarde Defender fix (https://forums.wow.sumy.ua/viewtopic.php?p=35#p35)

* Revert "[PATCH] Flight of the Wintergarde Defender fix (https://forums.wow.sumy.ua/viewtopic.php?p=35#p35)"

This reverts commit 2eaeb78bdee5b09f1ea5685a9b039f9221df4abe.

* Revert "Fix spell 35329 (Vibrant Blood)"

This reverts commit 0e7ee59588709050e2af9cc15e8ff1ed358936b2.

* Revert "Revert "Fix spell 35329 (Vibrant Blood)""

This reverts commit 5e4424b4d81ec3c1de1d6f73e48d848e63e92b79.

* Revert "Revert "[PATCH] Flight of the Wintergarde Defender fix (https://forums.wow.sumy.ua/viewtopic.php?p=35#p35)""

This reverts commit b3a9553a45e81f65b2eb15f127c5ca9eb99b6d1e.

* Revert "Revert "Revert "[PATCH] Flight of the Wintergarde Defender fix (https://forums.wow.sumy.ua/viewtopic.php?p=35#p35)"""

This reverts commit 0ced477c767b9087eefdf516d0e0fccf1567e6e3.

* Revert "Revert "Revert "Fix spell 35329 (Vibrant Blood)"""

This reverts commit a8da732cfb4369f218e96175fc8f33eafc1e69c9.

* Revert "Revert "Fix spell 35329 (Vibrant Blood)""

This reverts commit 5e4424b4d81ec3c1de1d6f73e48d848e63e92b79.

* Revert "Revert "[PATCH] Flight of the Wintergarde Defender fix (https://forums.wow.sumy.ua/viewtopic.php?p=35#p35)""

This reverts commit b3a9553a45e81f65b2eb15f127c5ca9eb99b6d1e.

* Revert "[PATCH] Flight of the Wintergarde Defender fix (https://forums.wow.sumy.ua/viewtopic.php?p=35#p35)"

This reverts commit 2eaeb78bdee5b09f1ea5685a9b039f9221df4abe.

* Revert "Fix spell 35329 (Vibrant Blood)"

This reverts commit 0e7ee59588709050e2af9cc15e8ff1ed358936b2.

* FIX LOS SAI
2024-03-08 11:15:45 -03:00
Dan
4fcd3402ca fix(Core/SmartAI): implement param maxCount for SMART_TARGET_PLAYER_RANGE (#18394)
* init

* conditional
2024-02-25 11:50:07 -03:00
AG
8f127f9e21 Fix combat movement (#18026)
* Improve combat movement

 - Removed a bunch of logic related to another attempt at fixing combat movement.
- Removed SMART_ACTION_SET_CASTER_COMBAT_DIST and updated smarts scripts accordingly.
- Cherry-picked 7fb7432620
- Cherry-picked 63a6e1e048

Co-Authored-By: Ludovic Barbier <ludovic.barbier03@gmail.com>
Co-Authored-By: Giacomo Pozzoni <giacomopoz@gmail.com>

* Some more cleanup + fix sql

* More fixes to caster chase/combat movement + some cherry picks because why not

- Fix casters always trying to chase to melee range
- Fix casters another case of casters sometimes walking back instead of stopping
- Cleaned up some code
- Cherry picked ca25e8d019
- Cherry picked 96b289cadb

Co-Authored-By: Giacomo Pozzoni <giacomopoz@gmail.com>

* Added parentheses

* Fixed caster combat movement when target is rooted

- Made a few adjustments to chase range and stuff, but nothing set in stone.

* convert uint to int

---------

Co-authored-by: Ludovic Barbier <ludovic.barbier03@gmail.com>
Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
2024-01-03 09:56:24 +01:00
avarishd
03d06da87b feat(Core/SmartScripts): SMART_EVENT_SUMMONED_UNIT_EVADE (#18018)
* feat(Core/SmartScripts): SMART_EVENT_SUMMONED_UNIT_EVADE

* .
2023-12-15 09:43:24 -03:00
Angelo Venturini
10c9a2729b fix(Core/SAI/SSC): Allow Farthest target to set a min distance (#17992) 2023-12-11 19:57:44 -03:00
Winfidonarleyan
eb1ecc38a5 feat(Core/Scripting): move all script objects to separated files (#17860)
* feat(Core/Scripts): move all script objects to separated files

* Apply 5bfeabde81

* try gcc build

* again
2023-12-02 21:13:20 +01:00
Gultask
e422583132 feat(Core/SmartAI): Implement a few more stuff (#17090)
* init

* init2

* attempt to fix WP delays

* init3

* init4

* buildfix

* Create rev_1693093120417899200.sql

* workflow

* Underbat

* castflag power mana

* did not work

* Update SmartScriptMgr.cpp

* ugly

* port range to new system

* attempt

* simplify cast

simplify cast
add iteration for aura_not_present
recalc timer if already castig spell

* Update SmartScript.cpp

* attempt

* attempts

* HP PCT

* missing aura to targetselector

* Update rev_1693093120417899200.sql

* Update SmartScriptMgr.h

* Update SmartScriptMgr.h

* Update SmartScript.cpp

* remove not_attacking, fix behind_me

* revert is_behind_me

* Update SmartScriptMgr.h

* Update underbog.cpp

* Update underbog.cpp
2023-09-10 13:12:55 +02:00
Francesco Borzì
5d01b700fd refactor(Core): remove unused imports (#17094) 2023-08-28 13:39:43 +02:00
Gultask
e42f43784c feat(Core/SmartAI): Implement SMART_ACTION_FOLLOW_GROUP (#17033)
* Update SmartScript.cpp

* INIT

* add as coauthor as well :)

Co-Authored-By: cyberium <346907+cyberium@users.noreply.github.com>

* codestyle

* test?

---------

Co-authored-by: cyberium <346907+cyberium@users.noreply.github.com>
2023-08-22 12:11:21 +02:00
Gultask
8d803334eb feat(Core/SmartAI): Add new event parameter, event_param6 (#16944)
* init

* pt2

* this template stuff must go

* also for my other event
2023-08-12 14:53:15 -03:00
Gultask
0276b141a8 feat(Core/SmartAI): Implement castFlag THREATLIST_NOT_SINGLE (#16911)
* init

* Update SmartScript.cpp
2023-08-06 20:25:31 +02:00
Gultask
52aa18f8bd feat(Core/SmartAI): Implement AoE variants of VICTIM_CASTING and RANGE events (#16720)
* init

* areaRange

* Update SmartScript.cpp

* error checks

* update SAI for area range

* areaCasting

* more

* Update rev_1689199652093827600.sql

* typo

* dont interrupt totems

* Update SmartScriptMgr.cpp

* target type needs to be 7

* Update rev_1689199652093827600.sql
2023-07-30 10:17:48 +02:00
天鹿
893a9beeac fix(Core/SmartScripts): Fix a check (#16663) 2023-07-05 09:25:02 +02:00
Gultask
9d7e472160 chore(Core/SmartAI): Add min/max timer error check for NEAR_PLAYERS (#16661)
Update SmartScriptMgr.cpp
2023-07-02 09:15:52 -03:00
Gultask
54f8386d99 feat(Core/SmartAI): Add more smart events (#16642)
* init

* :)

* Update rev_1687966694240866600.sql

* >:)

change name from unit -> target
fix typo

Co-Authored-By: Angelo Venturini <nefertum.dev@protonmail.com>

* Update data/sql/updates/pending_db_world/rev_1687966694240866600.sql

Co-authored-by: Francesco Borzì <borzifrancesco@gmail.com>

* more_events

* Update SmartScriptMgr.cpp

---------

Co-authored-by: Angelo Venturini <nefertum.dev@protonmail.com>
Co-authored-by: Francesco Borzì <borzifrancesco@gmail.com>
2023-07-02 08:57:56 +02:00
Gultask
7ec04d1408 feat(Core/SAI): Implement New Smart Actions SET_SCALE & SUMMON_RADIAL (#16444)
* init

* Update SmartScriptMgr.cpp

* Update SmartScript.cpp

* Update SmartScriptMgr.h

* more

* scale

* dist offset

* Update SmartScriptMgr.h
2023-06-27 19:34:26 -03:00
Gultask
7dcbf7c618 chore(Core/SAI): Allow ACTION_FOLLOW to stop follow movement if target type is SELF or NONE (#16445)
Update SmartScript.cpp
2023-06-25 15:04:20 -03:00
Angelo Venturini
d204eccdea fix(Core/SmartScripts): Allow SAI_ACTION_DIE to accept params (#16411) 2023-05-31 23:32:15 -03:00
Gultask
d696a85797 fix(Core/SAI): Allow LINK events to use event_chance (#16308) 2023-05-24 14:01:11 -03:00
Gultask
69fab3df70 feat(Core/SAI): Implement SMART_ACTION_DISABLE (#16254)
* init

* Create rev_1684036819129474700.sql

* Update rev_1684036819129474700.sql
2023-05-17 09:31:50 -03:00
天鹿
ab7c12fe41 chore(core): Cleanup code p2 (#16041)
* Update AchievementMgr.cpp

* Update M2Stores.cpp

* Update LFGHandler.cpp

* Update PetHandler.cpp

* Update WaypointMovementGenerator.cpp

* Update ScriptMgr.cpp

* Update SpellAuras.cpp

* Update Spell.cpp

* Update SecretMgr.cpp

* Update SpellScript.cpp

* Update SecretMgr.cpp

* Update Spell.cpp

* Update SpellAuras.cpp

* Add files via upload

* Update PetHandler.cpp

* Update PetHandler.cpp

* Update CalendarMgr.cpp

* Update LFG.h

* Update WaypointMovementGenerator.cpp

* Update MapScripts.cpp

* Update Unit.cpp

* Update SmartScript.cpp
2023-05-13 15:00:29 -03:00
M'Dic
ab2c062f03 feat(core\dbc): item.dbc, sItemStore, item_dbc, item enforcement conf, subclass fix (#14675)
feat (core\log\db): item.dbc and enforcement

dbc enforcement partial pick from tc: 0c44bd33ee

Custom Item for testing by menevia16a (SPP DEV VEIL)

feat (core\log\db): item.dbc and enforcement

Update Item.sql

Update DBCStores.cpp

Update World.cpp

Update ObjectMgr.cpp

further replacement from template to dbc lookup

further logging and implementation

cherry pick tc fd26c3c87c

replace with db lookup

update (sql): Murder all the backticks

line break fixit

fix (item_template): fix incorrect subclass

fix incorrect subclass matching with dbc enforcement

update: log correction for sub class

update log correction for sub class

add subclass to dbc enforcement

add subclass dbc enforcement since it is part of the item.dbc item_dbc

update (log): additional log

Co-authored-by: blub <trinity.michael_vincent@gmx.eu>
Co-authored-by: Shocker <511388+shocker@users.noreply.github.com>
Co-authored-by: Veil <1913466+menevia16a@users.noreply.github.com>
Co-authored-by: Shocker <43253032+shockerqt@users.noreply.github.com>
2023-04-28 01:26:44 +02:00
avarishd
a275a7c464 fix(Core/SmartScripts): Add Triggered Flags for CAST & INVOKER_CAST (#16045)
* cast/invoker_cast

* Update SmartScript.cpp

* {}
2023-04-25 06:21:16 -03:00
天鹿
d75bcf0f67 chore(core): Cleanup code (#16012)
* Update SmartScript.cpp

* Update M2Stores.cpp

* Update PetHandler.cpp

* Update WaypointMovementGenerator.cpp

* Update WorldSession.cpp

* Update spell_item.cpp

* Update LoginDatabase.cpp
2023-04-19 21:34:48 -03:00
IntelligentQuantum
87ea455bec feat(Core/SmartScripts): SMART_ACTION_SELF_CAST (#14371)
* feat(Core/SmartScripts): SMART_ACTION_SELF_CAST

* Update SmartScriptMgr.cpp
2023-04-17 21:07:59 -03:00
M'Dic
8aa2a2ac0f chore (core): Clean up (#15977)
* chore (core): Clean up

* Update SmartScript.cpp

* more clean up

* Update boss_xt002.cpp
2023-04-16 21:04:56 -04:00
Skjalf
f3c63f9662 feat(Core/SAI): Implement SMART_ACTION_SET_GUID (#15978)
* feat(Core/SAI): Implement SMART_ACTION_SET_GUID

* Update SmartScript.cpp

* Update src/server/game/AI/SmartScripts/SmartScriptMgr.h

* Update SmartScript.cpp
2023-04-16 21:00:44 -03:00
Skjalf
8fa0953671 feat(Core/Creature): Implement CREATURE_FLAG_EXTRA_DONT_OVERRIDE_ENTR… (#15976)
feat(Core/Creature): Implement CREATURE_FLAG_EXTRA_DONT_OVERRIDE_ENTRY_SAI
2023-04-16 19:45:09 -03:00
Gultask
aaa548df0b Revert "fix(Core/SAI): Set minions in combat with their master's vict… (#15967)
Revert "fix(Core/SAI): Set minions in combat with their master's victim (#14959)"

This reverts commit 1e17eaae0b.
2023-04-15 19:49:03 -03:00
Gultask
fd6941de7c fix(Core/SmartAI): Prevent MOVE_TO_POS from creating large distances between target (#15899)
Update SmartScript.cpp
2023-04-09 23:44:52 -03:00