Commit Graph

545 Commits

Author SHA1 Message Date
avarishd
38509d2b3a fix(Core/Spells): Apply AURA_STATE_FAERIE_FIRE to Lambent Blood. (#16103) 2023-05-13 14:11:04 -03:00
Gultask
64c7c99bda revert(Core/Player): Revert Delayed Damage System (#16246)
* Revert "fix(Core/Spells): Delayed Damage system (#16183)"

This reverts commit d282cce4af.

* Revert "fix: Crash on ProcessDelayedDamages (#16166)"

This reverts commit 3dbdea5e28.

* Revert "fix(core\player): Missing combat animation (#14199)"

This reverts commit a238e5e27b.
2023-05-13 13:50:27 -03:00
avarishd
3aedf2fbf8 fix(DB/SAI): Void Baron Galaxis encounter. (#15312)
* fix(DB/SAI): Void Baron Galaxis encounter.

* remove item cast + add void storm cloud
2023-05-10 06:29:51 -03:00
M'Dic
7e58650cf5 revert(Core): ChrRace.dbc full implementation (#16114)
* revert (core): ChrRace.dbc full implementation

we revert this due to several issues arrising. Although the dbc reading is done in full and correctly. Azerothcore relied on the original handling (althought not propper) for so long that  there is

* revert

* Update remove_charrace_dbc.sql

* Update remove_charrace_dbc.sql

* Update remove_charrace_dbc.sql
2023-04-29 08:23:11 -03:00
M'Dic
a238e5e27b fix(core\player): Missing combat animation (#14199) 2023-04-29 12:27:13 +02:00
M'Dic
3eae4c5713 fix(core/dbc): improve ChrRace DBC handling (#14843)
Cherry pick of https://github.com/TrinityCore/TrinityCore/pull/24508

Co-authored-by: HelloKitty <5829095+HelloKitty@users.noreply.github.com>
2023-04-28 01:29:33 +02:00
M'Dic
ab2c062f03 feat(core\dbc): item.dbc, sItemStore, item_dbc, item enforcement conf, subclass fix (#14675)
feat (core\log\db): item.dbc and enforcement

dbc enforcement partial pick from tc: 0c44bd33ee

Custom Item for testing by menevia16a (SPP DEV VEIL)

feat (core\log\db): item.dbc and enforcement

Update Item.sql

Update DBCStores.cpp

Update World.cpp

Update ObjectMgr.cpp

further replacement from template to dbc lookup

further logging and implementation

cherry pick tc fd26c3c87c

replace with db lookup

update (sql): Murder all the backticks

line break fixit

fix (item_template): fix incorrect subclass

fix incorrect subclass matching with dbc enforcement

update: log correction for sub class

update log correction for sub class

add subclass to dbc enforcement

add subclass dbc enforcement since it is part of the item.dbc item_dbc

update (log): additional log

Co-authored-by: blub <trinity.michael_vincent@gmx.eu>
Co-authored-by: Shocker <511388+shocker@users.noreply.github.com>
Co-authored-by: Veil <1913466+menevia16a@users.noreply.github.com>
Co-authored-by: Shocker <43253032+shockerqt@users.noreply.github.com>
2023-04-28 01:26:44 +02:00
Gultask
3dc7a89ad2 fix(DB/ShatteredHalls): Re-Construct Shattered Halls (#15990)
* init

* Legionnaire Gauntlet

* barracks pt1

* barracks done

* sewers

* Sparring Hall spawns

* Update rev_1680974634766349300.sql

* Update rev_1680974634766349300.sql

* Update rev_1680974634766349300.sql

* Update rev_1680974634766349300.sql

* Update rev_1680974634766349300.sql

* rest of spawns

* cleanup and linking

* errors and leftovers

* tweak

* Update data/sql/updates/pending_db_world/rev_1680974634766349300.sql

* more emotestates

* dont remove executioner
2023-04-22 10:12:11 -03:00
UltraNix
790417b1b1 fix(Core/Spells): Fixed somed Druid idols not being modified by spell… (#15452)
fix(Core/Spells): Fixed somed Druid idols not being modified by spell power coefficients.

Fixes #14479
2023-04-22 10:08:01 -03:00
Kitzunu
7eafd35190 chore(Spell/Effects): Small improvement to EffectDistract (#15920)
* chore(Spell/Effects): Small improvement to EffectDistract

* Update SpellEffects.cpp
2023-04-21 07:41:01 -03:00
M'Dic
8aa2a2ac0f chore (core): Clean up (#15977)
* chore (core): Clean up

* Update SmartScript.cpp

* more clean up

* Update boss_xt002.cpp
2023-04-16 21:04:56 -04:00
Gultask
d851e79a90 fix(DB/ShadowLab): Re-Construct Shadow Labyrinth (#15635)
* Create rev_1679869717906181100.sql

* Update rev_1679869717906181100.sql

* Update rev_1679869717906181100.sql

* Update rev_1679869717906181100.sql

* Update rev_1679869717906181100.sql

* WIP

* build

* more random spawns

* reorganize spawns to be more readable

* equip_id

* All scripted up to Murmur

* Murmur RP

* avoid many reschedulings

* Missing heroic ritualists

* Update rev_1679869717906181100.sql

* leftovers

* variables
2023-04-05 23:52:52 -03:00
UltraNix
a72f5f97e6 fix(Core/Spells): Implemented ENCHANT_PROC_ATTR_EXCLUSIVE. (#15476)
Fixes #12132
2023-04-02 15:28:23 -03:00
UltraNix
d029ffe3ab fix(Core/Spells): Fixed Battlegear of Eternal Justice set bonus. (#15593)
Fixes #14696
2023-04-02 15:28:03 -03:00
UltraNix
1acbb9ee53 fix(Core/Spells): Fixed Spiritual Attunement not working with partial… (#15767)
fix(Core/Spells): Fixed Spiritual Attunement not working with partial overheals.

Fixes #14430
2023-04-02 10:13:16 -03:00
UltraNix
1160f3bda9 fix(Core/Spells): Turn the Tables can stack with itself. (#15597)
Fixes #13911
2023-03-29 00:28:56 -03:00
UltraNix
a90c3c387d fix(Core/Spells): Seed of Corruption cannot be reflected. (#15473)
* fix(Core/Spells): Seed of Corruption cannot be reflected.

Fixes #15458

* Update.
2023-03-24 06:25:12 -03:00
avarishd
7f7ec62a0a fix(Core/Spells): Healing Salve having cast time. (#15329) 2023-03-17 17:38:54 +01:00
Kitzunu
422db05290 fix(Core/Spell): Removed gathering failure chance from herbalism and … (#15423)
fix(Core/Spell): Removed gathering failure chance from herbalism and mining nodes

* cherry-pick commit (052dfe27fc)

Co-authored-by: Tony Konzel <saxxonpike@gmail.com>
2023-03-17 10:24:36 +01:00
avarishd
aa3e2e052a fix(Core/Spells): Draenei Call of Air 4/4 Susurrus buff duration. (#15255) 2023-03-16 19:02:31 +01:00
Pedro Antonio
175c961c54 fix(Core/BattlefieldWG): Workshops/Graveyard not changing to neutral (#14002) 2023-03-16 18:51:59 +01:00
UltraNix
b21f98d639 fix(Scripts/Karazhan): Chess Event. (#14736) 2023-03-15 00:07:49 -03:00
avarishd
6270c6ab64 fix(Scripts/Ulduar): Yogg-Saron hardcode & some adustments. (#15146) 2023-03-13 10:19:08 -03:00
Maelthyr
0200a288cd refactor(Scripts/Northrend): conversion to std::chrono (#15269)
Co-authored-by: Maelthyrr <maelthyrr@users.noreply.github.com>
2023-03-07 09:23:33 -03:00
Gultask
0b04c7f3b6 fix(Core/Spells): Un-hack Spellcloth trigger spell (#15284)
Co-authored-by: Skjalf <47818697+Nyeriah@users.noreply.github.com>
2023-03-05 16:29:41 -03:00
UltraNix
88401360ab fix(Core/Spells): Seal of Command, Seal of Vengeance and Seal of Corr… (#15193) 2023-03-04 17:40:33 -03:00
UltraNix
e3ed2e99e6 fix(Core/Spells): Goblin Rocket Helmet should not cause auto-attack. (#15207) 2023-03-04 17:39:05 -03:00
Skjalf
fff0e17133 fix(Core/Cooldown): Implement spell cooldown overrides to address cha… (#15143) 2023-02-22 23:00:18 -03:00
Kitzunu
f039836a2f chore(Core/Misc): Change all TODO to doxygen comment (#14966) 2023-02-12 10:05:34 -03:00
UltraNix
579a1c0fa4 fix(Scripts/Spells): Nether Portal - Perseverence should not increase… (#13951) 2023-01-31 22:54:23 +01:00
UltraNix
8981f58682 fix(Core/Spells): Cleasing, Healing Stream Mana Tide totems should ig… (#14679) 2023-01-31 10:53:17 -03:00
Skjalf
2aeeee9c83 fix(Core/Spells): Remove all hardcoded restrictions for pick pocket sp… (#14788)
Co-authored-by: Shauren <shauren.trinity@gmail.com>
2023-01-29 12:12:21 -03:00
UltraNix
7f7a2f5a92 fix(Core/Creatures): Critters should start fleeing upon entering comb… (#14253) 2023-01-28 11:01:43 +01:00
UltraNix
9b59f35cb8 fix(Core/Spells): Fixed Master of Elements not refunding mana. (#14665) 2023-01-28 10:59:25 +01:00
UltraNix
44226e4754 fix(Core/Spells): Update crit chance on shapeshifting to/from feral f… (#14683) 2023-01-28 10:57:38 +01:00
NinjaPleezAC
716a822b48 fix(Core/Unit): Petrified Lichen Guard effect (#14436)
Co-authored-by: NinjaSoftworks <121171014+NinjaSoftworks@users.noreply.github.com>
2023-01-26 14:58:12 -05:00
UltraNix
3fee40be7d fix(Core/Creatures): Spells casted by player should tap the creature … (#14725)
…only if in combat with it.
2023-01-26 04:38:16 -03:00
UltraNix
ff8374ac98 fix(DB/SAI): Caretaker Smither. (#14445)
Fixes #14384
Author: @Gultask 

<!-- First of all, THANK YOU for your contribution. -->

## Issues Addressed:
<!-- If your fix has a relating issue, link it below -->
- Closes #14384

## Tests Performed:
<!-- Does it build without errors? Did you test in-game? What did you
test? On which OS did you test? Describe any other tests performed -->
- Tested ingame.

## How to Test the Changes:
<!-- Describe in a detailed step-by-step order how to test the changes
-->
`.go c id 20363`

<!-- If you intend to contribute repeatedly to our project, it is a good
idea to join our discord channel. We set ranks for our contributors and
give them access to special resources or knowledge:
https://discord.com/invite/DasJqPba)
Do not remove the instructions below about testing, they will help users
to test your PR -->
## How to Test AzerothCore PRs
 
When a PR is ready to be tested, it will be marked as **[WAITING TO BE
TESTED]**.

You can help by testing PRs and writing your feedback here on the PR's
page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

**REMEMBER**: when testing a PR that changes something **generic** (i.e.
a part of code that handles more than one specific thing), the tester
should not only check that the PR does its job (e.g. fixing spell XXX)
but **especially** check that the PR does not cause any regression (i.e.
introducing new bugs).

**For example**: if a PR fixes spell X by changing a part of code that
handles spells X, Y, and Z, we should not only test X, but **we should
test Y and Z as well**.

Co-authored-by: Gultask <gultask@gmail.com>
2023-01-25 17:00:19 -03:00
M'Dic
437d93926f fix (core): macos12 depreciation workflow error / security CWE-120 (#14746)
* fix (core): macos12 depreciation workflow error

Fix workflow error message:
azerothcore-wotlk/src/common/Utilities/Util.cpp:558:9: fatal error: 'sprintf' is deprecated: This function is provided for compatibility reasons only.  Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead. [-Wdeprecated-declarations]
        sprintf(buffer, "%02X", bytes[i]);

* Update BattlegroundAV.cpp

* more macos12 fixit

* Update spell_generic.cpp
2023-01-23 06:13:27 -05:00
UltraNix
8cb88cce52 fix(Scripts/The Underbog): Rewritten The Black Stalker's Levitate mec… (#14541)
* fix(Scripts/The Underbog): Rewritten The Black Stalker's Levitate mechanic.

Fixes #13988

* buildfix.

* Update src/server/scripts/Outland/CoilfangReservoir/underbog/boss_the_black_stalker.cpp

Co-authored-by: offl <offl@gmail.com>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2023-01-07 20:28:22 +01:00
Kitzunu
7b774c8141 fix(Core/Spell): Roll 'dem Bones (#14522)
* fix(Core/Spell): Roll 'dem Bones

* closes https://github.com/azerothcore/azerothcore-wotlk/issues/14357

* Partial cp of 029527365f

Co-Authored-By: joschiwald <736792+joschiwald@users.noreply.github.com>

* newline pleb

Co-authored-by: joschiwald <736792+joschiwald@users.noreply.github.com>
2023-01-07 20:05:42 +01:00
Gultask
6b4ef50e7a Revert "fix(Core/Spells): Ignite and Revitalize should not prelong co… (#14513)
Revert "fix(Core/Spells): Ignite and Revitalize should not prelong combat. (#13812)"

This reverts commit 96fa9c5c7b.
2023-01-05 23:14:56 -03:00
UltraNix
c3b8df8cb2 fix(Core/Spells): Aura with SPELL_AURA_MOD_FEAR effect are always c… (#14450)
fix(Core/Spells): Aura with `SPELL_AURA_MOD_FEAR` effect are always considered as negative.

Fixes #14297
2023-01-06 00:53:37 +01:00
UltraNix
7a03130b94 fix(Core/Spells): Regen auras should not be removed by Rapid Recupera… (#14269)
fix(Core/Spells): Regen auras should not be removed by Rapid Recuperation.

Fixes #14263
2023-01-06 00:53:10 +01:00
UltraNix
14f3b444ae fix(Core/Creatures): Implemented `SUMMON_PROP_FLAG_ONLY_VISIBLE_TO_SU… (#14054)
* fix(Core/Creatures): Implemented `SUMMON_PROP_FLAG_ONLY_VISIBLE_TO_SUMMONER` summon flag.

Fixes #6674

* Update.
2023-01-06 00:52:05 +01:00
UltraNix
0e1e8f27de fix(Core/Spells): Every spell casted by player should tap the creature. (#14037)
Fixes #11888
2023-01-06 00:51:54 +01:00
UltraNix
96fa9c5c7b fix(Core/Spells): Ignite and Revitalize should not prelong combat. (#13812)
Fixes #13330
2023-01-06 00:50:53 +01:00
Angelo Venturini
9e18b86311 fix(Core/Auras): SPELL_AURA_MOD_SCALE should scale additively instead… (#14425)
...multiplicatively

Co-authored-by: Shauren <shauren.trinity@gmail.com>
2023-01-02 20:43:20 -03:00
UltraNix
8448996639 fix(Core/Spells): Fixed Hunter's Mark not being casted by Swamplord M… (#14457)
fix(Core/Spells): Fixed Hunter's Mark not being casted by Swamplord Musel'ek.

Fixes #13993
2023-01-01 08:49:47 -03:00
Kitzunu
4870b14b1f refactor(Core/Object): getLevel() -> GetLevel() (#14122)
* refactor(Core/Object): getLevel() -> GetLevel()

* fix build and sneak some doxygen in

* codeSTLE

* codestyle
2022-12-31 17:39:23 +01:00