fix(Core/Spell): Removed gathering failure chance from herbalism and … (#15423)

fix(Core/Spell): Removed gathering failure chance from herbalism and mining nodes

* cherry-pick commit (052dfe27fc)

Co-authored-by: Tony Konzel <saxxonpike@gmail.com>
This commit is contained in:
Kitzunu
2023-03-17 10:24:36 +01:00
committed by GitHub
parent fd2fcc1275
commit 422db05290

View File

@@ -6328,7 +6328,8 @@ SpellCastResult Spell::CheckCast(bool strict)
// chance for fail at lockpicking attempt
// second check prevent fail at rechecks
if (skillId != SKILL_NONE && (!m_selfContainer || ((*m_selfContainer) != this)))
// herbalism and mining cannot fail as of patch 3.1.0
if (skillId != SKILL_NONE && skillId != SKILL_HERBALISM && skillId != SKILL_MINING && (!m_selfContainer || ((*m_selfContainer) != this)))
{
// chance for failure in orange lockpick
if (skillId == SKILL_LOCKPICKING && reqSkillValue > irand(skillValue - 25, skillValue + 37))