From 422db052906159245b574bd7ad2a09a70af864b7 Mon Sep 17 00:00:00 2001 From: Kitzunu <24550914+Kitzunu@users.noreply.github.com> Date: Fri, 17 Mar 2023 10:24:36 +0100 Subject: [PATCH] =?UTF-8?q?fix(Core/Spell):=20Removed=20gathering=20failur?= =?UTF-8?q?e=20chance=20from=20herbalism=20and=20=E2=80=A6=20(#15423)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit fix(Core/Spell): Removed gathering failure chance from herbalism and mining nodes * cherry-pick commit (https://github.com/TrinityCore/TrinityCore/commit/052dfe27fc324f13f8d4cc2af802f57963d8fe7c) Co-authored-by: Tony Konzel --- src/server/game/Spells/Spell.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/server/game/Spells/Spell.cpp b/src/server/game/Spells/Spell.cpp index e22e99eb6..d1bb58fca 100644 --- a/src/server/game/Spells/Spell.cpp +++ b/src/server/game/Spells/Spell.cpp @@ -6328,7 +6328,8 @@ SpellCastResult Spell::CheckCast(bool strict) // chance for fail at lockpicking attempt // second check prevent fail at rechecks - if (skillId != SKILL_NONE && (!m_selfContainer || ((*m_selfContainer) != this))) + // herbalism and mining cannot fail as of patch 3.1.0 + if (skillId != SKILL_NONE && skillId != SKILL_HERBALISM && skillId != SKILL_MINING && (!m_selfContainer || ((*m_selfContainer) != this))) { // chance for failure in orange lockpick if (skillId == SKILL_LOCKPICKING && reqSkillValue > irand(skillValue - 25, skillValue + 37))