Benjamin Jackson
1edac37ac3
refactor(Core): Make more use of helpers. ( #19835 )
...
* Init.
* Reword.
* Update codestyle script.
Co-Authored-By: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
* Add gameobject type ID check, reorder checks.
* Add helper/codestyle check for unit type.
* `IsUnit()` -> `IsCreature()`
* Add `IsUnit()` method.
* Use type mask.
https: //github.com/TrinityCore/TrinityCore/commit/cc71da35b5dc74abf71f8691161525a23d870bb5
Co-Authored-By: Giacomo Pozzoni <giacomopoz@gmail.com >
Co-Authored-By: Ovahlord <18347559+Ovahlord@users.noreply.github.com >
* Replace instances of `isType` with `IsUnit`.
---------
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com >
Co-authored-by: Ovahlord <18347559+Ovahlord@users.noreply.github.com >
2024-09-03 14:41:31 -03:00
Grimdhex
221dbd3fdb
chore(Apps/Codestyle): add new codestyle checks for pointers and range loops ( #19841 )
...
* chore(Apps/Codestyle): add new codestyle checks for pointers and range loops
* revert a typo
2024-09-03 13:02:38 -03:00
Kitzunu
9af86553c5
chore(Core/Misc): update floor and ceil to std ( #19837 )
2024-09-03 08:01:00 -03:00
Kitzunu
de2bcbdabf
refactor(Core/Misc): Acore::StringFormat to fmt format ( #19838 )
...
refactor(Core/Utilities): Acore::StringFormat to fmt format
* closes https://github.com/azerothcore/azerothcore-wotlk/issues/10356
2024-09-03 07:59:37 -03:00
Andrew
0954e314a0
fix(Scripts/BlackTemple): Fix Zerevor not casting Dampen Magic OOC ( #19768 )
...
* fix(Scripts/BlackTemple): Fix Zerevor not casting Dampen Magic OOC
* Update boss_illidari_council.cpp
* recast every 1min
* implement the recast checks
* Update CreatureAI.h
* Update boss_illidari_council.cpp
* Update boss_illidari_council.cpp
* fix ooc cast
* Update boss_illidari_council.cpp
* always respect the 60s lock
* Update boss_illidari_council.cpp
* Update boss_illidari_council.cpp
2024-09-02 20:44:34 -03:00
Benjamin Jackson
2f00db3418
fix(Scripts/BlackTemple): Adjust order of damage calculations for Shared Rule. ( #19849 )
...
Init.
2024-09-02 05:34:30 -03:00
Benjamin Jackson
f88812443d
refactor(Core): Correct typo. ( #19830 )
...
Init.
2024-08-31 17:38:03 -03:00
Andrew
83d623e559
fix(Scripts/BlackTemple): Fix Mother Shahraz teleport ( #19820 )
...
fix(Scripts/BlackTemple): Fix Mother Sharaz teleport
Co-authored-by: Keader <keader.android@gmail.com >
2024-08-31 17:35:17 -03:00
Walter Pagani
3b45e90e41
fix(Scripts/ICC): NPC Muradin Dialogues ( #18931 )
...
Co-authored-by: Meji <alvaro.megias@outlook.com >
Co-authored-by: 天鹿 <18535853+PkllonG@users.noreply.github.com >
2024-08-31 17:34:56 -03:00
Benjamin Jackson
30f87a3e2f
fix(Scripts/BlackTemple): Call evade for Council creature when members evade. ( #19808 )
...
Init.
2024-08-31 09:41:19 -03:00
Benjamin Jackson
9a503d4703
fix(Scripts/BlackTemple): Ensure Illidari council health is balanced across wipes. ( #19809 )
...
Init.
2024-08-31 09:40:48 -03:00
Jelle Meeus
0fb2c5efeb
fix(Scripts/TheEye): Kaelthas remove enchanted weapons ( #19801 )
...
* remove weapons
Co-authored-by: killerwife <killerwife@gmail.com >
* style
for consistency
* also cast on KT JustDied
* fix TriggerCastFlags to not ignore reagent cost
* Apply suggestions from code review
---------
Co-authored-by: killerwife <killerwife@gmail.com >
2024-08-30 16:20:52 -03:00
Grimdhex
e4aab5b4f0
fix(Scripts/TempestKeep): revamp Kael'Thas ( #19648 )
...
* fix(Scripts/TempestKeep): force attackstop for all player during the last phase and cleanup the script of Kael'Thas
* few new fixes
* fix codestyle
* fix codestyle and remove misc stuff
*remove the useless DisableSpline
*remove also a misc change use only during the dev
* pass the health to DamageTaken instead UpdateIA
* avoid to iterate over the threatlist and use RemoveAllAttackers() instead
* Revert "avoid to iterate over the threatlist and use RemoveAllAttackers() instead"
This reverts commit 0623c0075191c91c2530496c83d017d3b6a824db.
* Revert "pass the health to DamageTaken instead UpdateIA"
This reverts commit 7f8609af603ecc042c819801a2f04d9d65c5031a.
* revert recents commits
* avoid potential conflicts with others enums
* fix build
2024-08-30 16:10:51 -03:00
Benjamin Jackson
2bb45fcd30
fix(Scripts/BlackTemple): Adjust handling for Shared Rule spell. ( #19770 )
2024-08-30 09:04:08 -03:00
daobashun
e1692ae5b6
fix(scripts/npc_calvin_montague): Convert to SAI, Add emotes when completing quests ( #18087 )
...
* Magic uses sniffing IDs
Use the sniffer timer and factions
* Wait 3 minutes if the mission fails
* 1. When a task fails, it enters passive mode
2. Add 'quest_details' data to the database
* Remove spaces
* Delete blank lines
* Modify the code as required
* Update src/server/scripts/EasternKingdoms/zone_tirisfal_glades.cpp
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
* Remove curly braces
* Change the name of a private member variable
* Move the c ++ script to smart script
* Delete the C++ script
Re-add the deleted quest_details data
* del blank lines
* Delete the C++ script file
* Modify the annotation
Return to the home pointset phase to 0
Return to the home point to allow the SAI phase reset
* Remove spaces
* Delete functions that are not in use
* Update rev_1704025138911597700.sql
* fix merge error - delete zone file
---------
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
2024-08-28 21:05:40 +02:00
Andrew
7e2ffc2db8
feat(Scripts/Commands): Implement "pct" optional to the damage command ( #19745 )
2024-08-27 22:28:09 +02:00
Andrew
806d4962cf
fix(Scripts/Spells): L1 Arcane Charge should hit 3 targets ( #19752 )
...
* fix(Scripts/Spells): L1 Arcane Charge should hit 3 targets
* Daily Nitpicks
2024-08-27 22:26:05 +02:00
Jelle Meeus
53e0779ae8
fix(Scripts/Spells): General's Heart trinket ( #19756 )
...
* handle aura with spell_gen_absorb0_hitlimit1
* refactor enscapsulate limit
2024-08-27 22:25:41 +02:00
Benjamin Jackson
c76f2382d9
fix(Scripts/BlackTemple): Improve Illidari Council Empyreal Balance. ( #19757 )
2024-08-27 15:51:47 -03:00
Andrew
126f3a31ee
refactor(Scripts/BlackTemple): Update the Illidari Council script to the new registration method ( #19744 )
...
refactor(Scripts/BlackTemple): Update Illidari council to new model
2024-08-26 16:28:48 -03:00
Andrew
9ce2b23df3
refactor(Scripts/RuinsOfAhnQiraj): Clean up Ayamiss script ( #19742 )
2024-08-26 10:04:11 -03:00
Andrew
52cd493ad8
fix(Scripts/BlackTemple): L5 Arcane Charge should be modified by dama… ( #19730 )
...
* fix(Scripts/BlackTemple): L5 Arcane Charge should be modified by damage taken mods
* Create rev_1724540286668312700.sql
* Update spell_generic.cpp
* update to new format
2024-08-26 01:25:10 -03:00
Andrew
c5399509e6
refactor(Scripts/TempleOfAhnQiraj): Clean up Cthun script ( #19736 )
...
* refactor(Scripts/TempleOfAhnQiraj): Clean up Cthun script
* Update boss_cthun.cpp
* Update boss_cthun.cpp
2024-08-25 16:46:24 -03:00
Carriola-wotlk
4a14c61a90
fix(Scripts/BlackTemple) Gathios the Shatterer shouldnt use the same spell twice in a row ( #19672 )
...
* fix: SelectTargetMethod Random replaced with MaxThreat
* restore like origin
* fix: random spell casting replaced with alternating spells casting
* fix: alternating casting of aura, blessing and seal spells
* refactor: randomized toggle initialization refactored
---------
Co-authored-by: MattiaBallarini <ballarini.mattia1990@gmail.com >
2024-08-25 10:01:37 -03:00
Grimdhex
643362d697
refactor(Core/Object): adds consistency in the use of type object check ( #19671 )
2024-08-25 09:57:37 -03:00
Grimdhex
61f3a631c3
fix(Server): remove double blank lines at the end of several files ( #19735 )
2024-08-25 07:21:14 -03:00
Andrew
dd41692a8e
fix(Scripts/SethekkHalls): Prevent multiple spawns of Anzu ( #19636 )
...
* fix(Scripts/SethekkHalls): Prevent multiple spawns of Anzu
* Update instance_sethekk_halls.cpp
* Update instance_sethekk_halls.cpp
* Update rev_1723763212128826500.sql
2024-08-22 19:27:15 +02:00
Andrew
82db30868b
fix(Scripts/BlackTemple): Fatal Attraction ( #19641 )
...
* Fix it not being cast if no valid targets are available
* Apply Patch 2.2 nerfs
2024-08-19 23:17:17 -03:00
Kitzunu
337135bf9e
refactor(Core/Misc): Use NpcFlag helpers ( #19676 )
...
* chore(Core/Misc): Use HasNpcFlag instead of HasFlag
* extend to all npcflag helpers
2024-08-19 10:17:02 +02:00
Carriola-wotlk
01c8344cc8
fix(Scripts/BlackTemple): Gathios the Shatterer shouldnt use Hammer of Justice on random players ( #19653 )
...
* fix: SelectTargetMethod Random replaced with MaxThreat
* restore like origin
* fix: cast Hammer Of Justice on current target instead random target
* refactor: case EVENT_SPELL_HAMMER_OF_JUSTICE statement refactored
* refactor: if statement splitted
* refactor: last space removed
* Update src/server/scripts/Outland/BlackTemple/illidari_council.cpp
Co-authored-by: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com >
* fix redundant check and new line
---------
Co-authored-by: MattiaBallarini <ballarini.mattia1990@gmail.com >
Co-authored-by: Andrew <47818697+Nyeriah@users.noreply.github.com >
Co-authored-by: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com >
2024-08-18 21:06:45 -03:00
Yunfan Li
d436f97ea2
fix(Script/Vehicles): The next player entering Salvaged Siege Engine … ( #19674 )
...
fix(Script/Vehicles): The next player entering Salvaged Siege Engine should control turret if it's not occupied.
2024-08-18 14:28:56 -03:00
Andrew
167e06e287
fix(Scripts/BlackTemple): Gathios Judgment spell should consume seals ( #19640 )
2024-08-18 05:57:32 -03:00
Andrew
1565758da4
Revert "chore(Script/Misc): cleanup" ( #19627 )
...
Revert "chore(Script/Misc): cleanup (#19619 )"
This reverts commit 7ff8f72397 .
2024-08-15 05:43:11 +02:00
Kitzunu
7ff8f72397
chore(Script/Misc): cleanup ( #19619 )
...
* chore(Script/Misc): cleanup
* more cleanup
* cleanup
2024-08-14 16:29:50 -03:00
Kitzunu
2e02c76399
fix(Core/Creature): quest_greeting_locale ( #19615 )
...
* fix(Core/Creature): quest_greeting_locale
* closes https://github.com/azerothcore/azerothcore-wotlk/issues/14845
2024-08-13 21:09:36 +02:00
Kitzunu
4b63aa9015
feat(DB/Module): introduce module_string table ( #19475 )
2024-08-13 19:53:16 +02:00
Benjamin Jackson
c8be582f81
fix(Scripts): Rewrite Level 70 Elite Tauren Chieftain. ( #19546 )
...
* Init.
* Despawn music doodad.
* Add conditions behind events invoking performances.
* Update music doodad intervals.
55639.
* Add condition for BRD performance.
Ensures that manual performance and event performance do not overlap.
* Add scripting for Shattrath Saul.
* Add scripts for Silvermoon band members.
All verified in Cata Classic 55639.
* Whoops.
* Styling, initial Blastbolt scripting.
I don't know how to handle the roadies yet. Ugh.
* Whoops.
* Bad event param.
* Remove drumset respawn from action list.
* Update Shattrath Saul's Perry Gatner scripting.
* Ugh.
Hate SAI.
2024-08-13 11:56:43 -03:00
Kitzunu
e4df159f5c
refactor(Core/Chat): Move SendNotification to ChatHander ( #19491 )
...
* refactor(Core/Chat): Move SendNotification to ChatHander
* Update Battleground.cpp
* fix build
* Update src/server/game/Chat/Chat.h
2024-08-10 11:39:46 -03:00
Kitzunu
bb7765d91e
refactor(Core/World): Move SendGMText to ChatHandler and allow fmt ( #19490 )
...
* refactor(Core/World): Move SendGMText to WorldSession and allow `fmt`
- Move SendGMText from World to WorldSession
- Make SendGMText use fmt
- Make SendGMText parse acore_string entries
* Update cs_message.cpp
* tokenize the string only once
* Move to chathandler
* Update WorldSession.cpp
* make sure we have a session
2024-08-08 20:12:33 -03:00
Gultask
41366fcc69
fix(Scripts/ShadowmoonValley): Dragonmaw Races Reset ( #19570 )
...
* Update zone_shadowmoon_valley.cpp
* Update zone_shadowmoon_valley.cpp
2024-08-07 12:43:24 -03:00
Gultask
09e77dfd1c
fix(Scripts/BlackTemple): Mother Shahraz Periodic part 2 ( #19561 )
...
* init
* Update boss_mother_shahraz.cpp
* Update boss_mother_shahraz.cpp
* Update boss_mother_shahraz.cpp
* Update boss_mother_shahraz.cpp
2024-08-06 11:53:19 -03:00
Andrew
b8de917800
fix(Scripts/Hyjal): Anetheron dont sleep main tank ( #19544 )
...
* fix(Scripts/Hyjal): Anetheron dont sleep main tank
* Update boss_anetheron.cpp
2024-08-06 09:00:25 -03:00
Gultask
a23da06358
feat(Scripts/Commands): Morph Mount ( #19558 )
...
* init
* Update cs_modify.cpp
* Update data/sql/updates/pending_db_world/rev_1722817302187444800.sql
Co-authored-by: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com >
* Update cs_modify.cpp
---------
Co-authored-by: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com >
2024-08-05 21:41:00 -03:00
Andrew
f70e69cacf
fix(Scripts/BlackTemple): Mother Shahraz should not use frenzy ( #19543 )
2024-08-02 16:19:16 -03:00
Benjamin Jackson
7569a3bf1b
fix(Scripts/HyjalSummit): Adjust Air Burst cast targetting. ( #19488 )
...
Init.
2024-08-01 19:57:32 -03:00
Francesco Borzì
02a05fbd4c
refactor(src/common): remove unused imports ( #19506 )
...
* refactor(src/common): remove unused imports
* fix: build
* chore: fix build
* chore: size_t -> std::size_t
* chore: fix fuckup from previous commit
* chore: fix build
* chore: fix build
* chore: fix build
* chore: fix build with std::size_t
* chore: fix build
* chore: fix build
* chore: fix build
* chore: fix build
* chore: fix build
* chore: fix build
* chore: fix build
* chore: fix build
* chore: fix build
* chore: fix build
* chore: fix build
* chore: fix build
2024-07-30 20:06:46 -03:00
Gultask
203087f5e7
chore(Scripts/BlackTemple): Move Gurtogg Bloodboil to TaskScheduler ( #19532 )
...
* Update boss_bloodboil.cpp
* Update boss_bloodboil.cpp
2024-07-30 18:28:25 -03:00
Gultask
97ee20a7aa
fix(Scripts/BlackTemple): Reliquary of Souls move to TaskScheduler and Spirit Shock timer ( #19523 )
2024-07-30 17:33:10 -03:00
Justin Hanley
af6b8ce099
feat(Scripts/Commands): account set email ( #19481 )
...
* added worldserver command to set email address
* reverted sql, added Tail args
* removed pointer
* Added helper text via updatescript
* fix build
* fix build
* fixed db update
* Update data/sql/updates/db_world/2024_07_26_01.sql
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
* Update data/sql/updates/db_world/2024_07_26_01.sql
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
* fixed hander
* refactor with named params
* refactor with named params
---------
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
2024-07-30 15:33:13 +02:00
Gultask
fccfe51594
fix(Scripts/BlackTemple): Mother Shahraz Periodic Beams ( #19525 )
...
* init
* Update boss_mother_shahraz.cpp
2024-07-29 23:49:58 -03:00