Jelle Meeus
775b9ff29a
fix(Core/Player): correct SpellPriority logic ( #21052 )
...
Co-authored-by: killerwife <killerwife@gmail.com >
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
2025-04-30 02:09:20 +01:00
Benjamin Jackson
1bff305ad4
fix(Core/Spells): Adjust logic for removing/applying auras related to areas. ( #20299 )
...
* Init.
* Use apply instead of variable.
2024-11-03 21:39:56 -03:00
Kitzunu
386aea03ee
chore(Core/Misc): Some cleanup ( #19970 )
...
* remove weird blanks
* update if
* ) ) to ))
* missed some ) )
* now switch
* .
2024-09-21 19:34:31 +02:00
Benjamin Jackson
1edac37ac3
refactor(Core): Make more use of helpers. ( #19835 )
...
* Init.
* Reword.
* Update codestyle script.
Co-Authored-By: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
* Add gameobject type ID check, reorder checks.
* Add helper/codestyle check for unit type.
* `IsUnit()` -> `IsCreature()`
* Add `IsUnit()` method.
* Use type mask.
https: //github.com/TrinityCore/TrinityCore/commit/cc71da35b5dc74abf71f8691161525a23d870bb5
Co-Authored-By: Giacomo Pozzoni <giacomopoz@gmail.com >
Co-Authored-By: Ovahlord <18347559+Ovahlord@users.noreply.github.com >
* Replace instances of `isType` with `IsUnit`.
---------
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com >
Co-authored-by: Ovahlord <18347559+Ovahlord@users.noreply.github.com >
2024-09-03 14:41:31 -03:00
Grimdhex
643362d697
refactor(Core/Object): adds consistency in the use of type object check ( #19671 )
2024-08-25 09:57:37 -03:00
Andrew
1565758da4
Revert "chore(Script/Misc): cleanup" ( #19627 )
...
Revert "chore(Script/Misc): cleanup (#19619 )"
This reverts commit 7ff8f72397 .
2024-08-15 05:43:11 +02:00
Kitzunu
7ff8f72397
chore(Script/Misc): cleanup ( #19619 )
...
* chore(Script/Misc): cleanup
* more cleanup
* cleanup
2024-08-14 16:29:50 -03:00
avarishd
5b2a088da0
fix(Core/Auras): Add SPELL_ATTR0_CU_ONLY_ONE_AREA_AURA ( #19209 )
...
https: //github.com/azerothcore/azerothcore-wotlk/pull/19208
Co-authored-by: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com >
2024-06-28 05:23:38 -03:00
Nathan Handley
df33a57b78
feat(Core/Unit): New helper IsClass and script hook OnPlayerIsClass ( #18243 )
...
* Class Comparison Logic Encapsulation - Parity
* Add Context to IsClass
* Add Unit IsClass script hook
* Replace additional getClass with IsClass
* Update CanUseItem to replace getClass with IsClass
* Add separate context for pet vs ability
* Change Create to Init since not all referenced contexts are creation
* Align spacing in ClassContext
* Drop context on LFGManager max power
* Update IsClass context that wraps around Missle Barrage
* Rename context for swapping weapons
* Be more specific than CLASS_CONTEXT_TALENT
* Remove duplicate context
* Moved IsClass Hook to Player
* Removed unused parameter in virtual base function
* Added maybe_unused to IsClass virtual in order to compile
To match the override signature, the virtual base needs to include the parameter in question, so using [maybe_unused] to signal to the compiler to allow it
* Remove extra blank line
* Add ABILITY_REACTIVE context
* Add context for PET_CHARM
* Remove explicit nullopt check per review
* Code Readability - Change if to if else in pet
Due to the return pattern, this doesn't change functionality in any way
* Add OnPlayer to disambiguate
---------
Co-authored-by: NathanHandley <nathanhandley@protonmail.com >
2024-02-10 12:25:00 -03:00
v-mstrs
aaabca1cd0
fix(Core/Spells) Add Explosive Shot exception ( #16854 )
...
* gitpain
* Update SpellAuras.cpp
2023-08-01 14:11:22 -03:00
v-mstrs
d0fa5f04ef
fix(Core/Spells): Add Beast Lord 4P bonus ( #16655 )
2023-07-01 16:31:17 -03:00
Kitzunu
f039836a2f
chore(Core/Misc): Change all TODO to doxygen comment ( #14966 )
2023-02-12 10:05:34 -03:00
UltraNix
9b59f35cb8
fix(Core/Spells): Fixed Master of Elements not refunding mana. ( #14665 )
2023-01-28 10:59:25 +01:00
Kitzunu
4870b14b1f
refactor(Core/Object): getLevel() -> GetLevel() ( #14122 )
...
* refactor(Core/Object): getLevel() -> GetLevel()
* fix build and sneak some doxygen in
* codeSTLE
* codestyle
2022-12-31 17:39:23 +01:00
UltraNix
3603f44dad
fix(Core/Spells): FIxed calculating LoS for dynamic objects. ( #13795 )
...
Fixes #13777
2022-11-16 01:19:29 -03:00
UltraNix
0cd6319cfc
fix(Core/Spells): Fixed calculating LoS for dynamic objects. ( #13521 )
...
Fixes #13255
2022-10-29 07:12:49 -03:00
Angelo Venturini
f6b8840e34
refactor: rename spell_proc fields ( #13334 )
...
Co-authored-by: Shauren <shauren.trinity@gmail.com >
2022-10-13 14:04:55 -03:00
Angelo Venturini
ad4ce0895f
fix: Qaston revert ( #13320 )
...
* Revert "fix(Core/QAston): fixed shields oneshotting (#13271 )"
This reverts commit e05f61d1b3 .
* Revert "fix(Core): Crash (#13292 )"
This reverts commit a818bcf3e2 .
* Revert "fix: Crash (#13241 )"
This reverts commit be423a91b5 .
* delete sql
* Revert "refactor(Core/Spells): Implement QAston Proc System (#11079 )"
This reverts commit cbd3fd0967 .
* add sql revert
* fix sql
* remove update from world.updates
2022-10-05 21:53:20 +02:00
IntelligentQuantum
cbd3fd0967
refactor(Core/Spells): Implement QAston Proc System ( #11079 )
...
* .
* sql
* .
* .
* 1
* 2
* 3
* 4
* 5
* 6
* 7
* 8
* 9
* 10
* 11
* 12
* 13
* 14
* 15
* Update spell_item.cpp
* Update Unit.cpp
* 16
* 17
* 18
* 19
* 20
* 21
* Update Unit.cpp
* REVERT UltraNIX Commit
* 22
* 23
* .
* .
* .
* warrior
* warlock
* shaman rogue priest paladin mage
* spell item
* hunter
* druid
* dk
* war
* error style
* Update rev_1647677899565690722.sql
* Update rev_1647677899565690722.sql
* Update rev_1647677899565690722.sql
* .
* DOND DEL ME WAD DO DO
* error 2
* .
* .
* .
* FIX
* Update SpellInfoCorrections.cpp
* Update SpellInfoCorrections.cpp
* .
* ja genau
* Update .gitignore
* .
* .
* .,
* .
* .
* .
* .
* Update Unit.cpp
2022-10-02 19:39:34 +02:00
M'Dic
ed68d1bffa
fix (Core/Spell): Shadowform Dispel ( #13155 )
2022-09-28 12:13:46 -04:00
UltraNix
f658c8ea0c
fix(Core/Spells): Fingers of Frost should always proc alongside with … ( #13008 )
...
...Frostbite.
2022-09-19 00:52:37 -03:00
UltraNix
a5ab96c79d
fix(Scripts/Spells): Finger of Frost Shatter Combo. ( #13006 )
2022-09-19 00:46:17 -03:00
Maelthyr
d0d1671745
feat(Core/Debug): GetDebugInfo implementation ( #12705 )
...
Cherry-pick: 9a924fb9d5
Co-authored-by: jackpoz <giacomopoz@gmail.com >
Co-authored-by: jackpoz <giacomopoz@gmail.com >
2022-08-15 09:43:41 -03:00
UltraNix
2cde0c35ba
fix(Core/Spells): Fixed calculating LoS for dynamic objects. ( #12090 )
...
Fixed #12080
2022-06-18 11:08:07 -04:00
UltraNix
a2bc0ae028
fix(Core/Objects): Include combat reach instead of object size in LoS… ( #12013 )
...
... calculations.
Fixed LoS calculations for dynamic objects.
Modified combat reach of Deep Pool Threshfin.
Fixes #11886
2022-06-13 01:03:06 -03:00
UltraNix
6a8180e3fd
fix(Core/Spells): The Earthshatterer 8/9 set bonus should be removed … ( #11757 )
...
…along with Lightning Shield removal.
2022-05-18 04:50:52 -03:00
UltraNix
bd248a82d0
fix(Core/Spells): Ghost Wolf Speed from PvP 58 vl set. ( #11096 )
...
Fixes #9479
2022-04-01 07:01:21 -03:00
Kitzunu
455899dc75
fix(Core/Misc): Change const to be after type name ( #10591 )
2022-02-14 16:05:45 -03:00
UltraNix
8f8fbd95ce
fix(Core/Spells): Implemented SPELL_GROUP_SPECIAL_FLAG_SKIP_STRONGER_SAME_SPELL. ( #10307 )
...
Fixed #10263
2022-01-30 21:29:22 -03:00
Kargatum
5969df4e30
refactor(Core/Logging): switch to fmt style for LOG_ ( #10366 )
...
* feat(Core/Common): add support fmt style for ASSERT and ABORT
* correct CheckCompactArrayMaskOverflow
* 1
* Update src/server/game/Spells/Spell.cpp
* rework logging
* add fmt replace logs
* logging
* FMT_LOG_
* settings
* fix startup
* 1
* 2
* 3
* 4
* 5
* fmt::print
* to fmt
2022-01-27 16:44:41 +01:00
UltraNix
2fce4e0f12
fix(Core/Spells): Remove vanish immunity aura on stealth removal. ( #10106 )
...
Fixes #2668
2022-01-24 23:19:50 -03:00
Kargatum
8b7df23f06
feat(Core/Time): Implement saparated manager for game time ( #8630 )
2022-01-24 17:55:00 +07:00
UltraNix
e1617a0044
fix(Core/Spells): Restored special Rolling DoTs mechanic for Corruption and SW:Pain ( #10206 )
...
Fixes #9867
2022-01-21 13:39:11 -03:00
Kitzunu
ac99eb48e1
refactor(Core/Misc): abs() to std::abs() ( #9789 )
2021-12-31 19:29:39 -03:00
Francesco Borzì
cbc7e5466a
refactor(Core): remove unused imports ( #9767 )
2021-12-19 19:41:14 +01:00
UltraNix
4e70e60427
fix(Core/Spells): Properly handle pet spell auras with infinity cooldown. ( #9576 )
...
Fixes #9339
2021-12-12 11:43:22 -03:00
Skjalf
2d55974c0c
Revert "fix(Core/Spells): Forward core changes ( #8841 )" ( #9631 )
...
This reverts commit 85d2c39a48 .
2021-12-10 15:31:48 +01:00
acidmanifesto
85d2c39a48
fix(Core/Spells): Forward core changes ( #8841 )
2021-12-09 18:24:16 -03:00
Kitzunu
f9337497d8
chore(Core/Auras): Clean up Aura::CanBeSaved() ( #9343 )
2021-11-30 13:03:04 -03:00
UltraNix
c36168c604
fix(Core/Spells): Fixed calculating damage/healing pct auras on aura refresh. ( #9316 )
...
Fixes #8962
2021-11-29 20:36:48 -03:00
Andrius Peleckas
3ce64b0f01
feat(Core/Spells): implement two new custom attributes to handle aura saving rule ( #8377 )
2021-11-05 15:56:45 +01:00
UltraNix
16a54fdeac
fix(Core/Spells): Polymorphed targets should call assistance. ( #8674 )
...
Fixes #8413
2021-10-24 02:58:54 -03:00
UltraNix
96441a91dc
fix(Core/Spells): Auras triggered by talents/glyphs should be removed on respec. ( #8671 )
...
Fixes #8543
2021-10-24 01:23:04 -03:00
UltraNix
b0d4f1917e
fix(Core/Spells): passive auras should not stak with itself ( #8652 )
...
- Closes #8588
2021-10-22 11:32:35 +02:00
UltraNix
cbabc54659
fix(Scripts/Spells): Fixed Enrage armor reduce part. Source: TrinityCore. ( #8625 )
...
Fixes #8623
2021-10-21 15:48:49 -03:00
Kargatum
52aa0e9966
feat(License): add new headers information about license ( #7941 )
...
Co-authored-by: Francesco Borzì <borzifrancesco@gmail.com >
2021-09-30 13:40:52 +07:00
Viste
a9796af174
fix(Core/Misc): bunch of crashfixes ( #7307 )
2021-09-14 14:38:56 +02:00
UltraNix
7406a01ac3
fix(Core/Spells): several improvements to cooldowns ( #7559 )
...
- Reworked spell category cooldowns.
- Implemented category cooldowns for pets.
- Properly shows pet spell cooldowns in player's UI.
- Corrected pet spell cooldowns with infinity duration.
- Do not add/remove infinity spell cooldown on aura apply/remove if casted by item.
- Closes #5263
2021-09-13 20:57:48 +02:00
lineagedr
888549bcdc
fix(Core/Spells): Druid's Enrage not reducing armor ( #7394 )
2021-08-20 14:41:26 +02:00
KiK0
2b5144c8fe
fix(Core/Spells): Glyph of Freezing Trap Applying Slow Incorrectly ( #7184 )
2021-08-08 15:09:51 +02:00