nchebrov/azerothcore-wotlk
1
0
Fork 0
mirror of https://github.com/mod-playerbots/azerothcore-wotlk.git synced 2026-01-17 19:05:42 +00:00
Code Issues Packages Projects Releases Wiki Activity
8,377 Commits 8 Branches 0 Tags
fbbb287c29a2bc2e9609ba5fc7863caefd4887f0
Commit Graph

2927 Commits

Author SHA1 Message Date
arenacraftwow
cfdbf00afe fix(Core/Hook): OnFirstLogin can now make persistent changes (#2793) 
PlayerScript#OnFirstLogin was broken in that if you tried to teach the
player a spell or give an item to him that change wouldn't persist.
Meaning that the next time the Player would log in, his awarded spells
or items would be gone.

Meanwhile PlayerScript#OnLogin didn't have this behavior meaning
that the sematics of PlayerScript#OnFirstLogin and PlayerScript#OnLogin
where very different, which is unexpected.

This issue was caused by an implementation detail in Player#learnSpell
(and similiar) which behaves differently depending on
Player#isBeingLoaded phase. This code change makes its that
PlayerOnFirstLogin hook executes when Player#isBeingLoaded == false
fixing the issue.

Alternatives: The fact that Player#learnSpells and others behave
differently depending on the load phase is questionable and from my
research it seems like this impl detail is only used when giving the
player his template spells. We could add a overload to
Player#learnSpell with a flag like `isSpellTemporary` and make
the template spells loading use it. Then we would be able to remove
this implicit temporary spell mechanism when Player#isBeingLoaded
thing.  However this is a deeper change and not worth the risk.
 2020-04-01 20:16:00 +02:00
Stefano Borzì
19c3a70d41 feat(Core/Config): make stop time for creatures with WP movement configurable #2715 (#2829) 
Original author Stoabrogga
 2020-03-31 01:30:39 +02:00
Nefertumm
bb6047248a fix(Calendar/Packets): add additional validation when creating events (#2799) 2020-03-28 22:47:53 +01:00
Nefertumm
f5e38a7f57 Fix(Core/Packets/AntiDOS): Remove from default some repetitive movement packets (#2809) 2020-03-26 21:51:10 -03:00
Stefano Borzì
5ef98b95c9 chore(Core/AH): Restore little comment (#2702) 2020-03-25 20:40:25 +01:00
Stefano Borzì
19144d8bff fix(Core/Pet): Pet chase range check for melee ranged spells (#2694) 
Co-authored-by: Stoabrogga <38475780+Stoabrogga@users.noreply.github.com>
 2020-03-25 17:34:04 +01:00
Nefertumm
b868f0ad04 Revert "Fix(Core/Gameobjects): non-consumable goobers no longer despawn on use (#2750)" (#2797) 
This is causing troubles with veins and bg gameobjects (those are known)
This reverts commit 0521a314b5.
 2020-03-24 03:44:40 -03:00
Nefertumm
846f7862d8 feat(Core/Packet): Implement AntiDOS protection from Trinity (#2789) 
* Implement AntiDOS protection from Trinity


Co-authored-by: jackpoz <giacomopoz@gmail.com>
Co-authored-by: Shauren <shauren.trinity@gmail.com>
Co-authored-by: Vincent-Michael <trinity.michael_vincent@gmx.eu>
 2020-03-23 15:46:00 -03:00
Kitzunu
c5a7497f4d fix(Core/Gossip): fix titles in quest reward being able to show in gossip (#2791) 
Co-Authored-By: Wyrserth <wyrserth@users.noreply.github.com>
 2020-03-23 23:40:15 +07:00
Kitzunu
0521a314b5 Fix(Core/Gameobjects): non-consumable goobers no longer despawn on use (#2750) 
Taken from 50c5d30d13 & 2b1e8d135b


Co-authored-by: Wyrserth <wyrserth@protonmail.com>
 2020-03-21 22:29:52 +01:00
Francesco Borzì
3cf3f69e13 fix(Core/Spell): Melee ranged spells (#2686) 
Co-authored-by: Stoabrogga <38475780+Stoabrogga@users.noreply.github.com>
 2020-03-20 18:52:30 +01:00
Viste
ef5d6eae9b Core/Misc: Remove dependency on undefined behaviour (#2678) 
Co-authored-by: Ujp8LfXBJ6wCPR <github@lillecarl.com>

Co-authored-by: Ujp8LfXBJ6wCPR <github@lillecarl.com>
 2020-03-18 20:07:59 +01:00
Nefertumm
8d6bf1f4dc Fix(Core/Packet): Calendar events exploits (#2753) 
* Calendar handler exploit fix

* Travis and sugestions

* What a noob <.<
 2020-03-17 22:11:07 +01:00
Francesco Borzì
8231a7cc1a fix(GameObject/Quest): GameObject quest / gossip window (#2676) 
Co-authored-by: Stoabrogga <38475780+Stoabrogga@users.noreply.github.com>
 2020-03-15 10:09:25 +01:00
Stefano Borzì
ec91c779f3 fix(Core/SAI): SMARTCAST_COMBAT_MOVE (#2672) 
Co-authored-by: Stoabrogga <38475780+Stoabrogga@users.noreply.github.com>
 2020-03-14 17:41:03 +01:00
Alan
e72371ee4a fix: Zul'Aman raid improvements (#2654) 2020-03-09 22:54:18 +01:00
Stefano Borzì
ce2f622ef0 fix(core/packet): check malformed guild packet to prevent client crash (#2739) 
* Update AuctionHouseHandler.cpp

* fix(core/packet): prevent crash for malformed guild message

* fix(lint): fix codacy warnings
 2020-03-07 10:12:16 +01:00
gengarshadowball
95251dfd2d fix(Core/Dungeon): Halls of stone doors (#2646) 
* Improved logic and DX

Simplified the Developer Experience reading such a messy code and removed some duplicated useless conditions

* fix(core/dungeon): Halls of stone door

The door is closed before Maiden of Grief and Krystalus die.

* Revert "Merge commit 'refs/pull/2634/head' of https://github.com/azerothcore/azerothcore-wotlk into pr-2634"

This reverts commit 04e8ac45e4d868eda4a89229f3721ee699ba4be5, reversing
changes made to 2fa9f5c249.

* Review changes

* improvement to check

Co-authored-by: Yehonal <yehonal.azeroth@gmail.com>
 2020-03-03 14:00:40 +01:00
gengarshadowball
857e799298 Morph command update (#2641) 
* changed morph command

removed demorph and adapted morph to include a reset option

* command info updated

* Update data/sql/updates/pending_db_world/rev_1580747652284896800.sql

Co-Authored-By: Barbz <BarbzYHOOL@users.noreply.github.com>

* Added subcommand system for Morph

- Subcommands
- Descriptions on database

* travis

* two single quotes query

* Update data/sql/updates/pending_db_world/rev_1580747652284896800.sql

Co-Authored-By: Barbz <BarbzYHOOL@users.noreply.github.com>

* Update data/sql/updates/pending_db_world/rev_1580747652284896800.sql

Co-Authored-By: Barbz <BarbzYHOOL@users.noreply.github.com>

* Update data/sql/updates/pending_db_world/rev_1580747652284896800.sql

Co-Authored-By: Barbz <BarbzYHOOL@users.noreply.github.com>

Co-authored-by: Barbz <BarbzYHOOL@users.noreply.github.com>
 2020-03-01 10:34:56 +01:00
Stoabrogga
2eb0705668 fix(Core/Pet): only show pet details for hunter pets and demons (#2637) 2020-02-28 17:02:54 +01:00
Stoabrogga
9adba482c2 feat(Core/Hook): A few new hooks (#2671) 2020-02-27 22:45:38 +01:00
Stefano Borzì
0749a861aa fix(Core): build with ENABLE_EXTRA_LOGS (#2709) 2020-02-27 08:04:24 +01:00
Stoabrogga
8f5c628836 feat(Core/Hook): New GlobalScript hook (#2665) 
This allows you to change the behavior of phase system
 2020-02-26 09:44:12 +01:00
Amin.MasterkinG
17fc93d864 fix(Core/Crash): remove unneeded hook OnPlayerChat (#2707) 2020-02-26 08:03:18 +01:00
Barbz
6869848364 fix(Core/commands): Realign columns for command ".pdump" (#2699) 2020-02-25 08:49:25 +01:00
Stefano Borzì
9e307455a8 refactor(HandleAuctionListOwnerItems): prevent crash (#2684) 2020-02-24 08:40:02 +01:00
Stoabrogga
ed243d6911 feat(Core/Config): Parameter to set all creatures with WP movement active (#2615) 2020-02-23 14:08:42 +01:00
Viste
d387bdc695 fix(Core/Packet): fix crash happening when someone sends small packets that is processed directly to WorldSocket (#2669) 2020-02-22 11:24:08 +01:00
Viste
a7970b711a Core/Misc: Remove redundant null pointer checks before delete (#2679) 
Co-authored-by: Ujp8LfXBJ6wCPR <github@lillecarl.com>

Co-authored-by: Ujp8LfXBJ6wCPR <github@lillecarl.com>
 2020-02-20 18:33:28 +01:00
Yehonal
0cabb8e7e1 refactor(Core/Spells): Improved logic and DX Spell::EffectSummonPet (#2634) 2020-02-20 07:55:04 +01:00
niaro-kitty
32dcb3bf63 feat(Core/Spell): Header include optimization for files: SpellAura.h SpellAuraEffects.h (#2632) 2020-02-19 07:55:18 +01:00
Viste
38e8503d21 fix(Core/Misc): fix some exploits (#2630) 2020-02-18 08:26:12 +01:00
Stoabrogga
5ebb982db5 fix(Core/CreatureGroups): Fix "MoveSplineInitArgs::Validate" errors (#2604) 2020-02-16 10:04:55 +01:00
Stoabrogga
dcb714a5ef fix(Core/CreatureAI): Skip creatures in evade mode for DoZoneInCombat (#2599) 2020-02-14 08:06:58 +01:00
Stoabrogga
30fa1ae3b4 fix(Core/Unit): Fix Guardian Pets clearing combat state (#2619) 2020-02-13 08:12:52 +01:00
Rochet2
c16f21a271 fix(Core/Eluna): Fix issues with spell procs with Eluna (#2636) 2020-02-12 07:58:29 +01:00
Stoabrogga
166967fe86 fix(Core/TempSummon): Fix crash concerning PlayerScript hook (#2650) 2020-02-05 17:40:17 +01:00
Stoabrogga
3f0739f1c9 feat(Core/Hook): New PlayerScript hooks (#2639) 2020-02-04 08:25:11 +01:00
Kaev
2fa9f5c249 fix(Core): potential crashes/bugs reported by static analysis #2 (#2622) 2020-02-03 07:52:27 +01:00
Nefertumm
8cfdfd0af0 Fix (Core/DB): Remove hardcoded text from Malygos (#2618) 2020-02-01 22:46:27 -03:00
Dresmyr
1329b6b471 fix(Core/Hook): Make OnPlayerLeaveMap actually trigger (#2628) 
OnPlayerLeaveMap was previously inside the if(remove) block which only is called when the player is logging out, this moves it outside that block but still has it trigger in the same order, thus allowing OnPlayerLeaveMap scripts to fire properly (needed for AutoBalanceFix)
 2020-02-01 15:03:48 +01:00
Kaev
ab72dc1e7a fix(Core/Player): Fix removal of quest items (#2626) 2020-01-29 10:32:39 +01:00
Barbz
8760a9f5c9 refactor(CORE/scripts): Clearer error when script unassigned or alrea… (#2576) 2020-01-29 08:18:59 +01:00
Shard
35b6bedd81 fix(Core/DK): Don't allow starter dk to queue bg (#2584) 2020-01-26 16:25:48 +01:00
Kaev
999d588c37 fix(Core): Fixed a few crashes/bugs that were found via static code analysis (#2617) 2020-01-25 14:26:38 +01:00
Barbz
1bbe10dc33 fix(Core): Improve logging msg when missing .conf file (#2560) 
- Fixed typos
- Changed outError to outString when it's not an actual error but just a warning
- Display "load hardcoded default settings" only when .conf.dist AND .conf are missing
 2020-01-24 09:39:29 +01:00
Shard
9f690a3741 fix(Core) : Enable randomProperties or suffix up to 5 (#2340) 2020-01-23 08:06:05 +01:00
Nefertumm
59234f8f4b fix(CORE): Missing override on various functions (#2602) 2020-01-21 19:03:15 -03:00
Viste
b66ec5712e fix(Core/Battleground): must fix IC scoreboard (#2597) 2020-01-21 23:47:16 +07:00
Shard
eadcb1a782 feat(Core/Battlegrounds) Reworked enhanced bg system for modules (#2521) 2020-01-19 17:09:02 +01:00