Stefano Borzì
e5e514bbbe
feat(Core/Scripting): add OnBeforeArenaCheckWinConditions hook for mod-arena-replay compatibility ( #19856 )
2024-09-04 10:33:38 -03:00
Benjamin Jackson
bf18b9bdfb
fix(Core/AI): Improve creature leashing behavior. ( #19751 )
...
* Init.
https: //github.com/vmangos/core/commit/7d2f1e2923734ea1b983eeaa0208cfd158d4af02
Co-Authored-By: ratkosrb <35845488+ratkosrb@users.noreply.github.com >
* Hackfix for pets.
* Whoops.
* Correct evade uses.
* Conflict.
* Actually fix grace timer.
* Add visibility distance check.
Creatures should always fail combat checks in the open world if they're outside of visibility distance, might not be the case for worldbosses.
---------
Co-authored-by: ratkosrb <35845488+ratkosrb@users.noreply.github.com >
2024-09-03 21:08:56 +02:00
Benjamin Jackson
1edac37ac3
refactor(Core): Make more use of helpers. ( #19835 )
...
* Init.
* Reword.
* Update codestyle script.
Co-Authored-By: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
* Add gameobject type ID check, reorder checks.
* Add helper/codestyle check for unit type.
* `IsUnit()` -> `IsCreature()`
* Add `IsUnit()` method.
* Use type mask.
https: //github.com/TrinityCore/TrinityCore/commit/cc71da35b5dc74abf71f8691161525a23d870bb5
Co-Authored-By: Giacomo Pozzoni <giacomopoz@gmail.com >
Co-Authored-By: Ovahlord <18347559+Ovahlord@users.noreply.github.com >
* Replace instances of `isType` with `IsUnit`.
---------
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com >
Co-authored-by: Ovahlord <18347559+Ovahlord@users.noreply.github.com >
2024-09-03 14:41:31 -03:00
Benjamin Jackson
e3e4133e88
fix(Core/Handlers): Only remove emote if player is moving. ( #19740 )
...
Init.
2024-09-03 13:12:32 -03:00
Anton Popovichenko
9999a80c96
feat(Core/Achievements): Add possibility to complete achievements and update achievement criteria for offline players. ( #19851 )
2024-09-03 13:05:23 -03:00
Grimdhex
221dbd3fdb
chore(Apps/Codestyle): add new codestyle checks for pointers and range loops ( #19841 )
...
* chore(Apps/Codestyle): add new codestyle checks for pointers and range loops
* revert a typo
2024-09-03 13:02:38 -03:00
sudlud
c929b95172
fix(Conf): sync default values with core defaults ( #19708 )
...
fix(Conf): sync values with core defaults
2024-09-03 08:02:28 -03:00
Kitzunu
9af86553c5
chore(Core/Misc): update floor and ceil to std ( #19837 )
2024-09-03 08:01:00 -03:00
Kitzunu
de2bcbdabf
refactor(Core/Misc): Acore::StringFormat to fmt format ( #19838 )
...
refactor(Core/Utilities): Acore::StringFormat to fmt format
* closes https://github.com/azerothcore/azerothcore-wotlk/issues/10356
2024-09-03 07:59:37 -03:00
Andrew
0954e314a0
fix(Scripts/BlackTemple): Fix Zerevor not casting Dampen Magic OOC ( #19768 )
...
* fix(Scripts/BlackTemple): Fix Zerevor not casting Dampen Magic OOC
* Update boss_illidari_council.cpp
* recast every 1min
* implement the recast checks
* Update CreatureAI.h
* Update boss_illidari_council.cpp
* Update boss_illidari_council.cpp
* fix ooc cast
* Update boss_illidari_council.cpp
* always respect the 60s lock
* Update boss_illidari_council.cpp
* Update boss_illidari_council.cpp
2024-09-02 20:44:34 -03:00
Benjamin Jackson
0158fa3e9e
fix(Core/Handlers): Don't allow data to be sent while not grouped. ( #19852 )
...
Init.
https: //github.com/TrinityCore/TrinityCore/commit/f57647287af1f47a1c4a503cde654d6ff8f4261c
Co-authored-by: Shauren <shauren.trinity@gmail.com >
2024-09-02 15:22:01 -03:00
Jelle Meeus
0504c7f9de
fix(Core/GameObject): fixup allow use of Mage portal if caster is offline and still in group ( #19853 )
...
* fix portals
* fixup! fix portals
* fixup! fixup! fix portals
2024-09-02 14:00:15 -03:00
Benjamin Jackson
2f00db3418
fix(Scripts/BlackTemple): Adjust order of damage calculations for Shared Rule. ( #19849 )
...
Init.
2024-09-02 05:34:30 -03:00
Jelle Meeus
e1abc72a25
fix(Core/Spell): warrior stances proccing darkmoon card vengeance damage ( #19796 )
...
add spellinfocorrection
2024-09-01 20:58:03 -03:00
Saqra1
62b825f8bd
fix(Core/Movement): Don't move for change in orientation only ( #19687 )
...
Changing only the orientation of a unit also flags it as if it were
moving, which causes spells to be interrupted.
2024-09-01 20:57:17 -03:00
Jelle Meeus
5d4c85143c
fix(Core/GameObject): Allow use of Mage portal if caster is offline and still in group ( #19797 )
...
search group of user for ownerGUID
2024-09-01 20:56:05 -03:00
Benjamin Jackson
888aa00cfb
fix(Core/Guild): Require repair rights in order to make use of guild repairs. ( #19836 )
...
* Init.
* Ensure only repair requests are screened.
* Adjust parentheses.
2024-09-01 00:48:13 -03:00
Kitzunu
5d31b9f98f
refactor(Core/Item): Add helpers ( #19828 )
2024-08-31 19:38:50 -03:00
Benjamin Jackson
f88812443d
refactor(Core): Correct typo. ( #19830 )
...
Init.
2024-08-31 17:38:03 -03:00
Andrew
83d623e559
fix(Scripts/BlackTemple): Fix Mother Shahraz teleport ( #19820 )
...
fix(Scripts/BlackTemple): Fix Mother Sharaz teleport
Co-authored-by: Keader <keader.android@gmail.com >
2024-08-31 17:35:17 -03:00
Walter Pagani
3b45e90e41
fix(Scripts/ICC): NPC Muradin Dialogues ( #18931 )
...
Co-authored-by: Meji <alvaro.megias@outlook.com >
Co-authored-by: 天鹿 <18535853+PkllonG@users.noreply.github.com >
2024-08-31 17:34:56 -03:00
Carriola-wotlk
9ae19e5429
fix(DB/Item): Feathermoon Headdress has the wrong stats ( #19814 )
...
* fix(DB/Item): Feathermoon Headdress has the wrong stats
* ITEM_MOD_SPELL_DAMAGE_DONE deprecated check removed
2024-08-31 12:22:18 -03:00
Grimdhex
5ab142af93
fix(Core/AI): remove an unused variable in ScriptedAI ( #19816 )
...
fix(Core/AI): remove an unused variable
2024-08-31 11:05:18 -03:00
Benjamin Jackson
8874953862
fix(Core/CharmInfo): Respect charm spell indices when adding to action bar. ( #19811 )
...
Init.
2024-08-31 10:36:57 -03:00
Benjamin Jackson
30f87a3e2f
fix(Scripts/BlackTemple): Call evade for Council creature when members evade. ( #19808 )
...
Init.
2024-08-31 09:41:19 -03:00
Benjamin Jackson
9a503d4703
fix(Scripts/BlackTemple): Ensure Illidari council health is balanced across wipes. ( #19809 )
...
Init.
2024-08-31 09:40:48 -03:00
Jelle Meeus
0fb2c5efeb
fix(Scripts/TheEye): Kaelthas remove enchanted weapons ( #19801 )
...
* remove weapons
Co-authored-by: killerwife <killerwife@gmail.com >
* style
for consistency
* also cast on KT JustDied
* fix TriggerCastFlags to not ignore reagent cost
* Apply suggestions from code review
---------
Co-authored-by: killerwife <killerwife@gmail.com >
2024-08-30 16:20:52 -03:00
Grimdhex
e4aab5b4f0
fix(Scripts/TempestKeep): revamp Kael'Thas ( #19648 )
...
* fix(Scripts/TempestKeep): force attackstop for all player during the last phase and cleanup the script of Kael'Thas
* few new fixes
* fix codestyle
* fix codestyle and remove misc stuff
*remove the useless DisableSpline
*remove also a misc change use only during the dev
* pass the health to DamageTaken instead UpdateIA
* avoid to iterate over the threatlist and use RemoveAllAttackers() instead
* Revert "avoid to iterate over the threatlist and use RemoveAllAttackers() instead"
This reverts commit 0623c0075191c91c2530496c83d017d3b6a824db.
* Revert "pass the health to DamageTaken instead UpdateIA"
This reverts commit 7f8609af603ecc042c819801a2f04d9d65c5031a.
* revert recents commits
* avoid potential conflicts with others enums
* fix build
2024-08-30 16:10:51 -03:00
sudlud
40eb616e1f
fix(Conf): drop unused options from worldserver.conf.dist ( #19725 )
2024-08-30 09:08:17 -03:00
ianmeesters
a83cd03bfb
feat(Core/Player): add OnCalculateTalentsPoints hook ( #19749 )
...
* playerTalentsHook
* oeps :#
* :#
* does this work?
* make reference
---------
Co-authored-by: Amy Fang <amy@cavemail.ddns.net >
2024-08-30 09:06:07 -03:00
Benjamin Jackson
2bb45fcd30
fix(Scripts/BlackTemple): Adjust handling for Shared Rule spell. ( #19770 )
2024-08-30 09:04:08 -03:00
daobashun
e1692ae5b6
fix(scripts/npc_calvin_montague): Convert to SAI, Add emotes when completing quests ( #18087 )
...
* Magic uses sniffing IDs
Use the sniffer timer and factions
* Wait 3 minutes if the mission fails
* 1. When a task fails, it enters passive mode
2. Add 'quest_details' data to the database
* Remove spaces
* Delete blank lines
* Modify the code as required
* Update src/server/scripts/EasternKingdoms/zone_tirisfal_glades.cpp
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
* Remove curly braces
* Change the name of a private member variable
* Move the c ++ script to smart script
* Delete the C++ script
Re-add the deleted quest_details data
* del blank lines
* Delete the C++ script file
* Modify the annotation
Return to the home pointset phase to 0
Return to the home point to allow the SAI phase reset
* Remove spaces
* Delete functions that are not in use
* Update rev_1704025138911597700.sql
* fix merge error - delete zone file
---------
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
2024-08-28 21:05:40 +02:00
Gultask
8852f0c74c
feat(Core/SmartScripts): Implement Scripted Spawn System ( #19499 )
...
* prespawn2
* pfta
* Update rev_1717715555182000500.sql
* Update rev_1717715555182000500.sql
* Update rev_1717715555182000500.sql
* Update rev_1717715555182000500.sql
* Update rev_1717715555182000500.sql
* Update rev_1717715555182000500.sql
2024-08-28 08:18:02 -03:00
Grimdhex
2f85097413
docs(Core): improve several functions documentation ( #19677 )
...
* initial release
* fix reviews
* fix some typo and add new documetations for MotionMaster
* new update and fix the cli-codestyle
* fix typo
* fix reviews
2024-08-28 08:17:24 -03:00
Anton Popovichenko
9144031ed9
fix(Core/Pool): Fix degradation of pools over time ( #19750 )
2024-08-28 08:14:08 -03:00
Benjamin Jackson
b595586bf0
refactor(Core/SpellMgr): Remove nested ifs for binary evaluation. ( #19762 )
...
* Init.
Co-Authored-By: Anton Popovichenko <walkline.ua@gmail.com >
* Whitespace.
* Tiny nitpick.
Co-Authored-By: Anton Popovichenko <walkline.ua@gmail.com >
* Tiny nitpick.*
Today Bench learns the difference between break and continue.
Co-Authored-By: Anton Popovichenko <walkline.ua@gmail.com >
* Parentheses warnings.
* Apply suggestion.
Co-Authored-By: Anton Popovichenko <walkline.ua@gmail.com >
---------
Co-authored-by: Anton Popovichenko <walkline.ua@gmail.com >
2024-08-28 08:13:42 -03:00
Benjamin Jackson
5ffbfdd5d6
fix(Core/Creature): Fix grace period for can attack check. ( #19763 )
...
Init.
2024-08-28 08:13:06 -03:00
Andrew
7e2ffc2db8
feat(Scripts/Commands): Implement "pct" optional to the damage command ( #19745 )
2024-08-27 22:28:09 +02:00
Andrew
806d4962cf
fix(Scripts/Spells): L1 Arcane Charge should hit 3 targets ( #19752 )
...
* fix(Scripts/Spells): L1 Arcane Charge should hit 3 targets
* Daily Nitpicks
2024-08-27 22:26:05 +02:00
Jelle Meeus
53e0779ae8
fix(Scripts/Spells): General's Heart trinket ( #19756 )
...
* handle aura with spell_gen_absorb0_hitlimit1
* refactor enscapsulate limit
2024-08-27 22:25:41 +02:00
Benjamin Jackson
c76f2382d9
fix(Scripts/BlackTemple): Improve Illidari Council Empyreal Balance. ( #19757 )
2024-08-27 15:51:47 -03:00
Benjamin Jackson
8f335bbc2b
fix(Core/SpellMgr): Remove binary attribute from Drain Soul. ( #19760 )
...
Init.
2024-08-27 15:17:54 -03:00
Andrew
126f3a31ee
refactor(Scripts/BlackTemple): Update the Illidari Council script to the new registration method ( #19744 )
...
refactor(Scripts/BlackTemple): Update Illidari council to new model
2024-08-26 16:28:48 -03:00
Andrew
83f8871c31
refactor(Core/BossAI): Improve the ScheduleHealthCheck() code ( #19743 )
...
* refactor(Core/BossAI): Improve the ScheduleHealthCheck() code
* Update ScriptedCreature.cpp
---------
Co-authored-by: sudlud <sudlud@users.noreply.github.com >
2024-08-26 14:44:05 -03:00
Andrew
9ce2b23df3
refactor(Scripts/RuinsOfAhnQiraj): Clean up Ayamiss script ( #19742 )
2024-08-26 10:04:11 -03:00
Tereneckla
f2ed6f791b
fix (Core/Unit): add AutoRpeatSpell delay to Auto Shot as well ( #19603 )
...
Update Unit.cpp
2024-08-26 07:20:23 -03:00
Andrew
52cd493ad8
fix(Scripts/BlackTemple): L5 Arcane Charge should be modified by dama… ( #19730 )
...
* fix(Scripts/BlackTemple): L5 Arcane Charge should be modified by damage taken mods
* Create rev_1724540286668312700.sql
* Update spell_generic.cpp
* update to new format
2024-08-26 01:25:10 -03:00
Saqra1
68402b6d91
fix(Core/Spell): Reset cd on some channeled spells ( #19696 )
...
If a spell is both channeled and has SPELL_ATTR0_COOLDOWN_ON_EVENT
attribute (only rituals) is channeled for its full duration, it goes on
an infinite cooldown. The client needs to be notified when the ritual
ends without being completed.
2024-08-25 23:43:01 -03:00
Kitzunu
1bfcc0e469
fix(Core/BG): Fix fmt issue for bg sent notifications ( #19718 )
...
* closes https://github.com/azerothcore/azerothcore-wotlk/issues/19559
2024-08-25 19:22:37 -03:00
Andrew
c5399509e6
refactor(Scripts/TempleOfAhnQiraj): Clean up Cthun script ( #19736 )
...
* refactor(Scripts/TempleOfAhnQiraj): Clean up Cthun script
* Update boss_cthun.cpp
* Update boss_cthun.cpp
2024-08-25 16:46:24 -03:00