Commit Graph

363 Commits

Author SHA1 Message Date
Anton Popovichenko
c66972b900 fix(Core/Scripts): Fix heap-use-after-free in Fingers of Frost proc handler (#21943) 2025-04-17 09:27:49 +02:00
Jelle Meeus
094c15a323 fix(Core/Spells): implement SPELL_ATTR7_TREAT_AS_NPC_AOE (#21787)
Co-authored-by: Shauren <shauren.trinity@gmail.com>
2025-03-28 11:18:40 +01:00
Jelle Meeus
6535a75121 fix(Scripts/Spells): add warrior heroic strike daze bonus damage (#21650) 2025-03-17 11:04:31 +01:00
vrachv
0ff1a9756c fix(Core/Spell) Removed Prey on the Weak triggering on dead targets (#21611) 2025-02-25 23:52:23 +01:00
Paul
3fcccf2a2e fix(Core/Spells): Fixed misdirection triggering from mend pet (#21526)
Co-authored-by: pavel_k <pavel_k@mail.com>
2025-02-21 19:50:33 -03:00
Jelle Meeus
79ba56ed3d fix(Scripts/Spell): Priest shadowfiend attack and Shadowfiend Death proc (#20987)
Co-authored-by: killerwife <killerwife@gmail.com>
Co-authored-by: Grimdhex <176165533+Grimdhex@users.noreply.github.com>
2025-02-19 07:50:44 -03:00
Jelle Meeus
92ef042f33 fix(Scripts/Spells): Warrior IntimidationShout (#20969) 2025-02-16 23:19:50 +01:00
demetrzz
fe206c7138 fix(Scripts/Spells): Corrected shaman 8/8 T2 set bonus damage proc (#21432)
Co-authored-by: pavel_k <pavel_k@mail.com>
2025-02-15 12:02:27 +01:00
Andrew
be422f2f2a fix(Scripts/Spells): Fix Isle of Queldanas Orb of Translocation (#21325) 2025-02-05 07:43:39 +01:00
Jelle Meeus
a1cf6a7ceb fix(Scripts/ZulAman): Zul'Jin reduce procs of Energy Storm Aura (#21169) 2025-01-14 22:09:07 -03:00
Andrew
fb3749718e fix(Scripts/Spells): Move Curse of Mending (7098 & 39647) to spell sc… (#21117) 2025-01-09 20:15:50 +01:00
Jelle Meeus
638b8ea621 fix(Scripts/Spells): Death Knight Army of the Dead auras (#19795) 2024-12-28 14:23:14 +01:00
Kitzunu
bff594c4f5 feat(Unit/Misc): HasAnyAuras() HasAllAuras() HasAuras() (#21040) 2024-12-26 05:51:54 -03:00
Andrew
68d69c3596 fix(Scripts/Spells): Fix Aether Ray behaviour for quest Wrangle Aethe… (#20972)
fix(Scripts/Spells): Fix Aether Ray behaviour for quest Wrangle Aether Rays
2024-12-19 05:35:39 -03:00
Kitzunu
ed008a8780 refactor(Core/Spells): Add helpers for HasAuraType (#20802) 2024-12-01 08:50:59 -03:00
Jelle Meeus
047a21d31a fix(Scripts/ZulAman): Halazzi Phases (#20650) 2024-11-20 09:08:21 -03:00
avarishd
3ae3b08b85 fix(Scripts/Item): Multiphase Goggles not showing disturbances on minimap (#20446)
* fix(Scripts/Item): Multiphase Goggles not showing disturbances on mimimap

* Apply suggestions from code review
2024-11-19 12:11:34 -03:00
Andrew
5252e6cf5b fix(Scripts/Spells): Spell school reflectors should have failure chan… (#20560)
fix(Scripts/Spells): Spell school reflectors should have failure chance at higher levels
2024-11-14 16:03:35 -03:00
Jelle Meeus
3565e4a9eb feat(Core/WorldState): improved WorldState scripting (#20141)
* implement world state script

based on
0b87ca9d9e

Co-authored-by: killerwife <killerwife@gmail.com>

* refactor to use onleave and onenter instead of spell_area

allows players to right click remove adal's buff

* add MapMgr.h

* refactor: use condition enum instead of uint32, prefix WORLD_STATE where needed

* remove lock from WorldState::Update

sWorldState->Update() is only called from World::Update

* remove unsafe SmartAI action of setWorldState

---------

Co-authored-by: killerwife <killerwife@gmail.com>
2024-11-12 12:15:27 -03:00
Andrew
91b8cc29cf fix(Scripts/Spells): Limit Cyclone (39594) to 4 targets (#20506) 2024-11-10 14:54:33 -03:00
avarishd
705b8ab50e fix(Scripts/Item): Obsidian Armor & Frostfire Regalia Set (#20453) 2024-11-06 01:28:53 -03:00
avarishd
1c22cdcab2 fix(Core/Spells): Luffa removing bleeds over level 60 (#20411)
* fix(Core/Spells): Luffa

* Update spell_item.cpp

* Update spell_item.cpp

* Update spell_item.cpp
2024-11-04 21:09:10 +01:00
Francesco Borzì
cb7e28df05 refactor(src/server/game/*): remove unused imports (big part 1) (#20310) 2024-10-27 10:25:40 +01:00
Benjamin Jackson
4ad9d68f42 chore(Core): Correct typo of Suppress. (#20229)
* Init.

* Adjust spacing.
2024-10-17 22:09:53 +02:00
Jelle Meeus
9a1f27121a fix(Core/Unit): Flight Form riding crop, vehicle speed auras (#20079)
* vehicle aura stacking

Rename flight speed related auras
Co-authored-by: Laise <fenrisse@gmail.com>

* rename to better match existing flight auras
2024-10-01 21:39:42 +02:00
Andrew
98ae32e1da fix(Scripts/Spells): Remove immunity application from Preparation buff (#20042) 2024-09-25 12:00:57 -03:00
Grimgravy
511235cca3 fix(Scripts/Quest): Fires Over Skettis (#19567)
* fix(Scripts/Quest): Fires Over Skettis

* Update spell_item.cpp

---------
2024-09-23 14:05:11 +02:00
Kitzunu
386aea03ee chore(Core/Misc): Some cleanup (#19970)
* remove weird blanks

* update if

* ) ) to ))

* missed some ) )

* now switch

* .
2024-09-21 19:34:31 +02:00
Jelle Meeus
188b864d79 fix(DB/ArgentTournament): Stabled Campaign Warhorse missing error message (#19926)
* fix lance requirement error msg

* ;
2024-09-21 18:48:04 +02:00
Benjamin Jackson
1edac37ac3 refactor(Core): Make more use of helpers. (#19835)
* Init.

* Reword.

* Update codestyle script.

Co-Authored-By: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* Add gameobject type ID check, reorder checks.

* Add helper/codestyle check for unit type.

* `IsUnit()` -> `IsCreature()`

* Add `IsUnit()` method.

* Use type mask.

https: //github.com/TrinityCore/TrinityCore/commit/cc71da35b5dc74abf71f8691161525a23d870bb5
Co-Authored-By: Giacomo Pozzoni <giacomopoz@gmail.com>
Co-Authored-By: Ovahlord <18347559+Ovahlord@users.noreply.github.com>

* Replace instances of `isType` with `IsUnit`.

---------

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
Co-authored-by: Ovahlord <18347559+Ovahlord@users.noreply.github.com>
2024-09-03 14:41:31 -03:00
Grimdhex
221dbd3fdb chore(Apps/Codestyle): add new codestyle checks for pointers and range loops (#19841)
* chore(Apps/Codestyle): add new codestyle checks for pointers and range loops

* revert a typo
2024-09-03 13:02:38 -03:00
Kitzunu
9af86553c5 chore(Core/Misc): update floor and ceil to std (#19837) 2024-09-03 08:01:00 -03:00
Kitzunu
de2bcbdabf refactor(Core/Misc): Acore::StringFormat to fmt format (#19838)
refactor(Core/Utilities): Acore::StringFormat to fmt format

* closes https://github.com/azerothcore/azerothcore-wotlk/issues/10356
2024-09-03 07:59:37 -03:00
Benjamin Jackson
f88812443d refactor(Core): Correct typo. (#19830)
Init.
2024-08-31 17:38:03 -03:00
Andrew
806d4962cf fix(Scripts/Spells): L1 Arcane Charge should hit 3 targets (#19752)
* fix(Scripts/Spells): L1 Arcane Charge should hit 3 targets

* Daily Nitpicks
2024-08-27 22:26:05 +02:00
Jelle Meeus
53e0779ae8 fix(Scripts/Spells): General's Heart trinket (#19756)
* handle aura with spell_gen_absorb0_hitlimit1

* refactor enscapsulate limit
2024-08-27 22:25:41 +02:00
Andrew
52cd493ad8 fix(Scripts/BlackTemple): L5 Arcane Charge should be modified by dama… (#19730)
* fix(Scripts/BlackTemple): L5 Arcane Charge should be modified by damage taken mods

* Create rev_1724540286668312700.sql

* Update spell_generic.cpp

* update to new format
2024-08-26 01:25:10 -03:00
Grimdhex
643362d697 refactor(Core/Object): adds consistency in the use of type object check (#19671) 2024-08-25 09:57:37 -03:00
Grimdhex
61f3a631c3 fix(Server): remove double blank lines at the end of several files (#19735) 2024-08-25 07:21:14 -03:00
Gultask
e34ce755c8 fix(Scripts/ShadowmoonValley): Rewrite Dragonmaw Races (#19084)
* init

* fly :)

* finally

* melee attack :/

* Update zone_shadowmoon_valley.cpp

Co-Authored-By: Dan <83884799+elthehablo@users.noreply.github.com>

* Update zone_shadowmoon_valley.cpp

* Update zone_shadowmoon_valley.cpp

* Update zone_shadowmoon_valley.cpp

---------

Co-authored-by: Dan <83884799+elthehablo@users.noreply.github.com>
2024-07-27 07:32:17 -03:00
Francesco Borzì
e592fdd248 refactor(Scripts/misc): remove unused imports (#19458) 2024-07-22 16:20:41 -03:00
avarishd
f510e122a0 fix(Script/Quest): Protecting Our Own (#19247)
* fix(Core/Spells): Gor'drek's Ointment

* Update spell_item.cpp

* ;
2024-07-17 13:19:48 +02:00
Saqra1
a950a7f44e fix(Core/Pets): Add option to revive pets with full mana (#19383)
* fix(Scripts/Spells): Revive pets with full mana in bgs

* Pets were incorrectly revived without restoring its mana

* Closes #15894

* ready for merge

---------

Co-authored-by: Saqra1 <>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2024-07-17 12:38:10 +02:00
Jelle Meeus
e8af1aaffc fix(Scripts/Spells): warlock seed of corruption (#19322)
* remove seed of corruption handling in unit.cpp

* add generic and warlock aurascript

add warlock  aurascript

add enum

add generic aurascript

add OnRemove

2ff855054f (diff-ea612aafadff90005e88b243eb000369be9e5cb6f8dc85a008d31e42b156e0ec)

detonation threshold scaling added in: df5afca278

Co-authored-by: ariel- <ariel-@users.noreply.github.com>

* add LoS check to generic damage

* refactor 2 scripts to 1 with args

refactor const_cast to GetAura()->GetEffect(

refactor reduce a line

* fix detonation threshold scaling

changed SPELL_DIRECT_DAMAGE to DOT

* remove not needed IsExpired() check

removal upon expiration is notified by AURA_REMOVE_BY_EXPIRE

* update comment

* refactor script with args to single spellscript, fix detonate by evade

* refactor

detonation to Detonate()
rename amount to remainingDamage
remove no tneeded HealthBelowPctDamaged

* refactor to 2 spell scripts again

* rename detonation spell from seed_of_corruption to seed_of_corruption_damage

avoids confusion with seed of corruption (with dot effect)

---------

Co-authored-by: ariel- <ariel-@users.noreply.github.com>
2024-07-17 01:50:38 +02:00
avarishd
90c7658320 fix(Script/Spells): Script Glumdor's Steal Weapon (#19258)
* fix(Core/Spells): Script Glumdor's Steal Weapon

* add creature check
2024-07-17 01:44:49 +02:00
Jelle Meeus
a69d02e513 fix(Scripts/Spells): warlock demonic pact (#19386)
* add Demonic Pact Aura script

2ff855054f (diff-ea612aafadff90005e88b243eb000369be9e5cb6f8dc85a008d31e42b156e0ec)

Co-authored-by: ariel- <ariel-@users.noreply.github.com>

* spell_warlock aura:spell_warl_demonic_pact_aura

* fixup! spell_warlock aura:spell_warl_demonic_pact_aura

* remove not needed spell correction, flag is already set

* subtract current proc bonus before calculating new bonus

* also increase healing done

* remove Demonic Pact handling in Unit

* refactor indent, remove bonus from spell group effects e.g. totem of wrath

* Revert "refactor indent, remove bonus from spell group effects e.g. totem of wrath"

This reverts commit 104041172d34f542cc934e9f468407c36912cc7f.

* refactor indent

* manually set proc cooldown

---------

Co-authored-by: ariel- <ariel-@users.noreply.github.com>
2024-07-13 12:38:59 -03:00
sudlud
37e3d89f91 fix(CI): linux-build: add -Werror parameter (#19240)
* fix(CI): linux-build: add -Werror parameter

* add KI

tzunu

* Revert "feat(CI): enable fail-fast for pch/nopch (#19058)"

This reverts commit 564cbca7d3.

* Update midsummer.cpp - drop unused variable

* initialize variable

* Update core-build-nopch.yml - drop gcc12

* fix(Core/CalendarMgr): do not use element after delete, but before

* attempt to fix Socket.h error

* Revert "attempt to fix Socket.h error"

This reverts commit c1a59145ed3c49d0f76be2f81925434ea969db97.

* fix Socket.h error - attempt 2

* Update Socket.h

* Update Socket.h

* npc_shattrath_daily_quest: init variable templateID

* fix(Scripts/Karazhan): use size_t within loop in boss_shade_of_aran:Reset()

* boss_archimonde: drop unused variable

* Revert "fix(Scripts/Karazhan): use size_t within loop in boss_shade_of_aran:Reset()"

This reverts commit 1f71aaef256990c5cdc16561676be302c954ea9d.

* SmartScripts: SMART_TARGET_RANDOM_POINT: fix unintended fallthrough

* Revert "Revert "feat(CI): enable fail-fast for pch/nopch (#19058)""

This reverts commit d13df293624e0f50d9374272bfd05ab56242511d.

---------

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2024-07-07 22:00:24 +02:00
Kitzunu
172f73db92 fix(Core/Misc): unused param (#19286) 2024-07-05 15:06:03 -03:00
Andrew
d9f4ba5e1d fix(Scripts/Item): Fix Fel Mana Potion not benefiting from Alchemist'… (#19281)
fix(Scripts/Item): Fix Fel Mana Potion not benefiting from Alchemist's Stone
2024-07-05 06:32:33 -03:00
Kitzunu
bc91074b14 fix(build): mac (#19229) 2024-06-29 11:48:58 -03:00