refactor(src/server/game/*): remove unused imports (big part 1) (#20310)

src/server/game/AI/CreatureAIImpl.h

@@ -18,9 +18,7 @@
 #ifndef CREATUREAIIMPL_H
 #define CREATUREAIIMPL_H
 
-#include "CreatureAI.h"
 #include "Define.h"
-#include "SpellMgr.h"
 #include "TemporarySummon.h"
 
 template<typename First, typename Second, typename... Rest>

src/server/game/Achievements/AchievementMgr.h

@@ -23,7 +23,6 @@
 #include "DBCStores.h"
 #include "DatabaseEnv.h"
 #include "ObjectGuid.h"
-#include <chrono>
 #include <map>
 #include <string>
 

src/server/game/Addons/AddonMgr.h

@@ -22,7 +22,6 @@
 #include <array>
 #include <list>
 #include <string>
-#include <utility>
 
 struct AddonInfo
 {

src/server/game/ArenaSpectator/ArenaSpectator.cpp

@@ -23,7 +23,6 @@
 #include "Player.h"
 #include "SpellAuraEffects.h"
 #include "SpellAuras.h"
-#include "Types.h"
 #include "World.h"
 
 bool ArenaSpectator::HandleSpectatorSpectateCommand(ChatHandler* handler, std::string const& name)

src/server/game/Battlegrounds/BattlegroundQueue.h

@@ -23,7 +23,6 @@
 #include "DBCEnums.h"
 #include "EventProcessor.h"
 #include <array>
-#include <deque>
 
 constexpr auto COUNT_OF_PLAYERS_TO_AVERAGE_WAIT_TIME = 10;
 

src/server/game/Chat/Channels/Channel.h

@@ -21,10 +21,7 @@
 #include "Common.h"
 #include "WorldPacket.h"
 #include "WorldSession.h"
-#include <list>
-#include <map>
 #include <string>
-#include <utility>
 
 class Player;
 

src/server/game/Chat/Channels/ChannelMgr.h

@@ -19,7 +19,6 @@
 #define __ACORE_CHANNELMGR_H
 
 #include "Channel.h"
-#include "Common.h"
 #include "World.h"
 #include <map>
 #include <string>

src/server/game/Chat/Chat.h

@@ -22,7 +22,6 @@
 #include "Player.h"
 #include "SharedDefines.h"
 #include "WorldSession.h"
-#include <vector>
 
 class ChatHandler;
 class Creature;

src/server/game/Chat/ChatCommands/ChatCommand.h

@@ -23,14 +23,12 @@
 #include "Define.h"
 #include "Errors.h"
 #include "Language.h"
-#include "ObjectGuid.h"
 #include "Optional.h"
 #include "StringFormat.h"
 #include "Util.h"
 #include <cstddef>
 #include <map>
 #include <tuple>
-#include <utility>
 #include <variant>
 #include <vector>
 

src/server/game/Chat/ChatCommands/ChatCommandArgs.h

@@ -24,7 +24,6 @@
 #include "StringConvert.h"
 #include "StringFormat.h"
 #include "Util.h"
-#include <charconv>
 #include <map>
 #include <string>
 #include <string_view>

src/server/game/Combat/HostileRefMgr.h

@@ -18,7 +18,6 @@
 #ifndef _HOSTILEREFMANAGER
 #define _HOSTILEREFMANAGER
 
-#include "Common.h"
 #include "RefMgr.h"
 
 class Unit;

src/server/game/Combat/ThreatMgr.h

@@ -18,7 +18,6 @@
 #ifndef _THREATMANAGER
 #define _THREATMANAGER
 
-#include "Common.h"
 #include "IteratorPair.h"
 #include "ObjectGuid.h"
 #include "Reference.h"

src/server/game/Conditions/ConditionMgr.h

@@ -19,7 +19,6 @@
 #define ACORE_CONDITIONMGR_H
 
 #include "Define.h"
-#include "Errors.h"
 #include <list>
 #include <map>
 

src/server/game/Conditions/DisableMgr.cpp

@@ -25,6 +25,7 @@
 #include "SpellMgr.h"
 #include "StringConvert.h"
 #include "Tokenize.h"
+#include "VMapMgr2.h"
 #include "World.h"
 
 namespace DisableMgr

src/server/game/Conditions/DisableMgr.h

@@ -20,8 +20,6 @@
 
 #include "Define.h"
 #include "Map.h"
-#include "VMapMgr2.h"
-
 class Unit;
 
 enum DisableType

src/server/game/DataStores/M2Stores.cpp

@@ -23,7 +23,6 @@
 #include "World.h"
 #include <boost/filesystem/path.hpp>
 #include <fstream>
-#include <iostream>
 
 typedef std::vector<FlyByCamera> FlyByCameraCollection;
 std::unordered_map<uint32, FlyByCameraCollection> sFlyByCameraStore;

src/server/game/DungeonFinding/LFG.h

@@ -18,10 +18,7 @@
 #ifndef _LFG_H
 #define _LFG_H
 
-#include "Common.h"
-#include "ObjectDefines.h"
 #include "ObjectGuid.h"
-#include "SharedDefines.h"
 #include "WorldPacket.h"
 #include <array>
 #include <map>

src/server/game/DungeonFinding/LFGPlayerData.h

@@ -19,6 +19,7 @@
 #define _LFGPLAYERDATA_H
 
 #include "LFG.h"
+#include "SharedDefines.h"
 
 namespace lfg
 {

src/server/game/Entities/Creature/CreatureData.h

@@ -23,7 +23,6 @@
 #include "ItemTemplate.h"
 #include "LootMgr.h"
 #include "Unit.h"
-#include "World.h"
 #include <list>
 
 #define MAX_AGGRO_RESET_TIME 10 // in seconds

src/server/game/Events/GameEventMgr.cpp

@@ -21,7 +21,6 @@
 #include "DisableMgr.h"
 #include "GameObjectAI.h"
 #include "GameTime.h"
-#include "GossipDef.h"
 #include "Language.h"
 #include "Log.h"
 #include "MapMgr.h"

src/server/game/Grids/GridDefines.h

@@ -21,7 +21,6 @@
 #include "Common.h"
 #include "MapDefines.h"
 #include "NGrid.h"
-#include <cmath>
 
 // Forward class definitions
 class Corpse;

src/server/game/Maps/Map.cpp

@@ -26,6 +26,7 @@
 #include "GridNotifiers.h"
 #include "Group.h"
 #include "InstanceScript.h"
+#include "IVMapMgr.h"
 #include "LFGMgr.h"
 #include "MapInstanced.h"
 #include "Metric.h"
@@ -39,6 +40,7 @@
 #include "Transport.h"
 #include "VMapFactory.h"
 #include "Vehicle.h"
+#include "VMapMgr2.h"
 #include "Weather.h"
 
 union u_map_magic

src/server/game/Maps/Map.h

@@ -33,11 +33,9 @@
 #include "Position.h"
 #include "SharedDefines.h"
 #include "TaskScheduler.h"
-#include "Timer.h"
 #include <bitset>
 #include <list>
 #include <memory>
-#include <mutex>
 #include <shared_mutex>
 
 class Unit;

src/server/game/Maps/MapInstanced.cpp

@@ -23,7 +23,6 @@
 #include "ObjectMgr.h"
 #include "Player.h"
 #include "ScriptMgr.h"
-#include "VMapFactory.h"
 
 MapInstanced::MapInstanced(uint32 id) : Map(id, 0, DUNGEON_DIFFICULTY_NORMAL)
 {

src/server/game/Maps/MapMgr.h

@@ -25,8 +25,6 @@
 #include "MapUpdater.h"
 #include "Object.h"
 
-#include <mutex>
-
 class Transport;
 class StaticTransport;
 class MotionTransport;

src/server/game/Maps/MapUpdater.h

@@ -21,7 +21,6 @@
 #include "Define.h"
 #include "PCQueue.h"
 #include <condition_variable>
-#include <mutex>
 #include <thread>
 
 class Map;

src/server/game/Maps/ZoneScript.h

@@ -18,7 +18,6 @@
 #ifndef ZONE_SCRIPT_H_
 #define ZONE_SCRIPT_H_
 
-#include "Common.h"
 #include "Creature.h"
 
 class GameObject;

src/server/game/Spells/Spell.cpp

@@ -47,7 +47,6 @@
 #include "SpellScript.h"
 #include "TemporarySummon.h"
 #include "Unit.h"
-#include "UpdateData.h"
 #include "Util.h"
 #include "VMapFactory.h"
 #include "Vehicle.h"
@@ -60,6 +59,8 @@
 //  there is probably some underlying problem with imports which should properly addressed
 //  see: https://github.com/azerothcore/azerothcore-wotlk/issues/9766
 #include "GridNotifiersImpl.h"
+#include "IVMapMgr.h"
+#include "VMapMgr2.h"
 
 extern pEffect SpellEffects[TOTAL_SPELL_EFFECTS];
 

src/server/game/Warden/Warden.cpp

@@ -24,7 +24,6 @@
 #include "Opcodes.h"
 #include "Player.h"
 #include "SharedDefines.h"
-#include "Util.h"
 #include "World.h"
 #include "WorldPacket.h"
 #include "WorldSession.h"

src/server/game/Warden/WardenMac.h

@@ -18,10 +18,8 @@
 #ifndef _WARDEN_MAC_H
 #define _WARDEN_MAC_H
 
-#include "ARC4.h"
 #include "ByteBuffer.h"
 #include "Warden.h"
-#include <map>
 
 class WorldSession;
 class Warden;

src/server/game/Warden/WardenWin.h

@@ -19,8 +19,6 @@
 #define _WARDEN_WIN_H
 
 #include "ByteBuffer.h"
-#include "Cryptography/ARC4.h"
-#include "Cryptography/BigNumber.h"
 #include "Warden.h"
 #include <list>
 

src/server/scripts/EasternKingdoms/Karazhan/boss_chess_event.cpp

@@ -28,6 +28,8 @@
 #include "karazhan.h"
 #include <array>
 
+#include "SpellMgr.h"
+
 enum EchoOfMedivhGossipOptions
 {
     MEDIVH_GOSSIP_START_PVE = 1,

src/server/scripts/EasternKingdoms/Karazhan/boss_shade_of_aran.cpp

@@ -26,6 +26,7 @@
 #include "SpellScriptLoader.h"
 #include "TaskScheduler.h"
 #include "karazhan.h"
+#include "SpellMgr.h"
 
 enum Texts
 {

src/server/scripts/Events/pilgrims_bounty.cpp

@@ -21,6 +21,7 @@
 #include "PassiveAI.h"
 #include "Player.h"
 #include "SpellAuraEffects.h"
+#include "SpellMgr.h"
 #include "SpellScript.h"
 #include "SpellScriptLoader.h"
 #include "Vehicle.h"

src/server/scripts/Kalimdor/zone_silithus.cpp

@@ -39,6 +39,7 @@ EndContentData */
 #include "ScriptedGossip.h"
 #include "Spell.h"
 #include "SpellInfo.h"
+#include "SpellMgr.h"
 
 /*####
 # quest_a_pawn_on_the_eternal_board (Defines)

src/server/scripts/Northrend/AzjolNerub/AzjolNerub/boss_anubarak.cpp

@@ -20,6 +20,7 @@
 #include "SpellScriptLoader.h"
 #include "azjol_nerub.h"
 #include "SpellInfo.h"
+#include "SpellMgr.h"
 #include "SpellScript.h"
 
 enum Spells

src/server/scripts/Northrend/CrusadersColiseum/TrialOfTheChampion/boss_grand_champions.cpp

@@ -22,6 +22,7 @@
 #include "ScriptedCreature.h"
 #include "ScriptedEscortAI.h"
 #include "SpellInfo.h"
+#include "SpellMgr.h"
 #include "Vehicle.h"
 #include "trial_of_the_champion.h"
 

src/server/scripts/Northrend/DraktharonKeep/boss_trollgore.cpp

@@ -22,6 +22,7 @@
 #include "SpellScriptLoader.h"
 #include "drak_tharon_keep.h"
 #include "SpellAuraEffects.h"
+#include "SpellMgr.h"
 #include "SpellScript.h"
 
 enum Yells

src/server/scripts/Northrend/IcecrownCitadel/boss_deathbringer_saurfang.cpp

@@ -24,6 +24,7 @@
 #include "SpellAuras.h"
 #include "SpellScriptLoader.h"
 #include "icecrown_citadel.h"
+#include "SpellMgr.h"
 
 enum ScriptTexts
 {

src/server/scripts/Northrend/IcecrownCitadel/boss_festergut.cpp

@@ -22,6 +22,7 @@
 #include "SpellAuras.h"
 #include "SpellScriptLoader.h"
 #include "icecrown_citadel.h"
+#include "SpellMgr.h"
 
 enum ScriptTexts
 {

src/server/scripts/Northrend/IcecrownCitadel/icecrown_citadel_teleport.cpp

@@ -22,6 +22,7 @@
 #include "ScriptedGossip.h"
 #include "Spell.h"
 #include "icecrown_citadel.h"
+#include "SpellMgr.h"
 
 #define GOSSIP_SENDER_ICC_PORT 631
 

src/server/scripts/Outland/Auchindoun/SethekkHalls/boss_talon_king_ikiss.cpp

@@ -20,6 +20,7 @@
 #include "SpellScript.h"
 #include "SpellScriptLoader.h"
 #include "sethekk_halls.h"
+#include "SpellMgr.h"
 
 enum Text
 {

src/server/scripts/Outland/BlackTemple/boss_illidari_council.cpp

@@ -21,6 +21,7 @@
 #include "black_temple.h"
 #include "Player.h"
 #include "SpellAuraEffects.h"
+#include "SpellMgr.h"
 #include "SpellScript.h"
 
 enum Says

src/server/scripts/Outland/GruulsLair/boss_high_king_maulgar.cpp

@@ -19,6 +19,7 @@
 #include "ScriptedCreature.h"
 #include "TaskScheduler.h"
 #include "gruuls_lair.h"
+#include "SpellMgr.h"
 
 enum HighKingMaulgar
 {

src/server/scripts/Outland/HellfireCitadel/BloodFurnace/boss_broggok.cpp

@@ -22,6 +22,7 @@
 #include "SpellScript.h"
 #include "SpellScriptLoader.h"
 #include "blood_furnace.h"
+#include "SpellMgr.h"
 
 enum Say
 {

src/server/scripts/Pet/pet_mage.cpp

@@ -26,6 +26,7 @@
 #include "Player.h"
 #include "ScriptedCreature.h"
 #include "SpellAuras.h"
+#include "SpellMgr.h"
 
 enum MageSpells
 {

src/server/scripts/Spells/spell_item.cpp

@@ -23,6 +23,7 @@
 #include "ScriptedCreature.h"
 #include "SkillDiscovery.h"
 #include "SpellAuraEffects.h"
+#include "SpellMgr.h"
 #include "SpellScript.h"
 #include "SpellScriptLoader.h"
 #include "WorldSession.h"

src/server/scripts/World/item_scripts.cpp

@@ -20,6 +20,7 @@
 #include "Player.h"
 #include "ScriptedCreature.h"
 #include "Spell.h"
+#include "SpellMgr.h"
 
 /*#####
 # item_only_for_flight

src/server/scripts/World/mob_generic_creature.cpp

@@ -18,6 +18,7 @@
 #include "CreatureScript.h"
 #include "PassiveAI.h"
 #include "ScriptedCreature.h"
+#include "SpellMgr.h"
 
 class trigger_periodic : public CreatureScript
 {

src/server/scripts/World/npc_professions.cpp

@@ -21,6 +21,7 @@
 #include "ScriptedCreature.h"
 #include "ScriptedGossip.h"
 #include "SpellInfo.h"
+#include "SpellMgr.h"
 /* ScriptData
 SDName: Npc_Professions
 SD%Complete: 80