Exitare
98ceb1c067
fix(Core/PlayerScript) Align player script function names ( #21020 )
...
Co-authored-by: sudlud <sudlud@users.noreply.github.com >
2025-02-16 14:59:41 +01:00
Benjamin Jackson
1edac37ac3
refactor(Core): Make more use of helpers. ( #19835 )
...
* Init.
* Reword.
* Update codestyle script.
Co-Authored-By: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
* Add gameobject type ID check, reorder checks.
* Add helper/codestyle check for unit type.
* `IsUnit()` -> `IsCreature()`
* Add `IsUnit()` method.
* Use type mask.
https: //github.com/TrinityCore/TrinityCore/commit/cc71da35b5dc74abf71f8691161525a23d870bb5
Co-Authored-By: Giacomo Pozzoni <giacomopoz@gmail.com >
Co-Authored-By: Ovahlord <18347559+Ovahlord@users.noreply.github.com >
* Replace instances of `isType` with `IsUnit`.
---------
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com >
Co-authored-by: Ovahlord <18347559+Ovahlord@users.noreply.github.com >
2024-09-03 14:41:31 -03:00
Grimdhex
643362d697
refactor(Core/Object): adds consistency in the use of type object check ( #19671 )
2024-08-25 09:57:37 -03:00
Grimdhex
61f3a631c3
fix(Server): remove double blank lines at the end of several files ( #19735 )
2024-08-25 07:21:14 -03:00
Francesco Borzì
e592fdd248
refactor(Scripts/misc): remove unused imports ( #19458 )
2024-07-22 16:20:41 -03:00
sudlud
7b8e2514bf
fix(Scripts/Midsummer): correctly despawn gameobjects ( #19387 )
2024-07-14 12:24:06 -03:00
sudlud
3d03cb64ba
fix(Scripts/Midsummer): fix handling of unwanted npc and gameobject s… ( #19141 )
...
fix(Scripts/Midsummer): fix handling of unwanted npc and gameobject spawns
- properly spawn bonfire spell focus for city bonfires
- properly despawn unwanted creatures and gameobjects which are spawned
by linked traps
- all midsummer bonfire gameobjects have a linked trap "181290 Midsummer Bonfire Spawn Trap"
- the trap is linked to the spell "28784 Summon Midsummer Bonfire Bunnies" which then spawns
npc "16592 Midsummer Bonfire", npc "16606 Midsummer Bonfire Despawner" and gameobject
"181371 Midsummer Bonfire Spell Focus" i have no idea how this trap is beeing triggered,
but it's doing only harm right now
2024-06-24 05:10:31 -03:00
天鹿
680c219770
fix(Scripts/Midsummer): use GUID storage rather than Player object ( #19109 )
...
* Update midsummer.cpp
* Update midsummer.cpp
* Update midsummer.cpp
2024-06-21 10:45:56 -03:00
Benjamin Jackson
c3a2b83eba
fix(Scripts/Midsummer): Resolve Ribbon Pole crash. ( #19108 )
...
* Init.
* Add todo.
For you, Nyeriah. 😛
2024-06-20 22:06:49 -03:00
Anton Popovichenko
f792b0d708
feat(Core/Scripts): Optimize PlayerScripts by calling only overridden/implemented functions. ( #18672 )
...
* feat(Core/Scripts): Optimize PlayerScripts by calling only overridden/implemented functions.
* Fix codestyle.
* Fix typo
* PLAYERHOOK_END is not a hook
* Address code review feedback.
Co-authored-by: Winfidonarleyan <dowlandtop@yandex.com >
* Codestyle fixes
* Fix typo
Co-authored-by: PkllonG
---------
Co-authored-by: Winfidonarleyan <dowlandtop@yandex.com >
2024-04-11 17:08:30 -03:00
sudlud
a2f21bd46e
fix(Scripts/Midsummer): Add SpellScript for "Fire Festival Fortitude" ( #18246 )
...
- implement zone wide buff
- Blizzard originally used gameobject 181431 'Fire Festival Fury Trap'
for this implementation
2024-02-01 09:17:17 -03:00
Benjamin Jackson
c9bc5084be
fix(Scripts/Midsummer): Correct behavior for Striking Back quests. ( #18171 )
...
* Init.
Make use of spell for summoning Ahune's lieutenants, set up gossip/smart scripts for the cast and lieutenant summon speech, and remove permanent lieutenant spawns.
Partially cherry-picked from 91268f6631
Co-Authored-By: Xfurry <172444+xfurry@users.noreply.github.com >
* Use GUIDs for creature delete, add game_event_creature delete.
* Various adjustments.
Move comment block, add Desolace stones gossip menu options, add a delete before insert.
* Set up conditions.
* Add spell cast comments.
Sourced from Wrath Classic Wowhead.
* Add basic combat SmartAI.
* Remove comment block.
* Add creature name comments.
* Use `id1` in preparatory creature delete.
---------
Co-authored-by: Xfurry <172444+xfurry@users.noreply.github.com >
2024-01-21 00:05:18 +01:00
sudlud
8720e08da8
fix(DB/SAI): Move GameObjectScript go_midsummer_bonfire to SAI ( #18135 )
2024-01-14 11:08:18 -03:00
sudlud
87c3421262
fix(Scripts/Midsummer): Improve Torch Catching based on sniffs ( #18071 )
...
- Update creature 26188 '[PH] Torch Catching Target Bunny' with sniffed values
- correctly randomize torch target positions
2024-01-01 09:06:54 -03:00
sudlud
1710d4d1c3
fix(Scripts/Midsummer): Implement Midsummer Bonfire mechanics ( #18023 )
2023-12-25 03:06:15 -03:00
sudlud
f2007aa59e
refactor(Scripts/Midsummer): use scheduler provided by CreatureAI ( #17955 )
2023-12-08 23:44:51 +01:00
Winfidonarleyan
eb1ecc38a5
feat(Core/Scripting): move all script objects to separated files ( #17860 )
...
* feat(Core/Scripts): move all script objects to separated files
* Apply 5bfeabde81
* try gcc build
* again
2023-12-02 21:13:20 +01:00
sudlud
09d9a0b73f
fix(Scripts/Midsummer): AuraEffectRemoveFn -> AuraEffectApplyFn ( #17793 )
2023-11-19 13:28:38 +01:00
Kitzunu
bbadc32bea
Revert Visibility Notifier changes ( #17682 )
...
* Revert "fix(Core/Grid): Implement missing GridUnload setting (#17569 )"
This reverts commit 79b39f9655 .
* Revert "fix(Core/Grid): Address bugs and performance issues introduced by visibility notifier implementation (#17480 )"
This reverts commit 60e27511c5 .
* Revert "fix(Core): GridCleanUpDelay Log (#17436 )"
This reverts commit 90b16ca065 .
* Revert "feat(Core/Grids): Implement visibility notifier (#15919 )"
This reverts commit 2779833768 .
2023-11-12 00:48:49 +01:00
Ludwig
cb483d124f
fix(Script/Spell): fix AOE circle bug on Midsummer Torch Catching ( #17654 )
...
* fix(Spells/Midsummer): fix script for spell 46747 SPELL_FLING_TORCH_DUMMY
* SpellInfoCorrections: fix target of spell 46747 Fling torch
* DB: assign spell 46747 Fling torch to item 34833 Unlit Torches
* remove whitespaces at src/server/game/Spells/SpellInfoCorrections.cpp:4610
2023-11-09 00:19:57 +01:00
Ludwig
630b90a633
fix(Scripts/Midsummer): Implement Ribbon Pole dance effects ( #17417 )
...
* fix(Scripts/Midsummer): Implement Ribbon Pole dance effects
* midsummer.cpp: remove whitespaces at end of lines
* midsummer.cpp: fix unused parameter error
* add spacing after 0.0f
* replace Milliseconds(...) by ...ms and Seconds(...) by ...s
* cleanup comments
* remove manual cleanups / despawns from DoCleanupChecks()
- rely on NPC despawn timers
- manual cleanup / removal actually is a bit excessive
* set INTERVAL_DANCING_FLAMES to 15s
* set despawn time to 1min for big dancing flames according to spell 46827
* set spawnDist to 12 for big dancing flames according so spell 46827
* use library function Acore::Containers::RandomShuffle() to shuffle _danclerList
* sql: do not set SmartAI for NPC 17066
already using ScriptName and can't have both
* combine 3 sql files into 1
* remove INTERVAL_... enum values
* remove unnecessary checks of if(_bunny)
* sql: fix smartscript comment
* rename spell define to correct spell name
2023-10-18 14:22:26 +02:00
Ludwig
de50ce3305
fix(Scripts/Midsummer): Randomize ribbon pole beam color ( #17380 )
...
* fix(Scripts/Midsummer): Randomize ribbon pole beam color
* Update data/sql/updates/pending_db_world/rev_1695820418952974700.sql
Co-authored-by: Dan <83884799+elthehablo@users.noreply.github.com >
* Add Validate() to spell script spell_midsummer_ribbon_pole
---------
Co-authored-by: Dan <83884799+elthehablo@users.noreply.github.com >
2023-10-01 09:26:18 +02:00
Ludwig
1004dae7e5
refactor(Scripts/Midsummer): Add/Update Validate() for spell checks ( #17390 )
2023-09-30 09:54:27 +02:00
Ludwig
7a1c303d49
refactor(Scripts/Midsummer): Assign enum values to gameobjects and sp… ( #17379 )
...
* refactor(Scripts/Midsummer): Assign enum values to gameobjects and spells
* rename GO_TORCH_TOSS_TARGET_BUNNY to NPC_TORCH_TOSS_TARGET_BUNNY
* add more enum values to enum flingTorch
2023-09-29 18:30:35 +02:00
AG
2779833768
feat(Core/Grids): Implement visibility notifier ( #15919 )
...
* Cherry-picked from TrinityCore (unable to find author)
2023-09-28 22:28:28 +02:00
Ludwig
6649ad08d7
fix(Scripts/Midsummer): Make beam target Ribbon Pole top ( #17358 )
...
* fix(Scripts/Midsummer): Make beam target Ribbon Pole top
progress #12145
* refactor(Scripts/Midsummer): shorten spell_midsummer_ribbon_pole_visual::UpdateTarget
2023-09-26 18:51:59 -03:00
Ludwig
e2e393502c
fix(Scripts/Midsummer): Add missing torch shadows ( #17323 )
2023-09-24 16:24:33 -03:00
Ludwig
58f8fe6426
refactor(Scripts/Midsummer): Remove old unused code for spell 45644 ( #17324 )
...
- spell 45644 used to be linked to spell_midsummer_juggling_torch
- spell 45644 was later linked to new implementation
spell_midsummer_torch_catch in e1e4c6cddc
- old implementation of spell 45644 was never removed from
spell_midsummer_juggling_torch
2023-09-23 18:55:45 -03:00
Gultask
c0bbb52483
fix(Scripts/Midsummer): Stop Bonfires from spawning more gameobjects ( #16618 )
...
* Update midsummer.cpp
* .
2023-06-24 20:29:05 -03:00
Meramaf
e1e4c6cddc
Script/Spell: fix Midsummer's Juggling Torch ( #12198 )
...
* Script/Spell: fix Midsummer's Juggling Torch
* Update juggling_torch_fix.sql
* Update data/sql/updates/pending_db_world/juggling_torch_fix.sql
Co-authored-by: Nefertumm <nefertum.dev@protonmail.com >
* Update midsummer.cpp
Co-authored-by: Nefertumm <nefertum.dev@protonmail.com >
2022-07-02 16:30:58 -04:00
Kitzunu
27df910cb7
refactor(Script/Event): convert midsummer into new system ( #9607 )
2022-02-10 04:26:37 +01:00
Kargatum
8b7df23f06
feat(Core/Time): Implement saparated manager for game time ( #8630 )
2022-01-24 17:55:00 +07:00
Kargatum
f62664c987
refactor(Core/Misc): headers cleanup ( #9259 )
2021-11-22 17:24:39 +07:00
Malcrom
f106de8788
refactor(Core): update getFaction to GetFaction and setFaction to SetFaction ( #8708 )
2021-11-01 17:04:32 +01:00
Kargatum
52aa0e9966
feat(License): add new headers information about license ( #7941 )
...
Co-authored-by: Francesco Borzì <borzifrancesco@gmail.com >
2021-09-30 13:40:52 +07:00
UltraNix
dd0b964a2a
fix(Scripts/Spells): Unlit Torches cannot be used too far away from the bonfire ( #7644 )
...
- Closes #6551
2021-09-01 15:50:42 +02:00
Francesco Borzì
172d33d507
refactor(Scripts/Events): code cleanup (part 6) ( #6924 )
2021-07-20 09:55:31 +02:00
UltraNix
f4c226423d
feat(Core/Misc): implement ObjectGuid class (port from TC) ( #4885 )
2021-04-25 22:18:03 +02:00
Kitzunu
dbc0ff6554
refactor(Core): sort #includes alphabetically ( #4579 )
2021-02-24 22:34:42 +01:00
Kitzunu
0d52b4ca4a
feat(Core/Spell): Implement ValidateSpellInfo ( #4323 )
...
* feat(Core/Spell): Implement ValidateSpellInfo
* cherry-pick from 2b5d7eef3a & a0a158b5b8
* sLog->outError
* cleanup
* convert to ValidateSpellInfo
* fix error log
* improve sLog->outError
* remove non related spells stuff from Validate
* remove the last
* build
* build x2
2021-02-01 18:57:25 +01:00
Kitzunu
da4edd547d
chore(core): remove malformed whitespaces ( #4244 )
...
* from https://www.codefactor.io/repository/github/azerothcore/azerothcore-wotlk/issues?category=Style&groupId=838&lang=5&page=75
2021-01-10 14:27:55 +01:00
Kargatum
ea93a5c1a1
feat(CI/Codestyle): added codestyle check ( #3668 )
2021-01-09 11:59:50 +01:00
Francesco Borzì
d4a58700d4
refactor(Core): apply clang-tidy modernize-use-override ( #3817 )
2020-12-06 18:04:55 +01:00
Kargatum
5e20b46812
refactor(Core/Scripts): restyle scripts lib with astyle ( #3467 )
2020-10-11 10:35:34 +02:00
Kitzunu
1f89282b22
refactor(Core): NULL -> nullptr ( #3275 )
...
* NULL to nullptr
* NULL to nullptr
* NULL to nullptr
* NULL to nullptr
* NULL to nullptr
Co-authored-by: Francesco Borzì <borzifrancesco@gmail.com >
Co-authored-by: Stefano Borzì <stefanoborzi32@gmail.com >
2020-08-31 11:55:09 +02:00
Kargatum
b6cb9247ba
Refactor(Core/Gossip): Replacing old macros with new ( #1338 )
...
* Correct support new macro
2019-03-25 21:10:57 +07:00
Nefertumm
c15206fc15
Revert "feat(core): Ensure that all actions are compared to fixed point in time ( #1236 ) ( #1458 )" ( #1471 )
...
This reverts commit 51b8773528 .
2019-02-15 15:14:49 -03:00
Viste(Кирилл)
51b8773528
feat(core): Ensure that all actions are compared to fixed point in time ( #1236 ) ( #1458 )
...
i.e. world update start
2019-02-14 19:22:17 +01:00
Yehonal
17332304fd
Using TC structure allowing easier patches importing
2017-12-21 00:20:29 +01:00
Yehonal
0f85ce1c54
Big re-organization of repository [W.I.P]
2016-08-11 20:25:27 +02:00