Commit Graph

473 Commits

Author SHA1 Message Date
Andrew
7eee1345d0 fix(Scripts/BlackTemple): Gurtogg Bloodboil shouldnt cast bloodboil o… (#19886)
fix(Scripts/BlackTemple): Gurtogg Bloodboil shouldnt cast bloodboil on phase 2 and shouldnt chase immune targets
2024-09-07 07:05:43 -03:00
天鹿
dc4c874206 fix(Scripts/BlackTemple): blade_of_azzinoth...and Possible crash (#19891)
* Update boss_illidan.cpp

* Update boss_illidan.cpp
2024-09-07 07:05:18 -03:00
Andrew
78d40e4078 fix(Scripts/BlackTemple): Remove Shear from Illidan following wrath p… (#19881)
fix(Scripts/BlackTemple): Remove Shear from Illidan following wrath patch changes
2024-09-06 20:41:36 -03:00
Gultask
fa490c21e9 fix(Scripts/BlackTemple): Rewrite Illidan Stormrage Fight (#19574)
* Create rev_1722993051676997100.sql

* akama done

* Update boss_illidan.cpp

* maiev

* sssssssssllllll

* blerg

im sick irl

* door handel

* Update boss_illidan.cpp

* minions

* Update boss_illidan.cpp

* unneeded

* Update boss_illidan.cpp

* Update boss_illidan.cpp

* meow

* Update boss_illidan.cpp

* Update boss_illidan.cpp

* Update boss_illidan.cpp

* demon_phase

missing:
tear of azzinoth
trap + frenzy
flying phase wipe + animation

* akama's ending not working still

* Update boss_illidan.cpp

* Update boss_illidan.cpp

flying animation
akama isn't returning to complete the ending

* akama ending fixed

* cleanup

* Update boss_illidan.cpp

* Update boss_illidan.cpp
2024-09-05 10:16:26 -03:00
Benjamin Jackson
1edac37ac3 refactor(Core): Make more use of helpers. (#19835)
* Init.

* Reword.

* Update codestyle script.

Co-Authored-By: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* Add gameobject type ID check, reorder checks.

* Add helper/codestyle check for unit type.

* `IsUnit()` -> `IsCreature()`

* Add `IsUnit()` method.

* Use type mask.

https: //github.com/TrinityCore/TrinityCore/commit/cc71da35b5dc74abf71f8691161525a23d870bb5
Co-Authored-By: Giacomo Pozzoni <giacomopoz@gmail.com>
Co-Authored-By: Ovahlord <18347559+Ovahlord@users.noreply.github.com>

* Replace instances of `isType` with `IsUnit`.

---------

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
Co-authored-by: Ovahlord <18347559+Ovahlord@users.noreply.github.com>
2024-09-03 14:41:31 -03:00
Andrew
0954e314a0 fix(Scripts/BlackTemple): Fix Zerevor not casting Dampen Magic OOC (#19768)
* fix(Scripts/BlackTemple): Fix Zerevor not casting Dampen Magic OOC

* Update boss_illidari_council.cpp

* recast every 1min

* implement the recast checks

* Update CreatureAI.h

* Update boss_illidari_council.cpp

* Update boss_illidari_council.cpp

* fix ooc cast

* Update boss_illidari_council.cpp

* always respect the 60s lock

* Update boss_illidari_council.cpp

* Update boss_illidari_council.cpp
2024-09-02 20:44:34 -03:00
Benjamin Jackson
2f00db3418 fix(Scripts/BlackTemple): Adjust order of damage calculations for Shared Rule. (#19849)
Init.
2024-09-02 05:34:30 -03:00
Andrew
83d623e559 fix(Scripts/BlackTemple): Fix Mother Shahraz teleport (#19820)
fix(Scripts/BlackTemple): Fix Mother Sharaz teleport

Co-authored-by: Keader <keader.android@gmail.com>
2024-08-31 17:35:17 -03:00
Benjamin Jackson
30f87a3e2f fix(Scripts/BlackTemple): Call evade for Council creature when members evade. (#19808)
Init.
2024-08-31 09:41:19 -03:00
Benjamin Jackson
9a503d4703 fix(Scripts/BlackTemple): Ensure Illidari council health is balanced across wipes. (#19809)
Init.
2024-08-31 09:40:48 -03:00
Jelle Meeus
0fb2c5efeb fix(Scripts/TheEye): Kaelthas remove enchanted weapons (#19801)
* remove weapons

Co-authored-by: killerwife <killerwife@gmail.com>

* style

for consistency

* also cast on KT JustDied

* fix TriggerCastFlags to not ignore reagent cost

* Apply suggestions from code review

---------

Co-authored-by: killerwife <killerwife@gmail.com>
2024-08-30 16:20:52 -03:00
Grimdhex
e4aab5b4f0 fix(Scripts/TempestKeep): revamp Kael'Thas (#19648)
* fix(Scripts/TempestKeep): force attackstop for all player during the last phase and cleanup the script of Kael'Thas

* few new fixes

* fix codestyle

* fix codestyle and remove misc stuff

*remove the useless DisableSpline
*remove also a misc change use only during the dev

* pass the health to DamageTaken instead UpdateIA

* avoid to iterate over the threatlist and use RemoveAllAttackers() instead

* Revert "avoid to iterate over the threatlist and use RemoveAllAttackers() instead"

This reverts commit 0623c0075191c91c2530496c83d017d3b6a824db.

* Revert "pass the health to DamageTaken instead UpdateIA"

This reverts commit 7f8609af603ecc042c819801a2f04d9d65c5031a.

* revert recents commits

* avoid potential conflicts with others enums

* fix build
2024-08-30 16:10:51 -03:00
Benjamin Jackson
2bb45fcd30 fix(Scripts/BlackTemple): Adjust handling for Shared Rule spell. (#19770) 2024-08-30 09:04:08 -03:00
Benjamin Jackson
c76f2382d9 fix(Scripts/BlackTemple): Improve Illidari Council Empyreal Balance. (#19757) 2024-08-27 15:51:47 -03:00
Andrew
126f3a31ee refactor(Scripts/BlackTemple): Update the Illidari Council script to the new registration method (#19744)
refactor(Scripts/BlackTemple): Update Illidari council to new model
2024-08-26 16:28:48 -03:00
Andrew
52cd493ad8 fix(Scripts/BlackTemple): L5 Arcane Charge should be modified by dama… (#19730)
* fix(Scripts/BlackTemple): L5 Arcane Charge should be modified by damage taken mods

* Create rev_1724540286668312700.sql

* Update spell_generic.cpp

* update to new format
2024-08-26 01:25:10 -03:00
Carriola-wotlk
4a14c61a90 fix(Scripts/BlackTemple) Gathios the Shatterer shouldnt use the same spell twice in a row (#19672)
* fix: SelectTargetMethod Random replaced with MaxThreat

* restore like origin

* fix: random spell casting replaced with alternating spells casting

* fix: alternating casting of aura, blessing and seal spells

* refactor: randomized toggle initialization refactored

---------

Co-authored-by: MattiaBallarini <ballarini.mattia1990@gmail.com>
2024-08-25 10:01:37 -03:00
Grimdhex
643362d697 refactor(Core/Object): adds consistency in the use of type object check (#19671) 2024-08-25 09:57:37 -03:00
Grimdhex
61f3a631c3 fix(Server): remove double blank lines at the end of several files (#19735) 2024-08-25 07:21:14 -03:00
Andrew
dd41692a8e fix(Scripts/SethekkHalls): Prevent multiple spawns of Anzu (#19636)
* fix(Scripts/SethekkHalls): Prevent multiple spawns of Anzu

* Update instance_sethekk_halls.cpp

* Update instance_sethekk_halls.cpp

* Update rev_1723763212128826500.sql
2024-08-22 19:27:15 +02:00
Andrew
82db30868b fix(Scripts/BlackTemple): Fatal Attraction (#19641)
* Fix it not being cast if no valid targets are available
* Apply Patch 2.2 nerfs
2024-08-19 23:17:17 -03:00
Carriola-wotlk
01c8344cc8 fix(Scripts/BlackTemple): Gathios the Shatterer shouldnt use Hammer of Justice on random players (#19653)
* fix: SelectTargetMethod Random replaced with MaxThreat

* restore like origin

* fix: cast Hammer Of Justice on current target instead random target

* refactor: case EVENT_SPELL_HAMMER_OF_JUSTICE statement refactored

* refactor: if statement splitted

* refactor: last space removed

* Update src/server/scripts/Outland/BlackTemple/illidari_council.cpp

Co-authored-by: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>

* fix redundant check and new line

---------

Co-authored-by: MattiaBallarini <ballarini.mattia1990@gmail.com>
Co-authored-by: Andrew <47818697+Nyeriah@users.noreply.github.com>
Co-authored-by: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>
2024-08-18 21:06:45 -03:00
Andrew
167e06e287 fix(Scripts/BlackTemple): Gathios Judgment spell should consume seals (#19640) 2024-08-18 05:57:32 -03:00
Gultask
41366fcc69 fix(Scripts/ShadowmoonValley): Dragonmaw Races Reset (#19570)
* Update zone_shadowmoon_valley.cpp

* Update zone_shadowmoon_valley.cpp
2024-08-07 12:43:24 -03:00
Gultask
09e77dfd1c fix(Scripts/BlackTemple): Mother Shahraz Periodic part 2 (#19561)
* init

* Update boss_mother_shahraz.cpp

* Update boss_mother_shahraz.cpp

* Update boss_mother_shahraz.cpp

* Update boss_mother_shahraz.cpp
2024-08-06 11:53:19 -03:00
Andrew
f70e69cacf fix(Scripts/BlackTemple): Mother Shahraz should not use frenzy (#19543) 2024-08-02 16:19:16 -03:00
Gultask
203087f5e7 chore(Scripts/BlackTemple): Move Gurtogg Bloodboil to TaskScheduler (#19532)
* Update boss_bloodboil.cpp

* Update boss_bloodboil.cpp
2024-07-30 18:28:25 -03:00
Gultask
97ee20a7aa fix(Scripts/BlackTemple): Reliquary of Souls move to TaskScheduler and Spirit Shock timer (#19523) 2024-07-30 17:33:10 -03:00
Gultask
fccfe51594 fix(Scripts/BlackTemple): Mother Shahraz Periodic Beams (#19525)
* init

* Update boss_mother_shahraz.cpp
2024-07-29 23:49:58 -03:00
Gultask
506f95e6e5 fix(Scripts/BlackTemple): Mother Shahraz Taunt Immunity and Enrage cancelling (#19521)
* init

* Update rev_1722290115671857500.sql
2024-07-29 19:04:59 -03:00
Tereneckla
e44e8fe109 fix (Core/Movement) Allow MoveFollow to not inherit walkstate of the target to fix Enchanted Elemental speed (#19498)
* MoveFollow with own walkstate

* switch
2024-07-29 08:30:42 -03:00
Gultask
e34ce755c8 fix(Scripts/ShadowmoonValley): Rewrite Dragonmaw Races (#19084)
* init

* fly :)

* finally

* melee attack :/

* Update zone_shadowmoon_valley.cpp

Co-Authored-By: Dan <83884799+elthehablo@users.noreply.github.com>

* Update zone_shadowmoon_valley.cpp

* Update zone_shadowmoon_valley.cpp

* Update zone_shadowmoon_valley.cpp

---------

Co-authored-by: Dan <83884799+elthehablo@users.noreply.github.com>
2024-07-27 07:32:17 -03:00
Gultask
917c34cf52 fix(Scripts/BlackTemple): Move Supremus to TaskScheduler and tweak a bit (#19418)
* Update boss_supremus.cpp

* Update boss_supremus.cpp

* Update boss_supremus.cpp

* ble

* egh

* ye

* ermps

* ok done

* Update SpellInfoCorrections.cpp

* Update SpellInfoCorrections.cpp
2024-07-26 21:48:33 -03:00
Tereneckla
f3c561032e fix (script/SSC) Enchanted Elementals follow Vashj (#19477)
* elementals follow vashj

* ) :)
2024-07-26 21:47:46 -03:00
Francesco Borzì
393d9a5987 refactor(Scripts/Outland): remove unused imports (#19461) 2024-07-21 19:15:20 -03:00
Gultask
5081b0affd fix(Scripts/BlackTemple): Vengeful Spirit, Shadow of Death Remove (#19432)
* init

* shadowremove

* Update boss_teron_gorefiend.cpp
2024-07-19 12:34:14 +02:00
Gultask
f07da20a42 fix(Scripts/BlackTemple): Ashtongue Defenders unable to attack Akama (#19435)
Update boss_shade_of_akama.cpp
2024-07-19 12:30:38 +02:00
Jelle Meeus
e8af1aaffc fix(Scripts/Spells): warlock seed of corruption (#19322)
* remove seed of corruption handling in unit.cpp

* add generic and warlock aurascript

add warlock  aurascript

add enum

add generic aurascript

add OnRemove

2ff855054f (diff-ea612aafadff90005e88b243eb000369be9e5cb6f8dc85a008d31e42b156e0ec)

detonation threshold scaling added in: df5afca278

Co-authored-by: ariel- <ariel-@users.noreply.github.com>

* add LoS check to generic damage

* refactor 2 scripts to 1 with args

refactor const_cast to GetAura()->GetEffect(

refactor reduce a line

* fix detonation threshold scaling

changed SPELL_DIRECT_DAMAGE to DOT

* remove not needed IsExpired() check

removal upon expiration is notified by AURA_REMOVE_BY_EXPIRE

* update comment

* refactor script with args to single spellscript, fix detonate by evade

* refactor

detonation to Detonate()
rename amount to remainingDamage
remove no tneeded HealthBelowPctDamaged

* refactor to 2 spell scripts again

* rename detonation spell from seed_of_corruption to seed_of_corruption_damage

avoids confusion with seed of corruption (with dot effect)

---------

Co-authored-by: ariel- <ariel-@users.noreply.github.com>
2024-07-17 01:50:38 +02:00
Gultask
8eb7b24670 fix(Scripts/Netherstorm): Rewrite Phase Hunter AI (#19401)
* Update zone_netherstorm.cpp

* Update zone_netherstorm.cpp

* db
2024-07-14 12:27:32 -03:00
avarishd
c3d98054dd fix(Core/Spells): BT - Summon Shadowfiens should spawn 11, instead of 1 (#19391)
* fix(Core/Spells): BT - Summon Shadowfiens should spawn 10, instead of 1

* Revert "fix(Core/Spells): BT - Summon Shadowfiens should spawn 10, instead of 1"

This reverts commit e5040484b6bf1bce9343b5d2fae0b24057eeaf7f.

* 39649

* spellscript

* should summon 11

* Validate
2024-07-14 12:22:24 -03:00
avarishd
f109768665 fix(Scripts/TK): KT Mindcontrol should respect Line of Sight (#19398) 2024-07-14 05:41:10 -03:00
Andrew
6b50570247 refactor(Scripts/BlackTemple): Update Mother Sharahz script (#19378)
* refactor(Scripts/BlackTemple): Update Mother Sharahz script

* Update boss_mother_shahraz.cpp
2024-07-09 18:56:13 -03:00
Gultask
02104ca89b fix(Scripts/AuchenaiCrypts): Remove double scheduling of Carnivorous Bite (#19353)
Update boss_shirrak_the_dead_watcher.cpp
2024-07-09 13:05:09 -03:00
sudlud
37e3d89f91 fix(CI): linux-build: add -Werror parameter (#19240)
* fix(CI): linux-build: add -Werror parameter

* add KI

tzunu

* Revert "feat(CI): enable fail-fast for pch/nopch (#19058)"

This reverts commit 564cbca7d3.

* Update midsummer.cpp - drop unused variable

* initialize variable

* Update core-build-nopch.yml - drop gcc12

* fix(Core/CalendarMgr): do not use element after delete, but before

* attempt to fix Socket.h error

* Revert "attempt to fix Socket.h error"

This reverts commit c1a59145ed3c49d0f76be2f81925434ea969db97.

* fix Socket.h error - attempt 2

* Update Socket.h

* Update Socket.h

* npc_shattrath_daily_quest: init variable templateID

* fix(Scripts/Karazhan): use size_t within loop in boss_shade_of_aran:Reset()

* boss_archimonde: drop unused variable

* Revert "fix(Scripts/Karazhan): use size_t within loop in boss_shade_of_aran:Reset()"

This reverts commit 1f71aaef256990c5cdc16561676be302c954ea9d.

* SmartScripts: SMART_TARGET_RANDOM_POINT: fix unintended fallthrough

* Revert "Revert "feat(CI): enable fail-fast for pch/nopch (#19058)""

This reverts commit d13df293624e0f50d9374272bfd05ab56242511d.

---------

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2024-07-07 22:00:24 +02:00
Gultask
76b6da1b3f fix(Scripts/BlackTemple): Move Teron Gorefiend to scheduler and add Berserk (#19288)
Update boss_teron_gorefiend.cpp
2024-07-05 21:16:41 -03:00
avarishd
7cf25c94ab fix(Scripts/Shattrath): Daily Dungeon quests holograms (#19233)
* fix(Scripts/Shattrath): Daily Dungeon quests holographs

* Move to single script + doaction SAI

* ocd

* use NEAR_PLAYER

* use only Wind Trader as SAI

* use creature_guid target

* rename action

* cleanup

* zzz

* Update zone_shattrath_city.cpp
2024-07-04 15:50:11 -03:00
avarishd
f84a4f1408 fix(Scripts/TK): Kael'thas mind control should reset threat (#19264)
* fix(Scripts/TK): Kael'thas mind control should reset threat

* lol

* -2 lines

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

---------

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2024-07-04 13:50:45 -03:00
Benjamin Jackson
e41080468f fix(Scripts/TheEye): Kael'thas adjustments. (#19213)
* Init.

* Update advisor phase timer.
2024-07-04 09:26:23 -03:00
Kitzunu
5a4692e45a chore(Core/Misc): #include cleanup (#19255) 2024-07-02 15:52:02 +02:00
avarishd
7ae10d8ba6 fix(DB/Area): Horvon the Armorer & Greatfather Aldrimus phasing (#19138) 2024-06-29 00:24:50 -03:00