Commit Graph

2514 Commits

Author SHA1 Message Date
Kitzunu
3fbded8f6b refactor(Core/Chat): PSendSysMessage to fmt (#19449)
* refactor(Core/Chat): PSendSysMessage to `fmt`
2024-07-23 23:48:46 +02:00
avarishd
618f97bee6 feat(Core/Unit): Enable/Disable Daze config (#19454)
* daze

* bruh

* bruhx2
2024-07-20 15:53:00 -03:00
Kitzunu
21f86d1c3c chore(Core/Misc): Remove deprecated code (#19413)
* Config - Deprecated for 3 years
* ChatCommand - Deprecated for 2 years
* getLevel() - Deprecated for 2 years
* SendGlobalText - Deprecated for 8 years +
2024-07-20 09:11:01 +03:30
Benjamin Jackson
94d3caaf1b fix(Core): Further adjust packet structure for attack stop opcode. (#19438)
* Init.

* Fixy fix.
2024-07-19 06:58:58 -03:00
Jelle Meeus
2d1e4393ba fix(Spells/SpellInfoCorrections): remove AURA_INTERRUPT_FLAG_NOT_ABOVEWATER from some mounts (#19431)
remove AURA_INTERRUPT_FLAG_NOT_ABOVEWATER for some mounts
2024-07-18 21:56:12 -03:00
Benjamin Jackson
295e4dd3c6 fix(Core): Correct packet structure for combat stop messages. (#19434)
* Init.

* Reviewed changes.
2024-07-18 21:19:36 -03:00
Kitzunu
59766e10c6 fix(Core/Spell): Allow using SpellDifficulty in bg (#19422)
* fix(Core/Spell): Allow using SpellDifficulty in bg

* cherry-pick commit (e4caf52e5a)

* "Allow get SpellDifficulty on battleground maps
This is only for Isle of Conquest (Bracket 71-79 is Regular Difficulty, Bracket 80-84 is heroic or 25Man)
Spells of IoC Battleground vehicles, cannons, bombs and bosses have SpellDifficulty in DBC"

* Remove redundant CastSpell and assign a variable instead

Co-Authored-By: Gildor <521036+Jildor@users.noreply.github.com>

* Update isle_of_conquest.cpp

---------

Co-authored-by: Gildor <521036+Jildor@users.noreply.github.com>
2024-07-18 18:12:41 +02:00
avarishd
ade4c2527f fix(Core/Spells): Restore sending SMSG_CAST_FAILED for spells in SPEL… (#19102)
* fix(Core/Spells): Restore sending SMSG_CAST_FAILED for spells in SPELL_STATE_PREPARING state (cast bar in progress) unintentionally removed

https: //github.com/TrinityCore/TrinityCore/commit/844efbfca84580f7b2bd700f40209515f2aaa959
Co-Authored-By: Shauren <shauren.trinity@gmail.com>

* ocd

* correct animation and castbar staying

---------

Co-authored-by: Shauren <shauren.trinity@gmail.com>
2024-07-17 09:14:06 -03:00
avarishd
cf7c015ea4 fix(Core/Spell): Implement SPELL_ATTR6_NO_PUSHBACK (#19292)
fix(Core/Spell): ImplementSPELL_ATTR6_NO_PUSHBACK
2024-07-17 09:09:34 -03:00
avarishd
f510e122a0 fix(Script/Quest): Protecting Our Own (#19247)
* fix(Core/Spells): Gor'drek's Ointment

* Update spell_item.cpp

* ;
2024-07-17 13:19:48 +02:00
Jelle Meeus
9f5b01ab37 fix(Core/Unit): add melee spell breaking for spells with cast time (#19376)
melee spells breaking
2024-07-17 12:49:43 +02:00
Saqra1
a950a7f44e fix(Core/Pets): Add option to revive pets with full mana (#19383)
* fix(Scripts/Spells): Revive pets with full mana in bgs

* Pets were incorrectly revived without restoring its mana

* Closes #15894

* ready for merge

---------

Co-authored-by: Saqra1 <>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2024-07-17 12:38:10 +02:00
Jelle Meeus
e8af1aaffc fix(Scripts/Spells): warlock seed of corruption (#19322)
* remove seed of corruption handling in unit.cpp

* add generic and warlock aurascript

add warlock  aurascript

add enum

add generic aurascript

add OnRemove

2ff855054f (diff-ea612aafadff90005e88b243eb000369be9e5cb6f8dc85a008d31e42b156e0ec)

detonation threshold scaling added in: df5afca278

Co-authored-by: ariel- <ariel-@users.noreply.github.com>

* add LoS check to generic damage

* refactor 2 scripts to 1 with args

refactor const_cast to GetAura()->GetEffect(

refactor reduce a line

* fix detonation threshold scaling

changed SPELL_DIRECT_DAMAGE to DOT

* remove not needed IsExpired() check

removal upon expiration is notified by AURA_REMOVE_BY_EXPIRE

* update comment

* refactor script with args to single spellscript, fix detonate by evade

* refactor

detonation to Detonate()
rename amount to remainingDamage
remove no tneeded HealthBelowPctDamaged

* refactor to 2 spell scripts again

* rename detonation spell from seed_of_corruption to seed_of_corruption_damage

avoids confusion with seed of corruption (with dot effect)

---------

Co-authored-by: ariel- <ariel-@users.noreply.github.com>
2024-07-17 01:50:38 +02:00
Kitzunu
f0e6b0f1ab chore(Core/GameObjectAI): Cleanup register macro (#19409) 2024-07-17 00:17:49 +02:00
Kitzunu
2008d64e7b fix(Scripts/Commands): Ticket response (#19406)
* fix(Scripts/Commands): Ticket response

* closes https://github.com/azerothcore/azerothcore-wotlk/issues/19390

* Implements two new commands
    * ticket response delete - Delete a ticket response
    * ticket response show - Show current ticket response

* this better

* English?

* bette rlogic

* Update cs_ticket.cpp
2024-07-16 03:22:23 +02:00
Benjamin Jackson
05f4fa1a35 fix(Core/Unit): Adjust melee attack stop logic. (#19397)
Init.
2024-07-14 12:31:40 -03:00
Jelle Meeus
a69d02e513 fix(Scripts/Spells): warlock demonic pact (#19386)
* add Demonic Pact Aura script

2ff855054f (diff-ea612aafadff90005e88b243eb000369be9e5cb6f8dc85a008d31e42b156e0ec)

Co-authored-by: ariel- <ariel-@users.noreply.github.com>

* spell_warlock aura:spell_warl_demonic_pact_aura

* fixup! spell_warlock aura:spell_warl_demonic_pact_aura

* remove not needed spell correction, flag is already set

* subtract current proc bonus before calculating new bonus

* also increase healing done

* remove Demonic Pact handling in Unit

* refactor indent, remove bonus from spell group effects e.g. totem of wrath

* Revert "refactor indent, remove bonus from spell group effects e.g. totem of wrath"

This reverts commit 104041172d34f542cc934e9f468407c36912cc7f.

* refactor indent

* manually set proc cooldown

---------

Co-authored-by: ariel- <ariel-@users.noreply.github.com>
2024-07-13 12:38:59 -03:00
Benjamin Jackson
70eb920b10 feat(Core/Unit): Implement munching as a configurable option. (#19188)
* Init.

* Correct description.

* Adjust boolean to integer in config.
2024-07-10 12:26:53 -03:00
Kitzunu
793f87fd61 fix(Core/GameObject): Use correct spell at meeting stone (#19311)
* fix(Core/GameObject): Use correct spell at meeting stone

* cleanup
2024-07-09 19:39:58 -03:00
avarishd
7d08758f1f fix(Core/Totem): Totems shouldn't be immune to intervene. (#19372)
* fix(Core/Totem): Totems shouldn't be immune to intervene

* cs is my enemy
2024-07-09 14:39:05 -03:00
Jelle Meeus
ee4d728573 fix(Core/Pets): Correct Pet size for pets 3 (#19319)
* revert

* override maxScale for some families

add more families

sort

* add turtle
2024-07-09 14:16:30 -03:00
sudlud
37e3d89f91 fix(CI): linux-build: add -Werror parameter (#19240)
* fix(CI): linux-build: add -Werror parameter

* add KI

tzunu

* Revert "feat(CI): enable fail-fast for pch/nopch (#19058)"

This reverts commit 564cbca7d3.

* Update midsummer.cpp - drop unused variable

* initialize variable

* Update core-build-nopch.yml - drop gcc12

* fix(Core/CalendarMgr): do not use element after delete, but before

* attempt to fix Socket.h error

* Revert "attempt to fix Socket.h error"

This reverts commit c1a59145ed3c49d0f76be2f81925434ea969db97.

* fix Socket.h error - attempt 2

* Update Socket.h

* Update Socket.h

* npc_shattrath_daily_quest: init variable templateID

* fix(Scripts/Karazhan): use size_t within loop in boss_shade_of_aran:Reset()

* boss_archimonde: drop unused variable

* Revert "fix(Scripts/Karazhan): use size_t within loop in boss_shade_of_aran:Reset()"

This reverts commit 1f71aaef256990c5cdc16561676be302c954ea9d.

* SmartScripts: SMART_TARGET_RANDOM_POINT: fix unintended fallthrough

* Revert "Revert "feat(CI): enable fail-fast for pch/nopch (#19058)""

This reverts commit d13df293624e0f50d9374272bfd05ab56242511d.

---------

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2024-07-07 22:00:24 +02:00
avarishd
3db58e7086 fix(Core/Spells): Greater Fireball should ignore resistances (#19326)
* fix(Core/Spells): Greater Fireball should ignore resistances

* SPELL_ATTR4_IGNORE_ALL_RESISTANCES

* Revert "SPELL_ATTR4_IGNORE_ALL_RESISTANCES"

This reverts commit 2480fac3d5b295121a79989b4257ab990fd90f5e.
2024-07-07 18:59:59 +02:00
Kitzunu
ebf5f6710a feat(Core/Chat): Provide a fully-formed protocol for addons to intera… (#19305)
* feat(Core/Chat): Provide a fully-formed protocol for addons to interact with GM commands

* Send success/fail state, allow interleaving, and indicate end of output. Add framework for supporting non-human-readable output in commands.

* cherry-pick commit (508c9d2fc1)

This PR implements a well-formed protocol for addons to communicate with the server, outlined below:

- All communication happens over the addon channel (`LANG_ADDON` in terms of the core, `CHAT_MSG_ADDON`/`SendAddonMessage` for the client). The prefix used for all messages is `AzerothCore` (in client terms - in core terms, every message starts with `AzerothCore\t`).
- In each message, the first character is the opcode. The following four characters are a unique identifier for the invocation in question, and will be echoed back by the server in every message related to that invocation. Following is the message body, if any.
- The following opcodes are supported:
    - Client to server:
        - `p` - Ping request. The core will always respond by ACKing with the passed identifier. No body.
        - `i` or `h` - Command invocation. The message body is the command text without prefix. `i` requests machine-readable output, `h` requests human-readable.
    - Server to client:
        - `a` - ACK. The first message sent in response to any invocation (before any output). No body.
        - `m` - Message. Sent once per line of output the server generates. Body = output line.
        - `o` - OK. Indicates that the command finished processing with no errors. No body.
        - `f` - Failed. Indicates that command processing is done, but there was an error. No body.

Expected overhead is minimal, and this integrates seamlessly with existing command scripts (no changes necessary).

PS: There's also a client-side addon library that exposes this protocol in a developer-friendly way over at https://github.com/azerothcore/LibAzerothCore-1.0

---------

Co-authored-by: Treeston <14020072+Treeston@users.noreply.github.com>
2024-07-06 19:13:24 +02:00
Kitzunu
3c50b1a135 fix(Core/Player): Vertical Message distance (#19302)
* cherry-pick commit (297541e9c9)

* Get rid of unused param

* Merge SendMessageToSetInRange_OwnTeam into SendMessageToSetInRange

Co-authored-by: Badgersson <83663557+dekz120@users.noreply.github.com>
2024-07-06 10:05:34 -03:00
Kitzunu
f42ed2efa5 feat(Core/SAI): SetData now has invoker (#19296)
* cherry-pick commit (cfc77fd843)

* cherry-pick commit (beb333738d)

* Move IsSmart function from headerfile

Co-authored-by: Treeston <14020072+Treeston@users.noreply.github.com>
Co-authored-by: Shauren <shauren.trinity@gmail.com>
2024-07-06 13:46:10 +02:00
Kitzunu
fc8b67bbe4 chore(Scripts/Commands): QOL server debug (#19297)
* chore(Scripts/Commands): QOL server debug

* England

* might as well do updatetime while we are at it. Consistency right?

* Hey let's sneak this ENGLAND in
2024-07-06 01:18:38 +02:00
Anton Popovichenko
04acfd96a0 fix(Core/Unit): Invalidate update object cache when changing health in the same world update tick. (#19287)
* fix(Core/Unit): Invalidate update object cache when changing health in the same world update tick.

Should fix an issue when the client sees dead NPCs when they are not.

* Fix styling

* Another codestyle fix
2024-07-05 15:42:22 -03:00
Gultask
89a6996628 fix(Scripts/SmartAI): Rewrite ACTION_MOVE_TO_POS (#19190)
* init

* Update SmartScript.cpp

* combatReach

* Update SmartScript.cpp
2024-07-05 15:07:56 -03:00
Benjamin Jackson
620c40b010 fix(Core/Handlers): Adjust start swing handler. (#19267)
* Init.

* Flesh out packet info.

https: //github.com/TrinityCore/TrinityCore/commit/af6d207addfef177fb5ac3e7fa61ec93ced83d16
Co-Authored-By: ForesterDev <11771800+ForesterDev@users.noreply.github.com>

---------

Co-authored-by: ForesterDev <11771800+ForesterDev@users.noreply.github.com>
2024-07-05 07:45:26 -03:00
Jelle Meeus
37431cd7a6 fix(Core/Pets): Correct Pet size for bigger pets 2 (#18867)
* scale displayInfo, cap scale to maxScale

* prevent scaling with displayInfo if scale is already increasing the size
2024-07-04 16:34:14 -03:00
Kitzunu
8bca8a45ed chore(Core/Spells): Fix compile warning (#19278)
* chore(Core/Spells): Fix compile warning

* s
2024-07-04 14:47:36 -03:00
Kitzunu
bd29e9e1b3 fix(Core/Spell): Implement SPELL_ATTR1_AURA_STAYS_AFTER_COMBAT (#19254)
feat(Core/Spell): Implement SPELL_ATTR1_AURA_STAYS_AFTER_COMBAT

* closes https://github.com/azerothcore/azerothcore-wotlk/issues/19248
2024-07-04 14:30:59 -03:00
Kitzunu
aebb99ecda fix(Core/Character): TeleportTo() in HandlePlayerLoginFromDB() causes… (#19237)
fix(Core/Character): TeleportTo() in HandlePlayerLoginFromDB() causes breakdown in the network communication

* closes https://github.com/azerothcore/azerothcore-wotlk/issues/16307
2024-07-04 14:30:25 -03:00
Kitzunu
385d7fd515 chore(Core/DBC): define unused unknown dbc fields (#19262)
* chore(Core/DBC): define unused unknown dbc fields

* Name unused unknown dbc fields using WDBX and wowdev.wiki

* rename SpellShapeshiftEntry to SpellShapeshiftFormEntry to properly match the DBC used

* rename sSpellShapeshiftStore to sSpellShapeshiftFormStore to properly match the DBC used

* Comment out unused field for GlyphPropertiesEntry

* Comment out unused field for MapEntry

* forgot one

* SpellShapeshiftfmt to SpellShapeshiftFormfmt

* SpellShapeshiftFormEntryfmt
2024-07-04 14:23:25 -03:00
Kitzunu
193e906a84 fix(Core/Spells): Shapeshift should show in Old Hillsbrad Foothills a… (#19274)
fix(Core/Spells): Shapeshift should show in Old Hillsbrad Foothills as horde
2024-07-04 14:21:33 -03:00
Kitzunu
8745ac9c2e fix(Core/Loot): implement automatic pass in group loot for items that… (#19272)
* fix(Core/Loot): implement automatic pass in group loot for items that cannot be looted

* cherry-pick commit (00fdf6e99a)

* closes https://github.com/chromiecraft/chromiecraft/issues/4523

Co-Authored-By: Wyrserth <43747507+Wyrserth@users.noreply.github.com>

* whoopise

---------

Co-authored-by: Wyrserth <43747507+Wyrserth@users.noreply.github.com>
2024-07-04 14:21:00 -03:00
Kitzunu
e878cedb7f feat(Core/SAI): implement new removeObjectFromWorld param for SMART_A… (#19275)
feat(Core/SAI): implement new removeObjectFromWorld param for SMART_ACTION_FORCE_DESPAWN
2024-07-04 14:20:41 -03:00
Jelle Meeus
cf1185551d fix(Core/Pet): prevent LoadPetFromDB to trigger a fake summon spell cast in most cases (#19277)
* add CategoryRecoveryTime check

* add RecoveryTime check
2024-07-04 14:20:24 -03:00
Kitzunu
d5ba5e0168 fix(Core/Quest): typo in RewardQuest makes LFG quests not reward if dead (#19271)
fix(Core/Quest): typo in RewardQuest

* Allow LFG quests to be rewarded even when dead
2024-07-04 09:41:53 -03:00
thomasjteachey
fa8680746e fix(Core/Arena): Check to see if other members in your arena team are queued or in a r… (#18808)
* Check to see if other members in your arena team are queued or in a rated arena already and, if so, do not allow queue to go through

* Accidentally put team party check inside the for loop

* some basic logic efficiency changes

* minor syntax issue
2024-07-04 08:42:36 -03:00
sudlud
60be029e4c fix(Core/Scripting): fix OnBeforeCreateInstanceScript hook (#19252)
- to me this hook should obviously provide an option to overwrite
  the InstanceScript pointer
- this is e.g. beeing used by mod-eluna (but currently broken)
2024-07-03 14:54:45 -03:00
Kitzunu
e839581649 fix(Core/Player): Allow players to enter the world (#19261) 2024-07-03 12:06:48 +02:00
Kitzunu
0a8175ef03 refactor(Core/ObjectMgr): Handle Profanity & Reserved Names in load (#19259)
* refactor(Core/ObjectMgr): Handle Profanity & Reserved Names in load

* closes https://github.com/azerothcore/azerothcore-wotlk/issues/18556

* Update ObjectMgr.cpp

* Update ObjectMgr.cpp

* I swear I am not drunk

* We already check all of these

* fix build

* Forgot we dont send the responsecode in senderrormessage

* last commit I swear
2024-07-03 00:23:32 +02:00
Kitzunu
f96d4c8670 Revert "Add (core\db): Support for Homebind Orientation (#13389)" (#19257)
* Revert "Add (core\db): Support for Homebind Orientation (#13389)"

This reverts commit 2e6f6e26da.

 Changes to be committed:
	modified:   src/server/database/Database/Implementation/CharacterDatabase.cpp
	modified:   src/server/game/DungeonFinding/LFGScripts.cpp
	modified:   src/server/game/Entities/Player/Player.cpp
	modified:   src/server/game/Entities/Player/Player.h
	modified:   src/server/game/Entities/Player/PlayerStorage.cpp
	modified:   src/server/game/Entities/Player/PlayerUpdates.cpp
	modified:   src/server/game/Handlers/CharacterHandler.cpp
	modified:   src/server/game/Handlers/MiscHandler.cpp
	modified:   src/server/game/Handlers/MovementHandler.cpp
	modified:   src/server/game/Maps/Map.cpp
	modified:   src/server/game/Spells/Spell.cpp
	modified:   src/server/scripts/Commands/cs_misc.cpp
	modified:   src/server/scripts/Commands/cs_tele.cpp
	modified:   src/server/scripts/Northrend/VaultOfArchavon/instance_vault_of_archavon.cpp

 Untracked files:
	data/sql/updates/pending_db_world/rev_1719945200692175000.sql

* Revert "Add (core\db): Support for Homebind Orientation (#13389)"

* whoops
2024-07-02 22:02:15 +02:00
Kitzunu
5a4692e45a chore(Core/Misc): #include cleanup (#19255) 2024-07-02 15:52:02 +02:00
Kitzunu
1289e351a2 fix(Script/Commands): output lookup quest and npc near (#19243)
* close https://github.com/azerothcore/azerothcore-wotlk/issues/19216
2024-07-01 07:24:54 -03:00
Jelle Meeus
ed38e6e550 fix(Scripts/Naxxramas): Gothik missing visuals at minions death (#18666)
* add sql rev

* enable NPC_TRIGGER

* add npc_gothik_trigger

* add rest of script

* spell info correction

* fix compile issue

* fix desummon call

* remove comment

* access gothik by GUID

* add missing function overrides

* add braces

* add missing trigger, adjust CGUID value

* fixup! add missing trigger, adjust CGUID value

* select skulls based on coordinates

style

invert remove

remove CGUID comment

fix remove_if check, use correct def

* JustSummoned: target same side with mapLOS

* select random initial target on the same side

* add REACT_AGGRESSIVE and increase CallForHelp radius

* refactor spellscript

* style
2024-06-29 15:12:12 -03:00
Jelle Meeus
75582eb34b fix(Core/Spell): implement taunt DR CREATURE_FLAG_EXTRA_OBEYS_TAUNT_DIMINISHING_RETURNS (#19128)
* skip other effects in case of taunt DR

* set flags_extra creature_template

fe38b78c87

Co-authored-by: offl <offl@users.noreply.github.com>

* update query to only entries found in acore_world.creature_template

* add name as comment

* fix ci codestyle

---------

Co-authored-by: offl <offl@users.noreply.github.com>
2024-06-29 11:59:16 -03:00
avarishd
63c8c6480e fix(Core/Spells): Eye of Grillok improvements (#19148)
* fix(Core/Spells): Eye of Grillok improvements

* my eyes

* discovery of RegisterSpellAndAuraScriptPair

* comment
2024-06-29 07:33:23 -03:00