Benjamin Jackson
6c97e45e87
fix(Scripts/HyjalSummit): Adjust Doomfire Spirit movement logic. ( #19469 )
...
* Init.
Co-Authored-By: Tereneckla <Tereneckla@pm.me >
* Simplify code, add comment.
* Adjust scenario in which distance fails at all ranges.
* Remove unused variable.
* Account for deviation with distance check.
Co-Authored-By: Tereneckla <Tereneckla@pm.me >
* f
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
* Rewrite with initial teleport.
* Whitespace?
* Update function type.
* Drop Doomfire spawn timer.
Verified with le sniff. Teehee.
---------
Co-authored-by: Tereneckla <Tereneckla@pm.me >
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
2024-07-25 20:50:15 -03:00
Kitzunu
7c68ba51e7
fix(Scripts/Commands): serv info ( #19478 )
2024-07-25 18:40:54 -03:00
Tereneckla
be256e7a78
fix(scripts/HyjalSummit): Make Doomfire Spirit move away from Archimonde at first ( #19467 )
...
Update boss_archimonde.cpp
2024-07-24 11:00:07 -03:00
Kitzunu
3fbded8f6b
refactor(Core/Chat): PSendSysMessage to fmt ( #19449 )
...
* refactor(Core/Chat): PSendSysMessage to `fmt`
2024-07-23 23:48:46 +02:00
Francesco Borzì
e8bd391505
refactor(Scripts/EasternKingdoms): remove unused imports ( #19457 )
2024-07-23 08:56:46 -03:00
Francesco Borzì
e592fdd248
refactor(Scripts/misc): remove unused imports ( #19458 )
2024-07-22 16:20:41 -03:00
Francesco Borzì
393d9a5987
refactor(Scripts/Outland): remove unused imports ( #19461 )
2024-07-21 19:15:20 -03:00
avarishd
618f97bee6
feat(Core/Unit): Enable/Disable Daze config ( #19454 )
...
* daze
* bruh
* bruhx2
2024-07-20 15:53:00 -03:00
Kitzunu
21f86d1c3c
chore(Core/Misc): Remove deprecated code ( #19413 )
...
* Config - Deprecated for 3 years
* ChatCommand - Deprecated for 2 years
* getLevel() - Deprecated for 2 years
* SendGlobalText - Deprecated for 8 years +
2024-07-20 09:11:01 +03:30
sudlud
4b506a8cdd
fix(Scripts/FireworkShow): set firework gameobjects active ( #19403 )
...
- improve visibility of the show
- prevent glitches in the show execution
- each gameobject only exists for a very short duration, so there
should be no relevant performance impacts
2024-07-19 17:08:46 +02:00
Kitzunu
332446b8aa
fix(Scripts/ChatLogger): Differentiate addon whisper from player whisper ( #19441 )
...
* fix(Scripts/ChatLogger): Differentiate addon whisper from player whisper
* closes https://github.com/azerothcore/azerothcore-wotlk/issues/19439
* closes https://github.com/azerothcore/azerothcore-wotlk/issues/17570
* fix build
2024-07-19 15:26:34 +02:00
Kitzunu
428fb73e79
fix(Scripts/Reload): Only send reload output to GMs ( #19443 )
2024-07-19 14:45:14 +02:00
Gultask
5081b0affd
fix(Scripts/BlackTemple): Vengeful Spirit, Shadow of Death Remove ( #19432 )
...
* init
* shadowremove
* Update boss_teron_gorefiend.cpp
2024-07-19 12:34:14 +02:00
Gultask
f07da20a42
fix(Scripts/BlackTemple): Ashtongue Defenders unable to attack Akama ( #19435 )
...
Update boss_shade_of_akama.cpp
2024-07-19 12:30:38 +02:00
Benjamin Jackson
94d3caaf1b
fix(Core): Further adjust packet structure for attack stop opcode. ( #19438 )
...
* Init.
* Fixy fix.
2024-07-19 06:58:58 -03:00
Jelle Meeus
2d1e4393ba
fix(Spells/SpellInfoCorrections): remove AURA_INTERRUPT_FLAG_NOT_ABOVEWATER from some mounts ( #19431 )
...
remove AURA_INTERRUPT_FLAG_NOT_ABOVEWATER for some mounts
2024-07-18 21:56:12 -03:00
Benjamin Jackson
295e4dd3c6
fix(Core): Correct packet structure for combat stop messages. ( #19434 )
...
* Init.
* Reviewed changes.
2024-07-18 21:19:36 -03:00
Kitzunu
486cbb3970
fix(Scripts/ChatLog): Whoopsies ( #19430 )
2024-07-18 19:31:12 -03:00
Kitzunu
ab52e1f164
chore(Scripts/ChatLog): Cleanup the code ( #19411 )
...
* chore(Scripts/ChatLog): Cleanup the code
* Update chat_log.cpp
* remove more redundant code
2024-07-18 22:46:01 +02:00
Kitzunu
59766e10c6
fix(Core/Spell): Allow using SpellDifficulty in bg ( #19422 )
...
* fix(Core/Spell): Allow using SpellDifficulty in bg
* cherry-pick commit (e4caf52e5a )
* "Allow get SpellDifficulty on battleground maps
This is only for Isle of Conquest (Bracket 71-79 is Regular Difficulty, Bracket 80-84 is heroic or 25Man)
Spells of IoC Battleground vehicles, cannons, bombs and bosses have SpellDifficulty in DBC"
* Remove redundant CastSpell and assign a variable instead
Co-Authored-By: Gildor <521036+Jildor@users.noreply.github.com >
* Update isle_of_conquest.cpp
---------
Co-authored-by: Gildor <521036+Jildor@users.noreply.github.com >
2024-07-18 18:12:41 +02:00
avarishd
ade4c2527f
fix(Core/Spells): Restore sending SMSG_CAST_FAILED for spells in SPEL… ( #19102 )
...
* fix(Core/Spells): Restore sending SMSG_CAST_FAILED for spells in SPELL_STATE_PREPARING state (cast bar in progress) unintentionally removed
https: //github.com/TrinityCore/TrinityCore/commit/844efbfca84580f7b2bd700f40209515f2aaa959
Co-Authored-By: Shauren <shauren.trinity@gmail.com >
* ocd
* correct animation and castbar staying
---------
Co-authored-by: Shauren <shauren.trinity@gmail.com >
2024-07-17 09:14:06 -03:00
avarishd
cf7c015ea4
fix(Core/Spell): Implement SPELL_ATTR6_NO_PUSHBACK ( #19292 )
...
fix(Core/Spell): ImplementSPELL_ATTR6_NO_PUSHBACK
2024-07-17 09:09:34 -03:00
avarishd
f510e122a0
fix(Script/Quest): Protecting Our Own ( #19247 )
...
* fix(Core/Spells): Gor'drek's Ointment
* Update spell_item.cpp
* ;
2024-07-17 13:19:48 +02:00
Jelle Meeus
5674c23d04
fix(Scripts/BlackwingLair): Nefarian say low health and rewrite p3 ( #19405 )
...
* Nefaran says low hp and shadowflame texts, use ScheduleHealthCheckEvent
* use drakonic bone spells
* remove no longer needed _scheduler
* remove extra file
2024-07-17 08:09:38 -03:00
Jelle Meeus
9f5b01ab37
fix(Core/Unit): add melee spell breaking for spells with cast time ( #19376 )
...
melee spells breaking
2024-07-17 12:49:43 +02:00
Saqra1
a950a7f44e
fix(Core/Pets): Add option to revive pets with full mana ( #19383 )
...
* fix(Scripts/Spells): Revive pets with full mana in bgs
* Pets were incorrectly revived without restoring its mana
* Closes #15894
* ready for merge
---------
Co-authored-by: Saqra1 <>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
2024-07-17 12:38:10 +02:00
Jelle Meeus
e8af1aaffc
fix(Scripts/Spells): warlock seed of corruption ( #19322 )
...
* remove seed of corruption handling in unit.cpp
* add generic and warlock aurascript
add warlock aurascript
add enum
add generic aurascript
add OnRemove
2ff855054f (diff-ea612aafadff90005e88b243eb000369be9e5cb6f8dc85a008d31e42b156e0ec)
detonation threshold scaling added in: df5afca278
Co-authored-by: ariel- <ariel-@users.noreply.github.com >
* add LoS check to generic damage
* refactor 2 scripts to 1 with args
refactor const_cast to GetAura()->GetEffect(
refactor reduce a line
* fix detonation threshold scaling
changed SPELL_DIRECT_DAMAGE to DOT
* remove not needed IsExpired() check
removal upon expiration is notified by AURA_REMOVE_BY_EXPIRE
* update comment
* refactor script with args to single spellscript, fix detonate by evade
* refactor
detonation to Detonate()
rename amount to remainingDamage
remove no tneeded HealthBelowPctDamaged
* refactor to 2 spell scripts again
* rename detonation spell from seed_of_corruption to seed_of_corruption_damage
avoids confusion with seed of corruption (with dot effect)
---------
Co-authored-by: ariel- <ariel-@users.noreply.github.com >
2024-07-17 01:50:38 +02:00
Jelle Meeus
9109de6500
fix(Scripts/Karazhan): Nightbane Combat Abilities ( #19321 )
...
* fix(Scripts/Karazhan): NightbaneCombatAbilities
update fear
WIP add comments
increase air phase
* remove distracting ash from ground phase
* :sort
2024-07-17 01:46:23 +02:00
avarishd
90c7658320
fix(Script/Spells): Script Glumdor's Steal Weapon ( #19258 )
...
* fix(Core/Spells): Script Glumdor's Steal Weapon
* add creature check
2024-07-17 01:44:49 +02:00
Kitzunu
275b8b5d7f
chore(Scripts/ServerMail): Cleanup the code ( #19412 )
...
* chore(Scripts/ServerMail): Cleanup the code
* try to fix build error
* okay we resort to the AIs
2024-07-17 01:33:26 +02:00
Kitzunu
f0e6b0f1ab
chore(Core/GameObjectAI): Cleanup register macro ( #19409 )
2024-07-17 00:17:49 +02:00
Kitzunu
2008d64e7b
fix(Scripts/Commands): Ticket response ( #19406 )
...
* fix(Scripts/Commands): Ticket response
* closes https://github.com/azerothcore/azerothcore-wotlk/issues/19390
* Implements two new commands
* ticket response delete - Delete a ticket response
* ticket response show - Show current ticket response
* this better
* English?
* bette rlogic
* Update cs_ticket.cpp
2024-07-16 03:22:23 +02:00
avarishd
e92a5829a0
fix(Scripts/ZG): Jin'do using wrong hex spell ( #19389 )
2024-07-14 13:24:23 -03:00
Benjamin Jackson
05f4fa1a35
fix(Core/Unit): Adjust melee attack stop logic. ( #19397 )
...
Init.
2024-07-14 12:31:40 -03:00
Gultask
8eb7b24670
fix(Scripts/Netherstorm): Rewrite Phase Hunter AI ( #19401 )
...
* Update zone_netherstorm.cpp
* Update zone_netherstorm.cpp
* db
2024-07-14 12:27:32 -03:00
sudlud
7b8e2514bf
fix(Scripts/Midsummer): correctly despawn gameobjects ( #19387 )
2024-07-14 12:24:06 -03:00
avarishd
c3d98054dd
fix(Core/Spells): BT - Summon Shadowfiens should spawn 11, instead of 1 ( #19391 )
...
* fix(Core/Spells): BT - Summon Shadowfiens should spawn 10, instead of 1
* Revert "fix(Core/Spells): BT - Summon Shadowfiens should spawn 10, instead of 1"
This reverts commit e5040484b6bf1bce9343b5d2fae0b24057eeaf7f.
* 39649
* spellscript
* should summon 11
* Validate
2024-07-14 12:22:24 -03:00
avarishd
f109768665
fix(Scripts/TK): KT Mindcontrol should respect Line of Sight ( #19398 )
2024-07-14 05:41:10 -03:00
Jelle Meeus
a69d02e513
fix(Scripts/Spells): warlock demonic pact ( #19386 )
...
* add Demonic Pact Aura script
2ff855054f (diff-ea612aafadff90005e88b243eb000369be9e5cb6f8dc85a008d31e42b156e0ec)
Co-authored-by: ariel- <ariel-@users.noreply.github.com >
* spell_warlock aura:spell_warl_demonic_pact_aura
* fixup! spell_warlock aura:spell_warl_demonic_pact_aura
* remove not needed spell correction, flag is already set
* subtract current proc bonus before calculating new bonus
* also increase healing done
* remove Demonic Pact handling in Unit
* refactor indent, remove bonus from spell group effects e.g. totem of wrath
* Revert "refactor indent, remove bonus from spell group effects e.g. totem of wrath"
This reverts commit 104041172d34f542cc934e9f468407c36912cc7f.
* refactor indent
* manually set proc cooldown
---------
Co-authored-by: ariel- <ariel-@users.noreply.github.com >
2024-07-13 12:38:59 -03:00
Benjamin Jackson
c7d086862a
fix(Scripts/HyjalSummit): Adjust Azgalor's Rain of Fire timings. ( #19393 )
...
* Init.
* Bad number.
2024-07-12 20:07:25 -03:00
Benjamin Jackson
70eb920b10
feat(Core/Unit): Implement munching as a configurable option. ( #19188 )
...
* Init.
* Correct description.
* Adjust boolean to integer in config.
2024-07-10 12:26:53 -03:00
Kitzunu
793f87fd61
fix(Core/GameObject): Use correct spell at meeting stone ( #19311 )
...
* fix(Core/GameObject): Use correct spell at meeting stone
* cleanup
2024-07-09 19:39:58 -03:00
Andrew
6b50570247
refactor(Scripts/BlackTemple): Update Mother Sharahz script ( #19378 )
...
* refactor(Scripts/BlackTemple): Update Mother Sharahz script
* Update boss_mother_shahraz.cpp
2024-07-09 18:56:13 -03:00
avarishd
7d08758f1f
fix(Core/Totem): Totems shouldn't be immune to intervene. ( #19372 )
...
* fix(Core/Totem): Totems shouldn't be immune to intervene
* cs is my enemy
2024-07-09 14:39:05 -03:00
Francesco Borzì
4040f93f85
refactor(Scripts/Commands): remove unused imports ( #19340 )
...
* refactor(Scripts/Commands): remove unused imports
* chore: fix build
* chore: revert unwanted change
2024-07-09 14:17:06 -03:00
Jelle Meeus
ee4d728573
fix(Core/Pets): Correct Pet size for pets 3 ( #19319 )
...
* revert
* override maxScale for some families
add more families
sort
* add turtle
2024-07-09 14:16:30 -03:00
Benjamin Jackson
ccf5f06128
fix(Scripts/HyjalSummit): Correct Soul Charge color assignments. ( #19345 )
...
Init.
2024-07-09 14:15:34 -03:00
Jelle Meeus
2763625498
refactor(Scripts/Northrend): spell scripts registry macros ( #19346 )
...
* zone_sholazar_basin spell:spell_q12726_song_of_wind_and_water
* zone_sholazar_basin spell:spell_q12620_the_lifewarden_wrath
* zone_sholazar_basin spell:spell_q12589_shoot_rjr
* zone_sholazar_basin spell:spell_shango_tracks
* zone_borean_tundra aura:spell_q11919_q11940_drake_hunt_aura
* zone_borean_tundra spell:spell_arcane_chains_character_force_cast
* zone_borean_tundra spell:spell_q11719_bloodspore_ruination_45997
* isle_of_conquest aura:spell_ioc_repair_turret_aura
* isle_of_conquest spell:spell_ioc_bomb_blast_criteria
* isle_of_conquest spell:spell_ioc_gunship_portal
* isle_of_conquest aura:spell_ioc_parachute_ic_aura
* isle_of_conquest spell:spell_ioc_launch
* zone_dragonblight spell:spell_q12478_frostmourne_cavern
* zone_dragonblight aura:spell_q12243_fire_upon_the_waters_aura
* zone_dragonblight spell:spell_q24545_aod_special
* zone_dragonblight spell:spell_q12096_q12092_dummy
* zone_dragonblight spell:spell_q12096_q12092_bark
* zone_storm_peaks aura:spell_q13003_thursting_hodirs_spear_aura
* zone_storm_peaks spell:spell_q13007_iron_colossus
* zone_storm_peaks aura:spell_close_rift_aura
* zone_wintergrasp spell:spell_wintergrasp_force_building
* zone_wintergrasp spell:spell_wintergrasp_create_vehicle
* zone_wintergrasp spell:spell_wintergrasp_rp_gg
* zone_wintergrasp spell:spell_wintergrasp_portal
* zone_wintergrasp spell:spell_wintergrasp_water
* zone_wintergrasp aura:spell_wintergrasp_hide_small_elementals_aura
* zone_wintergrasp spell:spell_wg_reduce_damage_by_distance
* zone_icecrown spell:spell_switch_infragreen_bomber_station
* zone_icecrown pair:spell_charge_shield_bomber
* zone_icecrown spell:spell_fight_fire_bomber
* zone_icecrown spell:spell_anti_air_rocket_bomber
* zone_icecrown spell:spell_onslaught_or_call_bone_gryphon
* zone_grizzly_hills spell:spell_shredder_delivery
* zone_grizzly_hills aura:spell_infected_worgen_bite_aura
* zone_grizzly_hills spell:spell_vehicle_warhead_fuse
* zone_grizzly_hills spell:spell_warhead_detonate
* zone_grizzly_hills aura:spell_z_check_aura
* zone_grizzly_hills aura:spell_warhead_fuse_aura
* fixup! zone_icecrown pair:spell_charge_shield_bomber
2024-07-09 13:07:41 -03:00
Gultask
02104ca89b
fix(Scripts/AuchenaiCrypts): Remove double scheduling of Carnivorous Bite ( #19353 )
...
Update boss_shirrak_the_dead_watcher.cpp
2024-07-09 13:05:09 -03:00
sudlud
37e3d89f91
fix(CI): linux-build: add -Werror parameter ( #19240 )
...
* fix(CI): linux-build: add -Werror parameter
* add KI
tzunu
* Revert "feat(CI): enable fail-fast for pch/nopch (#19058 )"
This reverts commit 564cbca7d3 .
* Update midsummer.cpp - drop unused variable
* initialize variable
* Update core-build-nopch.yml - drop gcc12
* fix(Core/CalendarMgr): do not use element after delete, but before
* attempt to fix Socket.h error
* Revert "attempt to fix Socket.h error"
This reverts commit c1a59145ed3c49d0f76be2f81925434ea969db97.
* fix Socket.h error - attempt 2
* Update Socket.h
* Update Socket.h
* npc_shattrath_daily_quest: init variable templateID
* fix(Scripts/Karazhan): use size_t within loop in boss_shade_of_aran:Reset()
* boss_archimonde: drop unused variable
* Revert "fix(Scripts/Karazhan): use size_t within loop in boss_shade_of_aran:Reset()"
This reverts commit 1f71aaef256990c5cdc16561676be302c954ea9d.
* SmartScripts: SMART_TARGET_RANDOM_POINT: fix unintended fallthrough
* Revert "Revert "feat(CI): enable fail-fast for pch/nopch (#19058 )""
This reverts commit d13df293624e0f50d9374272bfd05ab56242511d.
---------
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
2024-07-07 22:00:24 +02:00