Benjamin Jackson
3c6273a9dd
fix(Core/Unit): Only allow Judgement of Light/Wisdom to proc for targets friendly to caster. ( #20374 )
...
Init.
2024-11-03 21:39:26 -03:00
Francesco Borzì
2ce2c8cf3a
refactor(src/server/game/*): remove unused imports (big part 3) ( #20315 )
2024-10-27 13:10:28 +01:00
Francesco Borzì
cb7e28df05
refactor(src/server/game/*): remove unused imports (big part 1) ( #20310 )
2024-10-27 10:25:40 +01:00
Francesco Borzì
2c344fc127
refactor(src/server/game/*): remove unused imports (big part 2) ( #20311 )
2024-10-27 05:06:14 +01:00
Angelo Venturini
47c61b2576
fix(Core/BG): Fix double method call on removing a player ( #20156 )
2024-10-24 09:12:29 -03:00
Grimdhex
261ca4408f
refactor(Core/Unit): cleanup header file - part 3 ( #20072 )
...
* refactor: cleanup unit header file - part3
* Update Unit.h
* Update Unit.h
* fnish to reorder the header file
* Update Unit.h
2024-10-23 12:54:03 -03:00
Andrew
034ebb3cdd
Revert "fix(Core/Spells): SPELL_ATTR1_IMMUNITY_PURGES_EFFECT should not remov…" ( #20245 )
...
This reverts commit 572be7d69f .
2024-10-19 20:53:24 +02:00
Benjamin Jackson
7abbca0f5b
fix(Core/CharmInfo): Adjust how spells are given to charmed creatures. ( #20227 )
...
Init.
2024-10-18 17:42:21 -03:00
Andrew
572be7d69f
fix(Core/Spells): SPELL_ATTR1_IMMUNITY_PURGES_EFFECT should not remov… ( #20032 )
...
fix(Core/Spells): SPELL_ATTR1_IMMUNITY_PURGES_EFFECT should not remove spells with no immunities
2024-10-18 08:43:51 -03:00
Benjamin Jackson
4ad9d68f42
chore(Core): Correct typo of Suppress. ( #20229 )
...
* Init.
* Adjust spacing.
2024-10-17 22:09:53 +02:00
Anton Popovichenko
cb241a35e7
fix(Core/Items): Don't remove all owned auras on removing enchantments. ( #20220 )
2024-10-16 06:14:09 -03:00
Angelo Venturini
fede17f782
fix(Core/Spells): Fix crash ( #20179 )
...
Co-authored-by: Ariel Silva <ariel-@users.noreply.github.com >
2024-10-11 08:15:02 -03:00
Jelle Meeus
859a42a41e
fix(Core/Vehicles): feat vehicle seat addon, vehicle enter/exit positions ( #20082 )
...
* implement initial vehicle_seat_addon
Co-authored-by: Ovah <dreadkiller@gmx.de >
* add more vehicle_seat_addon data
* make exiting passenger visible
fixes "immediate despawn" of travelers mammoth
* style, update comments
* remove hacked pos relocate
* remove sending MSG_MOVE_ROOT/UNROOT on Ack
* set and unset UNIT_NPC_FLAG_PLAYER_VEHICLE on init/entry
* ulduar demolisher: remove flag correction and no longer needed usableseat
* fixup! implement initial vehicle_seat_addon
* fixup! fixup! implement initial vehicle_seat_addon
* re-add AddPassenger Flame Leviathan hack
was commented by mistake
* Update rev_1725993194571320983.sql
add missing ticks
---------
Co-authored-by: Ovah <dreadkiller@gmx.de >
2024-10-11 07:08:14 +02:00
Benjamin Jackson
fd6d2efccb
fix(Core/Unit): Add mana drain effect to Black Bow of the Betrayer. ( #20155 )
...
* Init.
Co-authored by: stfxpi (stfx)
Original CMaNGOS commit: c750533b5e
* Add/adjust comments.
2024-10-09 06:00:20 -03:00
Jelle Meeus
a8d970caa7
fix(Core/Unit): add rage gain when attack is fully blocked, dodged or parried ( #19377 )
...
* generate rage if victim fully block, dodge, parry
* update rage calculation
* calc pct at the end
* update comment to link to Rage formulae and mention Bornak's bluepost
archived link to Bornak's bluepost
https://web.archive.org/web/20090604123729/http://forums.worldofwarcraft.com/thread.html?topicId=17367760070&pageNo=13#02500
2024-10-08 21:44:32 +02:00
Benjamin Jackson
a57d8db81a
fix(Core/CharmInfo): Add exception for Kil'jaeden dragon charm spells. ( #20150 )
...
Init.
2024-10-07 08:55:00 -03:00
Jelle Meeus
01b86ec7a6
fix(Core/Unit): update death state before handling RemoveAllAurasOnDeath() ( #20124 )
...
fix setDeathState
[PATCH] Don't allow units to enter combat upon death
91ebea4a77 .patch
Co-authored-by: trickerer <onlysuffering@gmail.com >
2024-10-04 11:01:36 -03:00
Anton Popovichenko
9f58d55a1d
fix(Core/Items): Fix exploit where multiple auras could be applied from a single enchantment. ( #20128 )
2024-10-04 06:32:42 -03:00
Jelle Meeus
9a1f27121a
fix(Core/Unit): Flight Form riding crop, vehicle speed auras ( #20079 )
...
* vehicle aura stacking
Rename flight speed related auras
Co-authored-by: Laise <fenrisse@gmail.com >
* rename to better match existing flight auras
2024-10-01 21:39:42 +02:00
Francesco Borzì
784e80668d
refactor(src/server/game/Entities): remove unused imports ( #20096 )
2024-09-29 20:19:02 +02:00
Grimdhex
8bf3595cef
fix(Script/BlackTemple): teleport position with fatal attraction ( #19971 )
...
* fix(Script/BlackTemple): teleport position with fatal attraction
* fix codestyle
* try a new way by keeping a random teleport
* remove the old fixed position
* improve the dest selection
* raycast around the new position for check a valid dest
* fix codestyle
* revert the old changes
* refactor to remove the while loop
* few refactor
* Revert "few refactor"
This reverts commit fb7613d5cc5a19df01bbcf41ef5c982119ee9685.
* .
* add a los check
* new improvement with stairs cases & console errors
* fix disableWarning option
* Update boss_mother_shahraz.cpp
* Update boss_mother_shahraz.cpp
* Update boss_mother_shahraz.cpp
* Update boss_mother_shahraz.cpp
* Update boss_mother_shahraz.cpp
2024-09-28 10:27:32 +02:00
Stefano Borzì
f6de601ddd
new BattlegroundDesertionTypes for hook OnBattlegroundDesertion ( #20039 )
...
* new BattlegroundDesertionTypes for hook OnBattlegroundDesertion
* chore: minor improvements
---------
Co-authored-by: laasker <79991768+laasker@users.noreply.github.com >
2024-09-27 22:19:56 +02:00
Jelle Meeus
8a0604479a
fix(Core/Unit): fix Dual Wield for more creatures... ( #20047 )
...
* non-weapons should return true
* remove shapeshift check
2024-09-26 07:13:47 -03:00
Jelle Meeus
6e4a9bbb14
fix(Core/Unit): fix Dual Wield for more creatures, CREATURE_FLAG_EXTRA_USE_OFFHAND_ATTACK, creature disarm damage ( #20015 )
...
* enable CREATURE_FLAG_EXTRA_USE_OFFHAND_ATTACK
* sql set CREATURE_FLAG_EXTRA_USE_OFFHAND
* use new HasOffHandWeaponForAttack instead of haveOffhandWeapon
no longer requires m_CanDualwield set to use Offhand attack
requires non-disarmed weapon in Offhand OR creature_flag_extra enabled
Co-authored-by: Ovah <dreadkiller@gmx.de >
Co-authored-by: Warlockbugs <warlockbugs@outlook.com >
* Make shapeshift forms which dont override attack speed use weapon damage
Co-authored-by: killerwife <killerwife@gmail.com >
* SetEquipmentSlots turning off damage update when using template default
Co-authored-by: killerwife <killerwife@gmail.com >
* Setup DualWield & Damage On Equipment Updates, implement Set and GetVirtualItem
Co-authored-by: Yatzii <47720837+Yatzii93@users.noreply.github.com >
* creature disarm damage
set disarm to reduce minmax damage by 50% instead of setting to 0
Co-authored-by: Warlockbugs <warlockbugs@outlook.com >
---------
Co-authored-by: Ovah <dreadkiller@gmx.de >
Co-authored-by: Warlockbugs <warlockbugs@outlook.com >
Co-authored-by: killerwife <killerwife@gmail.com >
Co-authored-by: Yatzii <47720837+Yatzii93@users.noreply.github.com >
2024-09-25 16:53:39 +02:00
IntelligentQuantum
985410f184
feat(Core/Items): Delete old item id from recovery item ( #18332 )
2024-09-22 08:32:16 +02:00
Jelle Meeus
b364e00238
fix(Core/Object): do not add Object to Transport when summoned by a Vehicle ( #19920 )
2024-09-21 21:57:26 +02:00
Kitzunu
386aea03ee
chore(Core/Misc): Some cleanup ( #19970 )
...
* remove weird blanks
* update if
* ) ) to ))
* missed some ) )
* now switch
* .
2024-09-21 19:34:31 +02:00
Benjamin Jackson
a0057b9e90
fix(Core/Spells): Resolve a case of triggered spells prolonging combat. ( #19991 )
...
* Revert "fix(Core/Spells): Revert triggered spell logic change. (#19983 )"
This reverts commit 3bb5ec779d .
* Add aura effect check.
Co-Authored-By: Anton Popovichenko <walkline.ua@gmail.com >
* Add comment, use target instead of owner.
* Adjust comment terminology.
---------
Co-authored-by: Anton Popovichenko <walkline.ua@gmail.com >
2024-09-19 09:49:56 -03:00
Benjamin Jackson
3bb5ec779d
fix(Core/Spells): Revert triggered spell logic change. ( #19983 )
...
Revert "fix(Core/Spells): Resolve a case of triggered spells prolonging comba…"
This reverts commit edd7e10dfc .
2024-09-16 11:15:50 -03:00
Anton Popovichenko
92ec34753f
fix(Core/Creature): Add support for CREATURE_FLAG_EXTRA_NO_PARRY_HAST… ( #19927 )
2024-09-13 16:23:05 -03:00
Jelle Meeus
8d7463c670
fix(Core/PlayerStorage): Equip OH, 2H, Titan's Grip weapon swapping ( #19884 )
...
titan's grip, unequip with full bags
2024-09-13 16:15:25 -03:00
Benjamin Jackson
edd7e10dfc
fix(Core/Spells): Resolve a case of triggered spells prolonging combat. ( #19819 )
...
* Init.
* Expand trigger info check.
* Enclose evaluation in parentheses.
Maybe workflow will be happy?
2024-09-11 11:52:15 -03:00
Stefano Borzì
a971f373a0
fix: default bgarenas visibility distance default value ( #19938 )
...
* fix: default bgarenas visibility distance default value
* chore: update worldserver.conf.dist
2024-09-11 11:50:45 -03:00
Grimdhex
56d2cc7b4c
refactor(Cote/Unit): cleanup - part2 ( #19821 )
...
* fix(Core/AI): remove an unused variable
* Move variables at the end of each sections
* reorder several methods
* remove few inline defintions
* few codestyle fixes
2024-09-11 11:50:24 -03:00
Saqra1
c42b3ee258
fix(Core/Pet): Control Infernal without enslave ( #19784 )
...
Check SummonProperties Category(Control) too to decide the type of
controls a Guardian should have.
Don't enslave Warlock's Infernal
2024-09-11 11:18:13 -03:00
Benjamin Jackson
00e35a201e
fix(Core/AI): Reduce movement leash extension interval. ( #19923 )
...
* Init.
* Use GetGameTime() instead of system call.
Co-Authored-By: Anton Popovichenko <walkline.ua@gmail.com >
* Update leash timer if rooted.
* Remove unnecessary checks, add extension for fanning.
More parity with VMaNGOS implementation.
---------
Co-authored-by: Anton Popovichenko <walkline.ua@gmail.com >
2024-09-11 03:25:32 -03:00
Benjamin Jackson
cdc00b42bd
fix(Core/AI): Add back leash update. ( #19916 )
...
Init.
2024-09-08 20:49:28 +02:00
天鹿
e7448f2986
fix(Scripts/Commands): .gps formatting transport offset ( #19890 )
...
* Update cs_misc.cpp
* Update PlayerUpdates.cpp
2024-09-07 01:03:41 -03:00
天鹿
dd2167b00b
fix(Core/AI): Creature SetInCombatState Leashing. ( #19889 )
...
* Update Unit.cpp
* Update pit_of_saron.cpp
* Update Unit.cpp
2024-09-07 01:03:19 -03:00
Benjamin Jackson
632d7f5f9e
fix(Core/Unit): Add leash extension with damage dealt. ( #19880 )
...
Init.
2024-09-06 17:02:53 -03:00
天鹿
9dae87595d
fix(Core/Creature): Creature Scale. ( #19722 )
...
Update Creature.cpp
2024-09-05 11:56:17 -03:00
Benjamin Jackson
bf18b9bdfb
fix(Core/AI): Improve creature leashing behavior. ( #19751 )
...
* Init.
https: //github.com/vmangos/core/commit/7d2f1e2923734ea1b983eeaa0208cfd158d4af02
Co-Authored-By: ratkosrb <35845488+ratkosrb@users.noreply.github.com >
* Hackfix for pets.
* Whoops.
* Correct evade uses.
* Conflict.
* Actually fix grace timer.
* Add visibility distance check.
Creatures should always fail combat checks in the open world if they're outside of visibility distance, might not be the case for worldbosses.
---------
Co-authored-by: ratkosrb <35845488+ratkosrb@users.noreply.github.com >
2024-09-03 21:08:56 +02:00
Benjamin Jackson
1edac37ac3
refactor(Core): Make more use of helpers. ( #19835 )
...
* Init.
* Reword.
* Update codestyle script.
Co-Authored-By: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
* Add gameobject type ID check, reorder checks.
* Add helper/codestyle check for unit type.
* `IsUnit()` -> `IsCreature()`
* Add `IsUnit()` method.
* Use type mask.
https: //github.com/TrinityCore/TrinityCore/commit/cc71da35b5dc74abf71f8691161525a23d870bb5
Co-Authored-By: Giacomo Pozzoni <giacomopoz@gmail.com >
Co-Authored-By: Ovahlord <18347559+Ovahlord@users.noreply.github.com >
* Replace instances of `isType` with `IsUnit`.
---------
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com >
Co-authored-by: Ovahlord <18347559+Ovahlord@users.noreply.github.com >
2024-09-03 14:41:31 -03:00
Anton Popovichenko
9999a80c96
feat(Core/Achievements): Add possibility to complete achievements and update achievement criteria for offline players. ( #19851 )
2024-09-03 13:05:23 -03:00
Grimdhex
221dbd3fdb
chore(Apps/Codestyle): add new codestyle checks for pointers and range loops ( #19841 )
...
* chore(Apps/Codestyle): add new codestyle checks for pointers and range loops
* revert a typo
2024-09-03 13:02:38 -03:00
Kitzunu
9af86553c5
chore(Core/Misc): update floor and ceil to std ( #19837 )
2024-09-03 08:01:00 -03:00
Andrew
0954e314a0
fix(Scripts/BlackTemple): Fix Zerevor not casting Dampen Magic OOC ( #19768 )
...
* fix(Scripts/BlackTemple): Fix Zerevor not casting Dampen Magic OOC
* Update boss_illidari_council.cpp
* recast every 1min
* implement the recast checks
* Update CreatureAI.h
* Update boss_illidari_council.cpp
* Update boss_illidari_council.cpp
* fix ooc cast
* Update boss_illidari_council.cpp
* always respect the 60s lock
* Update boss_illidari_council.cpp
* Update boss_illidari_council.cpp
2024-09-02 20:44:34 -03:00
Jelle Meeus
0504c7f9de
fix(Core/GameObject): fixup allow use of Mage portal if caster is offline and still in group ( #19853 )
...
* fix portals
* fixup! fix portals
* fixup! fixup! fix portals
2024-09-02 14:00:15 -03:00
Jelle Meeus
5d4c85143c
fix(Core/GameObject): Allow use of Mage portal if caster is offline and still in group ( #19797 )
...
search group of user for ownerGUID
2024-09-01 20:56:05 -03:00
Kitzunu
5d31b9f98f
refactor(Core/Item): Add helpers ( #19828 )
2024-08-31 19:38:50 -03:00