Benjamin Jackson
3bb5ec779d
fix(Core/Spells): Revert triggered spell logic change. ( #19983 )
...
Revert "fix(Core/Spells): Resolve a case of triggered spells prolonging comba…"
This reverts commit edd7e10dfc .
2024-09-16 11:15:50 -03:00
sudlud
e2353a1c9f
fix(Core/PlayerQuest): Introduce flag QUEST_SPECIAL_FLAGS_NO_LOREMAST… ( #19962 )
...
* fix(Core/PlayerQuest): Introduce flag QUEST_SPECIAL_FLAGS_NO_LOREMASTER_COUNT
- this allows flagging quests so that they will not count towards Loremaster achievement
- update Corrupted Flower Quests in Felwood accordingly as a first use case
* load Specialflags as uint32 from DB
2024-09-15 18:15:21 -03:00
Kitzunu
1df989f780
chore(Core/Achievement): cleanup offline achievement ( #19976 )
2024-09-15 16:11:24 -03:00
Andrew
ee6e74eb3c
fix(Scripts/Commands): Fix level up achievements not being granted ( #19969 )
2024-09-15 15:55:45 -03:00
Andrew
8b16f7d243
fix(Scripts/BlackTemple): Implement emotes when opening Najentus and … ( #19946 )
...
* fix(Scripts/BlackTemple): Implement emotes when opening Najentus and Den of Mortal Delights
* only check if state is done
2024-09-15 12:48:11 +02:00
Grimdhex
4fc60bbbdf
fix(Core/Spells): Shadow demon - Allow to move while casting Paralyze ( #19948 )
...
* fix(Scripts/BlackTemple): fix stationary shadow demons
* optimization: use else if to stop the execution when a condition is reach
* revert last changes and fix the spell to allow move while casting
* .
2024-09-14 08:39:03 -03:00
Anton Popovichenko
92ec34753f
fix(Core/Creature): Add support for CREATURE_FLAG_EXTRA_NO_PARRY_HAST… ( #19927 )
2024-09-13 16:23:05 -03:00
Jelle Meeus
8d7463c670
fix(Core/PlayerStorage): Equip OH, 2H, Titan's Grip weapon swapping ( #19884 )
...
titan's grip, unequip with full bags
2024-09-13 16:15:25 -03:00
Knindza
d5263b0aee
fix(Battlegrounds/AlteracValley): Adding missing Tower Archers ( #18746 )
...
Updating Alterac
2024-09-12 21:43:34 -03:00
Grimdhex
4254827b2c
Revert "chore(Debug/Scripting): improve debug errors during the unloading scripts ( #19643 )" ( #19951 )
...
This reverts commit db7183a573 .
*wrongly use to catch sigsegv
*null check isn't necessary: https://en.cppreference.com/w/cpp/memory/new/operator_delete
2024-09-12 08:05:12 -03:00
Saqra1
321ac4a8c2
fix(Core/Spell): Summoning Portal position ( #19705 )
...
* fix(Core/Spell): Summoning Portal position
Summoning Portal is created in front of the caster but it is still too
close to them. Move it away a bit.
* Cleanup unused SpellInfo correction
Spell 61994 was stopped being used for summons in favor of 23598 on:
67010623a0
2024-09-11 12:37:56 -03:00
Saqra1
4734582e58
fix(Core/Spell): Refreshment Table position ( #19704 )
...
Refreshment Table game object should be created at the same position its
Refreshment Portal was created.
2024-09-11 11:53:07 -03:00
Benjamin Jackson
edd7e10dfc
fix(Core/Spells): Resolve a case of triggered spells prolonging combat. ( #19819 )
...
* Init.
* Expand trigger info check.
* Enclose evaluation in parentheses.
Maybe workflow will be happy?
2024-09-11 11:52:15 -03:00
Stefano Borzì
d17c179c03
chore: remove unused hooks ( #19919 )
2024-09-11 11:50:59 -03:00
Stefano Borzì
a971f373a0
fix: default bgarenas visibility distance default value ( #19938 )
...
* fix: default bgarenas visibility distance default value
* chore: update worldserver.conf.dist
2024-09-11 11:50:45 -03:00
Grimdhex
56d2cc7b4c
refactor(Cote/Unit): cleanup - part2 ( #19821 )
...
* fix(Core/AI): remove an unused variable
* Move variables at the end of each sections
* reorder several methods
* remove few inline defintions
* few codestyle fixes
2024-09-11 11:50:24 -03:00
Stefano Borzì
f6e9bd51fd
feat(ScriptMgr): add OnArenaStart hook ( #19922 )
2024-09-11 11:18:36 -03:00
Saqra1
c42b3ee258
fix(Core/Pet): Control Infernal without enslave ( #19784 )
...
Check SummonProperties Category(Control) too to decide the type of
controls a Guardian should have.
Don't enslave Warlock's Infernal
2024-09-11 11:18:13 -03:00
Benjamin Jackson
00e35a201e
fix(Core/AI): Reduce movement leash extension interval. ( #19923 )
...
* Init.
* Use GetGameTime() instead of system call.
Co-Authored-By: Anton Popovichenko <walkline.ua@gmail.com >
* Update leash timer if rooted.
* Remove unnecessary checks, add extension for fanning.
More parity with VMaNGOS implementation.
---------
Co-authored-by: Anton Popovichenko <walkline.ua@gmail.com >
2024-09-11 03:25:32 -03:00
天鹿
fafd351e44
fix(Core/AI): creature leashing behavior. ( #19897 )
...
* Update Unit.cpp
* Update TargetedMovementGenerator.cpp
* Update Unit.cpp
* Update Unit.cpp
2024-09-09 07:07:11 -03:00
Benjamin Jackson
b47b5d2c51
fix(Core/AI): Initialize movement leash timer to five seconds. ( #19898 )
...
Init.
https: //github.com/vmangos/core/commit/c8510cbbd4dccbdac9900cc507910ef3ae0e6c43
Co-authored-by: ratkosrb <35845488+ratkosrb@users.noreply.github.com >
2024-09-08 21:44:09 -03:00
Benjamin Jackson
cdc00b42bd
fix(Core/AI): Add back leash update. ( #19916 )
...
Init.
2024-09-08 20:49:28 +02:00
Stefano Borzì
0dd5c6e3b4
feat(Battlegrounds): make it compatible with custom arena type ( #18679 )
...
* feat(Battlegrounds): make it compatible with custom arena type
* fix(BattlegroundQueue.cpp): ignore bg for arena condition
* feat(Scripting): add OnQueueUpdateValidity hook
* fix: codestyle
2024-09-08 20:05:58 +02:00
天鹿
e7448f2986
fix(Scripts/Commands): .gps formatting transport offset ( #19890 )
...
* Update cs_misc.cpp
* Update PlayerUpdates.cpp
2024-09-07 01:03:41 -03:00
天鹿
dd2167b00b
fix(Core/AI): Creature SetInCombatState Leashing. ( #19889 )
...
* Update Unit.cpp
* Update pit_of_saron.cpp
* Update Unit.cpp
2024-09-07 01:03:19 -03:00
Benjamin Jackson
632d7f5f9e
fix(Core/Unit): Add leash extension with damage dealt. ( #19880 )
...
Init.
2024-09-06 17:02:53 -03:00
天鹿
9dae87595d
fix(Core/Creature): Creature Scale. ( #19722 )
...
Update Creature.cpp
2024-09-05 11:56:17 -03:00
Stefano Borzì
e5e514bbbe
feat(Core/Scripting): add OnBeforeArenaCheckWinConditions hook for mod-arena-replay compatibility ( #19856 )
2024-09-04 10:33:38 -03:00
Benjamin Jackson
bf18b9bdfb
fix(Core/AI): Improve creature leashing behavior. ( #19751 )
...
* Init.
https: //github.com/vmangos/core/commit/7d2f1e2923734ea1b983eeaa0208cfd158d4af02
Co-Authored-By: ratkosrb <35845488+ratkosrb@users.noreply.github.com >
* Hackfix for pets.
* Whoops.
* Correct evade uses.
* Conflict.
* Actually fix grace timer.
* Add visibility distance check.
Creatures should always fail combat checks in the open world if they're outside of visibility distance, might not be the case for worldbosses.
---------
Co-authored-by: ratkosrb <35845488+ratkosrb@users.noreply.github.com >
2024-09-03 21:08:56 +02:00
Benjamin Jackson
1edac37ac3
refactor(Core): Make more use of helpers. ( #19835 )
...
* Init.
* Reword.
* Update codestyle script.
Co-Authored-By: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
* Add gameobject type ID check, reorder checks.
* Add helper/codestyle check for unit type.
* `IsUnit()` -> `IsCreature()`
* Add `IsUnit()` method.
* Use type mask.
https: //github.com/TrinityCore/TrinityCore/commit/cc71da35b5dc74abf71f8691161525a23d870bb5
Co-Authored-By: Giacomo Pozzoni <giacomopoz@gmail.com >
Co-Authored-By: Ovahlord <18347559+Ovahlord@users.noreply.github.com >
* Replace instances of `isType` with `IsUnit`.
---------
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com >
Co-authored-by: Ovahlord <18347559+Ovahlord@users.noreply.github.com >
2024-09-03 14:41:31 -03:00
Benjamin Jackson
e3e4133e88
fix(Core/Handlers): Only remove emote if player is moving. ( #19740 )
...
Init.
2024-09-03 13:12:32 -03:00
Anton Popovichenko
9999a80c96
feat(Core/Achievements): Add possibility to complete achievements and update achievement criteria for offline players. ( #19851 )
2024-09-03 13:05:23 -03:00
Grimdhex
221dbd3fdb
chore(Apps/Codestyle): add new codestyle checks for pointers and range loops ( #19841 )
...
* chore(Apps/Codestyle): add new codestyle checks for pointers and range loops
* revert a typo
2024-09-03 13:02:38 -03:00
sudlud
c929b95172
fix(Conf): sync default values with core defaults ( #19708 )
...
fix(Conf): sync values with core defaults
2024-09-03 08:02:28 -03:00
Kitzunu
9af86553c5
chore(Core/Misc): update floor and ceil to std ( #19837 )
2024-09-03 08:01:00 -03:00
Kitzunu
de2bcbdabf
refactor(Core/Misc): Acore::StringFormat to fmt format ( #19838 )
...
refactor(Core/Utilities): Acore::StringFormat to fmt format
* closes https://github.com/azerothcore/azerothcore-wotlk/issues/10356
2024-09-03 07:59:37 -03:00
Andrew
0954e314a0
fix(Scripts/BlackTemple): Fix Zerevor not casting Dampen Magic OOC ( #19768 )
...
* fix(Scripts/BlackTemple): Fix Zerevor not casting Dampen Magic OOC
* Update boss_illidari_council.cpp
* recast every 1min
* implement the recast checks
* Update CreatureAI.h
* Update boss_illidari_council.cpp
* Update boss_illidari_council.cpp
* fix ooc cast
* Update boss_illidari_council.cpp
* always respect the 60s lock
* Update boss_illidari_council.cpp
* Update boss_illidari_council.cpp
2024-09-02 20:44:34 -03:00
Benjamin Jackson
0158fa3e9e
fix(Core/Handlers): Don't allow data to be sent while not grouped. ( #19852 )
...
Init.
https: //github.com/TrinityCore/TrinityCore/commit/f57647287af1f47a1c4a503cde654d6ff8f4261c
Co-authored-by: Shauren <shauren.trinity@gmail.com >
2024-09-02 15:22:01 -03:00
Jelle Meeus
0504c7f9de
fix(Core/GameObject): fixup allow use of Mage portal if caster is offline and still in group ( #19853 )
...
* fix portals
* fixup! fix portals
* fixup! fixup! fix portals
2024-09-02 14:00:15 -03:00
Jelle Meeus
e1abc72a25
fix(Core/Spell): warrior stances proccing darkmoon card vengeance damage ( #19796 )
...
add spellinfocorrection
2024-09-01 20:58:03 -03:00
Saqra1
62b825f8bd
fix(Core/Movement): Don't move for change in orientation only ( #19687 )
...
Changing only the orientation of a unit also flags it as if it were
moving, which causes spells to be interrupted.
2024-09-01 20:57:17 -03:00
Jelle Meeus
5d4c85143c
fix(Core/GameObject): Allow use of Mage portal if caster is offline and still in group ( #19797 )
...
search group of user for ownerGUID
2024-09-01 20:56:05 -03:00
Benjamin Jackson
888aa00cfb
fix(Core/Guild): Require repair rights in order to make use of guild repairs. ( #19836 )
...
* Init.
* Ensure only repair requests are screened.
* Adjust parentheses.
2024-09-01 00:48:13 -03:00
Kitzunu
5d31b9f98f
refactor(Core/Item): Add helpers ( #19828 )
2024-08-31 19:38:50 -03:00
Benjamin Jackson
f88812443d
refactor(Core): Correct typo. ( #19830 )
...
Init.
2024-08-31 17:38:03 -03:00
Walter Pagani
3b45e90e41
fix(Scripts/ICC): NPC Muradin Dialogues ( #18931 )
...
Co-authored-by: Meji <alvaro.megias@outlook.com >
Co-authored-by: 天鹿 <18535853+PkllonG@users.noreply.github.com >
2024-08-31 17:34:56 -03:00
Carriola-wotlk
9ae19e5429
fix(DB/Item): Feathermoon Headdress has the wrong stats ( #19814 )
...
* fix(DB/Item): Feathermoon Headdress has the wrong stats
* ITEM_MOD_SPELL_DAMAGE_DONE deprecated check removed
2024-08-31 12:22:18 -03:00
Grimdhex
5ab142af93
fix(Core/AI): remove an unused variable in ScriptedAI ( #19816 )
...
fix(Core/AI): remove an unused variable
2024-08-31 11:05:18 -03:00
Benjamin Jackson
8874953862
fix(Core/CharmInfo): Respect charm spell indices when adding to action bar. ( #19811 )
...
Init.
2024-08-31 10:36:57 -03:00
ianmeesters
a83cd03bfb
feat(Core/Player): add OnCalculateTalentsPoints hook ( #19749 )
...
* playerTalentsHook
* oeps :#
* :#
* does this work?
* make reference
---------
Co-authored-by: Amy Fang <amy@cavemail.ddns.net >
2024-08-30 09:06:07 -03:00