Commit Graph

5191 Commits

Author SHA1 Message Date
Jelle Meeus
7410175a08 refactor(Scripts/EasternKingdoms): spell scripts use registry macros (#20399) 2024-11-01 16:54:41 -03:00
Jelle Meeus
bbbcaac77c refactor(scripts/CrusadersColiseum): spell scripts use registry macros (#20400) 2024-11-01 16:54:14 -03:00
Jelle Meeus
7eb1b64a6f refactor(Scripts/Northrend): spell scripts use registry macros (#20401) 2024-11-01 16:11:14 -03:00
Andrew
7a2b86425f fix(Core/Spells): Fix Gurtogg Bloodboil applying Acid Wound to himself (#20394) 2024-11-01 14:09:13 -03:00
Andrew
81ba01d2c1 fix(Scripts/BlackTemple): Parasitic Shadowfiends only target players (#20395) 2024-11-01 14:08:55 -03:00
Grimdhex
0b031de2ea fix(Core/Movement): fix a small memory leak in RandomMovementGenerator (#20258)
* fix(Core/Movement): memory leak and possible crash

Co-Authored-By: Ovahlord <18347559+ovahlord@users.noreply.github.com>

* .

* fix review

---------

Co-authored-by: Ovahlord <18347559+ovahlord@users.noreply.github.com>
2024-11-01 09:39:37 -03:00
Francesco Borzì
4dcaee1816 refactor(src/common|server): remove unused import (big part 2) (#20388) 2024-11-01 08:42:31 +01:00
Francesco Borzì
c06cadfe75 refactor(src/common|server): remove unused import (big part 1) (#20377)
* refactor(src/common|server): remove unused import (big part 1)

* chore: fix build

* chore: fix build

* chore: fix build

* chore: fix build

* chore: attempt to fix damn linkin error
2024-10-31 21:46:11 +01:00
Tereneckla
07a6327c8c fix(Script/BlackTemple): Spawn Shadow Demons 30s into phase 4 (#20335)
* schedule phase 4 demons

* whitespace
2024-10-29 10:49:35 -03:00
sudlud
fb886865ad fix(Core/BattlegroundAV): Add Hallow's End decorations to Alterac Valley (#20317) 2024-10-29 08:43:37 -03:00
Yggdrasil WoW
02b190668b fix(Scripts/Icecrown Citadel): Correct pipe pathing for Vengeful Fles… (#20048)
* fix(Scripts/Icecrown Citadel): Correct pipe pathing for Vengeful Fleshreapers

* fix(Scripts/Icecrown Citadel): Correct pipe pathing for Vengeful Fleshreapers

---------
2024-10-29 05:54:39 +01:00
Francesco Borzì
2317004417 refactor(src/server/database|shared): remove unused import (#20316) 2024-10-28 10:04:42 +01:00
Francesco Borzì
2ce2c8cf3a refactor(src/server/game/*): remove unused imports (big part 3) (#20315) 2024-10-27 13:10:28 +01:00
Francesco Borzì
cb7e28df05 refactor(src/server/game/*): remove unused imports (big part 1) (#20310) 2024-10-27 10:25:40 +01:00
Francesco Borzì
2c344fc127 refactor(src/server/game/*): remove unused imports (big part 2) (#20311) 2024-10-27 05:06:14 +01:00
Dan
d9e2773519 refactor(Scripts/ZulAman): refactor Jan'alai (#20195)
* Janalai (#13)

* wip

* nullcreature

* wipppp

* first attempt at working state

* hatcherai

* test

* conditions for hatching

* some potential fixes

* some debuggo

* some small fixes

* general fixes

* Update boss_janalai.cpp

* Update boss_janalai.cpp

* Update boss_janalai.cpp

* more debug

* Update boss_janalai.cpp

* Update boss_janalai.cpp

* Update boss_janalai.cpp

* fixed?

* Update boss_janalai.cpp

* Update boss_janalai.cpp

* Update boss_janalai.cpp

* remove dumb bomb count

it is not needed

* Update boss_janalai.cpp

* Update boss_janalai.cpp

* Update boss_janalai.cpp

* other debug

* Update boss_janalai.cpp

* Update boss_janalai.cpp

* Update boss_janalai.cpp

* Update boss_janalai.cpp

* Update boss_janalai.cpp

* remove script for egg

* F

* Revert "F"

This reverts commit 246c66ccdac52e38c95c63f0ee59f1add97f4d64.

* Revert "remove script for egg"

This reverts commit b85933583fd480f941b839623c7291b6d5887246.

* different spell ids

* Update boss_janalai.cpp

* Update boss_janalai.cpp

* Update boss_janalai.cpp

* restore data sets

changing this in a different PR, but data is still being set here
2024-10-26 00:44:25 +02:00
Andrew
02db94035e fix(Scripts/BlackTemple): Prevent further code execution if Illidan e… (#20292)
fix(Scripts/BlackTemple): Prevent further code execution if Illidan evades during air phase
2024-10-25 12:55:52 +02:00
Angelo Venturini
47c61b2576 fix(Core/BG): Fix double method call on removing a player (#20156) 2024-10-24 09:12:29 -03:00
Andrew
b5a8791ae1 fix(Scripts/BlackTemple): Fix Illidan Demon Phase being delayed indef… (#20286)
fix(Scripts/BlackTemple): Fix Illidan Demon Phase being delayed indefinitely
2024-10-24 09:09:17 -03:00
Andrew
d4f9b6bf7f fix(Scripts/BlackTemple): Prevent Illidan transformation during cutscene (#20271)
* fix(Scripts/BlackTemple): Prevent Illidan transformation during cutscene

* Update boss_illidan.cpp
2024-10-24 07:24:08 -03:00
@cgrahamseven
1c1a281eda fix(Core/SAI): rooted check blocks vehicles from casting quest credit (#20283)
spell

The quest SteamTank Surprise has a SmartAI entry in the db that causes
the tank to cast the kill credit spell on the player when they
successfully destroy a plague wagon. Currently, this spell cast is being
blocked by the rooted check handler for SMART_ACTION_CAST. The change
proposes that this rooted check should not apply to vehicles.

Closes AzerothCore issue #20237

Co-authored-by: cgrahamseven <chris.graham@protonmail.com>
2024-10-24 06:57:52 -03:00
Andrew
121d35b155 fix(Scripts/BlackTemple): Apply Shadow Prison spell immunities (#20272)
* fix(Scripts/BlackTemple): Apply Shadow Prison spell immunities

* Delete rev_1729660470785757300.sql
2024-10-24 11:41:48 +02:00
Andrew
c91148fd11 fix(Scripts/BlackTemple): Reset Illidan combat movement (#20276) 2024-10-23 18:45:12 +02:00
Grimdhex
261ca4408f refactor(Core/Unit): cleanup header file - part 3 (#20072)
* refactor: cleanup unit header file - part3

* Update Unit.h

* Update Unit.h

* fnish to reorder the header file

* Update Unit.h
2024-10-23 12:54:03 -03:00
Dan Costinas
87aeaf10fd fix(Core/SmartAI) : use explicit stack DS for ProcessAction instead of recursion (#16739)
* Use dequeue instead of recursion

* Remove to do comments

* Fix formatting

* Fix more formatting :(

* Use references instead of copies in the stack to correctly update event state

* formatting

* Revert FindLinkedEvent parameter name change and check for event type

* Fix event processing in SmartScript::UpdateTimer

* Use struct for defining SmartScriptFrame instead of tuple

* Fix emplace_back not working on default constructor on clang 15

* Fix const placement
2024-10-22 17:31:45 +02:00
Benjamin Jackson
bb40bf7727 fix(Scripts/BlackTemple): Properly randomize Illidan initial Eye Beam and order. (#20264)
Init.
2024-10-21 23:00:15 -03:00
Benjamin Jackson
faab07f08a fix(Scripts/BlackTemple): Randomize Eye Beam target position. (#20262)
* Init.

* Cast enum to int.

Apparently I don't have eyes.
2024-10-21 20:38:54 -03:00
Andrew
034ebb3cdd Revert "fix(Core/Spells): SPELL_ATTR1_IMMUNITY_PURGES_EFFECT should not remov…" (#20245)
This reverts commit 572be7d69f.
2024-10-19 20:53:24 +02:00
Benjamin Jackson
7abbca0f5b fix(Core/CharmInfo): Adjust how spells are given to charmed creatures. (#20227)
Init.
2024-10-18 17:42:21 -03:00
Andrew
572be7d69f fix(Core/Spells): SPELL_ATTR1_IMMUNITY_PURGES_EFFECT should not remov… (#20032)
fix(Core/Spells): SPELL_ATTR1_IMMUNITY_PURGES_EFFECT should not remove spells with no immunities
2024-10-18 08:43:51 -03:00
Benjamin Jackson
4ad9d68f42 chore(Core): Correct typo of Suppress. (#20229)
* Init.

* Adjust spacing.
2024-10-17 22:09:53 +02:00
Anton Popovichenko
cb241a35e7 fix(Core/Items): Don't remove all owned auras on removing enchantments. (#20220) 2024-10-16 06:14:09 -03:00
Andrew
92d73c6da7 fix(Scripts/BlackTemple): Clear events on evade (so he doesnt move wh… (#20199)
fix(Scripts/BlackTemple): Clear events on evade (so he doesnt move while dead/despawned)
2024-10-13 23:53:17 -03:00
Andrew
84e70c5cd8 fix(Scripts/BlackTemple): Fix Gathios not recasting Consecration (#20200) 2024-10-13 23:53:02 -03:00
Benjamin Jackson
4bdd818db4 fix(Scripts/BlackTemple): Grant proper encounter credit for Illidari Council. (#20201)
Init.
2024-10-13 23:52:48 -03:00
Rorschach91
91a5c49943 Fix(DB/Script): Phase change for DK starter area Eye of Acherus and npcs. (#20170)
* fix(Script/Mother Shahraz) Increase min teleport range and add new teleport points.

This fix increase minimum teleport range for Fatal Attraction and It adds 5 new teleport points if the boss is near the platform.

* Update boss_mother_shahraz.cpp

* fix(DB/Creature): Phase change for DK starter area npcs.

This fix change the phases when some npcs can be viewed.

* Update dk_phases_fix

* Update dk_phases_fix

* Create DK_NPC_Phases_Fix.sql

* Delete data/sql/updates/pending_db_world/dk_phases_fix

* Update DK_NPC_Phases_Fix.sql

* Update DK_NPC_Phases_Fix.sql

* Update DK_NPC_Phases_Fix.sql

* Update DK_NPC_Phases_Fix.sql

* Update SpellInfoCorrections.cpp

Eye of Acherus in Phase 2

* Update SpellInfoCorrections.cpp

Eye of Acherus ApplySpellFix removed (Eye of Acherus is in phase 2 now).

* Update DK_NPC_Phases_Fix.sql

Adding Npcs inside Acherus in phase 2.
2024-10-13 20:53:09 +02:00
Andrew
96082065f6 refactor(Scripts/ZulAman): Move Hexlord adds to SAI (#20185) 2024-10-13 07:47:05 -03:00
ConorB
1d99440f74 fix(cpp/db): how to win friends and infleunce enemies missing dialogue (#20132)
* fix(cpp/db): Quest how to win friends and infleunce enemies missing dialogue during torture

Scarlet Crusader (id: 28940), Scarlet Marksman (id: 28610), Scarlet Preacher (id: 28939) and
Scarlet Commander (id: 28936) were missing some dialog in the database and script
npc_crusade_persuaded always succeeded when the spell on Keleseth's Persuader (item id: 39371
and spell id: 52781) procced. It now only succeeds thirty percent of the time. Increased ppmRate for spell to 8.
Finally removed aggro when scarlet was 'persuaded'

closes Azerothcore issue #20110

* fix(cpp): trailing white space

* fix(db): error in text

* fix(db): syntax error

* fix(cpp/db): using urand and removed db name from insert

* fix(db): remove broadcast text and missing creature text

* fix(DB): change sql queries to comply with rules

Added a delete query before insert and backticks to column and table names

* add empty newline at the end

---------

Co-authored-by: Stefano Borzì <stefanoborzi32@gmail.com>
2024-10-12 13:06:42 +02:00
Jelle Meeus
e0f08bbfb6 fix(Core/Spells): supress caster procs for Siphon Life heal (#20175)
supress caster procs for Siphon Life heal
2024-10-12 13:05:44 +02:00
Andrew
cfaa0a9a6c fix(Scripts/BlackTemple): Ensure root state is cleared on wipes (#20183) 2024-10-12 05:58:12 -03:00
Andrew
3b09b21f6e fix(Scripts/BlackTemple): Flames should not charge players within 25y… (#20182)
* fix(Scripts/BlackTemple): Flames should not charge players within 25y of blade

* Update boss_illidan.cpp

---------

Co-authored-by: Keader <keader.android@gmail.com>
2024-10-12 05:58:01 -03:00
Rorschach91
84646a7955 fix(Script/DeathKnight): A Special Surprise Npcs issues. (#20178) 2024-10-11 23:52:06 -03:00
Benjamin Jackson
94a03c629b fix(Scripts/BlackTemple): Remove Naj'entus Spines from players on engage. (#20176) 2024-10-11 09:29:00 -03:00
Benjamin Jackson
a9080bef60 fix(Scripts/BlackTemple): Adjust cast behavior for Supremus's charge. (#20173)
Init.
2024-10-11 09:10:04 -03:00
Angelo Venturini
fede17f782 fix(Core/Spells): Fix crash (#20179)
Co-authored-by: Ariel Silva <ariel-@users.noreply.github.com>
2024-10-11 08:15:02 -03:00
Benjamin Jackson
c3ee737c80 fix(Core/SpellInfoCorrections): Add Arcane Missiles spell info correction. (#20165)
Init.

Co-authored-by: Ernesto Gonzalez <80600689+ernesto-glz@users.noreply.github.com>
2024-10-11 11:51:29 +02:00
kissingers
0cb6081bc7 fix(Scripts/ZulAman): Nalorakk can't able to trigger instance events when death (#19895)
* ignore .vs path

* Fix Nalorakk not able to trigger instance events when death

* Revert "ignore .vs path"

This reverts commit 81e949727645d0356eb8bb9490152971dbb9b09b.

* Remove instance null check

* Remove instance null check

* Revert "Remove instance null check"

This reverts commit b97b45284edb3166bc3c253adf1773b031bb1507.
2024-10-11 08:06:28 +02:00
Jelle Meeus
859a42a41e fix(Core/Vehicles): feat vehicle seat addon, vehicle enter/exit positions (#20082)
* implement initial vehicle_seat_addon

Co-authored-by: Ovah <dreadkiller@gmx.de>

* add more vehicle_seat_addon data

* make exiting passenger visible

fixes "immediate despawn" of travelers mammoth

* style, update comments

* remove hacked pos relocate

* remove sending MSG_MOVE_ROOT/UNROOT on Ack

* set and unset UNIT_NPC_FLAG_PLAYER_VEHICLE on init/entry

* ulduar demolisher: remove flag correction and no longer needed usableseat

* fixup! implement initial vehicle_seat_addon

* fixup! fixup! implement initial vehicle_seat_addon

* re-add AddPassenger Flame Leviathan hack

was commented by mistake

* Update rev_1725993194571320983.sql

add missing ticks

---------

Co-authored-by: Ovah <dreadkiller@gmx.de>
2024-10-11 07:08:14 +02:00
Walter Pagani
e43b760c08 fix(Core/QuestHandler): Question marks not being shown (#20099) 2024-10-10 18:10:55 -03:00
Angelo Venturini
9487b30ad7 refactor(Core/Misc): Use emplace_back instead of push_back to avoid extra copy/m… (#20114)
refactor: Use emplace_back instead of push_back to avoid extra copy/move operations
2024-10-10 21:55:58 +02:00