refactor(src/common|server): remove unused import (big part 2) (#20388)

src/common/Logging/AppenderFile.h

@@ -19,7 +19,7 @@
 #define APPENDERFILE_H
 
 #include "Appender.h"
-#include <atomic>
+#include <atomic> // NOTE: this import is NEEDED (even though some IDEs report it as unused)
 #include <vector>
 
 class AppenderFile : public Appender

src/common/Metric/Metric.h

@@ -22,7 +22,7 @@
 #include "Duration.h"
 #include "MPSCQueue.h"
 #include <functional>
-#include <memory>
+#include <memory> // NOTE: this import is NEEDED (even though some IDEs report it as unused)
 #include <string>
 #include <unordered_map>
 #include <vector>

src/common/Utilities/IteratorPair.h

@@ -18,7 +18,7 @@
 #ifndef IteratorPair_h__
 #define IteratorPair_h__
 
-#include <vector>
+#include <vector> // NOTE: this import is NEEDED (even though some IDEs report it as unused)
 
 namespace Acore
 {

src/server/game/Grids/Notifiers/GridNotifiersImpl.h

@@ -19,7 +19,6 @@
 #define ACORE_GRIDNOTIFIERSIMPL_H
 
 #include "Corpse.h"
-#include "CreatureAI.h"
 #include "GridNotifiers.h"
 #include "Object.h"
 #include "Player.h"

src/server/game/Tools/PlayerDump.h

@@ -21,7 +21,6 @@
 #include "ObjectGuid.h"
 #include <map>
 #include <set>
-#include <string>
 
 enum DumpTableType
 {

src/server/game/Warden/Warden.h

@@ -21,7 +21,6 @@
 #include "ARC4.h"
 #include "AuthDefines.h"
 #include "ByteBuffer.h"
-#include "WardenCheckMgr.h"
 #include "WardenPayloadMgr.h"
 #include <array>
 

src/server/scripts/Kalimdor/TempleOfAhnQiraj/boss_ouro.cpp

@@ -16,7 +16,7 @@
  */
 
 #include "Cell.h"
-#include "CellImpl.h"
+#include "CellImpl.h" // NOTE: this import is NEEDED (even though some IDEs report it as unused)
 #include "CreatureScript.h"
 #include "GridNotifiers.h"
 #include "GridNotifiersImpl.h"

src/server/shared/Realms/Realm.cpp

@@ -18,7 +18,7 @@
 #include "Realm.h"
 #include "IpNetwork.h"
 #include <boost/asio/ip/tcp.hpp>
-#include <memory>
+#include <memory> // NOTE: this import is NEEDED (even though some IDEs report it as unused)
 
 boost::asio::ip::tcp_endpoint Realm::GetAddressForClient(boost::asio::ip::address const& clientAddr) const
 {

src/server/shared/Realms/Realm.h

@@ -20,7 +20,7 @@
 
 #include "AsioHacksFwd.h"
 #include "Common.h"
-#include <memory>
+#include <memory> // NOTE: this import is NEEDED (even though some IDEs report it as unused)
 
 enum RealmFlags
 {

src/server/shared/Realms/RealmList.h

@@ -22,7 +22,7 @@
 #include "Realm.h"
 #include <array>
 #include <map>
-#include <memory>
+#include <memory> // NOTE: this import is NEEDED (even though some IDEs report it as unused)
 #include <vector>
 
 struct RealmBuildInfo