Commit Graph

592 Commits

Author SHA1 Message Date
Andrew
1bea402e5c fix(Scripts/ZulAman): Remove Eletrical Storm hacks (#20553)
* fix(Scripts/ZulAman): Remove Eletrical Storm hacks

* Update boss_akilzon.cpp

* Create rev_1731545993422354000.sql
2024-11-13 22:58:33 -03:00
Jelle Meeus
f011a849dc fix(Scripts/ZulAman): speed up gong event (#20547) 2024-11-13 16:10:36 -03:00
Andrew
d6b2529557 refactor(Scripts/SunwellPlateau): Update Brutallus script (#20548) 2024-11-13 16:02:01 -03:00
Francesco Borzì
b2ddd10369 refactor(src/server/scripts): remove unused imports (#20540) 2024-11-13 06:35:15 +01:00
Andrew
17ae7c86ff refactor(Scripts/SunwellPlateau): Modernize instance script (#20519) 2024-11-12 12:49:11 -03:00
Andrew
e80b0ce8b8 fix(Scripts/ZulAman): Set Akilzon encounter in progress when engaged (#20531) 2024-11-12 11:50:09 -03:00
Andrew
519daf9cc7 refactor(Scripts/SunwellPlateau): Modernize Eredar Twins script (#20516) 2024-11-11 06:09:08 -03:00
Andrew
fec7c88b51 fix(Scripts/ZulAman): Amani Hatchers should hatch eggs at increasing … (#20497) 2024-11-11 05:58:44 -03:00
Andrew
0ce15f0f5a refactor(Scripts/SunwellPlateau): Refactor areatriggers to OnlyOnceAr… (#20515)
refactor(Scripts/SunwellPlateau): Refactor areatriggers to OnlyOnceAreatrigger
2024-11-11 02:56:27 -03:00
Andrew
e741a9a87f feat(Core/Scripting): Implement SetInvincibility() to prevent creatur… (#20508) 2024-11-11 00:22:03 -03:00
Andrew
7f558f4e38 refactor(Scripts/MagisterTerrace): Move Kalecgos script to SAI (#20495)
* refactor(Scripts/MagisterTerrace): Move Kalecgos script to SAI

* Update instance_magisters_terrace.cpp
2024-11-11 00:58:51 +01:00
Andrew
4470891310 fix(Scripts/MagisterTerrace): Add all spells to SpellDifficulty dbc (#20502) 2024-11-10 15:51:28 -03:00
Andrew
bf925eda3c refactor(Scripts/SWP): Update creature scripts to new register method (#20503) 2024-11-10 15:44:35 -03:00
Andrew
8e05cd7e80 refactor(Scripts/ZulAman): Move Spirit of the Lynx to SAI (#20498) 2024-11-10 14:55:04 -03:00
Andrew
4da49dd63a fix(Scripts/ZulAman): Fix crash in Nalorakk script (#20499) 2024-11-10 15:33:01 +01:00
Andrew
e2be8fb296 fix(Scripts/ZulAman): Fix Akilzon not spawning eagles and update script (#20493)
* fix(Scripts/ZulAman): Fix Akilzon not spawning eagles and update script

* Update boss_akilzon.cpp
2024-11-10 08:41:46 -03:00
Andrew
8904a13304 fix(Scripts/ZulAman): Fix Sacrifice timers not updating after latest … (#20490) 2024-11-10 08:41:26 -03:00
Andrew
7b8fadaa0c refactor(Scripts/ZulAman): Move Jan'alai Fire Bomb to SAI (#20496) 2024-11-09 20:11:56 -03:00
Andrew
82d43ee52a fix(Scripts/ZulAman): Move Harrison Jones spawn to DB (#20491)
Co-authored-by: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>
2024-11-09 19:18:14 -03:00
Andrew
138a2ca974 refactor(Scripts/ZA): Update Zul'jin (#20456) 2024-11-08 21:05:30 -03:00
IntelligentQuantum
21cb6fbf4f fix(Scripts/MagisterTerrace): Kael'thas' Arcane Spheres & Phoenix should despawn (#20481)
* Fix(Core/Scripts): Kael'thas' Arcane Spheres & Phoenix

* it's better xD
2024-11-08 11:30:55 -03:00
avarishd
cce96d05fc fix(Scripts/ZG): Poisonous Blood not being removed after Blood Siphon (#20463)
* fix(Scripts/ZG): Poisonous blood not being removed at the end of siphon

* don't use doforall

* wrong spell -.-

* AURA_STATE_IMMUNITY

* was modified in SpellInfoCorrections

* drop toplayer
2024-11-06 11:09:55 -03:00
Dan
ce70cf1c13 refactor(Scripts/ZulAman): refactor set data to instance boss states and refactor Hex Lord Malacrass (#20206)
* load boss data and initialize hexlord

* boundaries and stuff

* Update boss_janalai.cpp

* Update instance_zulaman.cpp

* F

* Update boss_hexlord.cpp

* remove old creature spells

* restore alyson script

* remove instance data sets

* revert
2024-11-05 06:45:53 -03:00
Jelle Meeus
7410175a08 refactor(Scripts/EasternKingdoms): spell scripts use registry macros (#20399) 2024-11-01 16:54:41 -03:00
Francesco Borzì
cb7e28df05 refactor(src/server/game/*): remove unused imports (big part 1) (#20310) 2024-10-27 10:25:40 +01:00
Dan
d9e2773519 refactor(Scripts/ZulAman): refactor Jan'alai (#20195)
* Janalai (#13)

* wip

* nullcreature

* wipppp

* first attempt at working state

* hatcherai

* test

* conditions for hatching

* some potential fixes

* some debuggo

* some small fixes

* general fixes

* Update boss_janalai.cpp

* Update boss_janalai.cpp

* Update boss_janalai.cpp

* more debug

* Update boss_janalai.cpp

* Update boss_janalai.cpp

* Update boss_janalai.cpp

* fixed?

* Update boss_janalai.cpp

* Update boss_janalai.cpp

* Update boss_janalai.cpp

* remove dumb bomb count

it is not needed

* Update boss_janalai.cpp

* Update boss_janalai.cpp

* Update boss_janalai.cpp

* other debug

* Update boss_janalai.cpp

* Update boss_janalai.cpp

* Update boss_janalai.cpp

* Update boss_janalai.cpp

* Update boss_janalai.cpp

* remove script for egg

* F

* Revert "F"

This reverts commit 246c66ccdac52e38c95c63f0ee59f1add97f4d64.

* Revert "remove script for egg"

This reverts commit b85933583fd480f941b839623c7291b6d5887246.

* different spell ids

* Update boss_janalai.cpp

* Update boss_janalai.cpp

* Update boss_janalai.cpp

* restore data sets

changing this in a different PR, but data is still being set here
2024-10-26 00:44:25 +02:00
Andrew
96082065f6 refactor(Scripts/ZulAman): Move Hexlord adds to SAI (#20185) 2024-10-13 07:47:05 -03:00
ConorB
1d99440f74 fix(cpp/db): how to win friends and infleunce enemies missing dialogue (#20132)
* fix(cpp/db): Quest how to win friends and infleunce enemies missing dialogue during torture

Scarlet Crusader (id: 28940), Scarlet Marksman (id: 28610), Scarlet Preacher (id: 28939) and
Scarlet Commander (id: 28936) were missing some dialog in the database and script
npc_crusade_persuaded always succeeded when the spell on Keleseth's Persuader (item id: 39371
and spell id: 52781) procced. It now only succeeds thirty percent of the time. Increased ppmRate for spell to 8.
Finally removed aggro when scarlet was 'persuaded'

closes Azerothcore issue #20110

* fix(cpp): trailing white space

* fix(db): error in text

* fix(db): syntax error

* fix(cpp/db): using urand and removed db name from insert

* fix(db): remove broadcast text and missing creature text

* fix(DB): change sql queries to comply with rules

Added a delete query before insert and backticks to column and table names

* add empty newline at the end

---------

Co-authored-by: Stefano Borzì <stefanoborzi32@gmail.com>
2024-10-12 13:06:42 +02:00
Rorschach91
84646a7955 fix(Script/DeathKnight): A Special Surprise Npcs issues. (#20178) 2024-10-11 23:52:06 -03:00
kissingers
0cb6081bc7 fix(Scripts/ZulAman): Nalorakk can't able to trigger instance events when death (#19895)
* ignore .vs path

* Fix Nalorakk not able to trigger instance events when death

* Revert "ignore .vs path"

This reverts commit 81e949727645d0356eb8bb9490152971dbb9b09b.

* Remove instance null check

* Remove instance null check

* Revert "Remove instance null check"

This reverts commit b97b45284edb3166bc3c253adf1773b031bb1507.
2024-10-11 08:06:28 +02:00
ConorB
6ef16f18bb fix(Script): Fix npc following player after starting duel (#20161)
* fix(Script): Changed npc move script

Death Knight Initiate (id: 28406) was not turning to face the player
after they engaged a duel instead the npc followed the player
wherever they went. Change was to remove script line for follow
and replace with SetFacingToObject and specify the player
as the object.

Closes AzerothCore issue #20108

* fix(script): Fix npc following player whitespace issue

Attempt to fix code styling fail on whtiespace

* fix(script): Fix npc following player another whitespace issue

Found more whitespace that was made by the fix to previous whitespace
2024-10-10 14:43:57 +02:00
Francesco Borzì
5a96ce283d refactor(Scripts): remove unused imports (#20086) 2024-09-29 13:20:21 +02:00
Kitzunu
386aea03ee chore(Core/Misc): Some cleanup (#19970)
* remove weird blanks

* update if

* ) ) to ))

* missed some ) )

* now switch

* .
2024-09-21 19:34:31 +02:00
Mershl
0ac7ab03bb fix(Scripts/UBRS): increase Drakkisath's conflagrate interval from 10s..13s to 18s..25s, avoiding near infinite CC chains (#19806)
fix(Scripts/UBRS): increase Drakkisath's conflagrate interval from 10..13s to 18s..25s, avoids infinite CC chains (conflagrate is a 10s CC)
2024-09-11 11:19:14 -03:00
kissingers
cf95c1dfbd fix(Scripts/ZulAman): Nalorakk sometimes not move when player close (#19893)
* Fix nalorakk sometimes not move when player close

* init _phase

* Revert "Fix nalorakk sometimes not move when player close"

This reverts commit b42cd4634bb4ffd225eaa7480428c6ba6b4817c6.
2024-09-07 15:39:31 +02:00
Benjamin Jackson
1edac37ac3 refactor(Core): Make more use of helpers. (#19835)
* Init.

* Reword.

* Update codestyle script.

Co-Authored-By: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* Add gameobject type ID check, reorder checks.

* Add helper/codestyle check for unit type.

* `IsUnit()` -> `IsCreature()`

* Add `IsUnit()` method.

* Use type mask.

https: //github.com/TrinityCore/TrinityCore/commit/cc71da35b5dc74abf71f8691161525a23d870bb5
Co-Authored-By: Giacomo Pozzoni <giacomopoz@gmail.com>
Co-Authored-By: Ovahlord <18347559+Ovahlord@users.noreply.github.com>

* Replace instances of `isType` with `IsUnit`.

---------

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
Co-authored-by: Ovahlord <18347559+Ovahlord@users.noreply.github.com>
2024-09-03 14:41:31 -03:00
Grimdhex
221dbd3fdb chore(Apps/Codestyle): add new codestyle checks for pointers and range loops (#19841)
* chore(Apps/Codestyle): add new codestyle checks for pointers and range loops

* revert a typo
2024-09-03 13:02:38 -03:00
Kitzunu
9af86553c5 chore(Core/Misc): update floor and ceil to std (#19837) 2024-09-03 08:01:00 -03:00
daobashun
e1692ae5b6 fix(scripts/npc_calvin_montague): Convert to SAI, Add emotes when completing quests (#18087)
* Magic uses sniffing IDs
Use the sniffer timer and factions

* Wait 3 minutes if the mission fails

* 1. When a task fails, it enters passive mode
2. Add 'quest_details' data to the database

* Remove spaces

* Delete blank lines

* Modify the code as required

* Update src/server/scripts/EasternKingdoms/zone_tirisfal_glades.cpp

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* Remove curly braces

* Change the name of a private member variable

* Move the c ++ script to smart script

* Delete the C++ script
Re-add the deleted quest_details data

* del blank lines

* Delete the C++ script file

* Modify the annotation
Return to the home pointset phase to 0
Return to the home point to allow the SAI phase reset

* Remove spaces

* Delete functions that are not in use

* Update rev_1704025138911597700.sql

* fix merge error - delete zone file

---------

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2024-08-28 21:05:40 +02:00
Grimdhex
643362d697 refactor(Core/Object): adds consistency in the use of type object check (#19671) 2024-08-25 09:57:37 -03:00
Grimdhex
61f3a631c3 fix(Server): remove double blank lines at the end of several files (#19735) 2024-08-25 07:21:14 -03:00
Francesco Borzì
2dd53e3521 refactor(Scripts): remove unused imports (#19503) 2024-07-29 14:44:52 -03:00
Francesco Borzì
e8bd391505 refactor(Scripts/EasternKingdoms): remove unused imports (#19457) 2024-07-23 08:56:46 -03:00
Jelle Meeus
5674c23d04 fix(Scripts/BlackwingLair): Nefarian say low health and rewrite p3 (#19405)
* Nefaran says low hp and shadowflame texts, use ScheduleHealthCheckEvent

* use drakonic bone spells

* remove no longer needed _scheduler

* remove extra file
2024-07-17 08:09:38 -03:00
Jelle Meeus
9109de6500 fix(Scripts/Karazhan): Nightbane Combat Abilities (#19321)
* fix(Scripts/Karazhan): NightbaneCombatAbilities

update fear

WIP add comments

increase air phase

* remove distracting ash from ground phase

* :sort
2024-07-17 01:46:23 +02:00
avarishd
e92a5829a0 fix(Scripts/ZG): Jin'do using wrong hex spell (#19389) 2024-07-14 13:24:23 -03:00
Kitzunu
f41b80ddf1 fix(Build): -Wsign-compare (#19320) 2024-07-07 20:02:31 +02:00
Kitzunu
9e6eca979b fix(Scripts/ShadeOfAran): Make immune to Mind-numbing and Cure of Tongue (#19309)
* closes https://github.com/chromiecraft/chromiecraft/issues/6900
2024-07-06 11:22:13 +02:00
Dan
b959d5cc87 refactor(Scripts/ZulAman): Nalorakk refactored (#19010)
* init

* update movement

* updates and debug

* stuck :/

scheduler doesn't seem to update when at the end of wp movement???

* fix wps and implement fight

* finalise

* unused

* Update boss_nalorakk.cpp

* keep oprientation

* ran_intro
2024-07-04 20:13:41 +02:00
Kitzunu
5a4692e45a chore(Core/Misc): #include cleanup (#19255) 2024-07-02 15:52:02 +02:00