Jelle Meeus
a7578e1cce
fix(Scripts/TheEye): Kael'thas p5 transition, flight, MotionMaster:MoveTakeoff ( #20005 )
...
Co-authored-by: killerwife <killerwife@gmail.com >
2024-09-24 08:33:21 -03:00
Kitzunu
386aea03ee
chore(Core/Misc): Some cleanup ( #19970 )
...
* remove weird blanks
* update if
* ) ) to ))
* missed some ) )
* now switch
* .
2024-09-21 19:34:31 +02:00
Grimdhex
20b443e011
refactor(Scripts/TempestKeep): remove an dev residual from Kael'Thas revamp ( #19950 )
...
refactor(Scripts/TempestKeep): remove an dev rest from my last PR with Keal'Thas
2024-09-12 07:58:18 -03:00
Benjamin Jackson
1edac37ac3
refactor(Core): Make more use of helpers. ( #19835 )
...
* Init.
* Reword.
* Update codestyle script.
Co-Authored-By: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
* Add gameobject type ID check, reorder checks.
* Add helper/codestyle check for unit type.
* `IsUnit()` -> `IsCreature()`
* Add `IsUnit()` method.
* Use type mask.
https: //github.com/TrinityCore/TrinityCore/commit/cc71da35b5dc74abf71f8691161525a23d870bb5
Co-Authored-By: Giacomo Pozzoni <giacomopoz@gmail.com >
Co-Authored-By: Ovahlord <18347559+Ovahlord@users.noreply.github.com >
* Replace instances of `isType` with `IsUnit`.
---------
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com >
Co-authored-by: Ovahlord <18347559+Ovahlord@users.noreply.github.com >
2024-09-03 14:41:31 -03:00
Jelle Meeus
0fb2c5efeb
fix(Scripts/TheEye): Kaelthas remove enchanted weapons ( #19801 )
...
* remove weapons
Co-authored-by: killerwife <killerwife@gmail.com >
* style
for consistency
* also cast on KT JustDied
* fix TriggerCastFlags to not ignore reagent cost
* Apply suggestions from code review
---------
Co-authored-by: killerwife <killerwife@gmail.com >
2024-08-30 16:20:52 -03:00
Grimdhex
e4aab5b4f0
fix(Scripts/TempestKeep): revamp Kael'Thas ( #19648 )
...
* fix(Scripts/TempestKeep): force attackstop for all player during the last phase and cleanup the script of Kael'Thas
* few new fixes
* fix codestyle
* fix codestyle and remove misc stuff
*remove the useless DisableSpline
*remove also a misc change use only during the dev
* pass the health to DamageTaken instead UpdateIA
* avoid to iterate over the threatlist and use RemoveAllAttackers() instead
* Revert "avoid to iterate over the threatlist and use RemoveAllAttackers() instead"
This reverts commit 0623c0075191c91c2530496c83d017d3b6a824db.
* Revert "pass the health to DamageTaken instead UpdateIA"
This reverts commit 7f8609af603ecc042c819801a2f04d9d65c5031a.
* revert recents commits
* avoid potential conflicts with others enums
* fix build
2024-08-30 16:10:51 -03:00
Grimdhex
643362d697
refactor(Core/Object): adds consistency in the use of type object check ( #19671 )
2024-08-25 09:57:37 -03:00
Grimdhex
61f3a631c3
fix(Server): remove double blank lines at the end of several files ( #19735 )
2024-08-25 07:21:14 -03:00
Francesco Borzì
393d9a5987
refactor(Scripts/Outland): remove unused imports ( #19461 )
2024-07-21 19:15:20 -03:00
Jelle Meeus
e8af1aaffc
fix(Scripts/Spells): warlock seed of corruption ( #19322 )
...
* remove seed of corruption handling in unit.cpp
* add generic and warlock aurascript
add warlock aurascript
add enum
add generic aurascript
add OnRemove
2ff855054f (diff-ea612aafadff90005e88b243eb000369be9e5cb6f8dc85a008d31e42b156e0ec)
detonation threshold scaling added in: df5afca278
Co-authored-by: ariel- <ariel-@users.noreply.github.com >
* add LoS check to generic damage
* refactor 2 scripts to 1 with args
refactor const_cast to GetAura()->GetEffect(
refactor reduce a line
* fix detonation threshold scaling
changed SPELL_DIRECT_DAMAGE to DOT
* remove not needed IsExpired() check
removal upon expiration is notified by AURA_REMOVE_BY_EXPIRE
* update comment
* refactor script with args to single spellscript, fix detonate by evade
* refactor
detonation to Detonate()
rename amount to remainingDamage
remove no tneeded HealthBelowPctDamaged
* refactor to 2 spell scripts again
* rename detonation spell from seed_of_corruption to seed_of_corruption_damage
avoids confusion with seed of corruption (with dot effect)
---------
Co-authored-by: ariel- <ariel-@users.noreply.github.com >
2024-07-17 01:50:38 +02:00
avarishd
f109768665
fix(Scripts/TK): KT Mindcontrol should respect Line of Sight ( #19398 )
2024-07-14 05:41:10 -03:00
avarishd
f84a4f1408
fix(Scripts/TK): Kael'thas mind control should reset threat ( #19264 )
...
* fix(Scripts/TK): Kael'thas mind control should reset threat
* lol
* -2 lines
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
---------
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
2024-07-04 13:50:45 -03:00
Benjamin Jackson
e41080468f
fix(Scripts/TheEye): Kael'thas adjustments. ( #19213 )
...
* Init.
* Update advisor phase timer.
2024-07-04 09:26:23 -03:00
Kitzunu
5a4692e45a
chore(Core/Misc): #include cleanup ( #19255 )
2024-07-02 15:52:02 +02:00
Jelle Meeus
f65283c35a
refactor(Scripts/TempestKeep): Spell Scripts use registry macros ( #19123 )
...
* init sql
* instance_the_eye aura:spell_the_eye_countercharge_aura
* instance_the_botanica aura:spell_botanica_call_of_the_falcon_aura
* instance_the_botanica aura:spell_botanica_shift_form_aura
* arcatraz aura:spell_arcatraz_soul_steal_aura
2024-06-22 05:19:43 -03:00
Balleny
31096df053
fix(Scripts/TheEye): correct first phoenix in p5 ( #18802 )
...
correct first phoenix in p5
should spawn 15 seconds before 2nd gravity lapse
2024-05-11 13:54:51 +01:00
Balleny
c4726b2d0b
fix(Scripts/TheEye): Update Alar Dive Bomb timings ( #18654 )
...
Update Alar Dive Bomb timings
2024-04-23 18:54:45 +02:00
Balleny
f380e8f625
fix(Scripts/TheEye): Update Astromancer timings and add phase ( #18655 )
...
* Update Astromancer timings
* Reworked order and timings
* Whitespace removal
* Remove more whitespace
* Update boss_astromancer.cpp
* cleanup .schedule
2024-04-22 13:22:38 +02:00
Balleny
43792db685
fix(Scripts/TheEye): Update Kaelthas Phoenix timers ( #18657 )
...
Update Kaelthas Phoenix timers
2024-04-21 21:57:24 +02:00
Balleny
723596c673
fix(Scripts/TheEye): Kaelthas: Roar timer ( #18677 )
...
Roar timer
2024-04-10 19:37:01 +02:00
Dan
d52010f2fc
fix(Scripts/TheEye): make Al'ar not get stuck during dive bomb when no enemies in melee range ( #18693 )
...
* initial
* Update boss_alar.cpp
2024-04-10 13:51:21 -03:00
Dan
dcff70c935
fix(Scripts/TheEye): increase Void Reaver boundary so he does not reset when tanked against the wall ( #18683 )
...
* Update instance_the_eye.cpp
* increase range
2024-04-07 20:29:59 -03:00
Andrew
8ef8ddad24
fix(Scripts/TheEye): Fix Alar not using abilities if no target is in … ( #18678 )
...
fix(Scripts/TheEye): Fix Alar not using abilities if no target is in range
2024-04-06 19:14:55 +02:00
Anton Popovichenko
28a64111fd
fix(Scripts/TheEye): Fix crash in Kaelthas. ( #18653 )
...
* fix(Scripts/TheEye): Fix crash in Kaelthas.
* Remove whitespace
2024-04-02 21:00:53 +02:00
Gultask
9b6e07ec2d
fix(Scripts/TheEye): Lord Sanguinar's Bellowing Roar timer ( #18651 )
...
Update boss_kaelthas.cpp
2024-04-02 12:28:07 -03:00
Dan
1e52f715d0
fix(Scripts/TheEye): fix targetting logic in Void Reaver ( #18646 )
...
* initial
this works way better
* prettier
2024-04-01 15:56:55 -03:00
Dan
a62eef0dcf
fix(DB/TheEye): make Thaladred walk ( #18629 )
...
* init
Co-Authored-By: amed80 <8395873+amed80@users.noreply.github.com >
* remove walk from script and walkspeed
---------
Co-authored-by: amed80 <8395873+amed80@users.noreply.github.com >
2024-03-30 19:18:09 -03:00
Dan
a870173558
fix(Scripts/BossAI): add optional variable to BossAI class to make sure the boss calls for help ( #18630 )
...
init
2024-03-30 11:31:41 -03:00
Dan
3ea02712d4
fix(Scripts/TheEye): make Void Reaver abilities ignore LOS ( #18613 )
...
* initial
* Update SpellInfoCorrections.cpp
* Update SpellInfoCorrections.cpp
* cast on nearby target on spellcastfail
2024-03-26 18:23:02 -03:00
Andrew
79df83ec0c
fix(Scripts/TheEye): Alar dont take 2% damage during dive bomb ( #18599 )
2024-03-21 16:27:51 -03:00
Dan
482f4c94ff
fix(Scripts/TheEye): make sure schedules are cancelled when advisors die in p1 ( #18592 )
...
init
2024-03-21 06:21:53 -03:00
Andrew
1198766afa
fix(Scripts/TheEye): Make Solarian visible on phase transition ( #18585 )
2024-03-20 17:37:42 +01:00
Andrew
f567283f2b
fix(Scripts/Mechanar): Fix Ranging Flames should choose a new target … ( #18586 )
...
fix(Scripts/Mechanar): Fix Ranging Flames should choose a new target on evade
2024-03-20 17:36:58 +01:00
Andrew
b0a7f19f34
fix(Scripts/TheEye): Fix Ember of Alar ember blast percent damage ( #18588 )
2024-03-20 17:36:13 +01:00
Dan
c71f196591
fix(Scripts/TheEye): fix MC overlap ( #18584 )
...
init
2024-03-19 23:46:13 +01:00
Dan
8faaa77319
fix(Scripts/TheEye): fix Kael progress bug and some other issues ( #18580 )
...
* init
* some fixes
2024-03-18 22:04:49 +01:00
Dan
42c41525de
fix(Scripts/TheEye): increase dagger proc chance and make sure mind control only targets players ( #18563 )
2024-03-16 17:28:40 -03:00
Dan
a21ba7afc2
fix(Scripts/TheEye): another Al'ar hotfix ( #18554 )
...
init
2024-03-15 01:05:50 -03:00
Dan
e0bc7d73dd
fix(Scripts/TheEye): make sure Al'ar doesn't schedule abilities multiple times ( #18553 )
...
* init
* fix
2024-03-14 06:12:02 -03:00
Dan
28ea5ca879
fix(Scripts/TheEye): maybe fix Al'ar transition ( #18552 )
...
initial
2024-03-13 20:53:17 +01:00
Dan
6a58e611ed
fix(Scripts/TheEye): remove auras from Solarian on invisiblity and sniffed spell ( #18544 )
...
* init
* add sniffed spell and remove auras on invisible
* prevent true beam being cast on players
2024-03-13 03:42:07 -03:00
Dan
6b5289f373
fix(Scripts/TheEye): allow Solarian to cast on pets/totems ( #18539 )
...
init
2024-03-12 06:46:12 -03:00
Dan
a7026e7e39
fix(Scripts/TheEye): make sure Al'ar doesn't cast anything during rebirt + phoenix spawning ( #18540 )
...
* init
* more
* uh
2024-03-12 06:44:55 -03:00
Andrew
3a87b5a85e
fix(Scripts/TempestKeep): Kael pyroblast target only main target ( #18531 )
2024-03-12 00:14:00 +01:00
Dan
3f700645bd
fix(Scripts/TheEye): boss boundaries and Kael door ( #18517 )
2024-03-10 09:26:00 -03:00
Dan
db7475f4f5
fix(Scripts/TheEye): ensure Ember of Al'ar always spawn in the right spot ( #18511 )
...
init
2024-03-09 11:08:23 -03:00
Dan
903820077c
fix(Scripts/TheEye): make Solarian not overlap casts and not cast arcane missiles into p2 transition ( #18480 )
...
* initial
* add voiceline
* move position of yells
* change voicings
2024-03-08 07:55:42 +01:00
Dan
9e7c443f3c
fix(Scripts/TheEye): Al'ar phoenix spawn positions in p2 ( #18504 )
...
* wip
* wip
* finalise
2024-03-06 16:51:51 -03:00
Dan
663566af4b
fix(Scripts/TheEye): make sure Solarian does not cast arcane missiles on target with Wrath of the Astromancer active ( #18496 )
...
* initial
* add target reset
* fix targetting
* revert
2024-03-04 18:04:48 -03:00
Dan
429cd226f3
fix(Scripts/TheEye): amend Al'ar divebomb timer in p2 ( #18495 )
...
initial
2024-03-04 16:54:29 -03:00