fix(Scripts/Midsummer): fix handling of unwanted npc and gameobject spawns
- properly spawn bonfire spell focus for city bonfires
- properly despawn unwanted creatures and gameobjects which are spawned
by linked traps
- all midsummer bonfire gameobjects have a linked trap "181290 Midsummer Bonfire Spawn Trap"
- the trap is linked to the spell "28784 Summon Midsummer Bonfire Bunnies" which then spawns
npc "16592 Midsummer Bonfire", npc "16606 Midsummer Bonfire Despawner" and gameobject
"181371 Midsummer Bonfire Spell Focus" i have no idea how this trap is beeing triggered,
but it's doing only harm right now
* Init.
Make use of spell for summoning Ahune's lieutenants, set up gossip/smart scripts for the cast and lieutenant summon speech, and remove permanent lieutenant spawns.
Partially cherry-picked from 91268f6631
Co-Authored-By: Xfurry <172444+xfurry@users.noreply.github.com>
* Use GUIDs for creature delete, add game_event_creature delete.
* Various adjustments.
Move comment block, add Desolace stones gossip menu options, add a delete before insert.
* Set up conditions.
* Add spell cast comments.
Sourced from Wrath Classic Wowhead.
* Add basic combat SmartAI.
* Remove comment block.
* Add creature name comments.
* Use `id1` in preparatory creature delete.
---------
Co-authored-by: Xfurry <172444+xfurry@users.noreply.github.com>
* fix(Scripts/Midsummer): Implement Ribbon Pole dance effects
* midsummer.cpp: remove whitespaces at end of lines
* midsummer.cpp: fix unused parameter error
* add spacing after 0.0f
* replace Milliseconds(...) by ...ms and Seconds(...) by ...s
* cleanup comments
* remove manual cleanups / despawns from DoCleanupChecks()
- rely on NPC despawn timers
- manual cleanup / removal actually is a bit excessive
* set INTERVAL_DANCING_FLAMES to 15s
* set despawn time to 1min for big dancing flames according to spell 46827
* set spawnDist to 12 for big dancing flames according so spell 46827
* use library function Acore::Containers::RandomShuffle() to shuffle _danclerList
* sql: do not set SmartAI for NPC 17066
already using ScriptName and can't have both
* combine 3 sql files into 1
* remove INTERVAL_... enum values
* remove unnecessary checks of if(_bunny)
* sql: fix smartscript comment
* rename spell define to correct spell name
* refactor(Scripts/Midsummer): Assign enum values to gameobjects and spells
* rename GO_TORCH_TOSS_TARGET_BUNNY to NPC_TORCH_TOSS_TARGET_BUNNY
* add more enum values to enum flingTorch
* fix(Scripts/Midsummer): Make beam target Ribbon Pole top
progress #12145
* refactor(Scripts/Midsummer): shorten spell_midsummer_ribbon_pole_visual::UpdateTarget
- spell 45644 used to be linked to spell_midsummer_juggling_torch
- spell 45644 was later linked to new implementation
spell_midsummer_torch_catch in e1e4c6cddc
- old implementation of spell 45644 was never removed from
spell_midsummer_juggling_torch
* NULL to nullptr
* NULL to nullptr
* NULL to nullptr
* NULL to nullptr
* NULL to nullptr
Co-authored-by: Francesco Borzì <borzifrancesco@gmail.com>
Co-authored-by: Stefano Borzì <stefanoborzi32@gmail.com>
