Commit Graph

225 Commits

Author SHA1 Message Date
Anton Popovichenko
f4658a1df2 fix(Core/Scripts): Fix scripts where LoadObjectData can leave arrays boundaries. (#17070)
* fix(Core/Scripts): Fix scripts where LoadObjectData can leave arrays boundaries.

* Fix build
2023-08-25 09:15:07 -03:00
Tung Bui (Leo)
da8ebbae0b fix(Scripts/UBRS): typo in Blackrock Spire instance (#16976)
* fix(spells/scripts): typo in Blackrock Spire instance

* fix(spells/scripts): typo in Blackrock Spire instance - usage
2023-08-10 23:13:45 -03:00
KJack
a696227e8d fix(Scripts/UBRS): Update UBRS/Pyroguard Emberseer script to fix issues and increase accuracy (#16352)
* Update UBRS/Pyroguard Emberseer script to fix issues and increase accuracy.

- Remove EVENT_PLAYER_CHECK which was causing triggering the fight to work only sporadically
- Break out pre-enter-combat phase to better emulate actual timing. Fixes DBM timing being off
- Pre-enter-combat sequence starts as soon as the adds are engaged, not after 32 seconds
- disable fire shield during pre-enter-combat to keep the fight from resetting
- remove faster add despawn which doesn't appear to be in the WotLK Classic version
- remove adds doing EVENT_ENCAGE every 10-20s, which was unneccesary and caused them to glitch move around the player

* Small change to pre-add timing.
2023-06-01 08:40:02 -03:00
天鹿
df77b5f4f7 chore(core): cleanup code p3 (#16073)
* Update MMapMgr.cpp

* Update UpdateFetcher.cpp

* Update AuctionHouseMgr.cpp

* Update AuctionHouseMgr.h

* Update BattlegroundAV.cpp

* Update ChannelMgr.cpp

* Update ThreatMgr.h

* Update Player.h

* Update PlayerSettings.cpp

* Update ObjectMgr.cpp

* Update Guild.cpp

* Update Guild.h

* Update Map.cpp

* Update World.cpp

* Update boss_nefarian.cpp

* Update boss_prince_malchezaar.cpp

* Update boss_venoxis.cpp

* Update zone_elwynn_forest.cpp

* Update zulfarrak.cpp

* Update boss_novos.cpp
2023-04-24 08:13:07 -03:00
ZhengPeiRu21
817cb2d685 fix(Scripts/MoltenCore): Correct Baron Geddon Inferno damage values (#15637)
* fix(Scripts/Molten Core): Correct Baron Geddon Inferno damage values

* Update tick counts
2023-04-02 15:35:47 -03:00
Stefano Borzì
034b521501 feat(CI): add cppcheck (#15211)
Co-authored-by: Skjalf <47818697+Nyeriah@users.noreply.github.com>
2023-03-05 18:47:18 +01:00
Kitzunu
bd6034e1a9 refactor(Core/AI): Some more refactoring prep for Comat Threat system… (#15026)
Co-authored-by: Treeston <14020072+Treeston@users.noreply.github.com>
2023-02-13 21:39:40 +01:00
Tereneckla
fdfa88093e fix(Scripts/MoltenCore): revert ragnaros submerge event to 180s (#15001) 2023-02-13 14:32:42 -03:00
Skjalf
0dbb8c814c refactor(Core/InstanceScript): refactored load and save methods (#14977)
Co-authored-by: joschiwald <736792+joschiwald@users.noreply.github.com>
2023-02-12 15:53:48 -03:00
Kitzunu
f039836a2f chore(Core/Misc): Change all TODO to doxygen comment (#14966) 2023-02-12 10:05:34 -03:00
Skjalf
3106a83e8a fix(Scripts/BlackwingLair): Fix Flamegor frenzy timer (#14908) 2023-02-08 17:05:09 +01:00
Angelo Venturini
5029e1240d fix: Crash on Flamegor (#14906) 2023-02-08 16:57:35 +01:00
Maelthyr
afb071bb04 refactor(Scripts): Update vanilla scripts to std::chrono (#14876)
Co-authored-by: Maelthyrr <AmanThul-Project@proton.me>
Co-authored-by: Skjalf <47818697+Nyeriah@users.noreply.github.com>
2023-02-05 12:35:48 -03:00
Skjalf
bf30c66ba4 feat(Core/GameObject): Expand IsSummonedBy() to GameObjects (#14789)
Co-authored-by: jackpoz <giacomopoz@gmail.com>
2023-01-29 09:44:33 -03:00
Skjalf
b4e3f1310b feat(Core/Unit): Add KillSelf overload (#14785)
Co-authored-by: jackpoz <giacomopoz@gmail.com>
2023-01-28 17:57:23 -03:00
Kitzunu
4870b14b1f refactor(Core/Object): getLevel() -> GetLevel() (#14122)
* refactor(Core/Object): getLevel() -> GetLevel()

* fix build and sneak some doxygen in

* codeSTLE

* codestyle
2022-12-31 17:39:23 +01:00
UltraNix
08ff2f277b fix(Scripts/BlackwingLair): Razorgore the Untamed should not reset enco… (#13782)
* fix(Raids/BlackwingLair): Razorgore the Untamed should not reset encounter upon casting Conflagrate when soloing.

Fixes #13761

* Update.
2022-12-06 09:47:08 -03:00
Maelthyr
3024bee3ba refactor(Core/UnitAI): Update target selector (#13169)
* refactor(Core/UnitAI): Update TargetSelector.

Cherry-pick:
*https://github.com/TrinityCore/TrinityCore/pull/19930

Co-authored-by: Treeston <treeston@users.noreply.github.com>

* fix GGC/CLang errors in scripts

* .

* missing a file and fix a script error

* .

* fix path changes dude to a miss click in the second commit

* .

Co-authored-by: Maelthyrr <lynethris@protonmail.ch>
Co-authored-by: Treeston <treeston@users.noreply.github.com>
2022-12-06 09:27:13 -03:00
Maelthyr
c1c9dc6105 refactor(Core/ScriptedAI): few improvements with threat methods (#13146)
improve threat scripts

Co-authored-by: Maelthyrr <lynethris@protonmail.ch>
2022-11-12 13:29:28 +01:00
UltraNix
751bc4ffe1 fix(Scripts/MoltenCore): Lava Spawn. (#13508)
Fixes #13107
2022-10-29 07:14:38 -03:00
UltraNix
49ee806584 fix(Scripts/MoltenCore): Added loot recipient to Cache of the Firelord. (#13209) 2022-10-08 13:28:30 -03:00
UltraNix
6c3fc2603b fix(Scripts/MoltenCore): Players should not be able to summon Ragnaro… (#13128)
fix(Scripts/MoltenCore): Players should not be able to summon Ragnaros before Majordomo's teleport.

Fixes #11870
2022-09-26 09:41:20 -04:00
Maelthyr
1f472bddd3 refactor(Core/Combat): Code style and improvement of ThreatMgr (#12992) 2022-09-25 15:20:34 -03:00
UltraNix
dd4fa3893e fix(Scripts/MoltenCore): Boss' runes should not respawn after 5 min o… (#13127)
fix(Scripts/MoltenCore): Boss' runes should not respawn after 5 min of boss death.

Fixes #10039
2022-09-25 10:41:37 -03:00
SoglaHash
c79edad21f fix(Scripts/UpperBlackrockSpire): Missing Seal of Ascension event (#12891)
* fix(Scripts/UpperBlackrockSpire): Missing Seal of Ascension event

Using seal of ascension during the arena event  does not start event

Seal of ascension does not give chromatic protection buffs

Closes https://github.com/azerothcore/azerothcore-wotlk/issues/9069

* fixup! fix(Scripts/UpperBlackrockSpire): Missing Seal of Ascension event
2022-09-21 13:23:34 -04:00
SoglaHash
0f84e3ed34 fix(Scripts/BlackrockSpire): Scarshield Infiltrator (#12920) 2022-09-18 23:59:59 -03:00
SoglaHash
b2e449fd15 fix(Scripts/BlackwingLair): Chromaggus lever should stay open (#12758)
fix(Scripts/BWL): Chromaggus lever should stay open

Chromaggus lever door closes after reset, should stay open

Closes https://github.com/azerothcore/azerothcore-wotlk/issues/12743
2022-08-16 16:02:24 -03:00
Skjalf
a8c4a16a00 chore(Scripts/BlackwingLair): Another temporary solution to Chromaggu… (#12664)
chore(Scripts/BlackwingLair): Another temporary solution to Chromaggus being pulled through the floor
2022-08-12 15:23:07 -03:00
SoglaHash
d627e19649 fix(Core/BlackwingLair): add missing Nefarian Gate (#12608) 2022-08-07 14:52:01 -03:00
Eddy Vega
e075d87c0e fix(scripts/Ragnaros): Move root handling from DB to Core (#12245) 2022-06-30 18:12:26 -03:00
Skjalf
46789d5df6 fix(Scripts/BlackwingLair): Correct Bone Constructs abilities (#12180) 2022-06-26 04:45:15 -03:00
Skjalf
38889324b2 fix(Scripts/BlackwingLair): Nefarian class calls should not repeat (#12148) 2022-06-23 09:49:08 -03:00
Maelthyr
d928d8d96a refactor(Core/Unit): PC&NPC Immunity (#11986)
* initial

* refactor(Core/Unit): PC & NPC Immunities

Cherry-pick TC: 74af880217

Co-authored-by: Treeston <treeston.nmoc@gmail.com>

* fix builds error

Cherry-pick TC: 74af880217

Co-authored-by: Treeston <treeston.nmoc@gmail.com>

* Fix nef combat, and replace SetFlag by SetUnitFlag

* fix combat with jedoga

Co-authored-by: Treeston <treeston.nmoc@gmail.com>
2022-06-18 08:16:45 -04:00
temperrr
d3b381c238 fix(Scripts/BRD): Emperor should not yell when dead. (#12046)
Co-authored-by: Skjalf <47818697+Nyeriah@users.noreply.github.com>
2022-06-13 09:01:50 -03:00
UltraNix
5b719bab05 fix(Core): Crashfix. (#11898)
Fixes #11861
2022-05-30 06:36:58 -03:00
Maelthyr
dfc6adb081 refactor(Core/Combat): DeleteThreatLists() become ClearAllThreat() (#11824)
refactor(Chore/Combat): DeleteThreatLists() become ClearAllThreat()
2022-05-23 05:51:52 -03:00
Maelthyr
c5368816fa Core/Combat: rename getThreatMgr() to GetThreatMgr() (#11758) 2022-05-18 05:36:57 -03:00
Maelthyr
5ede1177c5 refactor(Core/Combat): implement compatiblity layer for ResetAllThreat() (#11778)
* implement ResetAllThreat()

* .
2022-05-17 12:01:25 -03:00
UltraNix
203450e949 fix(Scripts/BlackwingLair): Warrior Class Call should not restore to default stance on removal. (#11671) 2022-05-10 22:54:11 -03:00
Skjalf
12a0c6f1bc fix(Scripts/BlackwingLair): Prevent Chromaggus from hostilizing playe… (#11595)
* fix(Scripts/BlackwingLair): Prevent Chromaggus from hostilizing players in the floor underneath

* Update src/server/scripts/EasternKingdoms/BlackrockMountain/BlackwingLair/boss_chromaggus.cpp

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* Update src/server/scripts/EasternKingdoms/BlackrockMountain/BlackwingLair/boss_chromaggus.cpp

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2022-05-03 07:18:45 -03:00
Skjalf
3c851c059a fix(Scripts/BlackwingLair): Prevent Chromaggus cage from looking (#11603) 2022-05-03 07:10:09 -03:00
UltraNix
4e977d9ada fix(Scripts/BWL): Razorgore's Orb of Domination should not be usable during 2nd phase of the encounter. (#11580) 2022-05-02 21:01:00 -03:00
UltraNix
ef6c97e96e fix(Scripts/BlackiwingLair): Rogues should be teleported in front of Nefarian during Class Call event. (#11513) 2022-04-24 14:58:39 -03:00
Skjalf
88555b6564 refactor(Scripts/BlackwingLair): Refactor Chromaggus (#11501)
* refactor(Scripts/BlackwingLair): Refactor Chromaggus

* Update boss_chromaggus.cpp

* eof

* Update boss_chromaggus.cpp
2022-04-24 09:25:57 -03:00
Skjalf
c695d9b4bd fix(Scripts/BlackwingLair): Three drake bosses should be optional (#11506) 2022-04-24 02:48:35 -03:00
Skjalf
53bfc548a6 fix(Scripts/BlackwingLair): Bone Constructs should persist after Nefarian's death (#11504) 2022-04-24 02:05:27 -03:00
temperrr
343732ee0b fix(Script/BWL): Fix initial shadowflame timers (#11443) 2022-04-20 09:10:31 -03:00
temperrr
33a70dbebc fix(Scripts/BlackwingLair): Chromaggus shimmer timer adjustment, fre… (#11437)
* Fix (Scripts/BlackwingLair): Chromaggus shimmer timer adjustment, frenzy and enrage changed

* codestyle

* urand
2022-04-19 06:32:45 -03:00
Skjalf
f9a76d99d4 fix(Scripts/BlackwingLair): Prevent Nefarian's adds corpse from decaying (#11424) 2022-04-17 11:50:53 -03:00
Skjalf
ca95a986ba fix(Scripts/BlackwingLair): Improve Nefarian's add animations (#11414) 2022-04-16 10:36:04 -03:00