- improve visibility of the show
- prevent glitches in the show execution
- each gameobject only exists for a very short duration, so there
should be no relevant performance impacts
fix(Scripts/Midsummer): fix handling of unwanted npc and gameobject spawns
- properly spawn bonfire spell focus for city bonfires
- properly despawn unwanted creatures and gameobjects which are spawned
by linked traps
- all midsummer bonfire gameobjects have a linked trap "181290 Midsummer Bonfire Spawn Trap"
- the trap is linked to the spell "28784 Summon Midsummer Bonfire Bunnies" which then spawns
npc "16592 Midsummer Bonfire", npc "16606 Midsummer Bonfire Despawner" and gameobject
"181371 Midsummer Bonfire Spell Focus" i have no idea how this trap is beeing triggered,
but it's doing only harm right now
* init sql file for fireworks spectacular - add entry in game_event
* add missing delete statement
* add gameobjects 180698 'Party Table, 180699 'Festive Keg, 180700 'Hay Bale 1'
* update comment, add gameobject 180754 Toasting Goblet
- todo: pooling (?) - the tables are quite full
- todo: why are there tables missing? e.g. below:
.go ga 82615
* add gameobject 180905 'Festive Mug'
* add gameobjects 'Firework, Show, Type%'
* add vendors
* add revelers and bruisers
TODO: also add 15906 'Ironforge Reveler'
* remove '%Firework Show%' spawns
- these will be spawned temporarily via script
* add firework gameobject SmartAI
* WIP stormwind fireworks show
steps to test the show:
.go xyz -8984 498 96 0
.gob add temp 180749
* improve handling of fireworks show, add gameobject 180749 'Cheer Speaker' spawns
how to test:
.go ga 64640
.event start 72
* prepare fetching correct show based on map+zone
* introduce typedef for FireworkShow
* Add Teldrassil show
.go ga 64651
.event start 72
* fix Teldrassil and Stormwind shows, add initShow() debug message, replace magic numbers for fireworkShow sizes
- these were broken due to an error in my txt parsing script
* add Shattrath show
.go c 139914
.event start 72
* add Silvermoon show
.go ga 64670
.event start 72
* add Booty Bay show
.go ga 64630
.event start 72
* add Thunder Bluff show, add Exodar show, set firework gameobjects active, update comments, remove _maxCount
* add Underciy show
.go ga 64641
.event start 72
* fix Undercity show indexes
* move code from midsummer.cpp to new file firework_show.cpp
* add Orgrimmar show
.go ga 64647
.event start 72
* add Ironforge show
.go ga 64634
.event start 72
* update shows from sniff parses using fixed export script
* update 'Party Table, 'Festive Keg' and 'Hay Bale 1' spawns with additional sniffs
* update 'Toasting Goblet' spawns with additional sniffs
* update 'Festive Mug' spawns with additional sniffs
* update 'Fireworks Revelers' spawns with additional sniffs
* remove duplicate AND from sql file
* attempt moving FireworkShows to the heap
* start firework show at the full hour and also handle late starts correctly
- also perform a minor cleanup
* do not touch gameobject with guid 16586 which is linked to harvest festival
* move firework_show.cpp to subfolder firework_show
* move firework_show arrays to seperate header files
* update show handling, still not final
* update for new struct design, Teldrassil show running correctly already
* update remaining shows for new firework show structs
* rename go_cheer_speaker to go_firework_show
* update debug / error messages
* update all firework shows for local spawnIndex handling
* spawn 'Toasting Goblet's for 10min after show ende
* add reveler SAI and make revelers cheer on show end
* remove log_error messages
* add comment for festive mugs
* Update firework_show.cpp
* add missing include for uint32
* replace an uint32 with an int
* revert unintended changes in midsummer.cpp
* add #include "GameObjectScript.h"
* remove ThunderBluff Reveler spawns with wandering movement
- these probably should have waypoints instead or just got parsed incorrectly
- it should be safe to remove these for now and probably investigage this further later on
* update function names
* Init.
Make use of spell for summoning Ahune's lieutenants, set up gossip/smart scripts for the cast and lieutenant summon speech, and remove permanent lieutenant spawns.
Partially cherry-picked from 91268f6631
Co-Authored-By: Xfurry <172444+xfurry@users.noreply.github.com>
* Use GUIDs for creature delete, add game_event_creature delete.
* Various adjustments.
Move comment block, add Desolace stones gossip menu options, add a delete before insert.
* Set up conditions.
* Add spell cast comments.
Sourced from Wrath Classic Wowhead.
* Add basic combat SmartAI.
* Remove comment block.
* Add creature name comments.
* Use `id1` in preparatory creature delete.
---------
Co-authored-by: Xfurry <172444+xfurry@users.noreply.github.com>
* fix(Scripts/Midsummer): Implement Ribbon Pole dance effects
* midsummer.cpp: remove whitespaces at end of lines
* midsummer.cpp: fix unused parameter error
* add spacing after 0.0f
* replace Milliseconds(...) by ...ms and Seconds(...) by ...s
* cleanup comments
* remove manual cleanups / despawns from DoCleanupChecks()
- rely on NPC despawn timers
- manual cleanup / removal actually is a bit excessive
* set INTERVAL_DANCING_FLAMES to 15s
* set despawn time to 1min for big dancing flames according to spell 46827
* set spawnDist to 12 for big dancing flames according so spell 46827
* use library function Acore::Containers::RandomShuffle() to shuffle _danclerList
* sql: do not set SmartAI for NPC 17066
already using ScriptName and can't have both
* combine 3 sql files into 1
* remove INTERVAL_... enum values
* remove unnecessary checks of if(_bunny)
* sql: fix smartscript comment
* rename spell define to correct spell name
* refactor(Scripts/Midsummer): Assign enum values to gameobjects and spells
* rename GO_TORCH_TOSS_TARGET_BUNNY to NPC_TORCH_TOSS_TARGET_BUNNY
* add more enum values to enum flingTorch
* fix(Scripts/Midsummer): Make beam target Ribbon Pole top
progress #12145
* refactor(Scripts/Midsummer): shorten spell_midsummer_ribbon_pole_visual::UpdateTarget
- spell 45644 used to be linked to spell_midsummer_juggling_torch
- spell 45644 was later linked to new implementation
spell_midsummer_torch_catch in e1e4c6cddc
- old implementation of spell 45644 was never removed from
spell_midsummer_juggling_torch
* fix (core): macos12 depreciation workflow error
Fix workflow error message:
azerothcore-wotlk/src/common/Utilities/Util.cpp:558:9: fatal error: 'sprintf' is deprecated: This function is provided for compatibility reasons only. Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead. [-Wdeprecated-declarations]
sprintf(buffer, "%02X", bytes[i]);
* Update BattlegroundAV.cpp
* more macos12 fixit
* Update spell_generic.cpp
