Commit Graph

4735 Commits

Author SHA1 Message Date
Andrew
5a4fdc7de4 fix(Core/Spells): Banish should only be dispelled by Mass Dispel (#17703)
* fix(Core/Spells): Banish should only be dispelled by Mass Dispel

* Update Unit.cpp

* Update Unit.cpp
2023-11-14 16:27:37 +01:00
KJack
3d20f8902b feat(Core/Instance): InstanceScript: create Remove functions (#17702)
InstanceScript: create `Remove` helper functions
2023-11-14 08:13:28 -03:00
KJack
2e4ad36d20 feat(Core/AI): Add built-in TaskScheduler to CreatureAI (#17700)
* Add TaskScheduler to CreatureAI

* Code style, because of course.
2023-11-14 07:32:47 -03:00
avarishd
4cb25b4b5e fix(Scripts/DurnholdeKeep): Captain Skarloc spawning double/wrong adds (#17667)
* fix(Scripts/DurnholdeKeep): Captain Skarloc spawning double/wrong adds

* Ss

* DoForAllSummons
2023-11-14 08:53:17 +01:00
KJack
4fabaee597 fix(Scripts/ZulGurub): Jeklik (Bat Boss) - fix double-run scheduler (#17693)
* Don't double-run scheduler. Only run out of combat when needed.

* Comment clarification

* Rename variable

* Replace janky scheduling with `DespawnOnEvade()`
2023-11-13 03:42:16 -03:00
Andrew
bbedb91e2c fix(Scripts/Karazhan): Implement Nightbane summon emote and despawn on evade (#17690)
* fix(Scripts/Karazhan): Implement summon emote and despawn on evade

* missing flag
2023-11-13 01:39:14 -03:00
Andrew
975a6fccab feat(Core/Scripts): Prevent the inherited TaskScheduler from updating… (#17689) 2023-11-12 20:30:23 -03:00
Grimgravy
6486f72740 fix(Script/Quest): Improve A Spirit Ally? (#16893)
* fix(db/Quest): Improve A Spirit Ally?

* Update spell_quest.cpp

* improvement in position
2023-11-12 17:52:49 +01:00
Christopher Galbraith
ae5bf57dba fix(Core/Spell): Titan's Grip check if player has 2H and shield equipped (#16984)
* check if player has a 2H and shield equipped

* null check item2 for shield

* style whitespace

* removed unnecessary logic

* remove unnecessary brackets

---------

Co-authored-by: ChrisCGalbraith <chriscgalbraith@gmai.com>
2023-11-12 17:51:26 +01:00
AG
61fd3eebf9 fix(Metric/Misc): Change default updatetime to 1s (#17627)
* Update default metric interval

* codestyle

* ready for merge

---------

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2023-11-12 16:37:16 +01:00
avarishd
67811a6369 fix(Script/Spell): Carinda's Scroll of Retribution usable on players (#17601) 2023-11-12 16:32:16 +01:00
KJack
3c8adc71cd (Scripts/AI) ZG20: Jeklik (Bat Boss) - Implement Bat Riders, other fixes and improvements (#17573)
---------

Co-authored-by: AG <43139552+AGandrup@users.noreply.github.com>
2023-11-12 09:35:35 +01:00
forgives
ca7eb956aa feature(Core/Pet): Add pet talent rate config (#17678)
* feat: add pet talent rate config

* feat(Core/Pet): keep consistent with player talent config

* refactor(Core/Pet): delete empty line
2023-11-12 09:33:06 +01:00
Kitzunu
bbadc32bea Revert Visibility Notifier changes (#17682)
* Revert "fix(Core/Grid): Implement missing GridUnload setting (#17569)"

This reverts commit 79b39f9655.

* Revert "fix(Core/Grid): Address bugs and performance issues introduced by visibility notifier implementation (#17480)"

This reverts commit 60e27511c5.

* Revert "fix(Core): GridCleanUpDelay Log (#17436)"

This reverts commit 90b16ca065.

* Revert "feat(Core/Grids): Implement visibility notifier (#15919)"

This reverts commit 2779833768.
2023-11-12 00:48:49 +01:00
Vitumoc
4df0ab3427 fix(Core/Character): fix worldserver with autobalance mod crash when character creation fails (#17625)
* set vars before clean player when create err

* code style

* dont clean

* code style

* check flag
2023-11-12 00:15:05 +01:00
Dan
e1aa26f92d fix(Scripts/SSC): make sure adds properly respawn and DoAction only fires on Tidalvess alive (#17680)
initial commit
2023-11-11 23:20:26 +01:00
Dan
32ff556a99 fix(Scripts/SSC): make Fathomlord use his Spitfire Totem ability (#17674)
* initial

* new spell/aurascript format

* leftover
2023-11-11 19:45:21 +01:00
Dan
203536526c fix(Scripts/TheEye): Void Reaver sniffed timers (#17676)
initial commit
2023-11-11 19:34:42 +01:00
Dan
8f81a08455 fix(Scripts/SSC): make sure Insidious Whispers demons don't instantly despawn (#17672)
* initial commit

* reset threat list

threat should drop on any phase transition
2023-11-11 19:00:52 +01:00
KJack
896e7c5656 (Scripts/AI) ZG20: Improvements to Thekal (Tiger Boss) (#17603)
Co-authored-by: AG <43139552+AGandrup@users.noreply.github.com>
2023-11-11 08:13:43 +01:00
KJack
f7fdc7cb6c refactor(Scripts/RuinsOfAhnQiraj)Ç AQ20: Modernize Kurinnaxx (#17671) 2023-11-10 18:59:46 -03:00
Ludwig
2e5d5f2dc7 fix(Events): fix commoner spawns, auras and equips for all events (#17632)
* fix(Core/Spells): Implement Gossip NPC Appearance spells

65511 Gossip NPC Appearance - Brewfest
65522 Gossip NPC Appearance - Winter Veil
65523 Gossip NPC Appearance - Default
65524 Gossip NPC Appearance - Lunar Festival
65525 Gossip NPC Appearance - Hallow's End
65526 Gossip NPC Appearance - Midsummer
65527 Gossip NPC Appearance - Spirit of Competition
65528 Gossip NPC Appearance - Pirates' Day
65529 Gossip NPC Appearance - Day of the Dead (DotD)

* fix(DB/SAI): fix commoner spawns and auras

* equip random mug on spell 65511 Gossip NPC Appearance - Brewfest

* check if creature before equipping brewfest mug

* minor optical fixes, DELETE first, then remove duplicate spawns

* fix two displayIDs in NPC Gossip Appearance spells

* Remove whitespace at the end of the lines

* remove commoner spawns for event 7 Harvest festival from game_event_creature

* fix harvest festival event id

* Update rev_1698785311231174200.sql
2023-11-10 20:26:49 +01:00
Ludwig
cb483d124f fix(Script/Spell): fix AOE circle bug on Midsummer Torch Catching (#17654)
* fix(Spells/Midsummer): fix script for spell 46747 SPELL_FLING_TORCH_DUMMY

* SpellInfoCorrections: fix target of spell 46747 Fling torch

* DB: assign spell 46747 Fling torch to item 34833 Unlit Torches

* remove whitespaces at src/server/game/Spells/SpellInfoCorrections.cpp:4610
2023-11-09 00:19:57 +01:00
KJack
48a43c7f44 fix(Core/Creature): Resolve issue with dialog options randomly not working (#17596)
Remove unneeded ClearGossipMenuFor
2023-11-08 19:33:03 -03:00
Tristan 'Natrist' Cormier
f1cb3bfb3b refactor(Core/Network): remove redundant logging calls from some message handlers (#17565)
chore: removed redundant logging calls from some message handlers
2023-11-08 21:53:43 +01:00
Ludwig
ef09d4b63f fix(Core/Unit): Implement GetDisplayRace() (#17609) 2023-11-08 19:19:38 +01:00
KJack
e18bfae91c Feat (Core) Add CustomData to Groups (#17628)
* Add CustomData to Groups

* A one-line change and it STILL failed the first check run!
2023-11-08 19:18:58 +01:00
Benjamin Jackson
f898fa75cd fix(Core/Spells): Correct spell scaling formula. (#17649)
* Replace old spell scaling with revised version.

Co-Authored-By: balakethelock <111737968+balakethelock@users.noreply.github.com>

* Remove a single-use variable.

* Use funky multiply operator.

More similar to original function, if a tad less readable IMO.

---------

Co-authored-by: balakethelock <111737968+balakethelock@users.noreply.github.com>
2023-11-08 08:44:05 +01:00
avarishd
8af077bc33 fix(DB/SAI): Naberius (#17639) 2023-11-08 08:01:24 +01:00
Dan
145b14c567 refactor(Scripts/TheEye): High Astromancer Solarian script refactored using taskscheduler (#17653)
* initial commit

* some fixes

* remove leftovers

* no attack during invisibility
2023-11-07 22:13:23 +01:00
KJack
f417a166bc feat(Core/Scripts): added OnAfterSpecSlotChanged hook (#17637) 2023-11-07 23:46:08 +07:00
Winfidonarleyan
c5564e1363 feat(Deps/Fmt): update fmt lib to 10.1.1 (#17643) 2023-11-05 13:15:45 +07:00
avarishd
fb83c22dd2 fix(Core/Spells): T5 Warlock 4 Set (#17589)
* fix(Core/Spells): T5 Warlock 4 Set

* BonusMultiplier is 1 so we don't care about it
2023-11-02 12:30:03 -03:00
avarishd
11c88cb30e fix(Core/Spells): T4 Shadow Priest 4 Set (#17587)
* fix(Core/Spells): T4 Shadow Priest 4 Set

* zzz
2023-11-02 08:54:44 -03:00
avarishd
9c09ddc3df fix(DB/Creature): Hellfire Peninsula - Stonescythe mobs (#17604)
fix(DB/Creature): HFP - Stonescythe mobs
2023-11-02 08:54:11 -03:00
avarishd
bc688c2a51 fix(Core/Spells): Script Choking Vines (#17615)
* fix(DB/Custom): Choking Vines should stack from different sources

* script spell

* comment
2023-11-02 08:53:45 -03:00
KJack
751ffc7c70 feat(Core/Hooks): Add OnAfterDatabaseLoadCreatureTemplates hook (#17621)
* Add OnAfterDatabaseLoadCreatureTemplates hook
- fix issue where the fast template cache was not updated correctly after a CS reload of a single creature template

* Parameter naming tweak to reduce confusion.

* Refactor to streamline fastcache creation, remove threading concerns

* Remove unneeded resize when loading creature templates

* Update fast cache resizing to highest-performing option
2023-10-31 06:58:45 -03:00
Ovahlord
52d37a927d fix(Build): nopch build (#17617) 2023-10-30 00:24:18 +01:00
avarishd
0679789120 fix(Core/Spells): T5 Holy Paladin 2 set (#17566)
* fix(Core/Spells): T5 Holy Paladin 2 set

* thanks notepad (don't ask)
2023-10-29 23:36:27 +01:00
Kitzunu
f757e93da5 refactor(Core/Misc): Make DeathState enum class (#17607) 2023-10-28 10:54:03 +02:00
AG
79b39f9655 fix(Core/Grid): Implement missing GridUnload setting (#17569)
* Implement GridUnload setting

* Minor fixes

- Use GetOption instead of deprecated GetBoolDefault.
- Added a missing check for instances in LoadMap
- Replaced some numbers with global defines

* Possible crashfix + minor improvements

- Initialized initialOrientation which I had forgotten (likely cause of crash)
- Readded a previous check in UpdateSplineMovement
- Made i_objectsToRemove and i_worldObjects tos sets as they were previously, instead of unordered_set.

* Update worldserver.conf.dist

* Fix high CPU usage with preload grid enabled.

This should be it.
2023-10-26 19:32:15 -03:00
Andrew
3dcbe649dd fix(Scripts/Karazhan): Fix Flame Wreath affecting pets (#17581) 2023-10-25 19:01:15 -03:00
KJack
632b55faa5 fix (Scripts/ICC): Make Valithria starting health dynamic, fix broken channeling spell (#17586)
* Make Valithria starting health dynamic based on actual max health

* Fix Risen Archmage broken spell channel and combat log spam
2023-10-25 18:53:00 -03:00
Andrew
41dba1affb fix(Scripts/ObsidianSanctum): Fix Tenebron respawning (#17576)
fix(Scripts/ObsidianSanctum): Fix Shadron respawning
2023-10-25 06:14:09 -03:00
AG
60e27511c5 fix(Core/Grid): Address bugs and performance issues introduced by visibility notifier implementation (#17480)
* Bug fixes

- Corrected std::chrono from seconds to milliseconds
- Got rid of leftover code that caused objects to not show up on time

* Removed logic to set gameobject as active

- More alignement with TC.
- Reduces CPU usage drastically

* Revert back to using time_t instead of std chrono

* Invoke SetNoCreate() method to reduce CPU usage drastically

* Remove setActive from static and motion transports

* Fix performance issues

* Added SetFarVisible to WG and some dungeon scripts

- Also removed setActive(true) from creatures in Wintergrasp. As for gameobjects they are set to active upon being damaged/destroyed and removed from active on rebuild (reset)

* Removed comments related to VISIBILITY_COMPENSATION

* Fix log

* Deleted unused files + corrected a check

* Added missing header

* Removed unused parameter

* Removed another unsued parameter

* Changed vector to set for i_visibleNow

- Changed vector to set for i_visibleNow in VisibleNotifer
- Adjusted HaveAtClient to accept Object*
- Adjusted SendUpdateToPlayer to send createobject packet only if not known to client
2023-10-23 05:37:11 -03:00
Andrew
a56a224bd7 fix(Scripts/Karazhan): Update Aran with the new OnPowerUpdate() hook (#17561) 2023-10-23 05:28:29 -03:00
Andrew
69418ab936 fix(Scripts/Ulduar): Don't treat Algalon respawns as if they were the… (#17562)
* fix(Scripts/Ulduar): Don't treat Algalon respawns as if they were the first pull

* Update boss_algalon_the_observer.cpp
2023-10-22 15:12:30 +02:00
Andrew
9935e72341 feat(Core/Unit): Implement OnPowerUpdate() unit script hook (#17560) 2023-10-22 09:14:41 -03:00
Grimgravy
1262bbd237 fix(DB/Quest): Improve The Summoning Chamber (#16588)
* fix(DB/quest): The Summoning Chamber

* update

* improvement

* update

* update

* Update rev_1687180111436507500.sql

* improvement
2023-10-22 13:12:18 +02:00
pvp100
4962972eec fix(Core/BG): Relocate cannon in WG (#16673)
* fix(DB/Gameobject): fix towercanno error location in Flamewatch Tower

adjusted wintergrasp towercanno position

* Update src/server/game/Battlefield/Zones/BattlefieldWG.h

Co-authored-by: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>

---------

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
Co-authored-by: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>
2023-10-22 04:47:13 +02:00