Commit Graph

4735 Commits

Author SHA1 Message Date
Dan
5b899eb65d fix(Scripts/Karazhan): Aran now evades when pulled out of the room (#17264)
* initial

* use standard methods dummy

* Update boss_shade_of_aran.cpp

* Update boss_shade_of_aran.cpp

---------

Co-authored-by: Skjalf <47818697+Nyeriah@users.noreply.github.com>
2023-09-22 00:51:04 +02:00
Ludwig
056ea323f3 fix(Core/Achievement): Implement ACHIEVEMENT_CRITERIA_TYPE_ROLL_DISENCHANT (#17319) 2023-09-22 00:50:39 +02:00
Ludwig
f633eb8592 fix(Core/Achivement): Implement ACHIEVEMENT_FLAG_AVERAGE (#17263) 2023-09-21 18:56:28 +02:00
Stefano Borzì
168192b731 fix(CI): cppcheck failure step (#17240)
* feat: add cppcheck for scripts

* fix: cppcheck step failure

* trigger cppcheck build, it should fail

* fix: cppcheck should succeed

* fix: cppcheck
2023-09-21 12:43:57 +02:00
Mike Delago
b1c92f498a refactor(Core): Source config more aggressively from env, rephrase a few of the messages (#17114)
* refactor(Core): Let modules source config from env

* create a cache of configs from env

* Update src/common/Configuration/Config.cpp

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* Update src/common/Configuration/Config.cpp

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* enforce new function name

---------

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2023-09-20 22:55:46 +02:00
AG
540eda2af9 fix(Core/Unit): Added bluewall AoE check (#17064)
* Added bluewall AoE check

- AoE spells/abilities done by non-flagged players now has no effect on pvp flagged players.

* Crash fix

* Update Unit.cpp

Allow spells with flag "SPELL_ATTR5_IGNORE_AREA_EFFECT_PVP_CHECK" to pass this check.
2023-09-20 22:48:23 +02:00
Tralenor
0796df57ac feat(Core/Player): Addition of a Hook in CanFlyInZone check (#16590)
---------

Co-authored-by: tmoos <tmoos@meteomatics.com>
Co-authored-by: Winfidonarleyan <dowlandtop@yandex.com>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2023-09-20 22:40:08 +02:00
Skjalf
74353a3c83 fix(Scripts/Karazhan): Delay chain spawning so it spawns on proper place (#17311)
* fix(Scripts/Karazhan): Delay chain spawning so it spawns on proper place

* Update boss_terestian_illhoof.cpp
2023-09-19 21:39:07 -03:00
Skjalf
3cfb1d3bf6 fix(Scripts/Karazhan): Move Aran's elemental AI to SAI (#17312) 2023-09-19 21:38:41 -03:00
Skjalf
3a51249bf5 fix(Scripts/Karazhan): Fix fear immunity for Strawman (#17307) 2023-09-19 20:32:25 -03:00
Skjalf
7dd9ca01c5 fix(Scripts/Karazhan): Regen Curator mana on reset (#17310) 2023-09-19 20:30:34 -03:00
Dan
373fdd68bf fix(Scripts/Karazhan): fix visual of infernals on Malchezaar (#17304)
* test

* remove comment
2023-09-18 20:35:41 -03:00
Skjalf
89d0db3a93 fix(Scripts/Karazhan): Fix Aran's chase distance and Blink conditions (#17296)
* Revert "chore(Worldserver/Config): Clean up and reorganize config file (#17272)"

This reverts commit c709e2e7d3.

* fix(Scripts/Karazhan): Fix Aran's chase distance and Blink conditions

* Revert "Revert "chore(Worldserver/Config): Clean up and reorganize config file (#17272)""

This reverts commit 7075437947203943872aa7606c07c82ae4c8c93c.

* Update rev_1695004374973517300.sql
2023-09-18 15:55:15 -03:00
Skjalf
5b3c5740fb fix(Scripts/Karazhan): Fix Terestrian Illhoof not summoning any imps (#17297)
* fix(Scripts/Karazhan): Fix Terestrian Illhoof not summoning any imps

* Update rev_1695008245587651800.sql

* Update boss_terestian_illhoof.cpp

* make kilrek immune to enslave demon
2023-09-18 15:54:52 -03:00
Skjalf
9ac71a4e2a fix(Scripts/MagistersTerrace): Script Kalecgos' appearance after usin… (#17286) 2023-09-17 19:00:09 -03:00
daobashun
533b36406e fix(DB/Creature): move Fairbanks gossip to the database (#16974)
* Add gossip_menu_id for fairbanks

* npc_text ID uses the npc_text_broadcast_text Datasheet ID in CMANGOS

* Some emoticons will hold the weapon in your hand when used, so use smartAI instead.

* Only if there is an inventory or equipment Ashbringer will the gossip_menu_option be displayed

* Remove the code from the script

* Update the data

* Code formatting Remove comments

* Replace ## with --
Replace npc_text_broadcast_text with npc_text_broa*dcast_text

* Replace npc_text_broadcast_text with npc_text_broa*dcast_text

* Modify the comment
2023-09-17 21:48:25 +02:00
TuriansNotBad
89ba87495e fix(Core/Position): Normalize Position.GetRelativeAngle (#16825)
Normalize GetRelativeAngle

Normalize angle returned by both Position.GetRelativeAngle functions.
2023-09-17 21:35:34 +02:00
Skjalf
ca95b4a129 fix(Scripts/Karazhan): Fix Enfeeble hitting more than 5 targets (#17290)
* fix(Scripts/Karazhan): Fix Enfeeble hitting more than 5 targets

* reorder so there are no cases where only 4 players are hit

* missing override
2023-09-17 16:32:06 -03:00
Grimgravy
24c97c5f2f fix(Scrpits/Quest): Improve Recharging the Batteries (#16597)
* fix(Scrpits/Quest): Improve Recharging the Batteries

* Update zone_netherstorm.cpp

* update
2023-09-17 21:16:43 +02:00
Matthew M Dean
bc6a744538 fix(Core/Item): Reduce amount of excessive logging for enforeDBCAttributes (#16508)
bypass code block if enforceDBCAttributes is set to false
2023-09-17 21:00:37 +02:00
Kitzunu
1621da00da chore(misc): Mordenize maths (#17273) 2023-09-17 17:00:53 +02:00
Dan
52744e6032 fix(Scripts/Karazhan): Shade of Aran now no longer casts spells whilst he should be drinking (#17282)
* initial

* remove redundancy

* remove method

* space gone

* indentación
2023-09-17 11:50:21 -03:00
Skjalf
0bf559f975 feat(Core/Instance): Add TaskScheduler to the InstanceScript class (#17284)
feat(Core/Instance): Add TaskScheduler to the instancescript class
2023-09-17 10:56:02 -03:00
Tereneckla
1eb573be1c fix(Scripts/Karazhan): Curator fixes (#17270)
* stop channeling on enrage

* Create rev_1694861198470600600.sql

* Update boss_curator.cpp

* Update src/server/scripts/EasternKingdoms/Karazhan/boss_curator.cpp

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

---------

Co-authored-by: Angelo Venturini <nefertum.dev@protonmail.com>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2023-09-17 10:26:26 -03:00
Kitzunu
c709e2e7d3 chore(Worldserver/Config): Clean up and reorganize config file (#17272)
* chore(Worldserver/Config): Clean up and reorganize config file

* Update worldserver.conf.dist

* \n\n\n
2023-09-17 10:25:32 -03:00
Kitzunu
f1111be152 chore(misc): cleanup (#17274) 2023-09-17 10:19:09 -03:00
Skjalf
71de2e5c26 fix(Core/GameObject): Also send EventInform() calls for GAMEOBJECT_TY… (#17283)
fix(Core/GameObject): Also send EventInform() calls for GAMEOBJECT_TYPE_CAMERA

- This allows object and zone AI to process events called by camera objects as well (previously only possible through event_scripts)

(cherry-picked from commit 6904073c9c)
2023-09-17 10:18:13 -03:00
Kitzunu
4b21f01b91 fix(Core/TaskScheduler): warning (#17275) 2023-09-17 10:14:28 -03:00
Dan
45d6009cb7 fix(Scripts/Darkshore): ensure Kerlonian Evershade is always in bear form (#17062)
initial
2023-09-17 09:42:07 -03:00
Dan
d15d72c812 fix(Scripts/BlackwingLair): Orb of Domination can no longer be used when you are controlling a pet (#16880)
initial
2023-09-17 07:50:43 -03:00
Dan
a0a06a6d18 refactor(Scripts/SSC): Hydross the Unstable boss script updated (#17081)
* initial

* fix timers

Water tomb and vile sludge timers homogenised. I did this because the sniffs turn him into the pure form quite quickly. So I am assuming the initial timer is the same for both, and then taking some kind of average for the water tomb and also using that for vile sludge. We may need testing where we keep him in the first form for a bit just to look at the timers
2023-09-17 07:43:30 -03:00
Angelo Venturini
be5db26d24 fix(Scripts/MagtheridonLair): Magtheridon Debris (#17249)
* fix(Core/Scripts): Magtheridon Debris

* unhack

* cleanup

* eof line

* unused variable

* more cleanup
2023-09-17 07:43:10 -03:00
Dan
9b438731fd fix(Scripts/Karazhan): remove redundant spellcasting check on Netherspite to ensure he moves back to phase 1 (#17269)
initial
2023-09-17 07:38:53 -03:00
Kitzunu
b84596fcab chore(Scripts/DK): Move CheckCast to spell_dk_raise_ally script (#17221)
* chore(Scripts/Spell): Move CheckCast to spell_dk_raise_ally script

* Update spell_dk.cpp

* Update spell_dk.cpp
2023-09-17 03:05:10 +02:00
Kitzunu
fbf7ba2191 chore(Core/enumutils): regenerate enumutils (#17087)
* chore(misc/enumutils): update enumutils

* fix build

* latest update
2023-09-16 14:26:08 +02:00
Kitzunu
66066f508b fix(Scripts/Chat): Fix chat logger (#17102)
* fix(Scripts/Chat): Fix chat logger

* Update chat_log.cpp

* Update worldserver.conf.dist

* Update chat_log.cpp

* fix build

* oopsie

* fix clang
2023-09-16 08:17:42 +02:00
Tereneckla
edaf38c6c3 refactor(Scripts/Spells): Check for existence of AD debuff instead of adding a custom cooldown to heal (#17265)
* Update spell_paladin.cpp

* whitespace
2023-09-15 20:30:15 -03:00
Dan
d18368ad60 fix(Scripts/Karazhan): decrease Aran cast cooldown on normal spells (#17260)
initial
2023-09-15 05:57:53 -03:00
Benjamin Jackson
358a1e71e0 refactor(DB/Player): Unify two player stat tables. (#17188)
* Init.

Change query table names, move data to existing table.

* Combine two player stat loading functions.
2023-09-15 02:35:26 +02:00
Kitzunu
ecf85a2f3e chore(Core/Misc): Silence compile warning in boost::process with vers… (#17251)
chore(Core/Misc): Silence compile warning in boost::process with version 1.83

* Cherry-pick commit d8c98579d4

Co-authored-by: Shauren <shauren.trinity@gmail.com>
2023-09-15 02:32:36 +02:00
Ludwig
8ba8f0fe9e fix(Core/Achievement): Implement ACHIEVEMENT_CRITERIA_TYPE_OWN_RANK (#17180)
* fix(Core): Implement ACHIEVEMENT_CRITERIA_TYPE_OWN_RANK

* fix(Core): LoadAchievementCriteriaData(): Add ACHIEVEMENT_CRITERIA_TYPE_OWN_RANK

- fixes minor oversight of ACHIEVEMENT_CRITERIA_TYPE_OWN_RANK implementation
- this enables DB achievement_criteria_data check for ACHIEVEMENT_CRITERIA_TYPE_OWN_RANK
2023-09-14 22:27:39 +02:00
Skjalf
44d1df01c3 fix(Scripts/Karazhan): Should always be able to talk to chess pieces … (#17246)
fix(Scripts/Karazhan): Should always be able to talk to chess pieces regardless of faction
2023-09-14 01:10:36 -03:00
Dan
a469cb5956 fix(Scripts/Karazhan): Malchezaar infernals now spawn in the correct locations under the right conditions (#17237)
* initial
test

Co-authored-by: <100873791+Gultask@users.noreply.github.com>

* change spawnMask

* better failsafe

* get list once

* extend search range for relays

* put infernal spawn in separate method for

readability

* add more methods

* remove leftover method

* dumb and dumber mistakes
2023-09-13 20:58:19 -03:00
Gultask
e422583132 feat(Core/SmartAI): Implement a few more stuff (#17090)
* init

* init2

* attempt to fix WP delays

* init3

* init4

* buildfix

* Create rev_1693093120417899200.sql

* workflow

* Underbat

* castflag power mana

* did not work

* Update SmartScriptMgr.cpp

* ugly

* port range to new system

* attempt

* simplify cast

simplify cast
add iteration for aura_not_present
recalc timer if already castig spell

* Update SmartScript.cpp

* attempt

* attempts

* HP PCT

* missing aura to targetselector

* Update rev_1693093120417899200.sql

* Update SmartScriptMgr.h

* Update SmartScriptMgr.h

* Update SmartScript.cpp

* remove not_attacking, fix behind_me

* revert is_behind_me

* Update SmartScriptMgr.h

* Update underbog.cpp

* Update underbog.cpp
2023-09-10 13:12:55 +02:00
Christian Lohr
c43f62f6a9 fix(Core/Conf): log error in case configuration not found for DBImport (#17066)
* fix: log error in case configuration not found

* fix: register dbimport configuration file
2023-09-10 01:15:20 +02:00
Kitzunu
f6d11d526b fix(Core/AuctionHouse): fix crash in BuildListAuctionItems (#17222)
* closes https://github.com/azerothcore/azerothcore-wotlk/issues/17150
2023-09-08 23:09:35 -03:00
Skjalf
8d08a861aa feat(Core/Scripting): Implement OnAllowedToLootContainerCheck() hook (#17209)
* chore(Core/Loot): Move OnAllowedForPlayerLootCheck() hook call up

* Revert "chore(Core/Loot): Move OnAllowedForPlayerLootCheck() hook call up"

This reverts commit f841ef9da313976179fb788d9573ff8ced05ecb9.

* feat(Core/Scripting): Implement OnAllowedToLootContainerCheck() hook

* Update GlobalScript.cpp
2023-09-08 01:52:02 -03:00
Dan
76d1d02dce fix(Scripts/Magtheridon): add correct way to reset threat list (#17198)
* test

* fix but check

* fix?
2023-09-06 18:33:34 +02:00
Christopher Galbraith
4147418a7a refactor(Scripts/TheEye): Refactor Void Reaver boss script to new scheduler (#17044)
* WiP draft of void reaver refactor

* linting

* remove UpdateAI override

* add delay after pounding

* separate arcane_orb into group to delay

* clang fix

* removed unused context param

---------

Co-authored-by: ChrisCGalbraith <chriscgalbraith@gmai.com>
2023-09-05 13:16:31 -03:00
Dan
189818e781 fix(Scripts/Ulduar): update Winter Jormungar and Snow Mound creature script (#17054)
* initial

* add auras

* spacing
2023-09-05 06:39:44 -03:00