Commit Graph

2675 Commits

Author SHA1 Message Date
Jelle Meeus
e0f08bbfb6 fix(Core/Spells): supress caster procs for Siphon Life heal (#20175)
supress caster procs for Siphon Life heal
2024-10-12 13:05:44 +02:00
Angelo Venturini
fede17f782 fix(Core/Spells): Fix crash (#20179)
Co-authored-by: Ariel Silva <ariel-@users.noreply.github.com>
2024-10-11 08:15:02 -03:00
Benjamin Jackson
c3ee737c80 fix(Core/SpellInfoCorrections): Add Arcane Missiles spell info correction. (#20165)
Init.

Co-authored-by: Ernesto Gonzalez <80600689+ernesto-glz@users.noreply.github.com>
2024-10-11 11:51:29 +02:00
Jelle Meeus
859a42a41e fix(Core/Vehicles): feat vehicle seat addon, vehicle enter/exit positions (#20082)
* implement initial vehicle_seat_addon

Co-authored-by: Ovah <dreadkiller@gmx.de>

* add more vehicle_seat_addon data

* make exiting passenger visible

fixes "immediate despawn" of travelers mammoth

* style, update comments

* remove hacked pos relocate

* remove sending MSG_MOVE_ROOT/UNROOT on Ack

* set and unset UNIT_NPC_FLAG_PLAYER_VEHICLE on init/entry

* ulduar demolisher: remove flag correction and no longer needed usableseat

* fixup! implement initial vehicle_seat_addon

* fixup! fixup! implement initial vehicle_seat_addon

* re-add AddPassenger Flame Leviathan hack

was commented by mistake

* Update rev_1725993194571320983.sql

add missing ticks

---------

Co-authored-by: Ovah <dreadkiller@gmx.de>
2024-10-11 07:08:14 +02:00
Walter Pagani
e43b760c08 fix(Core/QuestHandler): Question marks not being shown (#20099) 2024-10-10 18:10:55 -03:00
Angelo Venturini
9487b30ad7 refactor(Core/Misc): Use emplace_back instead of push_back to avoid extra copy/m… (#20114)
refactor: Use emplace_back instead of push_back to avoid extra copy/move operations
2024-10-10 21:55:58 +02:00
Andrew
31cb7579e0 fix(Core/Scripts): Further improve the ScheduleHealthCheck() function (#20163) 2024-10-09 08:08:37 -03:00
Benjamin Jackson
fd6d2efccb fix(Core/Unit): Add mana drain effect to Black Bow of the Betrayer. (#20155)
* Init.

Co-authored by: stfxpi (stfx)
Original CMaNGOS commit: c750533b5e

* Add/adjust comments.
2024-10-09 06:00:20 -03:00
Jelle Meeus
a8d970caa7 fix(Core/Unit): add rage gain when attack is fully blocked, dodged or parried (#19377)
* generate rage if victim fully block, dodge, parry

* update rage calculation

* calc pct at the end

* update comment to link to Rage formulae and mention Bornak's bluepost

archived link to Bornak's bluepost
https://web.archive.org/web/20090604123729/http://forums.worldofwarcraft.com/thread.html?topicId=17367760070&pageNo=13#02500
2024-10-08 21:44:32 +02:00
Benjamin Jackson
cc5c582b4d fix(Core/Spell): Include damaging spells for starting combat. (#20154)
Init.
2024-10-07 08:55:28 -03:00
Benjamin Jackson
a57d8db81a fix(Core/CharmInfo): Add exception for Kil'jaeden dragon charm spells. (#20150)
Init.
2024-10-07 08:55:00 -03:00
Jelle Meeus
01b86ec7a6 fix(Core/Unit): update death state before handling RemoveAllAurasOnDeath() (#20124)
fix setDeathState

[PATCH] Don't allow units to enter combat upon death
91ebea4a77.patch
Co-authored-by: trickerer <onlysuffering@gmail.com>
2024-10-04 11:01:36 -03:00
Anton Popovichenko
9f58d55a1d fix(Core/Items): Fix exploit where multiple auras could be applied from a single enchantment. (#20128) 2024-10-04 06:32:42 -03:00
Jelle Meeus
9a1f27121a fix(Core/Unit): Flight Form riding crop, vehicle speed auras (#20079)
* vehicle aura stacking

Rename flight speed related auras
Co-authored-by: Laise <fenrisse@gmail.com>

* rename to better match existing flight auras
2024-10-01 21:39:42 +02:00
Andrew
ee870ff3b3 fix(Core/Spells): Restricted aura application prevention when immune to banish effects (e.g cyclone) (#20060) 2024-10-01 11:47:44 +02:00
Francesco Borzì
ae30489b23 refactor(src/server/game/Globals): remove unused imports (#20088) 2024-10-01 08:06:06 +02:00
Francesco Borzì
b0899664ef refactor(src/server/game/World): remove unused imports (#20090) 2024-10-01 08:05:36 +02:00
Francesco Borzì
484e19d21b refactor(src/server/game/Spells): remove unused imports (#20092) 2024-10-01 08:05:15 +02:00
Francesco Borzì
7d2aebb9d8 refactor(src/server/game/Chat): remove unused imports (#20093) 2024-10-01 08:04:51 +02:00
Francesco Borzì
9b17898f7b refactor(src/server/game/Grids): remove unused imports (#20094) 2024-10-01 08:04:26 +02:00
Francesco Borzì
d8c56392fb refactor(src/server/game/AI): remove unused imports (#20095) 2024-10-01 08:04:00 +02:00
Anton Popovichenko
804769400b fix(Core/GuardAI): crash when killer is null (#20100) 2024-09-30 13:19:44 +02:00
Francesco Borzì
784e80668d refactor(src/server/game/Entities): remove unused imports (#20096) 2024-09-29 20:19:02 +02:00
Francesco Borzì
1932fd0c8a refactor(src/server/game/Battle*): remove unused imports (#20097) 2024-09-29 18:14:46 +02:00
Francesco Borzì
6e2306f24a refactor(src/server/game/Movement): remove unused imports (#20098) 2024-09-29 18:14:12 +02:00
Francesco Borzì
1ebb53a248 refactor(src/server/apps|database|shared): remove unused imports (#19505) 2024-09-29 13:10:50 -03:00
Francesco Borzì
34a3b4ee47 feat(Core/BG): allow MinPlayersPerTeam override for low-levels (#20083) 2024-09-29 14:07:45 +02:00
Francesco Borzì
a4721c2821 refactor(src/server/game/Handlers): remove unused imports (#20087) 2024-09-29 13:19:40 +02:00
Jelle Meeus
b45166b2d0 fix(Core/Battlefield): shapeshift aura removal from players on leaving arena or battleground (#20069)
no longer remove shapeshift auras from player on leave
2024-09-29 13:18:36 +02:00
Grimdhex
8bf3595cef fix(Script/BlackTemple): teleport position with fatal attraction (#19971)
* fix(Script/BlackTemple): teleport position with fatal attraction

* fix codestyle

* try a new way by keeping a random teleport

* remove the old fixed position

* improve the dest selection

* raycast around the new position for check a valid dest

* fix codestyle

* revert the old changes

* refactor to remove the while loop

* few refactor

* Revert "few refactor"

This reverts commit fb7613d5cc5a19df01bbcf41ef5c982119ee9685.

* .

* add a los check

* new improvement with stairs cases & console errors

* fix disableWarning option

* Update boss_mother_shahraz.cpp

* Update boss_mother_shahraz.cpp

* Update boss_mother_shahraz.cpp

* Update boss_mother_shahraz.cpp

* Update boss_mother_shahraz.cpp
2024-09-28 10:27:32 +02:00
Stefano Borzì
f6de601ddd new BattlegroundDesertionTypes for hook OnBattlegroundDesertion (#20039)
* new BattlegroundDesertionTypes for hook OnBattlegroundDesertion

* chore: minor improvements

---------

Co-authored-by: laasker <79991768+laasker@users.noreply.github.com>
2024-09-27 22:19:56 +02:00
Jelle Meeus
8a0604479a fix(Core/Unit): fix Dual Wield for more creatures... (#20047)
* non-weapons should return true

* remove shapeshift check
2024-09-26 07:13:47 -03:00
Jelle Meeus
6e4a9bbb14 fix(Core/Unit): fix Dual Wield for more creatures, CREATURE_FLAG_EXTRA_USE_OFFHAND_ATTACK, creature disarm damage (#20015)
* enable CREATURE_FLAG_EXTRA_USE_OFFHAND_ATTACK

* sql set CREATURE_FLAG_EXTRA_USE_OFFHAND

* use new HasOffHandWeaponForAttack instead of haveOffhandWeapon

no longer requires m_CanDualwield set to use Offhand attack
requires non-disarmed weapon in Offhand OR creature_flag_extra enabled

Co-authored-by: Ovah <dreadkiller@gmx.de>
Co-authored-by: Warlockbugs <warlockbugs@outlook.com>

* Make shapeshift forms which dont override attack speed use weapon damage

Co-authored-by: killerwife <killerwife@gmail.com>

* SetEquipmentSlots turning off damage update when using template default

Co-authored-by: killerwife <killerwife@gmail.com>

* Setup DualWield & Damage On Equipment Updates, implement Set and GetVirtualItem

Co-authored-by: Yatzii <47720837+Yatzii93@users.noreply.github.com>

* creature disarm damage

set disarm to reduce minmax damage by 50% instead of setting to 0

Co-authored-by: Warlockbugs <warlockbugs@outlook.com>

---------

Co-authored-by: Ovah <dreadkiller@gmx.de>
Co-authored-by: Warlockbugs <warlockbugs@outlook.com>
Co-authored-by: killerwife <killerwife@gmail.com>
Co-authored-by: Yatzii <47720837+Yatzii93@users.noreply.github.com>
2024-09-25 16:53:39 +02:00
Walter Pagani
891bcd8e00 refactor(SQL/Quest) Rescuing the Rescuers ID 11244 (#20030)
* refactor(SQL/Quest) Rescuing the Rescuers ID 11244

* fix range and max targets

* Texts are added and the smart_script list is modified

Co-authored-by: DEV Seaferer <91832265+edgardavid94@users.noreply.github.com>

---------

Co-authored-by: DEV Seaferer <91832265+edgardavid94@users.noreply.github.com>
2024-09-25 10:36:56 +02:00
Andrew
dea3d44b46 fix(Core/Spells): Prevent aura application if the target is immune (#20031) 2024-09-24 15:17:22 -03:00
Jelle Meeus
a7578e1cce fix(Scripts/TheEye): Kael'thas p5 transition, flight, MotionMaster:MoveTakeoff (#20005)
Co-authored-by: killerwife <killerwife@gmail.com>
2024-09-24 08:33:21 -03:00
Anton Popovichenko
7dd460581d fix(Core/Loot): Fix crash for round robin loot mode when solving quest item for offline loot owner. (#20033) 2024-09-24 08:21:38 -03:00
Andrew
78cc255f43 fix(Core/Spells): Fix Fatal Attraction procing multiple times for eac… (#20014)
fix(Core/Spells): Fix Fatal Attraction procing multiple times for each player nearby
2024-09-22 14:52:19 -03:00
IntelligentQuantum
985410f184 feat(Core/Items): Delete old item id from recovery item (#18332) 2024-09-22 08:32:16 +02:00
Walter Pagani
cfd7bf4162 chore(Core/AllMapScript) Update structure (#19979)
* fix(Core/AllMapScript) Update structure to use CALL_ENABLED_HOOKS

* fatal error: no template named 'vector' in namespace 'std'

* fix build

Co-authored-by: Anton Popovichenko <anton.popovichenko@mendix.com>

---------

Co-authored-by: Anton Popovichenko <anton.popovichenko@mendix.com>
2024-09-21 22:25:22 +02:00
Jelle Meeus
b364e00238 fix(Core/Object): do not add Object to Transport when summoned by a Vehicle (#19920) 2024-09-21 21:57:26 +02:00
Kitzunu
386aea03ee chore(Core/Misc): Some cleanup (#19970)
* remove weird blanks

* update if

* ) ) to ))

* missed some ) )

* now switch

* .
2024-09-21 19:34:31 +02:00
skelUA
a196f7f28a fix(Core/Loot) fix bug with loot (#19882)
Try to fix bug with loot
2024-09-19 15:11:31 +02:00
Benjamin Jackson
a0057b9e90 fix(Core/Spells): Resolve a case of triggered spells prolonging combat. (#19991)
* Revert "fix(Core/Spells): Revert triggered spell logic change. (#19983)"

This reverts commit 3bb5ec779d.

* Add aura effect check.

Co-Authored-By: Anton Popovichenko <walkline.ua@gmail.com>

* Add comment, use target instead of owner.

* Adjust comment terminology.

---------

Co-authored-by: Anton Popovichenko <walkline.ua@gmail.com>
2024-09-19 09:49:56 -03:00
Benjamin Jackson
3bb5ec779d fix(Core/Spells): Revert triggered spell logic change. (#19983)
Revert "fix(Core/Spells): Resolve a case of triggered spells prolonging comba…"

This reverts commit edd7e10dfc.
2024-09-16 11:15:50 -03:00
sudlud
e2353a1c9f fix(Core/PlayerQuest): Introduce flag QUEST_SPECIAL_FLAGS_NO_LOREMAST… (#19962)
* fix(Core/PlayerQuest): Introduce flag QUEST_SPECIAL_FLAGS_NO_LOREMASTER_COUNT

- this allows flagging quests so that they will not count towards Loremaster achievement
- update Corrupted Flower Quests in Felwood accordingly as a first use case

* load Specialflags as uint32 from DB
2024-09-15 18:15:21 -03:00
Kitzunu
1df989f780 chore(Core/Achievement): cleanup offline achievement (#19976) 2024-09-15 16:11:24 -03:00
Andrew
ee6e74eb3c fix(Scripts/Commands): Fix level up achievements not being granted (#19969) 2024-09-15 15:55:45 -03:00
Andrew
8b16f7d243 fix(Scripts/BlackTemple): Implement emotes when opening Najentus and … (#19946)
* fix(Scripts/BlackTemple): Implement emotes when opening Najentus and Den of Mortal Delights

* only check if state is done
2024-09-15 12:48:11 +02:00
Grimdhex
4fc60bbbdf fix(Core/Spells): Shadow demon - Allow to move while casting Paralyze (#19948)
* fix(Scripts/BlackTemple): fix stationary shadow demons

* optimization: use else if to stop the execution when a condition is reach

* revert last changes and fix the spell to allow move while casting

* .
2024-09-14 08:39:03 -03:00