Commit Graph

348 Commits

Author SHA1 Message Date
Eddy Vega
e075d87c0e fix(scripts/Ragnaros): Move root handling from DB to Core (#12245) 2022-06-30 18:12:26 -03:00
UltraNix
a9256dd7c3 fix(Scripts/ZulGurub): Corrected Hakkar speeches at the very start of… (#12200)
fix(Scripts/ZulGurub): Corrected Hakkar speeches at the very start of the instance.

Fixes #12187
2022-06-27 06:15:48 -03:00
UltraNix
4cbe846d22 fix(Scripts/ZulGurub): Gri'lek should pursuit random targets. (#12194)
Fixes #12088
2022-06-26 15:07:25 -03:00
UltraNix
bd07d875a7 fix(Scripts/ZulGurub): Arlokk's Panthers should attack players. (#12185)
Fixes #12162
2022-06-26 06:08:29 -03:00
UltraNix
ea24a7b231 fix(Scripts/ZulGurub): Mandokir's Threatening Gaze. (#12095)
* fix(Scripts/ZulGurub: Mandokir's Threatening Gaze.

Boss can melee attack while casting.
Boss charges after the debuff run out.
Guillotine is casted on hit rather than on launch.
Properly coded Threatening Gaze Charge (with dot/hot exceptions)
Whirlwind is removed during charge.
Fixes #11748

* Update

* missing

* Update

* Update.

* Update.

* Update.

* Update.

* Update.
2022-06-26 04:50:50 -03:00
UltraNix
33fef6fb8d fix(Scripts/ZulGurub): Fixed never-ending Thousand Blades during Rena… (#12105)
fix(Scripts/ZulGurub): Fixed never-ending Thousand Blades during Renataki encounter.

Fixes #12078
2022-06-26 04:48:34 -03:00
Nefertumm
67e6954681 fix(Scripts/ZulGurub): Priestess Jeklik intro (#12109)
* fix(Core/ZulGurub): Priestess Jeklik intro

* ?

* sniffed values
2022-06-26 04:47:29 -03:00
Nefertumm
64a0cbba5a fix(Core/ZulGurub): Hakkar improvements (#12134)
* fix(Core/ZulGurub): Hakkar improvements

* remove debug

* code improvements

* just select the current victim for cause insanity

* remove will of hakkar <.<

* aspect of arlokk and marli should do a threat wipe

* dumb
2022-06-26 04:47:08 -03:00
Nefertumm
980f09ef22 fix(Core/ZulGurub): Arlokk reset behaviour (#12154)
* fix(Core/ZulGurub): Arlokk reset behaviour

* remove comment
2022-06-26 04:45:29 -03:00
Skjalf
46789d5df6 fix(Scripts/BlackwingLair): Correct Bone Constructs abilities (#12180) 2022-06-26 04:45:15 -03:00
Skjalf
38889324b2 fix(Scripts/BlackwingLair): Nefarian class calls should not repeat (#12148) 2022-06-23 09:49:08 -03:00
Maelthyr
c96a4ba223 fix(Scripts/ZulGurub): Venoxis - Holy wrath and Holy nova event (#12089)
* fix(Script/ZulGurub): fix Holy wrath and Holy nova event

*adjust timer too

* Remove condition for holy wrath. Adjust also timers with new researches.

* adjust first cast
2022-06-22 13:54:19 -04:00
Skjalf
ed7622b028 feat(Core/Formations): Implement GROUP_AI_FLAG_DONT_RESPAWN_LEADER_ON… (#12128) 2022-06-21 07:07:41 -03:00
Nefertumm
2db5f9a231 fix(Core/ZulGurub): Mandokir charge and chained spirits (#12072)
* fix(Core/ZulGurub): Mandokir charge and chained spirits

* build

* properly script threatening gaze

* refactor vilebranch speaker script

* remove useless trigger spell for Frightening Shout

* blank spaces

* build...

* sadly you can cheese threatening gaze

* revert threatening gaze part

* style

* charge should target the farthest one

* revert last thing of threatening gaze

* mod charge
2022-06-19 07:50:52 -04:00
UltraNix
82cfd1b8d4 fix(Scripts/ZulGurub): Improvements to Madonkir's melee spells. (#12096)
Overpower is casted on dodge.
Execute is casted when victim is below 20% health.
Cleave is casted when there is at least 5 targets in melee range.
Fixes #11747
2022-06-18 13:50:23 -04:00
Maelthyr
d928d8d96a refactor(Core/Unit): PC&NPC Immunity (#11986)
* initial

* refactor(Core/Unit): PC & NPC Immunities

Cherry-pick TC: 74af880217

Co-authored-by: Treeston <treeston.nmoc@gmail.com>

* fix builds error

Cherry-pick TC: 74af880217

Co-authored-by: Treeston <treeston.nmoc@gmail.com>

* Fix nef combat, and replace SetFlag by SetUnitFlag

* fix combat with jedoga

Co-authored-by: Treeston <treeston.nmoc@gmail.com>
2022-06-18 08:16:45 -04:00
UltraNix
235d2b6cf4 fix(Scripts/ZulGurub): Fixed spawning Edge of Madness bosses. (#11957)
Fixes #11609
2022-06-16 12:07:48 -03:00
UltraNix
117a18c961 fix(Scripts/ZulGurub): Renataki - improvements: (#11967)
Added missing spells and events.
Removed invalid spells
Corrected event timers
Fixes #11620
Fixes #11621
2022-06-16 11:39:09 -03:00
UltraNix
f9368ed00d fix(Scripts/ZulGurub): Improvements to Gah'zranka: (#11908)
Summoned Mudskunk Lure object and added visual splash.
Added pathing to Gahzranka
Corrected visual coordinates.
Gahzranka can be summoned only once per instance.
Fixes #11560
2022-06-13 23:33:35 -03:00
Nefertumm
396fd35ed5 fix(Core/Spells): Implement SPELL_EFFECT_ACTIVATE_OBJECT (#11648)
Co-authored-by: jackpoz <giacomopoz@gmail.com>
2022-06-13 21:10:31 -03:00
UltraNix
d5221ae423 fix(Scripts/ZulGurub): Fixed Jindo's Brain Wash Totem. (#11839) 2022-06-13 21:04:58 -03:00
UltraNix
21705d76ad fix(Scripts/ZulGurub): Improvements to Hazzarah encounter (#11964)
Corrected timers of events.
Added missing/Removed invalid spells.
Fixes #11612
2022-06-13 21:03:56 -03:00
Nefertumm
7e703393d2 fix(Core/ZG): Multiple improvements to High Priestess Mar'li (#11647) 2022-06-13 19:44:20 -03:00
Maelthyr
32334f5f14 refactor(Core/Unit): minor changes for the combat system (#11904)
Cherry-pick from TC: https://github.com/TrinityCore/TrinityCore/pull/19966

Co-authored-by: Treeston <treeston.nmoc@gmail.com>
2022-06-13 19:40:29 -03:00
UltraNix
d236dc9d07 fix(Scripts/ZulGurub): Wushoolay - improvements: (#11968)
* fix(Scripts/ZulGurub): Wushoolay - improvements:

Added missing spells and events.
Removed invalid spells
Corrected event timers.
Fixes #11627

* Update.
2022-06-13 09:02:57 -03:00
temperrr
d3b381c238 fix(Scripts/BRD): Emperor should not yell when dead. (#12046)
Co-authored-by: Skjalf <47818697+Nyeriah@users.noreply.github.com>
2022-06-13 09:01:50 -03:00
Eddy Vega
3b0cd43d12 fix(scripts/ZulGurub): Rewrite Broodlord Mandokir and Ohgan (#11854)
Co-authored-by: Nefertumm <nefertum.dev@protonmail.com>
2022-06-13 08:52:28 -03:00
UltraNix
e951208610 fix(Scripts/ZulGurub): Gah'zranka's Slam should reset threat. (#11910) 2022-06-09 20:28:57 -03:00
Eddy Vega
70f3891352 fix(Scripts/ZulGurub): Update Gahzranka's abilities (#11849) 2022-06-06 16:12:20 -03:00
UltraNix
41b0fa02f2 fix(Scripts/ZulGurub): Shade of Jin'do's invisibility aura should not… (#11838)
* fix(Scripts/ZulGurub): Shade of Jin'do's invisibility aura should not be removed on attack.

Fixes #11557

* missing stuff.

* Update.
2022-06-06 15:20:40 -03:00
UltraNix
ffda31fc23 fix(Scripts/ZulGurub): Fixed Jindo's Healing Ward Totem. (#11841)
Fixed #11763
2022-06-06 09:46:54 -03:00
Skjalf
5c7e7afade fix(Scripts/ZulGurub): Rewrite High Priest Thekal (#11784) 2022-06-06 09:35:48 -03:00
avarishd
7549eb59be fix(Script/Creature): Scarlet Commander Mograine - Pull entire cathedral and fix mob fleeing into him (#11766)
* Remove CallForHelp, add void PullCathedral

* cs
2022-06-06 09:02:55 -03:00
UltraNix
5454c0478f fix(Scripts/ZulGurub): Improvements to Gri'lek encounter: (#11960)
* fix(Scripts/ZulGurub): Improvements to Gri'lek encounter:

Corrected timers of events.
Avatar should wipe all threat for the entire raid.
Boss is immuned to taunt.
Added missing spells.
Fixes #11611

* missing sql.
2022-06-06 08:58:25 -03:00
Nefertumm
8e0b1ca286 fix(Core/ZulGurub): more improvements to High Priestess Jeklik (#11604)
* Fix(Core/ZulGurub): more improvements to High Priestess Jeklik

* remove old comment

* cancel phase one events on phase 2

* Update src/server/scripts/EasternKingdoms/ZulGurub/boss_jeklik.cpp

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* Update src/server/scripts/EasternKingdoms/ZulGurub/boss_jeklik.cpp

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* style

* build

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2022-06-03 09:26:18 -03:00
UltraNix
5b719bab05 fix(Core): Crashfix. (#11898)
Fixes #11861
2022-05-30 06:36:58 -03:00
UltraNix
f85b62a77f fix(Scripts/ZulGurub): Jindo cannot attack targets affected by Hex. (#11837)
Fixed #11556
2022-05-30 06:36:32 -03:00
UltraNix
be877a4e5d fix(Scripts/ZulGurub): Re-implemented Hakkar's Insanity. (#11840)
fix(Scripts/ZulGurub): Fixed Jindo's Brain Wash Totem.

Fixes #11760
2022-05-30 04:20:29 -03:00
UltraNix
1e79b10b79 fix(Scripts/ZulGurub): Massive Geyser should not attack players. (#11909)
Fixes #11563
2022-05-30 04:18:02 -03:00
Hanabi
a6a2ca8ef7 feat(Core/GameObjects): Instance gameobject save data implementation (#11113)
* fix(Core): Save gameobject state on instances

Currently, azerothcore doesn't save gameobject states on instances.
Whenever there's a re-start or crash, the instance's gameobjects and
their states aren't saved, producing un-wanted behaviours and blocking instances at times.

Implemented CRUD for new table `instance_saved_data` that holds the states of gameobjects.

- When worldserver launches and gameobjects are loaded, this will check
  if this object's state exists on the DB and sets the previous state.
- On instance deletion (reset) these states are also removed based on
  the instance ID.
- Whenever a gameobject state changes inside a dungeon or raid, we save
  on the database the set state.

* Select query to synchronous and used FindMap()

* loading gameobject states on create

* reseting instance saved data

* missing reset methods and on create state

* database structure

* Update src/server/game/Entities/GameObject/GameObject.cpp

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* Update src/server/game/Entities/GameObject/GameObject.cpp

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* Update src/server/game/Entities/GameObject/GameObject.cpp

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* Update src/server/game/Entities/GameObject/GameObject.cpp

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* Update src/server/game/Entities/Player/PlayerMisc.cpp

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* Update src/server/game/Groups/Group.cpp

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* codestyle

* table changes

* table style

* codestyle

* table changes for columns

* data sanitization

* todo:

- Finish loading db data into the containers
- Using containers to find data
- How to get data from ObjectMGR inside Gameobject?

* loading on start up and db changes

* Removing unused data structure

* Uninitialised integer

* Whitespace

* clean-up and hooks to save states on memory

* Codestyle MySQL deprecated backticks

* i dont understand codefactor

* build

* Update data/sql/updates/pending_db_world/rev_1643395587559675400.sql

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* Update src/server/game/Globals/ObjectMgr.h

Co-authored-by: Kargatum <dowlandtop@yandex.com>

* review changes

* unecessary removal

* pushback instead of emplace

* wrong database update

* Update ObjectMgr.cpp

* missing check

* removing entry from the PR

* missing removals

* last delete

* build

* aha! Found the culprit for the sudden assert errors

* type safety, save only important gameobjects

* static cast to unsigned short

* Update data/sql/updates/pending_db_characters/rev_1643629468629316100.sql

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* type changes

* queries fix

* fix build

* enabling which gameobjects to save on the database

* deadmines iron clad door

* Adjustment to gameobject onj create state and instances:

- Gnomeregan doors and Grubbis boss state
- Deadmines missing doors
- Stratholme gameobjects state saved

* forgot emi blastfuse change to despawn

* Leaving group logic

* codestyle

* fixing merge issues

* prevent bad behaviour

* brain meltdown

* Update data/sql/updates/pending_db_characters/rev_1643629468629316100.sql

* Update data/sql/updates/pending_db_world/rev_1649359139539727000.sql

Co-authored-by: Claudiodfc <54484196+claudiodfc@users.noreply.github.com>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
Co-authored-by: Kargatum <dowlandtop@yandex.com>
Co-authored-by: Skjalf <47818697+Nyeriah@users.noreply.github.com>
2022-05-24 10:33:45 -03:00
Maelthyr
dfc6adb081 refactor(Core/Combat): DeleteThreatLists() become ClearAllThreat() (#11824)
refactor(Chore/Combat): DeleteThreatLists() become ClearAllThreat()
2022-05-23 05:51:52 -03:00
temperrr
b6d79ac89e fix(Script/ZulGurub): Skeletons should appear in pit (#11561) 2022-05-23 05:47:30 -03:00
Maelthyr
c5368816fa Core/Combat: rename getThreatMgr() to GetThreatMgr() (#11758) 2022-05-18 05:36:57 -03:00
Maelthyr
5ede1177c5 refactor(Core/Combat): implement compatiblity layer for ResetAllThreat() (#11778)
* implement ResetAllThreat()

* .
2022-05-17 12:01:25 -03:00
Malcrom
aab3348e65 Fix(Script/SAI/Misc) Eversong Partygoers (#11786)
* Fix(Script/SAI/Misc) Eversong Partygoers

* Update zone_eversong_woods.cpp
2022-05-16 21:36:21 -03:00
acidmanifesto
06a62538cf fix (core\crash): fix client crash dk starter (#11726)
* fix (core\crash): fix client crash dk starter

Fixing it again. Something regressed.

* adjust timer and text playing

* improved timing

* Update chapter1.cpp
2022-05-13 13:00:59 -04:00
UltraNix
203450e949 fix(Scripts/BlackwingLair): Warrior Class Call should not restore to default stance on removal. (#11671) 2022-05-10 22:54:11 -03:00
Skjalf
12a0c6f1bc fix(Scripts/BlackwingLair): Prevent Chromaggus from hostilizing playe… (#11595)
* fix(Scripts/BlackwingLair): Prevent Chromaggus from hostilizing players in the floor underneath

* Update src/server/scripts/EasternKingdoms/BlackrockMountain/BlackwingLair/boss_chromaggus.cpp

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* Update src/server/scripts/EasternKingdoms/BlackrockMountain/BlackwingLair/boss_chromaggus.cpp

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2022-05-03 07:18:45 -03:00
Skjalf
3c851c059a fix(Scripts/BlackwingLair): Prevent Chromaggus cage from looking (#11603) 2022-05-03 07:10:09 -03:00
Maelthyr
0363b95919 fix(Script/ZulGurub): High Priestess Jeklik improvements (#11458) 2022-05-02 21:02:40 -03:00