Commit Graph

2409 Commits

Author SHA1 Message Date
Yunfan Li
d879fc9258 Merge branch 'master' into Playerbot 2023-10-27 20:12:09 +08:00
AG
79b39f9655 fix(Core/Grid): Implement missing GridUnload setting (#17569)
* Implement GridUnload setting

* Minor fixes

- Use GetOption instead of deprecated GetBoolDefault.
- Added a missing check for instances in LoadMap
- Replaced some numbers with global defines

* Possible crashfix + minor improvements

- Initialized initialOrientation which I had forgotten (likely cause of crash)
- Readded a previous check in UpdateSplineMovement
- Made i_objectsToRemove and i_worldObjects tos sets as they were previously, instead of unordered_set.

* Update worldserver.conf.dist

* Fix high CPU usage with preload grid enabled.

This should be it.
2023-10-26 19:32:15 -03:00
AG
60e27511c5 fix(Core/Grid): Address bugs and performance issues introduced by visibility notifier implementation (#17480)
* Bug fixes

- Corrected std::chrono from seconds to milliseconds
- Got rid of leftover code that caused objects to not show up on time

* Removed logic to set gameobject as active

- More alignement with TC.
- Reduces CPU usage drastically

* Revert back to using time_t instead of std chrono

* Invoke SetNoCreate() method to reduce CPU usage drastically

* Remove setActive from static and motion transports

* Fix performance issues

* Added SetFarVisible to WG and some dungeon scripts

- Also removed setActive(true) from creatures in Wintergrasp. As for gameobjects they are set to active upon being damaged/destroyed and removed from active on rebuild (reset)

* Removed comments related to VISIBILITY_COMPENSATION

* Fix log

* Deleted unused files + corrected a check

* Added missing header

* Removed unused parameter

* Removed another unsued parameter

* Changed vector to set for i_visibleNow

- Changed vector to set for i_visibleNow in VisibleNotifer
- Adjusted HaveAtClient to accept Object*
- Adjusted SendUpdateToPlayer to send createobject packet only if not known to client
2023-10-23 05:37:11 -03:00
Andrew
9935e72341 feat(Core/Unit): Implement OnPowerUpdate() unit script hook (#17560) 2023-10-22 09:14:41 -03:00
Yunfan Li
57e0c7a09f Merge branch 'master' of github.com:azerothcore/azerothcore-wotlk into Playerbot 2023-10-22 19:52:23 +08:00
pvp100
4962972eec fix(Core/BG): Relocate cannon in WG (#16673)
* fix(DB/Gameobject): fix towercanno error location in Flamewatch Tower

adjusted wintergrasp towercanno position

* Update src/server/game/Battlefield/Zones/BattlefieldWG.h

Co-authored-by: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>

---------

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
Co-authored-by: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>
2023-10-22 04:47:13 +02:00
Alyst3r
2e55cad450 refactor(DB/reputation_spillover_template): Reputation spillover table expansion (#14763)
* Update ObjectMgr.cpp

Rework to `ObjectMgr::LoadReputationSpilloverTemplate()` allowing more factons to be added.

* Create reputation_spillover_template-update.sql

Alteration to `reputation_spillover_template` table, update allowing to add two more factions.

* Update SharedDefines.h

`MAX_SPILLOVER_FACTIONS` is now equal 6 instead of 4.

* Update reputation_spillover_template-update.sql

Now it alters table instead recreating it.
2023-10-22 04:45:50 +02:00
avarishd
8c8d459c6f fix(Core/Spells): Marked for Death affecting wrong spells. (#17406) 2023-10-21 10:28:57 -03:00
Angelo Venturini
fb8e343677 fix(Core/Arena): Fix logging scores in db (#17504) 2023-10-21 08:12:22 -03:00
Hasn
5bf64a164a fix(Core/Player) Stop small durability loss from still occuring when DurabilityLoss options in worldserver.conf are set to 0 (#17407)
Fix durability loss even when "DurabilityLoss"-settings in
worldserver.conf are zeroed
2023-10-21 08:10:34 -03:00
avarishd
894732f11e fix(Scripts/EscortAI): Do not remove auras on evade (#17542) 2023-10-20 20:49:17 -03:00
avarishd
359985dd4c feat(Core/Conditions): Add GoState condition for near gameobject. (#17524)
* feat(Core/Conditions): Add GoState check for near gameobject.

* log_error

* Update ConditionMgr.h
2023-10-20 19:41:26 -03:00
Kitzunu
ec724cda89 chore(Core/Conf): Remove unused config (#17544) 2023-10-20 15:26:07 +02:00
Ludwig
de6ece2462 fix(Core/Spells): interrupt midsummer ribbonpole dance on mount or sp… (#17442)
fix(Core/Spells): interrupt midsummer ribbonpole dance on mount or spell cast
2023-10-19 21:40:08 -03:00
avarishd
a39175bc3b fix(Core/Spells): Demonic Knowledge missing 1% per rank (#17495) 2023-10-18 19:21:46 -03:00
Yunfan Li
a5e27362d8 Merge commit '26c583c24ab7dbbf1fecf3dcd737c1ad543c8b33' into Playerbot_1017 2023-10-17 22:18:39 +08:00
KJack
99bf49e0dd Fix (core/SpellEffects): Don't randomize summoned guardian position if target is in the DB (#17506)
* Doesn't randomize placement of guardian summons if the target position was specified in the DB

* Add `HasRadius()` check

* Add check for zero-radius effects, update IF condition style

* Accept IF condition statement suggestion

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

---------

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2023-10-17 00:07:47 +02:00
avarishd
2cd4af9446 fix(Core/Spells): Allow casting ground mounts in water (#17481)
https: //github.com/TrinityCore/TrinityCore/pull/17488

Co-authored-by: SnapperRy <19622383+SnapperRy@users.noreply.github.com>
2023-10-10 20:23:45 -03:00
avarishd
43be5db44c fix(Core/ChatHandler): SPELL_AURA_MOD_LANGUAGE should affect only Say… (#17465)
fix(Core/ChatHandler): SPELL_AURA_MOD_LANGUAGE should affect only Say and Yell
2023-10-10 10:15:48 -03:00
Hasn
e644dd949f feat(Core/Scripting): Implement hook OnAfterCalculateLootGroupAmount() (#17456)
Add hook 'OnAfterCalculateLootGroupAmount' to GlobalScript, similar to existing hook 'OnAfterRefCount'. Allows for dynamic modification of the group loot rate
2023-10-08 17:18:44 -03:00
KJack
f127e583aa fix(core/scripting) Calculate percent-based damage before ModifyPeriodicDamageAurasTick hook (#17387)
Moved damage calculation for `SPELL_AURA_PERIODIC_DAMAGE_PERCENT` to before the hook.

Co-authored-by: KJack <kjack@electricnightowl.com>
2023-10-08 15:38:07 -03:00
Kitzunu
2255f492b5 fix(Core/Creature): Update movement in UpdateEntry() (#17291)
* fix(Core/Creature): Update movement in UpdateEntry()

* Update Creature.cpp

* Update Creature.cpp

* hover

* just replace with updatemovememntflags

* Update Creature.cpp

* Update Creature.cpp

---------

Co-authored-by: Skjalf <47818697+Nyeriah@users.noreply.github.com>
2023-10-08 10:49:17 -03:00
avarishd
4e5077ed80 fix(Core/Spells): Script Shaman T8 Elemental 4P Bonus (#17424)
* fix(Core/Spells): Script Shaman T8 Elemental 4P Bonus

* 🧙‍♂️
2023-10-08 09:31:54 -03:00
Kitzunu
b1395b9450 refactor(Core/Creature): Calculate BaseArmor as float (#17448) 2023-10-08 08:56:16 -03:00
Kitzunu
a4e4d6ddb2 feat(Core/Player): Implement commentator tag (#17449)
* feat(Core/Player): Implement commentator tag

* remove redundant session check
2023-10-08 09:07:17 +02:00
Kitzunu
5357a31a01 chore(Core/Misc): warhead -> acore (#17447) 2023-10-08 09:06:57 +02:00
IntelligentQuantum
90b16ca065 fix(Core): GridCleanUpDelay Log (#17436)
Update World.cpp
2023-10-07 07:36:11 -03:00
avarishd
91c6bdd540 fix(Core/Spells): Script Lord Valthalak's Amulet (#17431)
* fix(Core/Spells): Script Lord Valthalak's Amulet

* cs
2023-10-07 07:34:35 -03:00
Andrew
2873736145 feat(Core/Player): Move SaveSkills() to the public scope (#17418) 2023-10-05 03:38:10 -03:00
KJack
a23d5ee50d feat(Core/Scripting): Implement OnBeforeCreatureSelectLevel() hook (#17391)
* Add `OnBeforeCreatureSelectLevel()` hook
- allows modules to alter the level of a creature just before it is set

* Fix missing class name.

* Hook should catch even if the level isn't being changed.

* Trim whitespace.

* Revert "Trim whitespace."

This reverts commit 76768d85c0b9878828b71a008e709c1df7ddadc5.

* Fix whitespace
2023-10-01 02:25:06 -03:00
Skjalf
7de2405604 fix(Scripts/Karazhan): Several Aran fixes (#17394)
- Fix drinking being interrupted by dots
- Fix first super timer
- Fix missing Arcane Explosion emote
- Fix supers being locked by spell interrupt
- Correct drinking to 10% mana down from 20%
2023-09-30 22:13:49 -03:00
KJack
c25d0b38e8 feat(Core/GameObject): Implement OnGameObjectModifyHealth() hook (#17374) 2023-09-28 22:39:57 +02:00
AG
2779833768 feat(Core/Grids): Implement visibility notifier (#15919)
* Cherry-picked from TrinityCore (unable to find author)
2023-09-28 22:28:28 +02:00
Sven Bledt
b80aaebb5a fix(Core/Quest): AllowableRaces to uint32 for custom Racemasks (#17372)
* fix(Core/Quest): AllowableRaces to uint32 for custom Racemasks

* Update data/sql/updates/pending_db_world/uint32_quest_template.sql

* ready for merge

---------

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2023-09-27 22:05:28 +02:00
Skjalf
ae99ce586a fix(Scripts/Karazhan): Fix Aran combat movement behavior (#17359)
* fix(Scripts/Karazhan): Fix Aran combat movement behavior

* Update SmartScript.cpp
2023-09-26 18:27:23 -03:00
Skjalf
a8e514ea39 fix(Core/Unit): Threat from energize effects should be proportional t… (#17352)
fix(Core/Unit): Threat from energize effects should be proportional to the amount of power gained
2023-09-26 17:30:35 -03:00
Kitzunu
2d3e9a8f23 fix(Player/Achievement): fix crash (#17357)
* closes https://github.com/azerothcore/azerothcore-wotlk/issues/17330
2023-09-25 21:01:19 +02:00
Skjalf
14ed5860e1 fix(Core/Spells): Correct swapped TARGET_UNIT_NEARBY_ALLY and TARGET_… (#17339)
fix(Core/Spells): Correct swapped TARGET_UNIT_NEARBY_ALLY and TARGET_UNIT_NEARBY_PARTY

(cherry picked from commit 7c6d92012a )
Co-Authored-By: xvwyh <43143822+xvwyh@users.noreply.github.com>
2023-09-25 08:33:23 -03:00
Skjalf
c7b7b7dc07 fix(Scripts/Spells): Fix Glyph of Voidwalker applying to every pet (#17342)
* fix(Scripts/Spells): Fix Glyph of Voidwalker applying to every pet

* Update src/server/game/Entities/Pet/Pet.cpp
2023-09-25 08:07:09 -03:00
Skjalf
4a0b879ee3 fix(Scripts/Karazhan): Fix Shade of Aran Blizzard and use proper spel… (#17329)
* fix(Scripts/Karazhan): Fix Shade of Aran Blizzard and use proper spells to summon elementals

* Update boss_shade_of_aran.cpp

* Update boss_shade_of_aran.cpp

* Update rev_1695546719351253200.sql

* missing sql
2023-09-25 06:41:21 -03:00
Skjalf
84d4d60cfc fix(Scripts/Karazhan): Fix Julliane awarding no loot (#17334)
* fix(Scripts/Karazhan): Fix Julliene awarding no loot

* Update bosses_opera.cpp
2023-09-25 06:38:01 -03:00
Skjalf
cc60bc0c35 fix(Scripts/Spells): Fix Healing & Mana injectors not giving bonus to… (#17348)
* fix(Scripts/Spells): Fix Healing & Mana injectors not giving bonus to engineers

* Update SpellEffects.cpp

* Update spell_item.cpp
2023-09-25 06:10:23 -03:00
Grimgravy
6990a1d2a4 fix(Scripts/Quest): improve Catch the Wild Wolpertinger! (#17333) 2023-09-24 16:23:58 -03:00
Mickaël Mauger
1a84ab6983 fix(Core/Unit): Fix CanSwim method not accurate for players (#17320) 2023-09-23 20:49:20 +02:00
Yunfan Li
2dd1490c18 Merge branch 'master' of github.com:azerothcore/azerothcore-wotlk into Playerbot 2023-09-23 22:44:15 +08:00
Ludwig
fcd58da08c fix(Core/Achievement): Implement ACHIEVEMENT_CRITERIA_TYPE_COMPLETE_RAID (#17316) 2023-09-22 00:54:08 +02:00
Ludwig
056ea323f3 fix(Core/Achievement): Implement ACHIEVEMENT_CRITERIA_TYPE_ROLL_DISENCHANT (#17319) 2023-09-22 00:50:39 +02:00
Ludwig
f633eb8592 fix(Core/Achivement): Implement ACHIEVEMENT_FLAG_AVERAGE (#17263) 2023-09-21 18:56:28 +02:00
Stefano Borzì
168192b731 fix(CI): cppcheck failure step (#17240)
* feat: add cppcheck for scripts

* fix: cppcheck step failure

* trigger cppcheck build, it should fail

* fix: cppcheck should succeed

* fix: cppcheck
2023-09-21 12:43:57 +02:00
AG
540eda2af9 fix(Core/Unit): Added bluewall AoE check (#17064)
* Added bluewall AoE check

- AoE spells/abilities done by non-flagged players now has no effect on pvp flagged players.

* Crash fix

* Update Unit.cpp

Allow spells with flag "SPELL_ATTR5_IGNORE_AREA_EFFECT_PVP_CHECK" to pass this check.
2023-09-20 22:48:23 +02:00