Benjamin Jackson
d6d49a9e45
refactor(Core/ObjectMgr): Implement display probabilities. ( #19068 )
...
* Init.
Cherry-picked from TC commits 9d210476e5 and c488fb219a
Co-Authored-By: Traesh <9392905+traesh@users.noreply.github.com >
Co-Authored-By: Shauren <shauren.trinity@gmail.com >
* Add brute data.
Needs validation against what existed before, i.e. Classic change prevention.
* Add validation info for brute data.
* Remove incomplete data queries.
* Requested changes.
* Whitespace.
* Requested change.
Table name.
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
* Requested change.
Table name.
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
* Resolve the funny merge conflicts.
I wonder why git blame doesn't work on a file with 20k lines in it that's odd huh champ.
* Remove unused parameter.
* Remove uses of unused parameter.
* Use unused parameter.
Hopefully?
* I will cry.
* Sobbing endlessly.
* Remove comment.
* Adjust table structure query.
Remove length parameters and allow null for build value.
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
* Adjust column datatype and add check constraint.
---------
Co-authored-by: Traesh <9392905+traesh@users.noreply.github.com >
Co-authored-by: Shauren <shauren.trinity@gmail.com >
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
2024-06-16 18:12:16 +02:00
Anton Popovichenko
1f640c9872
feat(Core/Optimization): Optimize build of units update object by leveraging cache ( #18637 )
...
* feat(Core/Optimization): Optimize build of units update object by leveraging cache.
* Remove whitespaces.
* Add alternative hooks to handle transmog and other similar things.
* Fix build on some compilers.
* Fix codestyle
* Fix build again.
* Take into account updateType.
2024-04-05 08:03:11 +02:00
Nathan Handley
df33a57b78
feat(Core/Unit): New helper IsClass and script hook OnPlayerIsClass ( #18243 )
...
* Class Comparison Logic Encapsulation - Parity
* Add Context to IsClass
* Add Unit IsClass script hook
* Replace additional getClass with IsClass
* Update CanUseItem to replace getClass with IsClass
* Add separate context for pet vs ability
* Change Create to Init since not all referenced contexts are creation
* Align spacing in ClassContext
* Drop context on LFGManager max power
* Update IsClass context that wraps around Missle Barrage
* Rename context for swapping weapons
* Be more specific than CLASS_CONTEXT_TALENT
* Remove duplicate context
* Moved IsClass Hook to Player
* Removed unused parameter in virtual base function
* Added maybe_unused to IsClass virtual in order to compile
To match the override signature, the virtual base needs to include the parameter in question, so using [maybe_unused] to signal to the compiler to allow it
* Remove extra blank line
* Add ABILITY_REACTIVE context
* Add context for PET_CHARM
* Remove explicit nullopt check per review
* Code Readability - Change if to if else in pet
Due to the return pattern, this doesn't change functionality in any way
* Add OnPlayer to disambiguate
---------
Co-authored-by: NathanHandley <nathanhandley@protonmail.com >
2024-02-10 12:25:00 -03:00
Nathan Handley
425a490a7b
feat(Core/Unit): New helper HasActivePowerType and script hook OnPlayerHasActivePowerType ( #18293 )
...
* Create HasActivePower for script intercept
* Replace relevant player-related getPowerType() comparators with HasActivePowerType
* Change OnPlayerHasActivePowerType to regular bool instead of optional
---------
Co-authored-by: NathanHandley <nathanhandley@protonmail.com >
2024-02-09 06:27:02 -03:00
Alethrion
b2fcc1babf
fix(Core/Unit): Remove delay for Conflagrate aura state ( #18068 )
...
Removes ConflagrateAuraStateDelayEvent
Cherry-picked from: e27c385b48
Co-authored-by: Ariel Silva <ariel-@users.noreply.github.com >
2024-01-01 07:59:23 -03:00
Winfidonarleyan
eb1ecc38a5
feat(Core/Scripting): move all script objects to separated files ( #17860 )
...
* feat(Core/Scripts): move all script objects to separated files
* Apply 5bfeabde81
* try gcc build
* again
2023-12-02 21:13:20 +01:00
Winfidonarleyan
e90d7a2f92
chore(Core/Misc): sort includes ( #17776 )
...
* chore(Cleanup): sort includes
* fix build
* fix build again
2023-11-18 17:51:26 +01:00
Andrew
5a4fdc7de4
fix(Core/Spells): Banish should only be dispelled by Mass Dispel ( #17703 )
...
* fix(Core/Spells): Banish should only be dispelled by Mass Dispel
* Update Unit.cpp
* Update Unit.cpp
2023-11-14 16:27:37 +01:00
Kitzunu
bbadc32bea
Revert Visibility Notifier changes ( #17682 )
...
* Revert "fix(Core/Grid): Implement missing GridUnload setting (#17569 )"
This reverts commit 79b39f9655 .
* Revert "fix(Core/Grid): Address bugs and performance issues introduced by visibility notifier implementation (#17480 )"
This reverts commit 60e27511c5 .
* Revert "fix(Core): GridCleanUpDelay Log (#17436 )"
This reverts commit 90b16ca065 .
* Revert "feat(Core/Grids): Implement visibility notifier (#15919 )"
This reverts commit 2779833768 .
2023-11-12 00:48:49 +01:00
Ludwig
ef09d4b63f
fix(Core/Unit): Implement GetDisplayRace() ( #17609 )
2023-11-08 19:19:38 +01:00
Kitzunu
f757e93da5
refactor(Core/Misc): Make DeathState enum class ( #17607 )
2023-10-28 10:54:03 +02:00
AG
60e27511c5
fix(Core/Grid): Address bugs and performance issues introduced by visibility notifier implementation ( #17480 )
...
* Bug fixes
- Corrected std::chrono from seconds to milliseconds
- Got rid of leftover code that caused objects to not show up on time
* Removed logic to set gameobject as active
- More alignement with TC.
- Reduces CPU usage drastically
* Revert back to using time_t instead of std chrono
* Invoke SetNoCreate() method to reduce CPU usage drastically
* Remove setActive from static and motion transports
* Fix performance issues
* Added SetFarVisible to WG and some dungeon scripts
- Also removed setActive(true) from creatures in Wintergrasp. As for gameobjects they are set to active upon being damaged/destroyed and removed from active on rebuild (reset)
* Removed comments related to VISIBILITY_COMPENSATION
* Fix log
* Deleted unused files + corrected a check
* Added missing header
* Removed unused parameter
* Removed another unsued parameter
* Changed vector to set for i_visibleNow
- Changed vector to set for i_visibleNow in VisibleNotifer
- Adjusted HaveAtClient to accept Object*
- Adjusted SendUpdateToPlayer to send createobject packet only if not known to client
2023-10-23 05:37:11 -03:00
AG
2779833768
feat(Core/Grids): Implement visibility notifier ( #15919 )
...
* Cherry-picked from TrinityCore (unable to find author)
2023-09-28 22:28:28 +02:00
Gultask
64c7c99bda
revert(Core/Player): Revert Delayed Damage System ( #16246 )
...
* Revert "fix(Core/Spells): Delayed Damage system (#16183 )"
This reverts commit d282cce4af .
* Revert "fix: Crash on ProcessDelayedDamages (#16166 )"
This reverts commit 3dbdea5e28 .
* Revert "fix(core\player): Missing combat animation (#14199 )"
This reverts commit a238e5e27b .
2023-05-13 13:50:27 -03:00
Angelo Venturini
d282cce4af
fix(Core/Spells): Delayed Damage system ( #16183 )
2023-05-07 08:58:38 -03:00
M'Dic
7e58650cf5
revert(Core): ChrRace.dbc full implementation ( #16114 )
...
* revert (core): ChrRace.dbc full implementation
we revert this due to several issues arrising. Although the dbc reading is done in full and correctly. Azerothcore relied on the original handling (althought not propper) for so long that there is
* revert
* Update remove_charrace_dbc.sql
* Update remove_charrace_dbc.sql
* Update remove_charrace_dbc.sql
2023-04-29 08:23:11 -03:00
M'Dic
a238e5e27b
fix(core\player): Missing combat animation ( #14199 )
2023-04-29 12:27:13 +02:00
M'Dic
3eae4c5713
fix(core/dbc): improve ChrRace DBC handling ( #14843 )
...
Cherry pick of https://github.com/TrinityCore/TrinityCore/pull/24508
Co-authored-by: HelloKitty <5829095+HelloKitty@users.noreply.github.com >
2023-04-28 01:29:33 +02:00
UltraNix
1acbb9ee53
fix(Core/Spells): Fixed Spiritual Attunement not working with partial… ( #15767 )
...
fix(Core/Spells): Fixed Spiritual Attunement not working with partial overheals.
Fixes #14430
2023-04-02 10:13:16 -03:00
UltraNix
b21f98d639
fix(Scripts/Karazhan): Chess Event. ( #14736 )
2023-03-15 00:07:49 -03:00
Maelthyr
0200a288cd
refactor(Scripts/Northrend): conversion to std::chrono ( #15269 )
...
Co-authored-by: Maelthyrr <maelthyrr@users.noreply.github.com >
2023-03-07 09:23:33 -03:00
Kitzunu
f039836a2f
chore(Core/Misc): Change all TODO to doxygen comment ( #14966 )
2023-02-12 10:05:34 -03:00
Skjalf
2aeeee9c83
fix(Core/Spells): Remove all hardcoded restrictions for pick pocket sp… ( #14788 )
...
Co-authored-by: Shauren <shauren.trinity@gmail.com >
2023-01-29 12:12:21 -03:00
Skjalf
b4e3f1310b
feat(Core/Unit): Add KillSelf overload ( #14785 )
...
Co-authored-by: jackpoz <giacomopoz@gmail.com >
2023-01-28 17:57:23 -03:00
UltraNix
9ce8b8cf29
fix(Core/Players): Fixed sending power regen update to nearby players. ( #14043 )
2023-01-28 11:03:56 +01:00
UltraNix
7f7a2f5a92
fix(Core/Creatures): Critters should start fleeing upon entering comb… ( #14253 )
2023-01-28 11:01:43 +01:00
Gultask
6b4ef50e7a
Revert "fix(Core/Spells): Ignite and Revitalize should not prelong co… ( #14513 )
...
Revert "fix(Core/Spells): Ignite and Revitalize should not prelong combat. (#13812 )"
This reverts commit 96fa9c5c7b .
2023-01-05 23:14:56 -03:00
UltraNix
96fa9c5c7b
fix(Core/Spells): Ignite and Revitalize should not prelong combat. ( #13812 )
...
Fixes #13330
2023-01-06 00:50:53 +01:00
Angelo Venturini
9e18b86311
fix(Core/Auras): SPELL_AURA_MOD_SCALE should scale additively instead… ( #14425 )
...
...multiplicatively
Co-authored-by: Shauren <shauren.trinity@gmail.com >
2023-01-02 20:43:20 -03:00
Kitzunu
4870b14b1f
refactor(Core/Object): getLevel() -> GetLevel() ( #14122 )
...
* refactor(Core/Object): getLevel() -> GetLevel()
* fix build and sneak some doxygen in
* codeSTLE
* codestyle
2022-12-31 17:39:23 +01:00
Angelo Venturini
4992940453
fix(Core/Auras): Implement Roc form ( #13959 )
...
Co-authored-by: Ariel Silva <ariel-@users.noreply.github.com >
Co-authored-by: Ariel Silva <ariel-@users.noreply.github.com >
2022-12-11 10:58:20 -03:00
Skjalf
19fa22ba92
Revert "refactor(Core/Movement): Naming convention" ( #14100 )
...
Revert "refactor(Core/Movement): Naming convention (#13989 )"
This reverts commit d2f440c3e8 .
2022-12-11 03:53:09 +01:00
Maelthyr
d2f440c3e8
refactor(Core/Movement): Naming convention ( #13989 )
...
update codestyle
Co-authored-by: Maelthyrr <lynethris@protonmail.ch >
2022-12-02 05:52:01 -03:00
Skjalf
bb9e80ded1
fix(Core/Unit): Exclude Sword Specialization and Hack and Slash from … ( #13706 )
...
* fix(Core/Unit): Exclude Sword Specialization and Hack and Slash from the extra attack range check
* fix logic
2022-11-05 15:04:02 -03:00
UltraNix
eb3f80ceff
fix(Core/Spells): Implemented SPELL_HIT_TYPE_SPLIT hit type. Source: … ( #13518 )
...
fix(Core/Spells): Implemented SPELL_HIT_TYPE_SPLIT hit type. Source: TrinityCore.
Fixes #13306
2022-10-29 07:13:36 -03:00
UltraNix
e390087efd
feat(Core/Items): Implemented elemental weapon damage. Source: Trinit… ( #13050 )
...
...yCore.
2022-10-08 14:34:52 -03:00
Angelo Venturini
ad4ce0895f
fix: Qaston revert ( #13320 )
...
* Revert "fix(Core/QAston): fixed shields oneshotting (#13271 )"
This reverts commit e05f61d1b3 .
* Revert "fix(Core): Crash (#13292 )"
This reverts commit a818bcf3e2 .
* Revert "fix: Crash (#13241 )"
This reverts commit be423a91b5 .
* delete sql
* Revert "refactor(Core/Spells): Implement QAston Proc System (#11079 )"
This reverts commit cbd3fd0967 .
* add sql revert
* fix sql
* remove update from world.updates
2022-10-05 21:53:20 +02:00
Angelo Venturini
e05f61d1b3
fix(Core/QAston): fixed shields oneshotting ( #13271 )
...
* fix(Core/QAston): fixed shields oneshotting
* fix build
2022-10-04 19:37:48 +02:00
IntelligentQuantum
cbd3fd0967
refactor(Core/Spells): Implement QAston Proc System ( #11079 )
...
* .
* sql
* .
* .
* 1
* 2
* 3
* 4
* 5
* 6
* 7
* 8
* 9
* 10
* 11
* 12
* 13
* 14
* 15
* Update spell_item.cpp
* Update Unit.cpp
* 16
* 17
* 18
* 19
* 20
* 21
* Update Unit.cpp
* REVERT UltraNIX Commit
* 22
* 23
* .
* .
* .
* warrior
* warlock
* shaman rogue priest paladin mage
* spell item
* hunter
* druid
* dk
* war
* error style
* Update rev_1647677899565690722.sql
* Update rev_1647677899565690722.sql
* Update rev_1647677899565690722.sql
* .
* DOND DEL ME WAD DO DO
* error 2
* .
* .
* .
* FIX
* Update SpellInfoCorrections.cpp
* Update SpellInfoCorrections.cpp
* .
* ja genau
* Update .gitignore
* .
* .
* .,
* .
* .
* .
* .
* Update Unit.cpp
2022-10-02 19:39:34 +02:00
UltraNix
a5ab96c79d
fix(Scripts/Spells): Finger of Frost Shatter Combo. ( #13006 )
2022-09-19 00:46:17 -03:00
ZhengPeiRu21
1ddd884d6a
feat(Core): Implement SP Bonus Coefficients from DBC ( #12562 )
...
* cherry-pick commit (1826437c09 )
* Co-authored by: ariel- <ariel-@users.noreply.github.com >
* feat(Core): Implement SP Bonus Coefficients from DBC
* Several coefficient corrections
* Fix spell_dru_lifebloom
2022-09-17 11:09:04 +02:00
Angelo Venturini
fa825ec419
fix(Core/TempleOfAhnQiraj): Twin emperors rewrite ( #12855 )
2022-09-06 21:33:51 -03:00
Maelthyr
d0d1671745
feat(Core/Debug): GetDebugInfo implementation ( #12705 )
...
Cherry-pick: 9a924fb9d5
Co-authored-by: jackpoz <giacomopoz@gmail.com >
Co-authored-by: jackpoz <giacomopoz@gmail.com >
2022-08-15 09:43:41 -03:00
UltraNix
22494532ce
fix(Core/Spells): Fixed Druid T3 8P bonus. ( #12598 )
2022-08-05 21:33:59 -03:00
Nefertumm
c806c62c62
fix(Core/Spells): Crashfix ( #12609 )
2022-08-03 09:05:24 -03:00
UltraNix
346150c92a
fix(Scripts/ZulGurub): Hakkar's Blood Siphon ( #12196 )
2022-07-09 11:05:09 -03:00
UltraNix
ea24a7b231
fix(Scripts/ZulGurub): Mandokir's Threatening Gaze. ( #12095 )
...
* fix(Scripts/ZulGurub: Mandokir's Threatening Gaze.
Boss can melee attack while casting.
Boss charges after the debuff run out.
Guillotine is casted on hit rather than on launch.
Properly coded Threatening Gaze Charge (with dot/hot exceptions)
Whirlwind is removed during charge.
Fixes #11748
* Update
* missing
* Update
* Update.
* Update.
* Update.
* Update.
* Update.
2022-06-26 04:50:50 -03:00
Maelthyr
d928d8d96a
refactor(Core/Unit): PC&NPC Immunity ( #11986 )
...
* initial
* refactor(Core/Unit): PC & NPC Immunities
Cherry-pick TC: 74af880217
Co-authored-by: Treeston <treeston.nmoc@gmail.com >
* fix builds error
Cherry-pick TC: 74af880217
Co-authored-by: Treeston <treeston.nmoc@gmail.com >
* Fix nef combat, and replace SetFlag by SetUnitFlag
* fix combat with jedoga
Co-authored-by: Treeston <treeston.nmoc@gmail.com >
2022-06-18 08:16:45 -04:00
UltraNix
daff1239d3
fix(Core/Units): Fixed restoring running movement flag after charm. Source: TrinityCore ( #12019 )
...
fix(Core/Units): Fixed restoring running movement flag after charm.
Fixes #12018
2022-06-16 08:45:46 -03:00
Maelthyr
32334f5f14
refactor(Core/Unit): minor changes for the combat system ( #11904 )
...
Cherry-pick from TC: https://github.com/TrinityCore/TrinityCore/pull/19966
Co-authored-by: Treeston <treeston.nmoc@gmail.com >
2022-06-13 19:40:29 -03:00