Commit Graph

457 Commits

Author SHA1 Message Date
Skjalf
ca95b4a129 fix(Scripts/Karazhan): Fix Enfeeble hitting more than 5 targets (#17290)
* fix(Scripts/Karazhan): Fix Enfeeble hitting more than 5 targets

* reorder so there are no cases where only 4 players are hit

* missing override
2023-09-17 16:32:06 -03:00
Dan
52744e6032 fix(Scripts/Karazhan): Shade of Aran now no longer casts spells whilst he should be drinking (#17282)
* initial

* remove redundancy

* remove method

* space gone

* indentación
2023-09-17 11:50:21 -03:00
Tereneckla
1eb573be1c fix(Scripts/Karazhan): Curator fixes (#17270)
* stop channeling on enrage

* Create rev_1694861198470600600.sql

* Update boss_curator.cpp

* Update src/server/scripts/EasternKingdoms/Karazhan/boss_curator.cpp

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

---------

Co-authored-by: Angelo Venturini <nefertum.dev@protonmail.com>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2023-09-17 10:26:26 -03:00
Dan
d15d72c812 fix(Scripts/BlackwingLair): Orb of Domination can no longer be used when you are controlling a pet (#16880)
initial
2023-09-17 07:50:43 -03:00
Dan
9b438731fd fix(Scripts/Karazhan): remove redundant spellcasting check on Netherspite to ensure he moves back to phase 1 (#17269)
initial
2023-09-17 07:38:53 -03:00
Dan
d18368ad60 fix(Scripts/Karazhan): decrease Aran cast cooldown on normal spells (#17260)
initial
2023-09-15 05:57:53 -03:00
Skjalf
44d1df01c3 fix(Scripts/Karazhan): Should always be able to talk to chess pieces … (#17246)
fix(Scripts/Karazhan): Should always be able to talk to chess pieces regardless of faction
2023-09-14 01:10:36 -03:00
Dan
a469cb5956 fix(Scripts/Karazhan): Malchezaar infernals now spawn in the correct locations under the right conditions (#17237)
* initial
test

Co-authored-by: <100873791+Gultask@users.noreply.github.com>

* change spawnMask

* better failsafe

* get list once

* extend search range for relays

* put infernal spawn in separate method for

readability

* add more methods

* remove leftover method

* dumb and dumber mistakes
2023-09-13 20:58:19 -03:00
Skjalf
0c90bfcf70 fix(Scripts/Karazhan): Remove redundant Garrote cast and despawn gues… (#17152)
fix(Scripts/Karazhan): Remove redundant Garrote cast and despawn guests on evade
2023-09-04 21:15:18 -03:00
Skjalf
cdc06e1703 fix(Scripts/Karazhan): Remove hacked knockback effect from Aran Flame… (#17174)
fix(Scripts/Karazhan): Remove hacked knockback effect from Aran Flame Wreath
2023-09-04 21:15:03 -03:00
Skjalf
5abfbdff42 fix(Scripts/Karazhan): Fix Nightbane health phase percentages (#17173)
* fix(Scripts/Karazhan): Fix Nightbane health phase percentages

* Update boss_nightbane.cpp
2023-09-04 21:11:58 -03:00
Dan
cacb32f423 fix(Scripts/Karazhan): change to right gossip menu for Barnes (#17151)
* initial

* make sense of ids
2023-09-03 09:44:43 -03:00
Dan
4886dac963 fix(Scripts/Karazhan): make it so door closes when Big Bad Wolf is engaged in Little Red Riding Hood in the Opera (#17172)
* initial

* not a boolean
2023-09-03 09:44:13 -03:00
Skjalf
4ce43d3f1f fix(Scripts/Karazhan): Maiden of Virtue repentance should have a cast… (#17153)
fix(Scripts/Karazhan): Maiden of Virtue repentance should have a cast time
2023-09-03 09:43:16 -03:00
Dan
6ff5f3811e fix(Scripts/Karazhan): fix gossip from the Grandmother in the Big Bad Wolf fight (#17155)
* initial

* switch is better

* add correct menu ids cmangos cherrypick

...

Co-authored-by:  <7995382+killerwife@users.noreply.github.com>

* remove sql
2023-09-02 18:51:28 -03:00
Dan
3ce2627c05 fix(Scripts/Karazhan): allow Moroes and adds to reset when an add is pulled out of the room (#17072)
* initial

* doforallsummons

* error fix
2023-08-27 16:08:34 -03:00
Anton Popovichenko
f4658a1df2 fix(Core/Scripts): Fix scripts where LoadObjectData can leave arrays boundaries. (#17070)
* fix(Core/Scripts): Fix scripts where LoadObjectData can leave arrays boundaries.

* Fix build
2023-08-25 09:15:07 -03:00
Dan
2aee8bb1c3 fix(Scripts/Karazhan): allow sequence of releases to continue even if Dorothee dies early (#17077)
* initial
initial

Co-authored-by: danqu <3050620+danqu@users.noreply.github.com>

* some changes because reset dun work

* oops

* fixes hopefully

* debug

* more debug

* bruh

* cleanup

---------

Co-authored-by: danqu <3050620+danqu@users.noreply.github.com>
2023-08-25 09:06:30 -03:00
Skjalf
49c2eabea1 fix(Scripts/Karazhan): Fix Servant Quarters rares not spawning (#17001)
* fix(Scripts/Karazhan): Fix Servant Quarters rares not spawning

* Update rev_1691944209332122100.sql
2023-08-13 13:51:43 -03:00
Skjalf
211ceecc32 chore(Scripts/Karazhan): Clean up Maiden of Virtue script (#16977) 2023-08-12 00:14:47 +02:00
Tung Bui (Leo)
da8ebbae0b fix(Scripts/UBRS): typo in Blackrock Spire instance (#16976)
* fix(spells/scripts): typo in Blackrock Spire instance

* fix(spells/scripts): typo in Blackrock Spire instance - usage
2023-08-10 23:13:45 -03:00
Dan
310b143008 chore(Scripts/Karazhan): rework Opera scripts using TaskScheduler (#16688)
* initial

* removing guids/using creature instance data

* move summontito

* add data for oz adds

* removal of unused stuff + removal of if condition
that makes it get stuck

* fix

* fix and add validators

* some fixes and validators

* attempt to reset

* fix talk + change flags

* debug to see where it is going wrong

* handle despawn on all

* cleanup

* codestyle

* more codestyle

* add tito data + tito despawn

* first steps on romulo and j

* with setdata

* test

* test

* some debug

* no way this was the problem

* add action to resume combat on revive

* leftovers

* remove old check to ensure abilities don't

keep casting. this was preventing the scheduler from updating

* getdata

* camelCase

* restore updatevictim

might make them attack you

* some cleanup

* some cleanup and door

door should now open on wipe

* fix mistake

* fix?

* attempt to fix dead attacking

* fix mistake

* schedule location fix

* fix logic

- Julianne and Romulo now resurrect properly
- fight stops when both die within 10 seconds
- correct lines are being said, I think
- made the script a bit better overall

* fix codestyle?

* remove leftovers

* remove leftovers

* add spaces
2023-08-10 14:03:48 -03:00
Dan
fcf7ceea42 chore(Scripts/Karazhan): rewrite Nightbane with scheduler + some fixes (#16687)
* initial

* leftovers

* whitespaces

* remove instance

* bla

* Update boss_nightbane.cpp

* add skeletonscheduler

* woops

* I do need to update it, silly

* fix

* fix with nesting?

* debug

* fix

* step 1

* step 2 of the hackest of fixes

* add leftover

* fix

* add forgotten scheduler validator
2023-07-27 09:04:31 -03:00
Eddy Vega
750e0b4c23 refactor(Scripts/Karazhan): Update Netherspite (#16756)
* init

* .

* .

* review

* .

* Remove whitespace at the end of the lines

* .

* .
2023-07-27 09:03:19 -03:00
Eddy Vega
d71f5dcfb2 refactor(Scripts/Karazhan): Update Servant Quarters (#16680)
init
2023-07-18 16:51:16 -03:00
Dan
cc6454b2ef chore(Scripts/Karazhan): change Moroes to use TaskScheduler instead of events (#16791)
* initial

* fix

* add garrote line

* change line

* add immunity during stealth

* bump + spacing
2023-07-18 16:50:16 -03:00
Eddy Vega
59886c5657 refactor(Scripts/Karazhan): Update Attumen and Midnight (#16681)
* init

* .
2023-07-18 13:51:32 -03:00
Dan
89e7fb301a chore(Scripts/Karazhan): rework Shade of Aran using TaskScheduler and fixes (#16689) 2023-07-18 09:56:00 -03:00
Eddy Vega
df8de555a3 refactor(Scripts/Karazhan): Update Maiden of Virtue (#16683)
* init

* .
2023-07-17 08:22:04 -03:00
Eddy Vega
3a7274709b refactor(Scripts/Karazhan): Update Moroes (#16682)
* init

* .
2023-07-17 08:21:13 -03:00
Eddy Vega
3860d273b4 chore(Scripts/Karazhan): The Curator - KilledUnit (#16770)
init
2023-07-16 19:42:26 -03:00
Eddy Vega
1184b3a693 fix(Scripts/Karazhan): Rewrite Terestian Illhoof (#16755)
* init

* m

* .
2023-07-15 17:13:38 -03:00
Eddy Vega
601d036295 refactor(Scripts/Karazhan): Update The Curator (#16754)
* init

* .

* .
2023-07-15 17:13:08 -03:00
The GhostRider
f09be5f124 fix(DB/SAI): Yenniku (#16631)
* Fix(SAI/C++/NPC): NPC Yenniku and Removal of AI C++

* Update rev_1687759233155225800.sql

Changes made

* Update rev_1687759233155225800.sql

* Update rev_1687759233155225800.sql

* Update rev_1687759233155225800.sql

* Update rev_1687759233155225800.sql

* Update rev_1687759233155225800.sql

* Update rev_1687759233155225800.sql

* Update data/sql/updates/pending_db_world/rev_1687759233155225800.sql

Co-authored-by: Gultask <100873791+Gultask@users.noreply.github.com>

* Update rev_1687759233155225800.sql

* Update rev_1687759233155225800.sql

---------

Co-authored-by: Gultask <100873791+Gultask@users.noreply.github.com>
2023-06-29 19:22:11 -03:00
Skjalf
ec5eabce25 fix(Scripts/Karazhan): Malchezaar should not cast Enfeeble on phase 3 (#16587) 2023-06-18 15:29:19 -03:00
Dan
a13601bbc5 fix(Scripts/Karazhan): Opera Wizard of Oz fight correct start timers for combat as well fixing restart of the event (#16303) 2023-06-08 22:40:24 -03:00
KJack
a696227e8d fix(Scripts/UBRS): Update UBRS/Pyroguard Emberseer script to fix issues and increase accuracy (#16352)
* Update UBRS/Pyroguard Emberseer script to fix issues and increase accuracy.

- Remove EVENT_PLAYER_CHECK which was causing triggering the fight to work only sporadically
- Break out pre-enter-combat phase to better emulate actual timing. Fixes DBM timing being off
- Pre-enter-combat sequence starts as soon as the adds are engaged, not after 32 seconds
- disable fire shield during pre-enter-combat to keep the fight from resetting
- remove faster add despawn which doesn't appear to be in the WotLK Classic version
- remove adds doing EVENT_ENCAGE every 10-20s, which was unneccesary and caused them to glitch move around the player

* Small change to pre-add timing.
2023-06-01 08:40:02 -03:00
KJack
7945e11557 fix(Scripts/ZulGurub): fix timing regression for Venoxis cobras (#16309)
Fixes timing regression caused by conversion miss in #14876
2023-05-18 15:34:50 -03:00
Johaine
ea3e6e8f3b fix(Scripts/Deadmines): Fix Factory Door in Deadmines being closable (#15201)
* fix(DB/SAI): Open Factory Door correctly (irreversibly)

Activate the Factory Door after the boss' death to open it instead of changing gameobject state only which can be reversed by another activation.

* fix(Script/Instance): Prevent Door being closed again after Server Restart

* Drop database name from update SQL

Other people might not use the standard database names

Co-authored-by: Gultask <100873791+Gultask@users.noreply.github.com>

---------

Co-authored-by: Gultask <100873791+Gultask@users.noreply.github.com>
2023-05-13 14:52:44 -03:00
天鹿
df77b5f4f7 chore(core): cleanup code p3 (#16073)
* Update MMapMgr.cpp

* Update UpdateFetcher.cpp

* Update AuctionHouseMgr.cpp

* Update AuctionHouseMgr.h

* Update BattlegroundAV.cpp

* Update ChannelMgr.cpp

* Update ThreatMgr.h

* Update Player.h

* Update PlayerSettings.cpp

* Update ObjectMgr.cpp

* Update Guild.cpp

* Update Guild.h

* Update Map.cpp

* Update World.cpp

* Update boss_nefarian.cpp

* Update boss_prince_malchezaar.cpp

* Update boss_venoxis.cpp

* Update zone_elwynn_forest.cpp

* Update zulfarrak.cpp

* Update boss_novos.cpp
2023-04-24 08:13:07 -03:00
avarishd
72f111dd65 fix(Scripts/Creature): Add Ravenclaw Apparition event. (#15200) 2023-04-21 15:06:08 -03:00
ZhengPeiRu21
817cb2d685 fix(Scripts/MoltenCore): Correct Baron Geddon Inferno damage values (#15637)
* fix(Scripts/Molten Core): Correct Baron Geddon Inferno damage values

* Update tick counts
2023-04-02 15:35:47 -03:00
UltraNix
e6fb7ff806 fix(Scripts/Karazhan): Fixed locking Shad of Aran entrance door. (#15450)
Fixes #15434
2023-04-02 15:29:56 -03:00
Revision
6e39ffa64e fix(Core/GameObject): Pumpkin Shrine (#13460)
Co-authored-by: M'Dic <joshua.lee.betts@gmail.com>
2023-03-16 18:57:36 +01:00
UltraNix
b21f98d639 fix(Scripts/Karazhan): Chess Event. (#14736) 2023-03-15 00:07:49 -03:00
Stefano Borzì
034b521501 feat(CI): add cppcheck (#15211)
Co-authored-by: Skjalf <47818697+Nyeriah@users.noreply.github.com>
2023-03-05 18:47:18 +01:00
Skjalf
e5c0c7227a fix(Scripts/Karazhan): Rework Prince Malchezaar (#14877) 2023-02-27 01:38:02 -03:00
patou01
a76c07698c fix(Scripts/Scholomance): Kirtonos the Herald event now starts correctly again (#15131) 2023-02-19 15:39:02 -03:00
Kitzunu
bd6034e1a9 refactor(Core/AI): Some more refactoring prep for Comat Threat system… (#15026)
Co-authored-by: Treeston <14020072+Treeston@users.noreply.github.com>
2023-02-13 21:39:40 +01:00
Tereneckla
fdfa88093e fix(Scripts/MoltenCore): revert ragnaros submerge event to 180s (#15001) 2023-02-13 14:32:42 -03:00