Commit Graph

2571 Commits

Author SHA1 Message Date
Andrew
c5399509e6 refactor(Scripts/TempleOfAhnQiraj): Clean up Cthun script (#19736)
* refactor(Scripts/TempleOfAhnQiraj): Clean up Cthun script

* Update boss_cthun.cpp

* Update boss_cthun.cpp
2024-08-25 16:46:24 -03:00
Grimdhex
643362d697 refactor(Core/Object): adds consistency in the use of type object check (#19671) 2024-08-25 09:57:37 -03:00
Grimdhex
61f3a631c3 fix(Server): remove double blank lines at the end of several files (#19735) 2024-08-25 07:21:14 -03:00
sudlud
30a790117b fix(Core/WorldSocketMgr): sync default Network.OutUBuff with worldser… (#19702)
* fix(Core/WorldSocketMgr): sync default Network.OutUBuff with worldserver.conf.dist

* Update WorldSocketMgr.cpp
2024-08-23 06:38:00 +02:00
Tereneckla
3419f0246b fix (Core/Spells) partially revert #19529 (#19703)
Update Spell.cpp
2024-08-22 20:36:39 -03:00
Andrew
c0b6eae0e1 fix(Core/Spells): Fix movement impairment auras not being removed (#19684) 2024-08-22 15:09:43 -03:00
Kitzunu
eb410d6ab2 refactor(Core/Battleground): rewrite SpiritOfCompetitionEvent() (#19675)
* Use DoForAllPlayers

* Change to void - we don't need to return a value

* Better readability
2024-08-22 19:24:08 +02:00
Grimdhex
db7183a573 chore(Debug/Scripting): improve debug errors during the unloading scripts (#19643)
* chore(Debug/Scripting): improve debug errors during script unloading

* add the script name to increase debug informations and ensure to derefence script pointers
2024-08-21 08:13:20 -03:00
Andrew
ef4e0c0d4a fix(Core/Spells): Power of the Guardian should persist through death (#19638) 2024-08-21 06:36:05 -03:00
Saqra1
087acc58bf fix(Core/PetHandler): Allow PetAI to handle flags (#19446)
When a pet ability was cast, PetHandler reset all CharmInfo flags before
calling PetAI methods, setting the attack flag to true every time.
This commands the pet to go and chase the target which is not correct
when the state is COMMAND_STAY.

PetAI already handles the scenario, it just wasn't getting the actual
pet attack state.
2024-08-19 13:15:39 -03:00
Kitzunu
337135bf9e refactor(Core/Misc): Use NpcFlag helpers (#19676)
* chore(Core/Misc): Use HasNpcFlag instead of HasFlag

* extend to all npcflag helpers
2024-08-19 10:17:02 +02:00
Tereneckla
79a653b13e fix (Core/Spells): remove object size for hit calculation of aoe aura spells that target enemies (#19529)
remove object size for aoe on enemy spells
2024-08-18 20:34:56 -03:00
Andrew
23f58016d0 fix(Core/Map): Exempt raids from the hourly limit (#19650) 2024-08-18 19:56:38 +02:00
Kitzunu
e33a56d89b fix(Core/Creature): Nullcheck for questgreeting greeting (#19669)
* fix(Core/Creature): Nullcheck for questgreeting greeting

* closes https://github.com/azerothcore/azerothcore-wotlk/issues/19659

* Update GossipDef.cpp
2024-08-18 06:41:18 -03:00
sudlud
adc9f4e7ab fix(Core/Spell): check for player before dereferencing (#19666) 2024-08-18 05:57:02 -03:00
Benjamin Jackson
adff3c3846 fix(Core/Spells): Revert ownership and follow logic adjustment for guardian summons. (#19664)
Revert "fix(Core/Spells): Adjust ownership and follow logic for guardian summ…"

This reverts commit cc2ef9d6dd.
2024-08-17 20:29:21 -03:00
Grimdhex
5cbe485785 fix(Core/PlayerUpdates): incorrect backslash in a debug_log (#19630) 2024-08-15 18:44:07 -03:00
Grimdhex
9dc20bc261 fix(Core/Entities): crash fix cause by a pointer change in #19622 (#19633)
* fix(Core/Entities): crash fix cause by a pointer change in #19622

* fix blank space for codestyle check
2024-08-15 16:28:50 -03:00
Grimdhex
7457aef78d refactor(Core/Entities): Cleanup Unit header file (#19622)
* move several enum definitions in a new files

* move more things

* remove the include comment

* move the related code to CharmInfo in this own file

*original idea of Ovahlord

Co-Authored-By: Ovahlord <18347559+Ovahlord@users.noreply.github.com>

* fix clang build errors and few blank lines

* missing forward declaration

* new tentative to fix gcc/clang build

* add several include could be necessary for gcc/clang compilation

* .

* revert some include since the last AC update

* fix some loop inconsistencies

* align all enums in UnitDefine.h

---------

Co-authored-by: Ovahlord <18347559+Ovahlord@users.noreply.github.com>
2024-08-15 05:12:44 -03:00
Andrew
1565758da4 Revert "chore(Script/Misc): cleanup" (#19627)
Revert "chore(Script/Misc): cleanup (#19619)"

This reverts commit 7ff8f72397.
2024-08-15 05:43:11 +02:00
Kitzunu
7ff8f72397 chore(Script/Misc): cleanup (#19619)
* chore(Script/Misc): cleanup

* more cleanup

* cleanup
2024-08-14 16:29:50 -03:00
Kitzunu
030716421f feat(Core/LFG): Option to disable deserter (#19618)
* feat(Core/LFG): Option to disable deserter

* closes https://github.com/azerothcore/azerothcore-wotlk/issues/19569

* Update IWorld.h
2024-08-14 09:19:56 -03:00
Kitzunu
2e02c76399 fix(Core/Creature): quest_greeting_locale (#19615)
* fix(Core/Creature): quest_greeting_locale

* closes https://github.com/azerothcore/azerothcore-wotlk/issues/14845
2024-08-13 21:09:36 +02:00
Kitzunu
4b63aa9015 feat(DB/Module): introduce module_string table (#19475) 2024-08-13 19:53:16 +02:00
Benjamin Jackson
67010623a0 fix(Core): Adjustments to summoning ritual object handling. (#19600)
* Init.

* Allow self-summoning.

* Revert unintended change.

Self-summoning still works fine without this being removed, I see no harm in putting it back.
2024-08-13 12:12:05 -03:00
Saqra1
ad411b49b7 fix(Core/Spell) Ritual spells cooldown on cancel (#19604)
762f78b313

Co-authored-by: killerwife <killerwife@gmail.com>
2024-08-13 12:05:12 -03:00
Saqra1
ed824de7b8 fix(Core): Ritual animations (#19602)
Channel the same spell as the original caster when clicking on a ritual
portal, but ignore the effects of the spell.

Co-authored-by: killerwife <killerwife@gmail.com>
2024-08-13 11:54:17 -03:00
Benjamin Jackson
cc2ef9d6dd fix(Core/Spells): Adjust ownership and follow logic for guardian summons. (#19599)
* Init.

* Remove totem ownership transfer.
2024-08-13 11:53:43 -03:00
Benjamin Jackson
35b551c0da fix(Core/SpellInfo): Disallow damage scaling trigger spells to get scaled twice. (#19605)
* Init.

* Deleted the wrong one.

* Add double scaling check.

* Whitespace.
2024-08-13 11:53:14 -03:00
Benjamin Jackson
3b2b8406a8 fix(Core/Entities): Only add use to spell caster objects if cast succeeds. (#19601)
Init.
2024-08-12 08:46:20 -03:00
Kitzunu
7b102f53f2 fix(Core/Chat): Correct misstake in b81bcfb causing outputs to CLI not working properly (#19593)
fix(Core/Chat): Correct misstake in b81bcfbfea causing outputs to CLI not working properly

* closes https://github.com/azerothcore/azerothcore-wotlk/issues/19592
2024-08-11 08:42:37 -03:00
Kitzunu
b81bcfbfea refactor(Core/ChatHandler): Cleanup retriving session and checking fo… (#19585)
* refactor(Core/ChatHandler): Cleanup retriving session and checking for valid session

* redundant

* make it clear what a "valid" session is

* HasValidSession -> HasSession

* Differentiate from "valid" which in this case would mean the player is in world which isnt checked here
2024-08-10 17:46:13 +02:00
Kitzunu
e4df159f5c refactor(Core/Chat): Move SendNotification to ChatHander (#19491)
* refactor(Core/Chat): Move SendNotification to ChatHander

* Update Battleground.cpp

* fix build

* Update src/server/game/Chat/Chat.h
2024-08-10 11:39:46 -03:00
Kitzunu
bb7765d91e refactor(Core/World): Move SendGMText to ChatHandler and allow fmt (#19490)
* refactor(Core/World): Move SendGMText to WorldSession and allow `fmt`

- Move SendGMText from World to WorldSession

- Make SendGMText use fmt

- Make SendGMText parse acore_string entries

* Update cs_message.cpp

* tokenize the string only once

* Move to chathandler

* Update WorldSession.cpp

* make sure we have a session
2024-08-08 20:12:33 -03:00
Gultask
09e77dfd1c fix(Scripts/BlackTemple): Mother Shahraz Periodic part 2 (#19561)
* init

* Update boss_mother_shahraz.cpp

* Update boss_mother_shahraz.cpp

* Update boss_mother_shahraz.cpp

* Update boss_mother_shahraz.cpp
2024-08-06 11:53:19 -03:00
avarishd
fcdc50306f fix(Core/Spells): Chromatic Resistance Aura shouldn't give holy resis… (#19549)
fix(Core/Spells): Chromatic Resistance Aura shouldn't give holy resistance
2024-08-03 12:02:49 -03:00
avarishd
c54fd66c73 fix(Core/Spells): Flame Wave (#19144)
* fix(Core/Spells): Flame Wave

* )

* .

flamewave faction id
3365e6a4b8/sql/old/9.x/world/21081_2021_10_15/2021_09_29_04_world_2018_06_17_04_world.sql (L46)

Co-Authored-By: Carlos Morales <carlos.morales@insmet.cu>

* lol

---------

Co-authored-by: Carlos Morales <carlos.morales@insmet.cu>
2024-08-02 16:20:27 -03:00
Francesco Borzì
02a05fbd4c refactor(src/common): remove unused imports (#19506)
* refactor(src/common): remove unused imports

* fix: build

* chore: fix build

* chore: size_t -> std::size_t

* chore: fix fuckup from previous commit

* chore: fix build

* chore: fix build

* chore: fix build

* chore: fix build with std::size_t

* chore: fix build

* chore: fix build

* chore: fix build

* chore: fix build

* chore: fix build

* chore: fix build

* chore: fix build

* chore: fix build

* chore: fix build

* chore: fix build

* chore: fix build

* chore: fix build
2024-07-30 20:06:46 -03:00
Benjamin Jackson
06a608d244 fix(Core/GroupHandler): Remove bad party invite check. (#19530)
Init.
2024-07-30 20:06:07 -03:00
Kitzunu
a1e9dfce41 fix(Core/World): Crash on SendWorldText(Optional) (#19531)
* fix(Core/World): Crash on SendWorldText(Optional)

* WorldText should be sent to all sessions

* now it works
2024-07-30 22:53:11 +02:00
Justin Hanley
af6b8ce099 feat(Scripts/Commands): account set email (#19481)
* added worldserver command to set email address

* reverted sql, added Tail args

* removed pointer

* Added helper text via updatescript

* fix build

* fix build

* fixed db update

* Update data/sql/updates/db_world/2024_07_26_01.sql

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* Update data/sql/updates/db_world/2024_07_26_01.sql

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* fixed hander

* refactor with named params

* refactor with named params

---------

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2024-07-30 15:33:13 +02:00
Gultask
fccfe51594 fix(Scripts/BlackTemple): Mother Shahraz Periodic Beams (#19525)
* init

* Update boss_mother_shahraz.cpp
2024-07-29 23:49:58 -03:00
avarishd
a567259770 fix(Core/Spells): [TK] Wing Buffet should be a cone. (#19382)
* fix(Core/Spells): [TK] Wing Buffet should be a cone.

* radius to 20, from 15

* Update SpellInfoCorrections.cpp
2024-07-29 21:39:36 -03:00
Kitzunu
87f4adf634 refactor(Core/Chat): Move SendWorldText(optional) to ChatHandler and … (#19501)
* refactor(Core/Chat): Move SendWorldText(optional) to ChatHandler and allow `fmt`

* Update src/server/game/Battlegrounds/BattlegroundQueue.cpp

* Update src/server/game/Battlegrounds/BattlegroundQueue.cpp

* Update src/server/game/Misc/BanMgr.cpp

* Update src/server/game/Misc/BanMgr.cpp

* Update src/server/game/Misc/BanMgr.cpp

* Update src/server/game/Misc/BanMgr.cpp

* Update src/server/game/Misc/BanMgr.cpp

* Update src/server/game/Misc/BanMgr.cpp

* Update src/server/game/Misc/BanMgr.cpp

* Update src/server/game/Misc/BanMgr.cpp
2024-07-29 14:44:13 -03:00
Tereneckla
e44e8fe109 fix (Core/Movement) Allow MoveFollow to not inherit walkstate of the target to fix Enchanted Elemental speed (#19498)
* MoveFollow with own walkstate

* switch
2024-07-29 08:30:42 -03:00
Benjamin Jackson
2b636adc2f fix(Core/AchievementMgr): Check for null achievement before being derefenced. (#19504)
* Init.

* Reviewed changes.
2024-07-28 16:40:21 -03:00
Francesco Borzì
54fadbda67 refactor(src/server/game/Entities): remove unused imports (#19507) 2024-07-28 16:39:39 -03:00
Kitzunu
4785aabbf2 fix(Scritps/AV): Use db defined text for Herald (#19486)
* fix(Scritps/AV): Use db defined text for Herald

* closes https://github.com/azerothcore/azerothcore-wotlk/issues/19483

* indent

* Update BattlegroundAV.cpp

* fix build

* remove from acore_string

* Update BattlegroundAV.h
2024-07-28 01:44:03 +02:00
Kitzunu
6c0afe1810 refactor(Core/WorldSession): Make SendNotification use fmt and parse acore_string (#19489)
* refactor(Core/WorldSession): Make SendNotification use `fmt`

* Make SendNotification use `fmt`

* Make SendNotification parse acore_string entries
2024-07-28 01:25:06 +02:00
Kitzunu
034a4c0ff6 fix(Core/Chat): Exempt addon messages from CONFIG_CHAT_MUTE_FIRST_LOGIN (#19472)
* closes https://github.com/azerothcore/azerothcore-wotlk/issues/19471
2024-07-27 08:21:23 -03:00