Commit Graph

2291 Commits

Author SHA1 Message Date
Andrew
c4722de46a fix(Scripts/Karazhan): Fix Temptation target (#17710) 2023-11-14 20:09:25 -03:00
KJack
1227e69600 fix(Core/InstanceScript): Fix new Remove function conversion miss (#17708) 2023-11-14 16:43:46 -03:00
Kitzunu
8bb6661c96 feat(Core/Guild): Allow to limit the amount of members within a guild (#17697)
* feat(Core/Guild): Allow to limit the amount of members within a guild

* Update Guild.cpp

* Update Guild.cpp

* Update Guild.cpp

* Update Guild.cpp

* improve message to player
2023-11-14 17:40:28 +01:00
Andrew
5a4fdc7de4 fix(Core/Spells): Banish should only be dispelled by Mass Dispel (#17703)
* fix(Core/Spells): Banish should only be dispelled by Mass Dispel

* Update Unit.cpp

* Update Unit.cpp
2023-11-14 16:27:37 +01:00
KJack
3d20f8902b feat(Core/Instance): InstanceScript: create Remove functions (#17702)
InstanceScript: create `Remove` helper functions
2023-11-14 08:13:28 -03:00
KJack
2e4ad36d20 feat(Core/AI): Add built-in TaskScheduler to CreatureAI (#17700)
* Add TaskScheduler to CreatureAI

* Code style, because of course.
2023-11-14 07:32:47 -03:00
Andrew
975a6fccab feat(Core/Scripts): Prevent the inherited TaskScheduler from updating… (#17689) 2023-11-12 20:30:23 -03:00
Christopher Galbraith
ae5bf57dba fix(Core/Spell): Titan's Grip check if player has 2H and shield equipped (#16984)
* check if player has a 2H and shield equipped

* null check item2 for shield

* style whitespace

* removed unnecessary logic

* remove unnecessary brackets

---------

Co-authored-by: ChrisCGalbraith <chriscgalbraith@gmai.com>
2023-11-12 17:51:26 +01:00
KJack
3c8adc71cd (Scripts/AI) ZG20: Jeklik (Bat Boss) - Implement Bat Riders, other fixes and improvements (#17573)
---------

Co-authored-by: AG <43139552+AGandrup@users.noreply.github.com>
2023-11-12 09:35:35 +01:00
forgives
ca7eb956aa feature(Core/Pet): Add pet talent rate config (#17678)
* feat: add pet talent rate config

* feat(Core/Pet): keep consistent with player talent config

* refactor(Core/Pet): delete empty line
2023-11-12 09:33:06 +01:00
Kitzunu
bbadc32bea Revert Visibility Notifier changes (#17682)
* Revert "fix(Core/Grid): Implement missing GridUnload setting (#17569)"

This reverts commit 79b39f9655.

* Revert "fix(Core/Grid): Address bugs and performance issues introduced by visibility notifier implementation (#17480)"

This reverts commit 60e27511c5.

* Revert "fix(Core): GridCleanUpDelay Log (#17436)"

This reverts commit 90b16ca065.

* Revert "feat(Core/Grids): Implement visibility notifier (#15919)"

This reverts commit 2779833768.
2023-11-12 00:48:49 +01:00
Vitumoc
4df0ab3427 fix(Core/Character): fix worldserver with autobalance mod crash when character creation fails (#17625)
* set vars before clean player when create err

* code style

* dont clean

* code style

* check flag
2023-11-12 00:15:05 +01:00
KJack
896e7c5656 (Scripts/AI) ZG20: Improvements to Thekal (Tiger Boss) (#17603)
Co-authored-by: AG <43139552+AGandrup@users.noreply.github.com>
2023-11-11 08:13:43 +01:00
Ludwig
2e5d5f2dc7 fix(Events): fix commoner spawns, auras and equips for all events (#17632)
* fix(Core/Spells): Implement Gossip NPC Appearance spells

65511 Gossip NPC Appearance - Brewfest
65522 Gossip NPC Appearance - Winter Veil
65523 Gossip NPC Appearance - Default
65524 Gossip NPC Appearance - Lunar Festival
65525 Gossip NPC Appearance - Hallow's End
65526 Gossip NPC Appearance - Midsummer
65527 Gossip NPC Appearance - Spirit of Competition
65528 Gossip NPC Appearance - Pirates' Day
65529 Gossip NPC Appearance - Day of the Dead (DotD)

* fix(DB/SAI): fix commoner spawns and auras

* equip random mug on spell 65511 Gossip NPC Appearance - Brewfest

* check if creature before equipping brewfest mug

* minor optical fixes, DELETE first, then remove duplicate spawns

* fix two displayIDs in NPC Gossip Appearance spells

* Remove whitespace at the end of the lines

* remove commoner spawns for event 7 Harvest festival from game_event_creature

* fix harvest festival event id

* Update rev_1698785311231174200.sql
2023-11-10 20:26:49 +01:00
Ludwig
cb483d124f fix(Script/Spell): fix AOE circle bug on Midsummer Torch Catching (#17654)
* fix(Spells/Midsummer): fix script for spell 46747 SPELL_FLING_TORCH_DUMMY

* SpellInfoCorrections: fix target of spell 46747 Fling torch

* DB: assign spell 46747 Fling torch to item 34833 Unlit Torches

* remove whitespaces at src/server/game/Spells/SpellInfoCorrections.cpp:4610
2023-11-09 00:19:57 +01:00
KJack
48a43c7f44 fix(Core/Creature): Resolve issue with dialog options randomly not working (#17596)
Remove unneeded ClearGossipMenuFor
2023-11-08 19:33:03 -03:00
Tristan 'Natrist' Cormier
f1cb3bfb3b refactor(Core/Network): remove redundant logging calls from some message handlers (#17565)
chore: removed redundant logging calls from some message handlers
2023-11-08 21:53:43 +01:00
Ludwig
ef09d4b63f fix(Core/Unit): Implement GetDisplayRace() (#17609) 2023-11-08 19:19:38 +01:00
KJack
e18bfae91c Feat (Core) Add CustomData to Groups (#17628)
* Add CustomData to Groups

* A one-line change and it STILL failed the first check run!
2023-11-08 19:18:58 +01:00
Benjamin Jackson
f898fa75cd fix(Core/Spells): Correct spell scaling formula. (#17649)
* Replace old spell scaling with revised version.

Co-Authored-By: balakethelock <111737968+balakethelock@users.noreply.github.com>

* Remove a single-use variable.

* Use funky multiply operator.

More similar to original function, if a tad less readable IMO.

---------

Co-authored-by: balakethelock <111737968+balakethelock@users.noreply.github.com>
2023-11-08 08:44:05 +01:00
avarishd
8af077bc33 fix(DB/SAI): Naberius (#17639) 2023-11-08 08:01:24 +01:00
KJack
f417a166bc feat(Core/Scripts): added OnAfterSpecSlotChanged hook (#17637) 2023-11-07 23:46:08 +07:00
Winfidonarleyan
c5564e1363 feat(Deps/Fmt): update fmt lib to 10.1.1 (#17643) 2023-11-05 13:15:45 +07:00
avarishd
fb83c22dd2 fix(Core/Spells): T5 Warlock 4 Set (#17589)
* fix(Core/Spells): T5 Warlock 4 Set

* BonusMultiplier is 1 so we don't care about it
2023-11-02 12:30:03 -03:00
avarishd
11c88cb30e fix(Core/Spells): T4 Shadow Priest 4 Set (#17587)
* fix(Core/Spells): T4 Shadow Priest 4 Set

* zzz
2023-11-02 08:54:44 -03:00
KJack
751ffc7c70 feat(Core/Hooks): Add OnAfterDatabaseLoadCreatureTemplates hook (#17621)
* Add OnAfterDatabaseLoadCreatureTemplates hook
- fix issue where the fast template cache was not updated correctly after a CS reload of a single creature template

* Parameter naming tweak to reduce confusion.

* Refactor to streamline fastcache creation, remove threading concerns

* Remove unneeded resize when loading creature templates

* Update fast cache resizing to highest-performing option
2023-10-31 06:58:45 -03:00
Ovahlord
52d37a927d fix(Build): nopch build (#17617) 2023-10-30 00:24:18 +01:00
Kitzunu
f757e93da5 refactor(Core/Misc): Make DeathState enum class (#17607) 2023-10-28 10:54:03 +02:00
AG
79b39f9655 fix(Core/Grid): Implement missing GridUnload setting (#17569)
* Implement GridUnload setting

* Minor fixes

- Use GetOption instead of deprecated GetBoolDefault.
- Added a missing check for instances in LoadMap
- Replaced some numbers with global defines

* Possible crashfix + minor improvements

- Initialized initialOrientation which I had forgotten (likely cause of crash)
- Readded a previous check in UpdateSplineMovement
- Made i_objectsToRemove and i_worldObjects tos sets as they were previously, instead of unordered_set.

* Update worldserver.conf.dist

* Fix high CPU usage with preload grid enabled.

This should be it.
2023-10-26 19:32:15 -03:00
AG
60e27511c5 fix(Core/Grid): Address bugs and performance issues introduced by visibility notifier implementation (#17480)
* Bug fixes

- Corrected std::chrono from seconds to milliseconds
- Got rid of leftover code that caused objects to not show up on time

* Removed logic to set gameobject as active

- More alignement with TC.
- Reduces CPU usage drastically

* Revert back to using time_t instead of std chrono

* Invoke SetNoCreate() method to reduce CPU usage drastically

* Remove setActive from static and motion transports

* Fix performance issues

* Added SetFarVisible to WG and some dungeon scripts

- Also removed setActive(true) from creatures in Wintergrasp. As for gameobjects they are set to active upon being damaged/destroyed and removed from active on rebuild (reset)

* Removed comments related to VISIBILITY_COMPENSATION

* Fix log

* Deleted unused files + corrected a check

* Added missing header

* Removed unused parameter

* Removed another unsued parameter

* Changed vector to set for i_visibleNow

- Changed vector to set for i_visibleNow in VisibleNotifer
- Adjusted HaveAtClient to accept Object*
- Adjusted SendUpdateToPlayer to send createobject packet only if not known to client
2023-10-23 05:37:11 -03:00
Andrew
9935e72341 feat(Core/Unit): Implement OnPowerUpdate() unit script hook (#17560) 2023-10-22 09:14:41 -03:00
pvp100
4962972eec fix(Core/BG): Relocate cannon in WG (#16673)
* fix(DB/Gameobject): fix towercanno error location in Flamewatch Tower

adjusted wintergrasp towercanno position

* Update src/server/game/Battlefield/Zones/BattlefieldWG.h

Co-authored-by: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>

---------

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
Co-authored-by: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>
2023-10-22 04:47:13 +02:00
Alyst3r
2e55cad450 refactor(DB/reputation_spillover_template): Reputation spillover table expansion (#14763)
* Update ObjectMgr.cpp

Rework to `ObjectMgr::LoadReputationSpilloverTemplate()` allowing more factons to be added.

* Create reputation_spillover_template-update.sql

Alteration to `reputation_spillover_template` table, update allowing to add two more factions.

* Update SharedDefines.h

`MAX_SPILLOVER_FACTIONS` is now equal 6 instead of 4.

* Update reputation_spillover_template-update.sql

Now it alters table instead recreating it.
2023-10-22 04:45:50 +02:00
avarishd
8c8d459c6f fix(Core/Spells): Marked for Death affecting wrong spells. (#17406) 2023-10-21 10:28:57 -03:00
Angelo Venturini
fb8e343677 fix(Core/Arena): Fix logging scores in db (#17504) 2023-10-21 08:12:22 -03:00
Hasn
5bf64a164a fix(Core/Player) Stop small durability loss from still occuring when DurabilityLoss options in worldserver.conf are set to 0 (#17407)
Fix durability loss even when "DurabilityLoss"-settings in
worldserver.conf are zeroed
2023-10-21 08:10:34 -03:00
avarishd
894732f11e fix(Scripts/EscortAI): Do not remove auras on evade (#17542) 2023-10-20 20:49:17 -03:00
avarishd
359985dd4c feat(Core/Conditions): Add GoState condition for near gameobject. (#17524)
* feat(Core/Conditions): Add GoState check for near gameobject.

* log_error

* Update ConditionMgr.h
2023-10-20 19:41:26 -03:00
Kitzunu
ec724cda89 chore(Core/Conf): Remove unused config (#17544) 2023-10-20 15:26:07 +02:00
Ludwig
de6ece2462 fix(Core/Spells): interrupt midsummer ribbonpole dance on mount or sp… (#17442)
fix(Core/Spells): interrupt midsummer ribbonpole dance on mount or spell cast
2023-10-19 21:40:08 -03:00
avarishd
a39175bc3b fix(Core/Spells): Demonic Knowledge missing 1% per rank (#17495) 2023-10-18 19:21:46 -03:00
KJack
99bf49e0dd Fix (core/SpellEffects): Don't randomize summoned guardian position if target is in the DB (#17506)
* Doesn't randomize placement of guardian summons if the target position was specified in the DB

* Add `HasRadius()` check

* Add check for zero-radius effects, update IF condition style

* Accept IF condition statement suggestion

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

---------

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2023-10-17 00:07:47 +02:00
avarishd
2cd4af9446 fix(Core/Spells): Allow casting ground mounts in water (#17481)
https: //github.com/TrinityCore/TrinityCore/pull/17488

Co-authored-by: SnapperRy <19622383+SnapperRy@users.noreply.github.com>
2023-10-10 20:23:45 -03:00
avarishd
43be5db44c fix(Core/ChatHandler): SPELL_AURA_MOD_LANGUAGE should affect only Say… (#17465)
fix(Core/ChatHandler): SPELL_AURA_MOD_LANGUAGE should affect only Say and Yell
2023-10-10 10:15:48 -03:00
Hasn
e644dd949f feat(Core/Scripting): Implement hook OnAfterCalculateLootGroupAmount() (#17456)
Add hook 'OnAfterCalculateLootGroupAmount' to GlobalScript, similar to existing hook 'OnAfterRefCount'. Allows for dynamic modification of the group loot rate
2023-10-08 17:18:44 -03:00
KJack
f127e583aa fix(core/scripting) Calculate percent-based damage before ModifyPeriodicDamageAurasTick hook (#17387)
Moved damage calculation for `SPELL_AURA_PERIODIC_DAMAGE_PERCENT` to before the hook.

Co-authored-by: KJack <kjack@electricnightowl.com>
2023-10-08 15:38:07 -03:00
Kitzunu
2255f492b5 fix(Core/Creature): Update movement in UpdateEntry() (#17291)
* fix(Core/Creature): Update movement in UpdateEntry()

* Update Creature.cpp

* Update Creature.cpp

* hover

* just replace with updatemovememntflags

* Update Creature.cpp

* Update Creature.cpp

---------

Co-authored-by: Skjalf <47818697+Nyeriah@users.noreply.github.com>
2023-10-08 10:49:17 -03:00
avarishd
4e5077ed80 fix(Core/Spells): Script Shaman T8 Elemental 4P Bonus (#17424)
* fix(Core/Spells): Script Shaman T8 Elemental 4P Bonus

* 🧙‍♂️
2023-10-08 09:31:54 -03:00
Kitzunu
b1395b9450 refactor(Core/Creature): Calculate BaseArmor as float (#17448) 2023-10-08 08:56:16 -03:00
Kitzunu
a4e4d6ddb2 feat(Core/Player): Implement commentator tag (#17449)
* feat(Core/Player): Implement commentator tag

* remove redundant session check
2023-10-08 09:07:17 +02:00