GrenderG
8d2f307483
fix(Core/Spells): Correct follow position for Pets and Companions. ( #23154 )
...
Co-authored-by: sogladev <sogladev@gmail.com >
2025-10-09 20:09:40 +02:00
Takenbacon
73317b2706
feat(Core/Grids): Remove WorldObject separation in grid containers ( #22595 )
2025-08-09 06:36:24 +02:00
Takenbacon
a77bd19104
feat(Core/Maps): Remove worldobject container switch functionality ( #22586 )
2025-07-29 09:18:07 -03:00
Jelle Meeus
7561147e7c
fix(Core/Spells): No longer add a signature to items created by NPCs ( #22415 )
2025-07-03 12:35:06 -03:00
Andrew
31012923c1
fix(Core/Spells): Fix SPELL_EFFECT_LEAP_BACK not working on targeted … ( #22389 )
2025-06-29 16:11:11 -03:00
Tereneckla
bea53b9826
fix(Core/Spells): simplify and fix Blood-Caked Strike calculation ( #22243 )
2025-06-05 15:49:44 -03:00
Macs-Account
31ea22acc4
fix(Core/Spells): weapon damage based magic abilities gain too much effect from spell aura % damage increase ( #22232 )
2025-06-05 12:48:38 -03:00
Tereneckla
2b70446322
fix(Core/Spell): Revert paladin seal hackfixes ( #22264 )
2025-06-05 12:47:37 -03:00
Benjamin Jackson
db18d5b035
refactor(Core): Use database tables for Shaman totems and Druid shapeshift forms. ( #22104 )
...
Co-authored-by: DoctorKraft <25483209+doctorkraft@users.noreply.github.com >
Co-authored-by: Shauren <shauren.trinity@gmail.com >
Co-authored-by: ForesterDev <11771800+ForesterDev@users.noreply.github.com >
2025-05-27 14:40:57 +01:00
Exitare
98ceb1c067
fix(Core/PlayerScript) Align player script function names ( #21020 )
...
Co-authored-by: sudlud <sudlud@users.noreply.github.com >
2025-02-16 14:59:41 +01:00
Anton Popovichenko
2982b64430
fix(Core/Spell): Reset insignia spell target when it is deleted. ( #21437 )
2025-02-14 21:58:30 +01:00
Kitzunu
ed008a8780
refactor(Core/Spells): Add helpers for HasAuraType ( #20802 )
2024-12-01 08:50:59 -03:00
Andrew
2649ca2d65
feat(Core/Spells): Allow modifying MiscValues during cast ( #20731 )
2024-11-26 12:17:02 -03:00
Jelle Meeus
9f58216383
fix(Core/Spell): EffectQuestComplete, set quest to rewarded instead of complete ( #20358 )
...
set quest to rewarded instead of complete when targetted by SPELL_EFFECT_QUEST_COMPLETE
Prevents people from ending up with strange quests in their quest logs.
https://github.com/TrinityCore/TrinityCore/commit/6d62f852acf3e1a3ee57cde2442832280aee814
Co-authored-by: SnapperRy <snapperryen@gmail.com >
2024-11-15 03:47:41 -03:00
Andrew
7746287ee1
fix(Core/Spells): Fix Lay on Hands healing bypassing Cyclone ( #20552 )
...
* fix(Core/Spells): Fix Lay on Hands healing bypassing Cyclone
* and mana as well
2024-11-14 03:37:23 -03:00
Jelle Meeus
cc03798123
fix(Core/Spells): Jump Speed Calculations ( #20479 )
...
Core/Spell: Jump Speed Calculations
0197a2f990
Co-authored-by: DanVS <33371360+DanVS@users.noreply.github.com >
2024-11-12 12:16:41 -03:00
Francesco Borzì
c06cadfe75
refactor(src/common|server): remove unused import (big part 1) ( #20377 )
...
* refactor(src/common|server): remove unused import (big part 1)
* chore: fix build
* chore: fix build
* chore: fix build
* chore: fix build
* chore: attempt to fix damn linkin error
2024-10-31 21:46:11 +01:00
Francesco Borzì
484e19d21b
refactor(src/server/game/Spells): remove unused imports ( #20092 )
2024-10-01 08:05:15 +02:00
Kitzunu
386aea03ee
chore(Core/Misc): Some cleanup ( #19970 )
...
* remove weird blanks
* update if
* ) ) to ))
* missed some ) )
* now switch
* .
2024-09-21 19:34:31 +02:00
Saqra1
c42b3ee258
fix(Core/Pet): Control Infernal without enslave ( #19784 )
...
Check SummonProperties Category(Control) too to decide the type of
controls a Guardian should have.
Don't enslave Warlock's Infernal
2024-09-11 11:18:13 -03:00
Benjamin Jackson
1edac37ac3
refactor(Core): Make more use of helpers. ( #19835 )
...
* Init.
* Reword.
* Update codestyle script.
Co-Authored-By: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
* Add gameobject type ID check, reorder checks.
* Add helper/codestyle check for unit type.
* `IsUnit()` -> `IsCreature()`
* Add `IsUnit()` method.
* Use type mask.
https: //github.com/TrinityCore/TrinityCore/commit/cc71da35b5dc74abf71f8691161525a23d870bb5
Co-Authored-By: Giacomo Pozzoni <giacomopoz@gmail.com >
Co-Authored-By: Ovahlord <18347559+Ovahlord@users.noreply.github.com >
* Replace instances of `isType` with `IsUnit`.
---------
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com >
Co-authored-by: Ovahlord <18347559+Ovahlord@users.noreply.github.com >
2024-09-03 14:41:31 -03:00
Saqra1
62b825f8bd
fix(Core/Movement): Don't move for change in orientation only ( #19687 )
...
Changing only the orientation of a unit also flags it as if it were
moving, which causes spells to be interrupted.
2024-09-01 20:57:17 -03:00
Kitzunu
5d31b9f98f
refactor(Core/Item): Add helpers ( #19828 )
2024-08-31 19:38:50 -03:00
Grimdhex
643362d697
refactor(Core/Object): adds consistency in the use of type object check ( #19671 )
2024-08-25 09:57:37 -03:00
Benjamin Jackson
adff3c3846
fix(Core/Spells): Revert ownership and follow logic adjustment for guardian summons. ( #19664 )
...
Revert "fix(Core/Spells): Adjust ownership and follow logic for guardian summ…"
This reverts commit cc2ef9d6dd .
2024-08-17 20:29:21 -03:00
Benjamin Jackson
67010623a0
fix(Core): Adjustments to summoning ritual object handling. ( #19600 )
...
* Init.
* Allow self-summoning.
* Revert unintended change.
Self-summoning still works fine without this being removed, I see no harm in putting it back.
2024-08-13 12:12:05 -03:00
Benjamin Jackson
cc2ef9d6dd
fix(Core/Spells): Adjust ownership and follow logic for guardian summons. ( #19599 )
...
* Init.
* Remove totem ownership transfer.
2024-08-13 11:53:43 -03:00
Kitzunu
e4df159f5c
refactor(Core/Chat): Move SendNotification to ChatHander ( #19491 )
...
* refactor(Core/Chat): Move SendNotification to ChatHander
* Update Battleground.cpp
* fix build
* Update src/server/game/Chat/Chat.h
2024-08-10 11:39:46 -03:00
Kitzunu
793f87fd61
fix(Core/GameObject): Use correct spell at meeting stone ( #19311 )
...
* fix(Core/GameObject): Use correct spell at meeting stone
* cleanup
2024-07-09 19:39:58 -03:00
Mykhailo Redko
33f951d742
fix(Core/Spells): Fixed work of sobering spells and other improvements for drunk system ( #18390 )
...
* fix(Core/Spells): Fix sobering spells and possible uint8 overflow/underflow in SPELL_EFFECT_INEBRIATE handler.
* fix(Core/Spells): Improvements for SPELL_AURA_MOD_FAKE_INEBRIATE handling
2024-03-20 01:45:01 -03:00
Nathan Handley
df33a57b78
feat(Core/Unit): New helper IsClass and script hook OnPlayerIsClass ( #18243 )
...
* Class Comparison Logic Encapsulation - Parity
* Add Context to IsClass
* Add Unit IsClass script hook
* Replace additional getClass with IsClass
* Update CanUseItem to replace getClass with IsClass
* Add separate context for pet vs ability
* Change Create to Init since not all referenced contexts are creation
* Align spacing in ClassContext
* Drop context on LFGManager max power
* Update IsClass context that wraps around Missle Barrage
* Rename context for swapping weapons
* Be more specific than CLASS_CONTEXT_TALENT
* Remove duplicate context
* Moved IsClass Hook to Player
* Removed unused parameter in virtual base function
* Added maybe_unused to IsClass virtual in order to compile
To match the override signature, the virtual base needs to include the parameter in question, so using [maybe_unused] to signal to the compiler to allow it
* Remove extra blank line
* Add ABILITY_REACTIVE context
* Add context for PET_CHARM
* Remove explicit nullopt check per review
* Code Readability - Change if to if else in pet
Due to the return pattern, this doesn't change functionality in any way
* Add OnPlayer to disambiguate
---------
Co-authored-by: NathanHandley <nathanhandley@protonmail.com >
2024-02-10 12:25:00 -03:00
Nathan Handley
425a490a7b
feat(Core/Unit): New helper HasActivePowerType and script hook OnPlayerHasActivePowerType ( #18293 )
...
* Create HasActivePower for script intercept
* Replace relevant player-related getPowerType() comparators with HasActivePowerType
* Change OnPlayerHasActivePowerType to regular bool instead of optional
---------
Co-authored-by: NathanHandley <nathanhandley@protonmail.com >
2024-02-09 06:27:02 -03:00
Kitzunu
7a859da266
fix(Script/Spell): Vanish Purge behavior ( #18127 )
2024-01-07 12:03:53 -03:00
Alethrion
b2fcc1babf
fix(Core/Unit): Remove delay for Conflagrate aura state ( #18068 )
...
Removes ConflagrateAuraStateDelayEvent
Cherry-picked from: e27c385b48
Co-authored-by: Ariel Silva <ariel-@users.noreply.github.com >
2024-01-01 07:59:23 -03:00
Tristan 'Natrist' Cormier
ac676f87ab
chore(Core/Player): remove unused AnticheatSetSkipOnePacketForASH() function ( #17947 )
2023-12-09 01:09:52 +01:00
Andrew
5a4fdc7de4
fix(Core/Spells): Banish should only be dispelled by Mass Dispel ( #17703 )
...
* fix(Core/Spells): Banish should only be dispelled by Mass Dispel
* Update Unit.cpp
* Update Unit.cpp
2023-11-14 16:27:37 +01:00
Kitzunu
bbadc32bea
Revert Visibility Notifier changes ( #17682 )
...
* Revert "fix(Core/Grid): Implement missing GridUnload setting (#17569 )"
This reverts commit 79b39f9655 .
* Revert "fix(Core/Grid): Address bugs and performance issues introduced by visibility notifier implementation (#17480 )"
This reverts commit 60e27511c5 .
* Revert "fix(Core): GridCleanUpDelay Log (#17436 )"
This reverts commit 90b16ca065 .
* Revert "feat(Core/Grids): Implement visibility notifier (#15919 )"
This reverts commit 2779833768 .
2023-11-12 00:48:49 +01:00
Kitzunu
f757e93da5
refactor(Core/Misc): Make DeathState enum class ( #17607 )
2023-10-28 10:54:03 +02:00
AG
60e27511c5
fix(Core/Grid): Address bugs and performance issues introduced by visibility notifier implementation ( #17480 )
...
* Bug fixes
- Corrected std::chrono from seconds to milliseconds
- Got rid of leftover code that caused objects to not show up on time
* Removed logic to set gameobject as active
- More alignement with TC.
- Reduces CPU usage drastically
* Revert back to using time_t instead of std chrono
* Invoke SetNoCreate() method to reduce CPU usage drastically
* Remove setActive from static and motion transports
* Fix performance issues
* Added SetFarVisible to WG and some dungeon scripts
- Also removed setActive(true) from creatures in Wintergrasp. As for gameobjects they are set to active upon being damaged/destroyed and removed from active on rebuild (reset)
* Removed comments related to VISIBILITY_COMPENSATION
* Fix log
* Deleted unused files + corrected a check
* Added missing header
* Removed unused parameter
* Removed another unsued parameter
* Changed vector to set for i_visibleNow
- Changed vector to set for i_visibleNow in VisibleNotifer
- Adjusted HaveAtClient to accept Object*
- Adjusted SendUpdateToPlayer to send createobject packet only if not known to client
2023-10-23 05:37:11 -03:00
KJack
99bf49e0dd
Fix (core/SpellEffects): Don't randomize summoned guardian position if target is in the DB ( #17506 )
...
* Doesn't randomize placement of guardian summons if the target position was specified in the DB
* Add `HasRadius()` check
* Add check for zero-radius effects, update IF condition style
* Accept IF condition statement suggestion
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
---------
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
2023-10-17 00:07:47 +02:00
Skjalf
cc60bc0c35
fix(Scripts/Spells): Fix Healing & Mana injectors not giving bonus to… ( #17348 )
...
* fix(Scripts/Spells): Fix Healing & Mana injectors not giving bonus to engineers
* Update SpellEffects.cpp
* Update spell_item.cpp
2023-09-25 06:10:23 -03:00
UltraNix
c3acf75618
fix(Core/Spells): Taunt always set proper target while channelling sp… ( #13948 )
...
* fix(Core/Spells): Taunt always set proper target while channelling spells.
Fixes #13841
* Update.
* Update.
2023-08-06 03:16:05 +02:00
Synful-Syn
f84d786df0
chore(Scripts/Spells): Reduce the amount of player checks ( #16719 )
...
merge some player checks
2023-07-17 08:24:18 -03:00
Tereneckla
a234314d35
fix (Core/Spells) Apply Seals of Pure talent to Seal of Vengeance/Corruption again ( #16559 )
...
Update SpellEffects.cpp
2023-06-30 09:18:02 -03:00
Tereneckla
6fe6f891fc
Revert "fix(Core/Spells): Seal of Command, Seal of Vengeance and Seal… ( #15938 )
...
* Revert "fix(Core/Spells): Seal of Command, Seal of Vengeance and Seal of Corr… (#15193 )"
This reverts commit 88401360ab .
* Keep Divine Storm in SPELLFAMILIY_PALADIN case
* Update SpellEffects.cpp
2023-05-13 14:41:27 -03:00
Kitzunu
7eafd35190
chore(Spell/Effects): Small improvement to EffectDistract ( #15920 )
...
* chore(Spell/Effects): Small improvement to EffectDistract
* Update SpellEffects.cpp
2023-04-21 07:41:01 -03:00
UltraNix
88401360ab
fix(Core/Spells): Seal of Command, Seal of Vengeance and Seal of Corr… ( #15193 )
2023-03-04 17:40:33 -03:00
UltraNix
e3ed2e99e6
fix(Core/Spells): Goblin Rocket Helmet should not cause auto-attack. ( #15207 )
2023-03-04 17:39:05 -03:00
Kitzunu
f039836a2f
chore(Core/Misc): Change all TODO to doxygen comment ( #14966 )
2023-02-12 10:05:34 -03:00
Skjalf
2aeeee9c83
fix(Core/Spells): Remove all hardcoded restrictions for pick pocket sp… ( #14788 )
...
Co-authored-by: Shauren <shauren.trinity@gmail.com >
2023-01-29 12:12:21 -03:00