Commit Graph

2380 Commits

Author SHA1 Message Date
Nefertumm
298b08c9a5 fix(Core/ZulGurub): Hazza'rah improvements (#12236)
* fix(Core/ZulGurub): Hazza'rah improvements

* dumb
2022-07-01 20:22:13 +02:00
UltraNix
e924289405 fix(Core): Crashfix. (#12184) 2022-06-28 20:04:23 -03:00
UltraNix
8c1b729375 fix(Core/Spells): Removed any triggered auras on glyph removal. (#12168)
* fix(Core/Spells): Removed any triggered auras on glyph removal.

Fixes #11939

* Update.
2022-06-28 16:19:35 -04:00
UltraNix
ea24a7b231 fix(Scripts/ZulGurub): Mandokir's Threatening Gaze. (#12095)
* fix(Scripts/ZulGurub: Mandokir's Threatening Gaze.

Boss can melee attack while casting.
Boss charges after the debuff run out.
Guillotine is casted on hit rather than on launch.
Properly coded Threatening Gaze Charge (with dot/hot exceptions)
Whirlwind is removed during charge.
Fixes #11748

* Update

* missing

* Update

* Update.

* Update.

* Update.

* Update.

* Update.
2022-06-26 04:50:50 -03:00
UltraNix
255c5d8b72 fix(Core): Crashfix. (#11903)
* fix(Core): Crashfix.

Fixes #11650

* Update.
2022-06-26 04:50:22 -03:00
Nefertumm
64a0cbba5a fix(Core/ZulGurub): Hakkar improvements (#12134)
* fix(Core/ZulGurub): Hakkar improvements

* remove debug

* code improvements

* just select the current victim for cause insanity

* remove will of hakkar <.<

* aspect of arlokk and marli should do a threat wipe

* dumb
2022-06-26 04:47:08 -03:00
UltraNix
68d026e8ac fix(Core/Spells): Fixed cooldowns on shaman totems. (#12166)
Fixed #11937
2022-06-26 04:46:22 -03:00
Skjalf
46789d5df6 fix(Scripts/BlackwingLair): Correct Bone Constructs abilities (#12180) 2022-06-26 04:45:15 -03:00
UltraNix
ee7539e117 fix(Core/LFG): Fixed joining seasonal bosses if only `LFG_OPTION_ENAB… (#12163)
fix(Core/LFG): Fixed joining seasonal bosses if only `LFG_OPTION_ENABLE_SEASONAL_BOSSES` is set.

Fixes #12135
2022-06-26 04:44:45 -03:00
UltraNix
e11fea28c5 fix(Core/Units): Fixed problems with charming non-demon creatures by … (#12164)
fix(Core/Units): Fixed problems with charming non-demon creatures by warlock.

Fixed #12114
2022-06-26 04:44:30 -03:00
UltraNix
53836284c2 fix(Core/Spells): Shaman T10 4Set bonus should properly extend Flame … (#12167)
* fix(Core/Spells): Shaman T10 4Set bonus should properly extend Flame Shock duration.

Fixes #11938

* Update.
2022-06-26 04:44:15 -03:00
Julio A. Leyva Osorio
37c1ce5e36 fix(core): Npc gossip error logging (#11999) 2022-06-24 12:35:25 -03:00
UltraNix
113bdacb5f fix(Core/Tools): Revert "Handle different slopes in mmaps and Add so… (#12111)
...me more input parameters to improve"

This reverts commit b544eb420e.
Fixes #12079
2022-06-21 16:07:53 -03:00
Kitzunu
73bd2b446c fix(Core/Groups): Level restriction on allowing raid groups (#12110) 2022-06-21 13:18:03 -03:00
Skjalf
ed7622b028 feat(Core/Formations): Implement GROUP_AI_FLAG_DONT_RESPAWN_LEADER_ON… (#12128) 2022-06-21 07:07:41 -03:00
UltraNix
61c64bbf30 fix(Core/Movement): Water-bound creatures should not evade if their t… (#12112)
fix(Core/Movement): Water-bound creatures should not evade if their target is near the surface/jumping in the water.

Fixed #10383
2022-06-20 14:31:28 -04:00
Nefertumm
2db5f9a231 fix(Core/ZulGurub): Mandokir charge and chained spirits (#12072)
* fix(Core/ZulGurub): Mandokir charge and chained spirits

* build

* properly script threatening gaze

* refactor vilebranch speaker script

* remove useless trigger spell for Frightening Shout

* blank spaces

* build...

* sadly you can cheese threatening gaze

* revert threatening gaze part

* style

* charge should target the farthest one

* revert last thing of threatening gaze

* mod charge
2022-06-19 07:50:52 -04:00
UltraNix
1bb343c847 fix(Core/Professions): Players should be able to update gathering ski… (#12033)
fix(Core/Professions): Players should be able to update gathering skill only once per gameobject.

Fixes #11918
2022-06-19 07:46:56 -04:00
UltraNix
a935e51754 fix(Core/Pets): Mob "soloed" by pet should not grant exp/loot to its … (#11969)
* fix(Core/Pets): Mob "soloed" by pet should not grant exp/loot to its master.

Fixes #11528
2022-06-19 07:46:23 -04:00
UltraNix
82cfd1b8d4 fix(Scripts/ZulGurub): Improvements to Madonkir's melee spells. (#12096)
Overpower is casted on dodge.
Execute is casted when victim is below 20% health.
Cleave is casted when there is at least 5 targets in melee range.
Fixes #11747
2022-06-18 13:50:23 -04:00
UltraNix
39c0f1a700 feat(Core/Players): Enabled resurrecting players from opposite factio… (#12012)
* feat(Core/Players): Enabled resurrecting players from opposite faction in crossfactioned raids.

Fixes #8600

* Update
2022-06-18 13:49:35 -04:00
Luis Vaz
37ee4c6a88 fix (core): value of the MAX_ARENA_SLOT const
Update ArenaTeam.h
2022-06-18 13:48:24 -04:00
UltraNix
0cf1303b9a fix(Core/Items): Special bags cannot be stored inside other special b… (#12032)
fix(Core/Items): Special bags cannot be stored inside other special bags.

Fixes #11946
2022-06-18 13:46:00 -04:00
UltraNix
2cde0c35ba fix(Core/Spells): Fixed calculating LoS for dynamic objects. (#12090)
Fixed #12080
2022-06-18 11:08:07 -04:00
UltraNix
d41cf026e0 fix(Core/Spells): Fixed calculating LoS checks for spells casted by g… (#12091)
fix(Core/Spells): Fixed calculating LoS checks for spells casted by gameobjects.

Fixed #12066
2022-06-18 11:05:18 -04:00
Maelthyr
d928d8d96a refactor(Core/Unit): PC&NPC Immunity (#11986)
* initial

* refactor(Core/Unit): PC & NPC Immunities

Cherry-pick TC: 74af880217

Co-authored-by: Treeston <treeston.nmoc@gmail.com>

* fix builds error

Cherry-pick TC: 74af880217

Co-authored-by: Treeston <treeston.nmoc@gmail.com>

* Fix nef combat, and replace SetFlag by SetUnitFlag

* fix combat with jedoga

Co-authored-by: Treeston <treeston.nmoc@gmail.com>
2022-06-18 08:16:45 -04:00
UltraNix
117a18c961 fix(Scripts/ZulGurub): Renataki - improvements: (#11967)
Added missing spells and events.
Removed invalid spells
Corrected event timers
Fixes #11620
Fixes #11621
2022-06-16 11:39:09 -03:00
UltraNix
daff1239d3 fix(Core/Units): Fixed restoring running movement flag after charm. Source: TrinityCore (#12019)
fix(Core/Units): Fixed restoring running movement flag after charm.

Fixes #12018
2022-06-16 08:45:46 -03:00
Nefertumm
396fd35ed5 fix(Core/Spells): Implement SPELL_EFFECT_ACTIVATE_OBJECT (#11648)
Co-authored-by: jackpoz <giacomopoz@gmail.com>
2022-06-13 21:10:31 -03:00
UltraNix
d5221ae423 fix(Scripts/ZulGurub): Fixed Jindo's Brain Wash Totem. (#11839) 2022-06-13 21:04:58 -03:00
Maelthyr
32334f5f14 refactor(Core/Unit): minor changes for the combat system (#11904)
Cherry-pick from TC: https://github.com/TrinityCore/TrinityCore/pull/19966

Co-authored-by: Treeston <treeston.nmoc@gmail.com>
2022-06-13 19:40:29 -03:00
Kempec Halk
8e7c4fa226 fix(Core): Deserter overrides from BG and Command (#11961)
* fix(Core/Command): Deserter offline add

* feat(Core/Command): Deserter online add restriction

* fix(Core/Battleground): Deserter overrides longer debuff
2022-06-13 08:58:49 -03:00
UltraNix
db41a0132e fix(Core/Misc): Fixed radius of areatriggers in battlegrounds. (#12017)
* fix(Core/Misc): Fixed radius of areatriggers in battlegrounds.

Fixes #12004

* buildfix.
2022-06-13 08:57:35 -03:00
Eddy Vega
3b0cd43d12 fix(scripts/ZulGurub): Rewrite Broodlord Mandokir and Ohgan (#11854)
Co-authored-by: Nefertumm <nefertum.dev@protonmail.com>
2022-06-13 08:52:28 -03:00
UltraNix
a2bc0ae028 fix(Core/Objects): Include combat reach instead of object size in LoS… (#12013)
... calculations.

Fixed LoS calculations for dynamic objects.
Modified combat reach of Deep Pool Threshfin.
Fixes #11886
2022-06-13 01:03:06 -03:00
UltraNix
bab2c6291b fix(Core/Spell): Fixed Divine Shield not granting immunity to spell s… (#11954)
...chools.
2022-06-07 23:43:36 -03:00
UltraNix
41b0fa02f2 fix(Scripts/ZulGurub): Shade of Jin'do's invisibility aura should not… (#11838)
* fix(Scripts/ZulGurub): Shade of Jin'do's invisibility aura should not be removed on attack.

Fixes #11557

* missing stuff.

* Update.
2022-06-06 15:20:40 -03:00
Skjalf
5c7e7afade fix(Scripts/ZulGurub): Rewrite High Priest Thekal (#11784) 2022-06-06 09:35:48 -03:00
UltraNix
228b2f6f6b fix(Core/Movement): Improved fleeing movement generator. (#11896)
* fix(Core/Movement): Improved fleeing movement generator.

Fixes #11850

* Update.
2022-06-06 09:19:27 -03:00
UltraNix
f28c678c14 fix(Core/Spells): Hunter traps should not be activated by targets not… (#11971)
fix(Core/Spells): Hunter traps should not be activated by targets not in LoS.

Fixes #11432
2022-06-06 09:03:24 -03:00
UltraNix
3f8bf7f994 fix(Core/Spells): Properly handle SPELL_MOD_THREAT flat spell mods. (#11911)
* fix(Core/Spells): Properly handle SPELL_MOD_THREAT flat spell mods.

Fixes #11570

* buildfix.
2022-06-06 09:01:32 -03:00
天鹿
40a5eef152 refactor(Core/Instances): Update CHAR_DELETE_INSTANCE_SAVED_DATA (#11866)
* Update InstanceSaveMgr.cpp

* Update Group.cpp

* Update InstanceSaveMgr.cpp

* Update InstanceSaveMgr.h

* Update InstanceSaveMgr.cpp

* Update InstanceSaveMgr.h

* Update InstanceSaveMgr.cpp

* Update InstanceSaveMgr.h

* Update InstanceSaveMgr.cpp

* Update Group.cpp

* Update PlayerMisc.cpp

* Update InstanceSaveMgr.h

* Update Group.cpp

* Update PlayerMisc.cpp

* Update Group.cpp

* Update Group.cpp

* Update InstanceSaveMgr.cpp

* Update InstanceSaveMgr.h

* Update Group.h

* Update InstanceSaveMgr.cpp

* Update InstanceSaveMgr.cpp

* Update InstanceSaveMgr.cpp
2022-05-30 15:27:50 -03:00
UltraNix
a0da7417a0 fix(Core/Units): Clear any movement on charm - vol. 2. (#11897)
* fix(Core/Units): Clear any movement on charm - vol. 2.

Fixes #11880

* Update.
2022-05-30 04:19:53 -03:00
UltraNix
7b4e1ef7d3 fix(Core/Spells): Shadow Weaving should not proc off from DoTs. (#11825) 2022-05-25 05:00:05 -03:00
UltraNix
b66586c1d7 fix(Core/Spells): Fixed players being able to mount with all transfor… (#11767)
…m auras.

Co-authored-by: Shauren <shauren.trinity@gmail.com>
2022-05-25 04:56:35 -03:00
Hanabi
a6a2ca8ef7 feat(Core/GameObjects): Instance gameobject save data implementation (#11113)
* fix(Core): Save gameobject state on instances

Currently, azerothcore doesn't save gameobject states on instances.
Whenever there's a re-start or crash, the instance's gameobjects and
their states aren't saved, producing un-wanted behaviours and blocking instances at times.

Implemented CRUD for new table `instance_saved_data` that holds the states of gameobjects.

- When worldserver launches and gameobjects are loaded, this will check
  if this object's state exists on the DB and sets the previous state.
- On instance deletion (reset) these states are also removed based on
  the instance ID.
- Whenever a gameobject state changes inside a dungeon or raid, we save
  on the database the set state.

* Select query to synchronous and used FindMap()

* loading gameobject states on create

* reseting instance saved data

* missing reset methods and on create state

* database structure

* Update src/server/game/Entities/GameObject/GameObject.cpp

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* Update src/server/game/Entities/GameObject/GameObject.cpp

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* Update src/server/game/Entities/GameObject/GameObject.cpp

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* Update src/server/game/Entities/GameObject/GameObject.cpp

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* Update src/server/game/Entities/Player/PlayerMisc.cpp

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* Update src/server/game/Groups/Group.cpp

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* codestyle

* table changes

* table style

* codestyle

* table changes for columns

* data sanitization

* todo:

- Finish loading db data into the containers
- Using containers to find data
- How to get data from ObjectMGR inside Gameobject?

* loading on start up and db changes

* Removing unused data structure

* Uninitialised integer

* Whitespace

* clean-up and hooks to save states on memory

* Codestyle MySQL deprecated backticks

* i dont understand codefactor

* build

* Update data/sql/updates/pending_db_world/rev_1643395587559675400.sql

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* Update src/server/game/Globals/ObjectMgr.h

Co-authored-by: Kargatum <dowlandtop@yandex.com>

* review changes

* unecessary removal

* pushback instead of emplace

* wrong database update

* Update ObjectMgr.cpp

* missing check

* removing entry from the PR

* missing removals

* last delete

* build

* aha! Found the culprit for the sudden assert errors

* type safety, save only important gameobjects

* static cast to unsigned short

* Update data/sql/updates/pending_db_characters/rev_1643629468629316100.sql

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* type changes

* queries fix

* fix build

* enabling which gameobjects to save on the database

* deadmines iron clad door

* Adjustment to gameobject onj create state and instances:

- Gnomeregan doors and Grubbis boss state
- Deadmines missing doors
- Stratholme gameobjects state saved

* forgot emi blastfuse change to despawn

* Leaving group logic

* codestyle

* fixing merge issues

* prevent bad behaviour

* brain meltdown

* Update data/sql/updates/pending_db_characters/rev_1643629468629316100.sql

* Update data/sql/updates/pending_db_world/rev_1649359139539727000.sql

Co-authored-by: Claudiodfc <54484196+claudiodfc@users.noreply.github.com>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
Co-authored-by: Kargatum <dowlandtop@yandex.com>
Co-authored-by: Skjalf <47818697+Nyeriah@users.noreply.github.com>
2022-05-24 10:33:45 -03:00
UltraNix
b638d44693 fix(Core/Units): Clear any movement on charm. (#11826)
Fixes #10343
2022-05-23 06:04:27 -03:00
Maelthyr
dfc6adb081 refactor(Core/Combat): DeleteThreatLists() become ClearAllThreat() (#11824)
refactor(Chore/Combat): DeleteThreatLists() become ClearAllThreat()
2022-05-23 05:51:52 -03:00
UltraNix
55720eedd3 fix(Scripts/Spells): Sweeping Strikes - improvements. (#11666)
* fix(Scripts/Spells): Sweeping Strikes - improvements.

Fixes #11594

* Buildfix.
2022-05-23 05:49:56 -03:00
UltraNix
bcfaf2daad fix(Scripts/Spells): Replenishment should proc off from Vampiric Touc… (#11772)
* fix(Scripts/Spells): Replenishment should proc off from Vampiric Touch even if target died from Mind Blast.

Fixes #8502

* Update.
2022-05-23 05:45:01 -03:00