Commit Graph

4375 Commits

Author SHA1 Message Date
Francesco Borzì
54fadbda67 refactor(src/server/game/Entities): remove unused imports (#19507) 2024-07-28 16:39:39 -03:00
Kitzunu
4785aabbf2 fix(Scritps/AV): Use db defined text for Herald (#19486)
* fix(Scritps/AV): Use db defined text for Herald

* closes https://github.com/azerothcore/azerothcore-wotlk/issues/19483

* indent

* Update BattlegroundAV.cpp

* fix build

* remove from acore_string

* Update BattlegroundAV.h
2024-07-28 01:44:03 +02:00
Kitzunu
6c0afe1810 refactor(Core/WorldSession): Make SendNotification use fmt and parse acore_string (#19489)
* refactor(Core/WorldSession): Make SendNotification use `fmt`

* Make SendNotification use `fmt`

* Make SendNotification parse acore_string entries
2024-07-28 01:25:06 +02:00
Kitzunu
034a4c0ff6 fix(Core/Chat): Exempt addon messages from CONFIG_CHAT_MUTE_FIRST_LOGIN (#19472)
* closes https://github.com/azerothcore/azerothcore-wotlk/issues/19471
2024-07-27 08:21:23 -03:00
Jelle Meeus
a9e4d3d37e refactor(Scripts/RubySanctum): Spell Scripts registry macros (#19487) 2024-07-27 08:17:06 -03:00
天鹿
c8cb2e55ee chore(Core/Authserver): Remove redundant conversion during Reconnect Proof cmd (#18957)
https://github.com/TrinityCore/TrinityCore/pull/26765
Author: [walkline](https://github.com/walkline)
2024-07-27 07:43:07 -03:00
Kitzunu
5da3e2e688 refactor(Core/SmartScripts): Change invoker to be WorldObject (#19408)
* refactor(Core/SmartScripts): Change invoker to be WorldObject

* avoid dangling else

* womp womp

* check for null

* null check

* Update SmartScript.cpp

* Avarishd broke it for sure

* remove redundant check

* reduce more redundant code

* who doesnt love redundancy
2024-07-27 07:32:55 -03:00
Gultask
e34ce755c8 fix(Scripts/ShadowmoonValley): Rewrite Dragonmaw Races (#19084)
* init

* fly :)

* finally

* melee attack :/

* Update zone_shadowmoon_valley.cpp

Co-Authored-By: Dan <83884799+elthehablo@users.noreply.github.com>

* Update zone_shadowmoon_valley.cpp

* Update zone_shadowmoon_valley.cpp

* Update zone_shadowmoon_valley.cpp

---------

Co-authored-by: Dan <83884799+elthehablo@users.noreply.github.com>
2024-07-27 07:32:17 -03:00
avarishd
3c9dc6ed78 fix(Core/Unit): Split Damage auras should ignore LOS (#19357) 2024-07-27 07:31:22 -03:00
atrapalis
138c18dbd3 fix(Core/LootMgr): Improved drop checks for items that start quests (#19463)
* fix(Core/LootMgr): Improved drop checks for items that start quests to prevent unnecessary or inappropriate drops

* Tweaked 2nd condition to only be valid for unique items
2024-07-27 07:18:37 -03:00
Gultask
917c34cf52 fix(Scripts/BlackTemple): Move Supremus to TaskScheduler and tweak a bit (#19418)
* Update boss_supremus.cpp

* Update boss_supremus.cpp

* Update boss_supremus.cpp

* ble

* egh

* ye

* ermps

* ok done

* Update SpellInfoCorrections.cpp

* Update SpellInfoCorrections.cpp
2024-07-26 21:48:33 -03:00
Tereneckla
f3c561032e fix (script/SSC) Enchanted Elementals follow Vashj (#19477)
* elementals follow vashj

* ) :)
2024-07-26 21:47:46 -03:00
Tereneckla
6289be19c7 fix (Core/Spells): Commanding Shout and Blood Pact remember percentage of health (#19479)
* Update SpellAuraEffects.cpp

* add comment
2024-07-26 21:47:04 -03:00
avarishd
6e0853dd76 feat(Scripts/Commands): .aura stack - Modify aura stacks (#19462)
* feat(Scripts/Commands): .aurastack - Modify aura stacks

* aura stack

* remove aur check

* {}

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

---------

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2024-07-26 20:00:37 -03:00
Francesco Borzì
dc3dfd3ab0 refactor(Scripts/Kalimdor): remove unused imports (#19459)
* refactor(Scripts/Kalimdor): remove unused imports

* chore: remove duplicate blank line

* chore: damn linking issue

* chore: wip

* chore: wip

* chore: wip
2024-07-26 19:58:11 -03:00
Francesco Borzì
af769c6c7e refactor(Scripts/Northrend): remove unused imports (#19460)
* refactor(Scripts/Northrend): remove unused imports

* chore: wip
2024-07-26 19:56:33 -03:00
Benjamin Jackson
6c97e45e87 fix(Scripts/HyjalSummit): Adjust Doomfire Spirit movement logic. (#19469)
* Init.

Co-Authored-By: Tereneckla <Tereneckla@pm.me>

* Simplify code, add comment.

* Adjust scenario in which distance fails at all ranges.

* Remove unused variable.

* Account for deviation with distance check.

Co-Authored-By: Tereneckla <Tereneckla@pm.me>

* f

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* Rewrite with initial teleport.

* Whitespace?

* Update function type.

* Drop Doomfire spawn timer.

Verified with le sniff. Teehee.

---------

Co-authored-by: Tereneckla <Tereneckla@pm.me>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2024-07-25 20:50:15 -03:00
Kitzunu
7c68ba51e7 fix(Scripts/Commands): serv info (#19478) 2024-07-25 18:40:54 -03:00
Tereneckla
be256e7a78 fix(scripts/HyjalSummit): Make Doomfire Spirit move away from Archimonde at first (#19467)
Update boss_archimonde.cpp
2024-07-24 11:00:07 -03:00
Kitzunu
3fbded8f6b refactor(Core/Chat): PSendSysMessage to fmt (#19449)
* refactor(Core/Chat): PSendSysMessage to `fmt`
2024-07-23 23:48:46 +02:00
Francesco Borzì
e8bd391505 refactor(Scripts/EasternKingdoms): remove unused imports (#19457) 2024-07-23 08:56:46 -03:00
Francesco Borzì
e592fdd248 refactor(Scripts/misc): remove unused imports (#19458) 2024-07-22 16:20:41 -03:00
Francesco Borzì
393d9a5987 refactor(Scripts/Outland): remove unused imports (#19461) 2024-07-21 19:15:20 -03:00
avarishd
618f97bee6 feat(Core/Unit): Enable/Disable Daze config (#19454)
* daze

* bruh

* bruhx2
2024-07-20 15:53:00 -03:00
Kitzunu
21f86d1c3c chore(Core/Misc): Remove deprecated code (#19413)
* Config - Deprecated for 3 years
* ChatCommand - Deprecated for 2 years
* getLevel() - Deprecated for 2 years
* SendGlobalText - Deprecated for 8 years +
2024-07-20 09:11:01 +03:30
sudlud
4b506a8cdd fix(Scripts/FireworkShow): set firework gameobjects active (#19403)
- improve visibility of the show
- prevent glitches in the show execution
- each gameobject only exists for a very short duration, so there
  should be no relevant performance impacts
2024-07-19 17:08:46 +02:00
Kitzunu
332446b8aa fix(Scripts/ChatLogger): Differentiate addon whisper from player whisper (#19441)
* fix(Scripts/ChatLogger): Differentiate addon whisper from player whisper

* closes https://github.com/azerothcore/azerothcore-wotlk/issues/19439
* closes https://github.com/azerothcore/azerothcore-wotlk/issues/17570

* fix build
2024-07-19 15:26:34 +02:00
Kitzunu
428fb73e79 fix(Scripts/Reload): Only send reload output to GMs (#19443) 2024-07-19 14:45:14 +02:00
Gultask
5081b0affd fix(Scripts/BlackTemple): Vengeful Spirit, Shadow of Death Remove (#19432)
* init

* shadowremove

* Update boss_teron_gorefiend.cpp
2024-07-19 12:34:14 +02:00
Gultask
f07da20a42 fix(Scripts/BlackTemple): Ashtongue Defenders unable to attack Akama (#19435)
Update boss_shade_of_akama.cpp
2024-07-19 12:30:38 +02:00
Benjamin Jackson
94d3caaf1b fix(Core): Further adjust packet structure for attack stop opcode. (#19438)
* Init.

* Fixy fix.
2024-07-19 06:58:58 -03:00
Jelle Meeus
2d1e4393ba fix(Spells/SpellInfoCorrections): remove AURA_INTERRUPT_FLAG_NOT_ABOVEWATER from some mounts (#19431)
remove AURA_INTERRUPT_FLAG_NOT_ABOVEWATER for some mounts
2024-07-18 21:56:12 -03:00
Benjamin Jackson
295e4dd3c6 fix(Core): Correct packet structure for combat stop messages. (#19434)
* Init.

* Reviewed changes.
2024-07-18 21:19:36 -03:00
Kitzunu
486cbb3970 fix(Scripts/ChatLog): Whoopsies (#19430) 2024-07-18 19:31:12 -03:00
Kitzunu
ab52e1f164 chore(Scripts/ChatLog): Cleanup the code (#19411)
* chore(Scripts/ChatLog): Cleanup the code

* Update chat_log.cpp

* remove more redundant code
2024-07-18 22:46:01 +02:00
Kitzunu
59766e10c6 fix(Core/Spell): Allow using SpellDifficulty in bg (#19422)
* fix(Core/Spell): Allow using SpellDifficulty in bg

* cherry-pick commit (e4caf52e5a)

* "Allow get SpellDifficulty on battleground maps
This is only for Isle of Conquest (Bracket 71-79 is Regular Difficulty, Bracket 80-84 is heroic or 25Man)
Spells of IoC Battleground vehicles, cannons, bombs and bosses have SpellDifficulty in DBC"

* Remove redundant CastSpell and assign a variable instead

Co-Authored-By: Gildor <521036+Jildor@users.noreply.github.com>

* Update isle_of_conquest.cpp

---------

Co-authored-by: Gildor <521036+Jildor@users.noreply.github.com>
2024-07-18 18:12:41 +02:00
avarishd
ade4c2527f fix(Core/Spells): Restore sending SMSG_CAST_FAILED for spells in SPEL… (#19102)
* fix(Core/Spells): Restore sending SMSG_CAST_FAILED for spells in SPELL_STATE_PREPARING state (cast bar in progress) unintentionally removed

https: //github.com/TrinityCore/TrinityCore/commit/844efbfca84580f7b2bd700f40209515f2aaa959
Co-Authored-By: Shauren <shauren.trinity@gmail.com>

* ocd

* correct animation and castbar staying

---------

Co-authored-by: Shauren <shauren.trinity@gmail.com>
2024-07-17 09:14:06 -03:00
avarishd
cf7c015ea4 fix(Core/Spell): Implement SPELL_ATTR6_NO_PUSHBACK (#19292)
fix(Core/Spell): ImplementSPELL_ATTR6_NO_PUSHBACK
2024-07-17 09:09:34 -03:00
avarishd
f510e122a0 fix(Script/Quest): Protecting Our Own (#19247)
* fix(Core/Spells): Gor'drek's Ointment

* Update spell_item.cpp

* ;
2024-07-17 13:19:48 +02:00
Jelle Meeus
5674c23d04 fix(Scripts/BlackwingLair): Nefarian say low health and rewrite p3 (#19405)
* Nefaran says low hp and shadowflame texts, use ScheduleHealthCheckEvent

* use drakonic bone spells

* remove no longer needed _scheduler

* remove extra file
2024-07-17 08:09:38 -03:00
Jelle Meeus
9f5b01ab37 fix(Core/Unit): add melee spell breaking for spells with cast time (#19376)
melee spells breaking
2024-07-17 12:49:43 +02:00
Saqra1
a950a7f44e fix(Core/Pets): Add option to revive pets with full mana (#19383)
* fix(Scripts/Spells): Revive pets with full mana in bgs

* Pets were incorrectly revived without restoring its mana

* Closes #15894

* ready for merge

---------

Co-authored-by: Saqra1 <>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2024-07-17 12:38:10 +02:00
Jelle Meeus
e8af1aaffc fix(Scripts/Spells): warlock seed of corruption (#19322)
* remove seed of corruption handling in unit.cpp

* add generic and warlock aurascript

add warlock  aurascript

add enum

add generic aurascript

add OnRemove

2ff855054f (diff-ea612aafadff90005e88b243eb000369be9e5cb6f8dc85a008d31e42b156e0ec)

detonation threshold scaling added in: df5afca278

Co-authored-by: ariel- <ariel-@users.noreply.github.com>

* add LoS check to generic damage

* refactor 2 scripts to 1 with args

refactor const_cast to GetAura()->GetEffect(

refactor reduce a line

* fix detonation threshold scaling

changed SPELL_DIRECT_DAMAGE to DOT

* remove not needed IsExpired() check

removal upon expiration is notified by AURA_REMOVE_BY_EXPIRE

* update comment

* refactor script with args to single spellscript, fix detonate by evade

* refactor

detonation to Detonate()
rename amount to remainingDamage
remove no tneeded HealthBelowPctDamaged

* refactor to 2 spell scripts again

* rename detonation spell from seed_of_corruption to seed_of_corruption_damage

avoids confusion with seed of corruption (with dot effect)

---------

Co-authored-by: ariel- <ariel-@users.noreply.github.com>
2024-07-17 01:50:38 +02:00
Jelle Meeus
9109de6500 fix(Scripts/Karazhan): Nightbane Combat Abilities (#19321)
* fix(Scripts/Karazhan): NightbaneCombatAbilities

update fear

WIP add comments

increase air phase

* remove distracting ash from ground phase

* :sort
2024-07-17 01:46:23 +02:00
avarishd
90c7658320 fix(Script/Spells): Script Glumdor's Steal Weapon (#19258)
* fix(Core/Spells): Script Glumdor's Steal Weapon

* add creature check
2024-07-17 01:44:49 +02:00
Kitzunu
275b8b5d7f chore(Scripts/ServerMail): Cleanup the code (#19412)
* chore(Scripts/ServerMail): Cleanup the code

* try to fix build error

* okay we resort to the AIs
2024-07-17 01:33:26 +02:00
Kitzunu
f0e6b0f1ab chore(Core/GameObjectAI): Cleanup register macro (#19409) 2024-07-17 00:17:49 +02:00
Kitzunu
2008d64e7b fix(Scripts/Commands): Ticket response (#19406)
* fix(Scripts/Commands): Ticket response

* closes https://github.com/azerothcore/azerothcore-wotlk/issues/19390

* Implements two new commands
    * ticket response delete - Delete a ticket response
    * ticket response show - Show current ticket response

* this better

* English?

* bette rlogic

* Update cs_ticket.cpp
2024-07-16 03:22:23 +02:00
avarishd
e92a5829a0 fix(Scripts/ZG): Jin'do using wrong hex spell (#19389) 2024-07-14 13:24:23 -03:00
Benjamin Jackson
05f4fa1a35 fix(Core/Unit): Adjust melee attack stop logic. (#19397)
Init.
2024-07-14 12:31:40 -03:00