If a spell is both channeled and has SPELL_ATTR0_COOLDOWN_ON_EVENT
attribute (only rituals) is channeled for its full duration, it goes on
an infinite cooldown. The client needs to be notified when the ritual
ends without being completed.
* chore(Debug/Scripting): improve debug errors during script unloading
* add the script name to increase debug informations and ensure to derefence script pointers
When a pet ability was cast, PetHandler reset all CharmInfo flags before
calling PetAI methods, setting the attack flag to true every time.
This commands the pet to go and chase the target which is not correct
when the state is COMMAND_STAY.
PetAI already handles the scenario, it just wasn't getting the actual
pet attack state.
* fix: SelectTargetMethod Random replaced with MaxThreat
* restore like origin
* fix: cast Hammer Of Justice on current target instead random target
* refactor: case EVENT_SPELL_HAMMER_OF_JUSTICE statement refactored
* refactor: if statement splitted
* refactor: last space removed
* Update src/server/scripts/Outland/BlackTemple/illidari_council.cpp
Co-authored-by: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>
* fix redundant check and new line
---------
Co-authored-by: MattiaBallarini <ballarini.mattia1990@gmail.com>
Co-authored-by: Andrew <47818697+Nyeriah@users.noreply.github.com>
Co-authored-by: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>
* move several enum definitions in a new files
* move more things
* remove the include comment
* move the related code to CharmInfo in this own file
*original idea of Ovahlord
Co-Authored-By: Ovahlord <18347559+Ovahlord@users.noreply.github.com>
* fix clang build errors and few blank lines
* missing forward declaration
* new tentative to fix gcc/clang build
* add several include could be necessary for gcc/clang compilation
* .
* revert some include since the last AC update
* fix some loop inconsistencies
* align all enums in UnitDefine.h
---------
Co-authored-by: Ovahlord <18347559+Ovahlord@users.noreply.github.com>
* Init.
* Allow self-summoning.
* Revert unintended change.
Self-summoning still works fine without this being removed, I see no harm in putting it back.
* Init.
* Despawn music doodad.
* Add conditions behind events invoking performances.
* Update music doodad intervals.
55639.
* Add condition for BRD performance.
Ensures that manual performance and event performance do not overlap.
* Add scripting for Shattrath Saul.
* Add scripts for Silvermoon band members.
All verified in Cata Classic 55639.
* Whoops.
* Styling, initial Blastbolt scripting.
I don't know how to handle the roadies yet. Ugh.
* Whoops.
* Bad event param.
* Remove drumset respawn from action list.
* Update Shattrath Saul's Perry Gatner scripting.
* Ugh.
Hate SAI.
Channel the same spell as the original caster when clicking on a ritual
portal, but ignore the effects of the spell.
Co-authored-by: killerwife <killerwife@gmail.com>
* refactor(Core/ChatHandler): Cleanup retriving session and checking for valid session
* redundant
* make it clear what a "valid" session is
* HasValidSession -> HasSession
* Differentiate from "valid" which in this case would mean the player is in world which isnt checked here
* refactor(Core/World): Move SendGMText to WorldSession and allow `fmt`
- Move SendGMText from World to WorldSession
- Make SendGMText use fmt
- Make SendGMText parse acore_string entries
* Update cs_message.cpp
* tokenize the string only once
* Move to chathandler
* Update WorldSession.cpp
* make sure we have a session
