Benjamin Jackson
3b2b8406a8
fix(Core/Entities): Only add use to spell caster objects if cast succeeds. ( #19601 )
...
Init.
2024-08-12 08:46:20 -03:00
Kitzunu
7b102f53f2
fix(Core/Chat): Correct misstake in b81bcfb causing outputs to CLI not working properly ( #19593 )
...
fix(Core/Chat): Correct misstake in b81bcfbfea causing outputs to CLI not working properly
* closes https://github.com/azerothcore/azerothcore-wotlk/issues/19592
2024-08-11 08:42:37 -03:00
Kitzunu
b81bcfbfea
refactor(Core/ChatHandler): Cleanup retriving session and checking fo… ( #19585 )
...
* refactor(Core/ChatHandler): Cleanup retriving session and checking for valid session
* redundant
* make it clear what a "valid" session is
* HasValidSession -> HasSession
* Differentiate from "valid" which in this case would mean the player is in world which isnt checked here
2024-08-10 17:46:13 +02:00
Kitzunu
e4df159f5c
refactor(Core/Chat): Move SendNotification to ChatHander ( #19491 )
...
* refactor(Core/Chat): Move SendNotification to ChatHander
* Update Battleground.cpp
* fix build
* Update src/server/game/Chat/Chat.h
2024-08-10 11:39:46 -03:00
Kitzunu
bb7765d91e
refactor(Core/World): Move SendGMText to ChatHandler and allow fmt ( #19490 )
...
* refactor(Core/World): Move SendGMText to WorldSession and allow `fmt`
- Move SendGMText from World to WorldSession
- Make SendGMText use fmt
- Make SendGMText parse acore_string entries
* Update cs_message.cpp
* tokenize the string only once
* Move to chathandler
* Update WorldSession.cpp
* make sure we have a session
2024-08-08 20:12:33 -03:00
Gultask
09e77dfd1c
fix(Scripts/BlackTemple): Mother Shahraz Periodic part 2 ( #19561 )
...
* init
* Update boss_mother_shahraz.cpp
* Update boss_mother_shahraz.cpp
* Update boss_mother_shahraz.cpp
* Update boss_mother_shahraz.cpp
2024-08-06 11:53:19 -03:00
avarishd
fcdc50306f
fix(Core/Spells): Chromatic Resistance Aura shouldn't give holy resis… ( #19549 )
...
fix(Core/Spells): Chromatic Resistance Aura shouldn't give holy resistance
2024-08-03 12:02:49 -03:00
avarishd
c54fd66c73
fix(Core/Spells): Flame Wave ( #19144 )
...
* fix(Core/Spells): Flame Wave
* )
* .
flamewave faction id
3365e6a4b8/sql/old/9.x/world/21081_2021_10_15/2021_09_29_04_world_2018_06_17_04_world.sql (L46)
Co-Authored-By: Carlos Morales <carlos.morales@insmet.cu >
* lol
---------
Co-authored-by: Carlos Morales <carlos.morales@insmet.cu >
2024-08-02 16:20:27 -03:00
Francesco Borzì
02a05fbd4c
refactor(src/common): remove unused imports ( #19506 )
...
* refactor(src/common): remove unused imports
* fix: build
* chore: fix build
* chore: size_t -> std::size_t
* chore: fix fuckup from previous commit
* chore: fix build
* chore: fix build
* chore: fix build
* chore: fix build with std::size_t
* chore: fix build
* chore: fix build
* chore: fix build
* chore: fix build
* chore: fix build
* chore: fix build
* chore: fix build
* chore: fix build
* chore: fix build
* chore: fix build
* chore: fix build
* chore: fix build
2024-07-30 20:06:46 -03:00
Benjamin Jackson
06a608d244
fix(Core/GroupHandler): Remove bad party invite check. ( #19530 )
...
Init.
2024-07-30 20:06:07 -03:00
Kitzunu
a1e9dfce41
fix(Core/World): Crash on SendWorldText(Optional) ( #19531 )
...
* fix(Core/World): Crash on SendWorldText(Optional)
* WorldText should be sent to all sessions
* now it works
2024-07-30 22:53:11 +02:00
Justin Hanley
af6b8ce099
feat(Scripts/Commands): account set email ( #19481 )
...
* added worldserver command to set email address
* reverted sql, added Tail args
* removed pointer
* Added helper text via updatescript
* fix build
* fix build
* fixed db update
* Update data/sql/updates/db_world/2024_07_26_01.sql
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
* Update data/sql/updates/db_world/2024_07_26_01.sql
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
* fixed hander
* refactor with named params
* refactor with named params
---------
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
2024-07-30 15:33:13 +02:00
Gultask
fccfe51594
fix(Scripts/BlackTemple): Mother Shahraz Periodic Beams ( #19525 )
...
* init
* Update boss_mother_shahraz.cpp
2024-07-29 23:49:58 -03:00
avarishd
a567259770
fix(Core/Spells): [TK] Wing Buffet should be a cone. ( #19382 )
...
* fix(Core/Spells): [TK] Wing Buffet should be a cone.
* radius to 20, from 15
* Update SpellInfoCorrections.cpp
2024-07-29 21:39:36 -03:00
Kitzunu
87f4adf634
refactor(Core/Chat): Move SendWorldText(optional) to ChatHandler and … ( #19501 )
...
* refactor(Core/Chat): Move SendWorldText(optional) to ChatHandler and allow `fmt`
* Update src/server/game/Battlegrounds/BattlegroundQueue.cpp
* Update src/server/game/Battlegrounds/BattlegroundQueue.cpp
* Update src/server/game/Misc/BanMgr.cpp
* Update src/server/game/Misc/BanMgr.cpp
* Update src/server/game/Misc/BanMgr.cpp
* Update src/server/game/Misc/BanMgr.cpp
* Update src/server/game/Misc/BanMgr.cpp
* Update src/server/game/Misc/BanMgr.cpp
* Update src/server/game/Misc/BanMgr.cpp
* Update src/server/game/Misc/BanMgr.cpp
2024-07-29 14:44:13 -03:00
Tereneckla
e44e8fe109
fix (Core/Movement) Allow MoveFollow to not inherit walkstate of the target to fix Enchanted Elemental speed ( #19498 )
...
* MoveFollow with own walkstate
* switch
2024-07-29 08:30:42 -03:00
Benjamin Jackson
2b636adc2f
fix(Core/AchievementMgr): Check for null achievement before being derefenced. ( #19504 )
...
* Init.
* Reviewed changes.
2024-07-28 16:40:21 -03:00
Francesco Borzì
54fadbda67
refactor(src/server/game/Entities): remove unused imports ( #19507 )
2024-07-28 16:39:39 -03:00
Kitzunu
4785aabbf2
fix(Scritps/AV): Use db defined text for Herald ( #19486 )
...
* fix(Scritps/AV): Use db defined text for Herald
* closes https://github.com/azerothcore/azerothcore-wotlk/issues/19483
* indent
* Update BattlegroundAV.cpp
* fix build
* remove from acore_string
* Update BattlegroundAV.h
2024-07-28 01:44:03 +02:00
Kitzunu
6c0afe1810
refactor(Core/WorldSession): Make SendNotification use fmt and parse acore_string ( #19489 )
...
* refactor(Core/WorldSession): Make SendNotification use `fmt`
* Make SendNotification use `fmt`
* Make SendNotification parse acore_string entries
2024-07-28 01:25:06 +02:00
Kitzunu
034a4c0ff6
fix(Core/Chat): Exempt addon messages from CONFIG_CHAT_MUTE_FIRST_LOGIN ( #19472 )
...
* closes https://github.com/azerothcore/azerothcore-wotlk/issues/19471
2024-07-27 08:21:23 -03:00
Kitzunu
5da3e2e688
refactor(Core/SmartScripts): Change invoker to be WorldObject ( #19408 )
...
* refactor(Core/SmartScripts): Change invoker to be WorldObject
* avoid dangling else
* womp womp
* check for null
* null check
* Update SmartScript.cpp
* Avarishd broke it for sure
* remove redundant check
* reduce more redundant code
* who doesnt love redundancy
2024-07-27 07:32:55 -03:00
Gultask
e34ce755c8
fix(Scripts/ShadowmoonValley): Rewrite Dragonmaw Races ( #19084 )
...
* init
* fly :)
* finally
* melee attack :/
* Update zone_shadowmoon_valley.cpp
Co-Authored-By: Dan <83884799+elthehablo@users.noreply.github.com >
* Update zone_shadowmoon_valley.cpp
* Update zone_shadowmoon_valley.cpp
* Update zone_shadowmoon_valley.cpp
---------
Co-authored-by: Dan <83884799+elthehablo@users.noreply.github.com >
2024-07-27 07:32:17 -03:00
avarishd
3c9dc6ed78
fix(Core/Unit): Split Damage auras should ignore LOS ( #19357 )
2024-07-27 07:31:22 -03:00
atrapalis
138c18dbd3
fix(Core/LootMgr): Improved drop checks for items that start quests ( #19463 )
...
* fix(Core/LootMgr): Improved drop checks for items that start quests to prevent unnecessary or inappropriate drops
* Tweaked 2nd condition to only be valid for unique items
2024-07-27 07:18:37 -03:00
Gultask
917c34cf52
fix(Scripts/BlackTemple): Move Supremus to TaskScheduler and tweak a bit ( #19418 )
...
* Update boss_supremus.cpp
* Update boss_supremus.cpp
* Update boss_supremus.cpp
* ble
* egh
* ye
* ermps
* ok done
* Update SpellInfoCorrections.cpp
* Update SpellInfoCorrections.cpp
2024-07-26 21:48:33 -03:00
Tereneckla
6289be19c7
fix (Core/Spells): Commanding Shout and Blood Pact remember percentage of health ( #19479 )
...
* Update SpellAuraEffects.cpp
* add comment
2024-07-26 21:47:04 -03:00
avarishd
6e0853dd76
feat(Scripts/Commands): .aura stack - Modify aura stacks ( #19462 )
...
* feat(Scripts/Commands): .aurastack - Modify aura stacks
* aura stack
* remove aur check
* {}
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
---------
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
2024-07-26 20:00:37 -03:00
Kitzunu
3fbded8f6b
refactor(Core/Chat): PSendSysMessage to fmt ( #19449 )
...
* refactor(Core/Chat): PSendSysMessage to `fmt`
2024-07-23 23:48:46 +02:00
avarishd
618f97bee6
feat(Core/Unit): Enable/Disable Daze config ( #19454 )
...
* daze
* bruh
* bruhx2
2024-07-20 15:53:00 -03:00
Kitzunu
21f86d1c3c
chore(Core/Misc): Remove deprecated code ( #19413 )
...
* Config - Deprecated for 3 years
* ChatCommand - Deprecated for 2 years
* getLevel() - Deprecated for 2 years
* SendGlobalText - Deprecated for 8 years +
2024-07-20 09:11:01 +03:30
Benjamin Jackson
94d3caaf1b
fix(Core): Further adjust packet structure for attack stop opcode. ( #19438 )
...
* Init.
* Fixy fix.
2024-07-19 06:58:58 -03:00
Jelle Meeus
2d1e4393ba
fix(Spells/SpellInfoCorrections): remove AURA_INTERRUPT_FLAG_NOT_ABOVEWATER from some mounts ( #19431 )
...
remove AURA_INTERRUPT_FLAG_NOT_ABOVEWATER for some mounts
2024-07-18 21:56:12 -03:00
Benjamin Jackson
295e4dd3c6
fix(Core): Correct packet structure for combat stop messages. ( #19434 )
...
* Init.
* Reviewed changes.
2024-07-18 21:19:36 -03:00
Kitzunu
59766e10c6
fix(Core/Spell): Allow using SpellDifficulty in bg ( #19422 )
...
* fix(Core/Spell): Allow using SpellDifficulty in bg
* cherry-pick commit (e4caf52e5a )
* "Allow get SpellDifficulty on battleground maps
This is only for Isle of Conquest (Bracket 71-79 is Regular Difficulty, Bracket 80-84 is heroic or 25Man)
Spells of IoC Battleground vehicles, cannons, bombs and bosses have SpellDifficulty in DBC"
* Remove redundant CastSpell and assign a variable instead
Co-Authored-By: Gildor <521036+Jildor@users.noreply.github.com >
* Update isle_of_conquest.cpp
---------
Co-authored-by: Gildor <521036+Jildor@users.noreply.github.com >
2024-07-18 18:12:41 +02:00
avarishd
ade4c2527f
fix(Core/Spells): Restore sending SMSG_CAST_FAILED for spells in SPEL… ( #19102 )
...
* fix(Core/Spells): Restore sending SMSG_CAST_FAILED for spells in SPELL_STATE_PREPARING state (cast bar in progress) unintentionally removed
https: //github.com/TrinityCore/TrinityCore/commit/844efbfca84580f7b2bd700f40209515f2aaa959
Co-Authored-By: Shauren <shauren.trinity@gmail.com >
* ocd
* correct animation and castbar staying
---------
Co-authored-by: Shauren <shauren.trinity@gmail.com >
2024-07-17 09:14:06 -03:00
avarishd
cf7c015ea4
fix(Core/Spell): Implement SPELL_ATTR6_NO_PUSHBACK ( #19292 )
...
fix(Core/Spell): ImplementSPELL_ATTR6_NO_PUSHBACK
2024-07-17 09:09:34 -03:00
avarishd
f510e122a0
fix(Script/Quest): Protecting Our Own ( #19247 )
...
* fix(Core/Spells): Gor'drek's Ointment
* Update spell_item.cpp
* ;
2024-07-17 13:19:48 +02:00
Jelle Meeus
9f5b01ab37
fix(Core/Unit): add melee spell breaking for spells with cast time ( #19376 )
...
melee spells breaking
2024-07-17 12:49:43 +02:00
Saqra1
a950a7f44e
fix(Core/Pets): Add option to revive pets with full mana ( #19383 )
...
* fix(Scripts/Spells): Revive pets with full mana in bgs
* Pets were incorrectly revived without restoring its mana
* Closes #15894
* ready for merge
---------
Co-authored-by: Saqra1 <>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
2024-07-17 12:38:10 +02:00
Jelle Meeus
e8af1aaffc
fix(Scripts/Spells): warlock seed of corruption ( #19322 )
...
* remove seed of corruption handling in unit.cpp
* add generic and warlock aurascript
add warlock aurascript
add enum
add generic aurascript
add OnRemove
2ff855054f (diff-ea612aafadff90005e88b243eb000369be9e5cb6f8dc85a008d31e42b156e0ec)
detonation threshold scaling added in: df5afca278
Co-authored-by: ariel- <ariel-@users.noreply.github.com >
* add LoS check to generic damage
* refactor 2 scripts to 1 with args
refactor const_cast to GetAura()->GetEffect(
refactor reduce a line
* fix detonation threshold scaling
changed SPELL_DIRECT_DAMAGE to DOT
* remove not needed IsExpired() check
removal upon expiration is notified by AURA_REMOVE_BY_EXPIRE
* update comment
* refactor script with args to single spellscript, fix detonate by evade
* refactor
detonation to Detonate()
rename amount to remainingDamage
remove no tneeded HealthBelowPctDamaged
* refactor to 2 spell scripts again
* rename detonation spell from seed_of_corruption to seed_of_corruption_damage
avoids confusion with seed of corruption (with dot effect)
---------
Co-authored-by: ariel- <ariel-@users.noreply.github.com >
2024-07-17 01:50:38 +02:00
Kitzunu
f0e6b0f1ab
chore(Core/GameObjectAI): Cleanup register macro ( #19409 )
2024-07-17 00:17:49 +02:00
Kitzunu
2008d64e7b
fix(Scripts/Commands): Ticket response ( #19406 )
...
* fix(Scripts/Commands): Ticket response
* closes https://github.com/azerothcore/azerothcore-wotlk/issues/19390
* Implements two new commands
* ticket response delete - Delete a ticket response
* ticket response show - Show current ticket response
* this better
* English?
* bette rlogic
* Update cs_ticket.cpp
2024-07-16 03:22:23 +02:00
Benjamin Jackson
05f4fa1a35
fix(Core/Unit): Adjust melee attack stop logic. ( #19397 )
...
Init.
2024-07-14 12:31:40 -03:00
Jelle Meeus
a69d02e513
fix(Scripts/Spells): warlock demonic pact ( #19386 )
...
* add Demonic Pact Aura script
2ff855054f (diff-ea612aafadff90005e88b243eb000369be9e5cb6f8dc85a008d31e42b156e0ec)
Co-authored-by: ariel- <ariel-@users.noreply.github.com >
* spell_warlock aura:spell_warl_demonic_pact_aura
* fixup! spell_warlock aura:spell_warl_demonic_pact_aura
* remove not needed spell correction, flag is already set
* subtract current proc bonus before calculating new bonus
* also increase healing done
* remove Demonic Pact handling in Unit
* refactor indent, remove bonus from spell group effects e.g. totem of wrath
* Revert "refactor indent, remove bonus from spell group effects e.g. totem of wrath"
This reverts commit 104041172d34f542cc934e9f468407c36912cc7f.
* refactor indent
* manually set proc cooldown
---------
Co-authored-by: ariel- <ariel-@users.noreply.github.com >
2024-07-13 12:38:59 -03:00
Benjamin Jackson
70eb920b10
feat(Core/Unit): Implement munching as a configurable option. ( #19188 )
...
* Init.
* Correct description.
* Adjust boolean to integer in config.
2024-07-10 12:26:53 -03:00
Kitzunu
793f87fd61
fix(Core/GameObject): Use correct spell at meeting stone ( #19311 )
...
* fix(Core/GameObject): Use correct spell at meeting stone
* cleanup
2024-07-09 19:39:58 -03:00
avarishd
7d08758f1f
fix(Core/Totem): Totems shouldn't be immune to intervene. ( #19372 )
...
* fix(Core/Totem): Totems shouldn't be immune to intervene
* cs is my enemy
2024-07-09 14:39:05 -03:00
Jelle Meeus
ee4d728573
fix(Core/Pets): Correct Pet size for pets 3 ( #19319 )
...
* revert
* override maxScale for some families
add more families
sort
* add turtle
2024-07-09 14:16:30 -03:00
sudlud
37e3d89f91
fix(CI): linux-build: add -Werror parameter ( #19240 )
...
* fix(CI): linux-build: add -Werror parameter
* add KI
tzunu
* Revert "feat(CI): enable fail-fast for pch/nopch (#19058 )"
This reverts commit 564cbca7d3 .
* Update midsummer.cpp - drop unused variable
* initialize variable
* Update core-build-nopch.yml - drop gcc12
* fix(Core/CalendarMgr): do not use element after delete, but before
* attempt to fix Socket.h error
* Revert "attempt to fix Socket.h error"
This reverts commit c1a59145ed3c49d0f76be2f81925434ea969db97.
* fix Socket.h error - attempt 2
* Update Socket.h
* Update Socket.h
* npc_shattrath_daily_quest: init variable templateID
* fix(Scripts/Karazhan): use size_t within loop in boss_shade_of_aran:Reset()
* boss_archimonde: drop unused variable
* Revert "fix(Scripts/Karazhan): use size_t within loop in boss_shade_of_aran:Reset()"
This reverts commit 1f71aaef256990c5cdc16561676be302c954ea9d.
* SmartScripts: SMART_TARGET_RANDOM_POINT: fix unintended fallthrough
* Revert "Revert "feat(CI): enable fail-fast for pch/nopch (#19058 )""
This reverts commit d13df293624e0f50d9374272bfd05ab56242511d.
---------
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
2024-07-07 22:00:24 +02:00