* fix(Core/AI): remove an unused variable
* Move variables at the end of each sections
* reorder several methods
* remove few inline defintions
* few codestyle fixes
* Init.
https: //github.com/vmangos/core/commit/7d2f1e2923734ea1b983eeaa0208cfd158d4af02
Co-Authored-By: ratkosrb <35845488+ratkosrb@users.noreply.github.com>
* Hackfix for pets.
* Whoops.
* Correct evade uses.
* Conflict.
* Actually fix grace timer.
* Add visibility distance check.
Creatures should always fail combat checks in the open world if they're outside of visibility distance, might not be the case for worldbosses.
---------
Co-authored-by: ratkosrb <35845488+ratkosrb@users.noreply.github.com>
* initial release
* fix reviews
* fix some typo and add new documetations for MotionMaster
* new update and fix the cli-codestyle
* fix typo
* fix reviews
* move several enum definitions in a new files
* move more things
* remove the include comment
* move the related code to CharmInfo in this own file
*original idea of Ovahlord
Co-Authored-By: Ovahlord <18347559+Ovahlord@users.noreply.github.com>
* fix clang build errors and few blank lines
* missing forward declaration
* new tentative to fix gcc/clang build
* add several include could be necessary for gcc/clang compilation
* .
* revert some include since the last AC update
* fix some loop inconsistencies
* align all enums in UnitDefine.h
---------
Co-authored-by: Ovahlord <18347559+Ovahlord@users.noreply.github.com>
* remove seed of corruption handling in unit.cpp
* add generic and warlock aurascript
add warlock aurascript
add enum
add generic aurascript
add OnRemove
2ff855054f (diff-ea612aafadff90005e88b243eb000369be9e5cb6f8dc85a008d31e42b156e0ec)
detonation threshold scaling added in: df5afca278
Co-authored-by: ariel- <ariel-@users.noreply.github.com>
* add LoS check to generic damage
* refactor 2 scripts to 1 with args
refactor const_cast to GetAura()->GetEffect(
refactor reduce a line
* fix detonation threshold scaling
changed SPELL_DIRECT_DAMAGE to DOT
* remove not needed IsExpired() check
removal upon expiration is notified by AURA_REMOVE_BY_EXPIRE
* update comment
* refactor script with args to single spellscript, fix detonate by evade
* refactor
detonation to Detonate()
rename amount to remainingDamage
remove no tneeded HealthBelowPctDamaged
* refactor to 2 spell scripts again
* rename detonation spell from seed_of_corruption to seed_of_corruption_damage
avoids confusion with seed of corruption (with dot effect)
---------
Co-authored-by: ariel- <ariel-@users.noreply.github.com>
* add Demonic Pact Aura script
2ff855054f (diff-ea612aafadff90005e88b243eb000369be9e5cb6f8dc85a008d31e42b156e0ec)
Co-authored-by: ariel- <ariel-@users.noreply.github.com>
* spell_warlock aura:spell_warl_demonic_pact_aura
* fixup! spell_warlock aura:spell_warl_demonic_pact_aura
* remove not needed spell correction, flag is already set
* subtract current proc bonus before calculating new bonus
* also increase healing done
* remove Demonic Pact handling in Unit
* refactor indent, remove bonus from spell group effects e.g. totem of wrath
* Revert "refactor indent, remove bonus from spell group effects e.g. totem of wrath"
This reverts commit 104041172d34f542cc934e9f468407c36912cc7f.
* refactor indent
* manually set proc cooldown
---------
Co-authored-by: ariel- <ariel-@users.noreply.github.com>
* fix(Core/Unit): Invalidate update object cache when changing health in the same world update tick.
Should fix an issue when the client sees dead NPCs when they are not.
* Fix styling
* Another codestyle fix
* chore(Core/DBC): define unused unknown dbc fields
* Name unused unknown dbc fields using WDBX and wowdev.wiki
* rename SpellShapeshiftEntry to SpellShapeshiftFormEntry to properly match the DBC used
* rename sSpellShapeshiftStore to sSpellShapeshiftFormStore to properly match the DBC used
* Comment out unused field for GlyphPropertiesEntry
* Comment out unused field for MapEntry
* forgot one
* SpellShapeshiftfmt to SpellShapeshiftFormfmt
* SpellShapeshiftFormEntryfmt
* feat(Core/Optimization): Optimize build of units update object by leveraging cache.
* Remove whitespaces.
* Add alternative hooks to handle transmog and other similar things.
* Fix build on some compilers.
* Fix codestyle
* Fix build again.
* Take into account updateType.
* Class Comparison Logic Encapsulation - Parity
* Add Context to IsClass
* Add Unit IsClass script hook
* Replace additional getClass with IsClass
* Update CanUseItem to replace getClass with IsClass
* Add separate context for pet vs ability
* Change Create to Init since not all referenced contexts are creation
* Align spacing in ClassContext
* Drop context on LFGManager max power
* Update IsClass context that wraps around Missle Barrage
* Rename context for swapping weapons
* Be more specific than CLASS_CONTEXT_TALENT
* Remove duplicate context
* Moved IsClass Hook to Player
* Removed unused parameter in virtual base function
* Added maybe_unused to IsClass virtual in order to compile
To match the override signature, the virtual base needs to include the parameter in question, so using [maybe_unused] to signal to the compiler to allow it
* Remove extra blank line
* Add ABILITY_REACTIVE context
* Add context for PET_CHARM
* Remove explicit nullopt check per review
* Code Readability - Change if to if else in pet
Due to the return pattern, this doesn't change functionality in any way
* Add OnPlayer to disambiguate
---------
Co-authored-by: NathanHandley <nathanhandley@protonmail.com>
