nchebrov/azerothcore-wotlk
1
0
Fork 0
mirror of https://github.com/mod-playerbots/azerothcore-wotlk.git synced 2026-01-22 05:06:24 +00:00
Code Issues Packages Projects Releases Wiki Activity
12,776 Commits 8 Branches 0 Tags
1c8644b3bc32a5f73cadd80616330454b394d4f1
Commit Graph

184 Commits

Author SHA1 Message Date
Elmsroth
729a1ff539 fix(Crash/Quest/Spell) : The Boon of Remulos (#18379) 
Fix the spell : https://www.wowhead.com/wotlk/spell=57678/emerald-acorn-effect
Used in quest : https://www.wowhead.com/wotlk/quest=13075/the-boon-of-remulos

The crashed was caused by a nullptr Excception. It also could be throuwn in another similar test that has also been fixed.
If the spell did not have a CastTimeEntry a nullptr Exception was not checked.
 2024-02-22 22:40:26 -03:00
Nathan Handley
df33a57b78 feat(Core/Unit): New helper IsClass and script hook OnPlayerIsClass (#18243) 
* Class Comparison Logic Encapsulation - Parity

* Add Context to IsClass

* Add Unit IsClass script hook

* Replace additional getClass with IsClass

* Update CanUseItem to replace getClass with IsClass

* Add separate context for pet vs ability

* Change Create to Init since not all referenced contexts are creation

* Align spacing in ClassContext

* Drop context on LFGManager max power

* Update IsClass context that wraps around Missle Barrage

* Rename context for swapping weapons

* Be more specific than CLASS_CONTEXT_TALENT

* Remove duplicate context

* Moved IsClass Hook to Player

* Removed unused parameter in virtual base function

* Added maybe_unused to IsClass virtual in order to compile

To match the override signature, the virtual base needs to include the parameter in question, so using [maybe_unused] to signal to the compiler to allow it

* Remove extra blank line

* Add ABILITY_REACTIVE context

* Add context for PET_CHARM

* Remove explicit nullopt check per review

* Code Readability - Change if to if else in pet

Due to the return pattern, this doesn't change functionality in any way

* Add OnPlayer to disambiguate

---------

Co-authored-by: NathanHandley <nathanhandley@protonmail.com>
 2024-02-10 12:25:00 -03:00
Nathan Handley
425a490a7b feat(Core/Unit): New helper HasActivePowerType and script hook OnPlayerHasActivePowerType (#18293) 
* Create HasActivePower for script intercept

* Replace relevant player-related getPowerType() comparators with HasActivePowerType

* Change OnPlayerHasActivePowerType to regular bool instead of optional

---------

Co-authored-by: NathanHandley <nathanhandley@protonmail.com>
 2024-02-09 06:27:02 -03:00
3ster
000ec142a2 Check if triggered spell has cast time (#18231) 
* Check if triggered spell has cast time

* Fix client crash upon manually cancelling finished spell
 2024-02-03 11:52:34 +01:00
Kitzunu
69dc8804e6 feat(Core/Spell): Add helper for TriggeredCastFlag (#18227) 
* feat(Core/Spell): Add helper for TriggeredCastFlag

* Lol

* fix build
 2024-01-26 13:51:42 +01:00
Andrew
5a4fdc7de4 fix(Core/Spells): Banish should only be dispelled by Mass Dispel (#17703) 
* fix(Core/Spells): Banish should only be dispelled by Mass Dispel

* Update Unit.cpp

* Update Unit.cpp
 2023-11-14 16:27:37 +01:00
Kitzunu
f757e93da5 refactor(Core/Misc): Make DeathState enum class (#17607) 2023-10-28 10:54:03 +02:00
avarishd
2cd4af9446 fix(Core/Spells): Allow casting ground mounts in water (#17481) 
https: //github.com/TrinityCore/TrinityCore/pull/17488

Co-authored-by: SnapperRy <19622383+SnapperRy@users.noreply.github.com>
 2023-10-10 20:23:45 -03:00
Kitzunu
b84596fcab chore(Scripts/DK): Move CheckCast to spell_dk_raise_ally script (#17221) 
* chore(Scripts/Spell): Move CheckCast to spell_dk_raise_ally script

* Update spell_dk.cpp

* Update spell_dk.cpp
 2023-09-17 03:05:10 +02:00
Francesco Borzì
5d01b700fd refactor(Core): remove unused imports (#17094) 2023-08-28 13:39:43 +02:00
Synful-Syn
6b583089f3 fix(Core/Spell): Stop Blink from the falling player to move upward by 1y and stop moving backward when facing a wall (#16657) 
* blink-bad-warps

* Change formatting of an if
 2023-08-25 09:14:27 -03:00
M'Dic
ab2c062f03 feat(core\dbc): item.dbc, sItemStore, item_dbc, item enforcement conf, subclass fix (#14675) 
feat (core\log\db): item.dbc and enforcement

dbc enforcement partial pick from tc: 0c44bd33ee

Custom Item for testing by menevia16a (SPP DEV VEIL)

feat (core\log\db): item.dbc and enforcement

Update Item.sql

Update DBCStores.cpp

Update World.cpp

Update ObjectMgr.cpp

further replacement from template to dbc lookup

further logging and implementation

cherry pick tc fd26c3c87c

replace with db lookup

update (sql): Murder all the backticks

line break fixit

fix (item_template): fix incorrect subclass

fix incorrect subclass matching with dbc enforcement

update: log correction for sub class

update log correction for sub class

add subclass to dbc enforcement

add subclass dbc enforcement since it is part of the item.dbc item_dbc

update (log): additional log

Co-authored-by: blub <trinity.michael_vincent@gmx.eu>
Co-authored-by: Shocker <511388+shocker@users.noreply.github.com>
Co-authored-by: Veil <1913466+menevia16a@users.noreply.github.com>
Co-authored-by: Shocker <43253032+shockerqt@users.noreply.github.com>
 2023-04-28 01:26:44 +02:00
Kitzunu
422db05290 fix(Core/Spell): Removed gathering failure chance from herbalism and … (#15423) 
fix(Core/Spell): Removed gathering failure chance from herbalism and mining nodes

* cherry-pick commit (052dfe27fc)

Co-authored-by: Tony Konzel <saxxonpike@gmail.com>
 2023-03-17 10:24:36 +01:00
Kitzunu
f039836a2f chore(Core/Misc): Change all TODO to doxygen comment (#14966) 2023-02-12 10:05:34 -03:00
UltraNix
3fee40be7d fix(Core/Creatures): Spells casted by player should tap the creature … (#14725) 
…only if in combat with it.
 2023-01-26 04:38:16 -03:00
UltraNix
0e1e8f27de fix(Core/Spells): Every spell casted by player should tap the creature. (#14037) 
Fixes #11888
 2023-01-06 00:51:54 +01:00
Kitzunu
4870b14b1f refactor(Core/Object): getLevel() -> GetLevel() (#14122) 
* refactor(Core/Object): getLevel() -> GetLevel()

* fix build and sneak some doxygen in

* codeSTLE

* codestyle
 2022-12-31 17:39:23 +01:00
UltraNix
4ef1010f37 fix(Core/Spells): Maelstrom Weapon should not reset attack timers. (#13504) 
Fixes #13179
 2022-10-29 07:13:09 -03:00
M'Dic
2e6f6e26da Add (core\db): Support for Homebind Orientation (#13389) 
Add (core\db) Support for Homebind Orientation
 2022-10-12 14:39:02 -04:00
UltraNix
e390087efd feat(Core/Items): Implemented elemental weapon damage. Source: Trinit… (#13050) 
...yCore.
 2022-10-08 14:34:52 -03:00
Angelo Venturini
ad4ce0895f fix: Qaston revert (#13320) 
* Revert "fix(Core/QAston): fixed shields oneshotting (#13271)"

This reverts commit e05f61d1b3.

* Revert "fix(Core): Crash (#13292)"

This reverts commit a818bcf3e2.

* Revert "fix: Crash (#13241)"

This reverts commit be423a91b5.

* delete sql

* Revert "refactor(Core/Spells): Implement QAston Proc System (#11079)"

This reverts commit cbd3fd0967.

* add sql revert

* fix sql

* remove update from world.updates
 2022-10-05 21:53:20 +02:00
Angelo Venturini
be423a91b5 fix: Crash (#13241) 2022-10-03 16:14:43 -03:00
Angelo Venturini
590525b86c fix: Crash (#13230) 2022-10-02 22:35:45 -03:00
IntelligentQuantum
cbd3fd0967 refactor(Core/Spells): Implement QAston Proc System (#11079) 
* .

* sql

* .

* .

* 1

* 2

* 3

* 4

* 5

* 6

* 7

* 8

* 9

* 10

* 11

* 12

* 13

* 14

* 15

* Update spell_item.cpp

* Update Unit.cpp

* 16

* 17

* 18

* 19

* 20

* 21

* Update Unit.cpp

* REVERT UltraNIX Commit

* 22

* 23

* .

* .

* .

* warrior

* warlock

* shaman rogue priest paladin mage

* spell item

* hunter

* druid

* dk

* war

* error style

* Update rev_1647677899565690722.sql

* Update rev_1647677899565690722.sql

* Update rev_1647677899565690722.sql

* .

* DOND DEL ME WAD DO DO

* error 2

* .

* .

* .

* FIX

* Update SpellInfoCorrections.cpp

* Update SpellInfoCorrections.cpp

* .

* ja genau

* Update .gitignore

* .

* .

* .,

* .

* .

* .

* .

* Update Unit.cpp
 2022-10-02 19:39:34 +02:00
M'Dic
33fcab0917 fix (core): Log correction (#13181) 
fix (core): Commit LOG correction
 2022-10-01 09:45:29 -04:00
UltraNix
f658c8ea0c fix(Core/Spells): Fingers of Frost should always proc alongside with … (#13008) 
...Frostbite.
 2022-09-19 00:52:37 -03:00
ZhengPeiRu21
1ddd884d6a feat(Core): Implement SP Bonus Coefficients from DBC (#12562) 
* cherry-pick commit (1826437c09)

* Co-authored by: ariel- <ariel-@users.noreply.github.com>

* feat(Core): Implement SP Bonus Coefficients from DBC

* Several coefficient corrections

* Fix spell_dru_lifebloom
 2022-09-17 11:09:04 +02:00
UltraNix
577a0a1f3e fix(Core/Spells): Improved Blink in WSG near NE huts. (#13012) 2022-09-13 22:54:05 -03:00
UltraNix
ea7f86ae64 fix(Core/Spells): Fixed ground destination of Blink. (#13009) 
Fixes #11721
 2022-09-13 22:51:40 -03:00
UltraNix
2ef8d2e1e2 fix(Core/Spells): Revive Pet cannot be cast if there is not pet to resurrect (#12818) 
- Closes #12776
 2022-09-12 03:01:53 +02:00
Maelthyr
d0d1671745 feat(Core/Debug): GetDebugInfo implementation (#12705) 
Cherry-pick: 9a924fb9d5

Co-authored-by: jackpoz <giacomopoz@gmail.com>

Co-authored-by: jackpoz <giacomopoz@gmail.com>
 2022-08-15 09:43:41 -03:00
Nefertumm
c806c62c62 fix(Core/Spells): Crashfix (#12609) 2022-08-03 09:05:24 -03:00
UltraNix
346150c92a fix(Scripts/ZulGurub): Hakkar's Blood Siphon (#12196) 2022-07-09 11:05:09 -03:00
UltraNix
d41cf026e0 fix(Core/Spells): Fixed calculating LoS checks for spells casted by g… (#12091) 
fix(Core/Spells): Fixed calculating LoS checks for spells casted by gameobjects.

Fixed #12066
 2022-06-18 11:05:18 -04:00
UltraNix
f28c678c14 fix(Core/Spells): Hunter traps should not be activated by targets not… (#11971) 
fix(Core/Spells): Hunter traps should not be activated by targets not in LoS.

Fixes #11432
 2022-06-06 09:03:24 -03:00
UltraNix
55720eedd3 fix(Scripts/Spells): Sweeping Strikes - improvements. (#11666) 
* fix(Scripts/Spells): Sweeping Strikes - improvements.

Fixes #11594

* Buildfix.
 2022-05-23 05:49:56 -03:00
UltraNix
99f1cd84e2 fix(Core/Spells): Improvements to Far Sight spell: (#11683) 
* fix(Core/Spells): Improvements to Far Sight spell:

Far Sight should not interrupt while casting another spell.
Corrected setting Far Sight object as an active object.
Fixed grid activation range for active dynamic objects.
When Far Sight is over, the camera be reset to player.
Enable swapping camera between Far Sight and Sentry Totem.
Fixes #6368

* Update.

* Update.
 2022-05-23 04:26:51 -03:00
天鹿
0c0a2eac3b fix (core): Build Fix (#11723) 
* Update Spell.cpp
 2022-05-12 10:43:07 -04:00
UltraNix
0d4adf5a3e fix(Core/Spells): Blink. (#11663) 
* fix(Core/Spells): Blink.

Fixes #6427
Fixes #7571

* Update.
 2022-05-10 22:37:53 +02:00
IntelligentQuantum
59e45c251e fix(Core/Spell): Improvements to path generation for Charge mechanic (#11534) 
It has its flaws but it can be improved and it's actually a lot better than what we currently have.
 2022-04-27 20:18:44 -03:00
acidmanifesto
f2de895921 fix(core): Null check the helpers (#11476) 
* fix (core): move helper

* Update Spell.cpp

* Update Unit.cpp
 2022-04-22 10:11:06 -03:00
Kitzunu
90c47ca61a fix(Core/Spell): Move SelectTrajTarget log to Debug (#11465) 
* closes https://github.com/azerothcore/azerothcore-wotlk/issues/6785
 2022-04-21 18:22:37 +02:00
acidmanifesto
d38b6ce0db Feat: (core) Additional Helper (#11457) 
* Feat: (core) Additional Helper
 2022-04-21 06:06:22 -04:00
UltraNix
3d609bfd24 fix(Core/Spells): Send proper caster's guid in SMSG_SPELL_START/SMSG_SPELL_GO packets in case of spells casted originally by gameobjects. (#11337) 
Added visual channeling when mind controlling Razorgore by player.
Fixes #11275
 2022-04-15 12:16:02 -03:00
UltraNix
47790c9714 fix(Core/Vmaps): Stop M2s from occluding for spellcast LoS. Original autho… (#11341) 
* Core/Vmaps: Stop M2s from occluding for spellcast LoS. Original authors: @Shauren & @HelloKitty

Fixes #11293

* buildfix.

Co-Authored-By: HelloKitty <5829095+HelloKitty@users.noreply.github.com>
 2022-04-10 09:24:35 -03:00
Kitzunu
b709a22ddc feat(Core/Players): PlayerFlag helpers (#11294) 
* feat(Core/Players): PlayerFlag helpers

* Update Player.h

* fix build
 2022-04-05 18:53:50 +02:00
UltraNix
341154fee4 fix(Core/Spells): Fixed displaying runes cooldowns. (#11250) 
Fixes #11186
 2022-04-02 07:27:33 -03:00
UltraNix
4845086e32 fix(Core/Spells): Do not reset periodic timers for auras with multiple stacks. (#11167) 
Fixes #11126
 2022-04-01 07:09:48 -03:00
Kitzunu
856aed6fc6 feat(Core/Unit): New helpers for UnitFlag and UnitFlag2 (#11227) 2022-03-30 07:59:42 -03:00
Kitzunu
54c06eb72e fix(Core/Misc): Update some log errors to debug (#11225) 2022-03-30 09:47:53 +02:00