Commit Graph

3014 Commits

Author SHA1 Message Date
Saqra1
c42b3ee258 fix(Core/Pet): Control Infernal without enslave (#19784)
Check SummonProperties Category(Control) too to decide the type of
controls a Guardian should have.

Don't enslave Warlock's Infernal
2024-09-11 11:18:13 -03:00
Benjamin Jackson
00e35a201e fix(Core/AI): Reduce movement leash extension interval. (#19923)
* Init.

* Use GetGameTime() instead of system call.

Co-Authored-By: Anton Popovichenko <walkline.ua@gmail.com>

* Update leash timer if rooted.

* Remove unnecessary checks, add extension for fanning.

More parity with VMaNGOS implementation.

---------

Co-authored-by: Anton Popovichenko <walkline.ua@gmail.com>
2024-09-11 03:25:32 -03:00
天鹿
fafd351e44 fix(Core/AI): creature leashing behavior. (#19897)
* Update Unit.cpp

* Update TargetedMovementGenerator.cpp

* Update Unit.cpp

* Update Unit.cpp
2024-09-09 07:07:11 -03:00
Benjamin Jackson
b47b5d2c51 fix(Core/AI): Initialize movement leash timer to five seconds. (#19898)
Init.

https: //github.com/vmangos/core/commit/c8510cbbd4dccbdac9900cc507910ef3ae0e6c43

Co-authored-by: ratkosrb <35845488+ratkosrb@users.noreply.github.com>
2024-09-08 21:44:09 -03:00
Benjamin Jackson
cdc00b42bd fix(Core/AI): Add back leash update. (#19916)
Init.
2024-09-08 20:49:28 +02:00
Stefano Borzì
0dd5c6e3b4 feat(Battlegrounds): make it compatible with custom arena type (#18679)
* feat(Battlegrounds): make it compatible with custom arena type

* fix(BattlegroundQueue.cpp): ignore bg for arena condition

* feat(Scripting): add OnQueueUpdateValidity hook

* fix: codestyle
2024-09-08 20:05:58 +02:00
天鹿
e7448f2986 fix(Scripts/Commands): .gps formatting transport offset (#19890)
* Update cs_misc.cpp

* Update PlayerUpdates.cpp
2024-09-07 01:03:41 -03:00
天鹿
dd2167b00b fix(Core/AI): Creature SetInCombatState Leashing. (#19889)
* Update Unit.cpp

* Update pit_of_saron.cpp

* Update Unit.cpp
2024-09-07 01:03:19 -03:00
Benjamin Jackson
632d7f5f9e fix(Core/Unit): Add leash extension with damage dealt. (#19880)
Init.
2024-09-06 17:02:53 -03:00
天鹿
9dae87595d fix(Core/Creature): Creature Scale. (#19722)
Update Creature.cpp
2024-09-05 11:56:17 -03:00
Stefano Borzì
e5e514bbbe feat(Core/Scripting): add OnBeforeArenaCheckWinConditions hook for mod-arena-replay compatibility (#19856) 2024-09-04 10:33:38 -03:00
Benjamin Jackson
bf18b9bdfb fix(Core/AI): Improve creature leashing behavior. (#19751)
* Init.

https: //github.com/vmangos/core/commit/7d2f1e2923734ea1b983eeaa0208cfd158d4af02
Co-Authored-By: ratkosrb <35845488+ratkosrb@users.noreply.github.com>

* Hackfix for pets.

* Whoops.

* Correct evade uses.

* Conflict.

* Actually fix grace timer.

* Add visibility distance check.

Creatures should always fail combat checks in the open world if they're outside of visibility distance, might not be the case for worldbosses.

---------

Co-authored-by: ratkosrb <35845488+ratkosrb@users.noreply.github.com>
2024-09-03 21:08:56 +02:00
Benjamin Jackson
1edac37ac3 refactor(Core): Make more use of helpers. (#19835)
* Init.

* Reword.

* Update codestyle script.

Co-Authored-By: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* Add gameobject type ID check, reorder checks.

* Add helper/codestyle check for unit type.

* `IsUnit()` -> `IsCreature()`

* Add `IsUnit()` method.

* Use type mask.

https: //github.com/TrinityCore/TrinityCore/commit/cc71da35b5dc74abf71f8691161525a23d870bb5
Co-Authored-By: Giacomo Pozzoni <giacomopoz@gmail.com>
Co-Authored-By: Ovahlord <18347559+Ovahlord@users.noreply.github.com>

* Replace instances of `isType` with `IsUnit`.

---------

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
Co-authored-by: Ovahlord <18347559+Ovahlord@users.noreply.github.com>
2024-09-03 14:41:31 -03:00
Benjamin Jackson
e3e4133e88 fix(Core/Handlers): Only remove emote if player is moving. (#19740)
Init.
2024-09-03 13:12:32 -03:00
Anton Popovichenko
9999a80c96 feat(Core/Achievements): Add possibility to complete achievements and update achievement criteria for offline players. (#19851) 2024-09-03 13:05:23 -03:00
Grimdhex
221dbd3fdb chore(Apps/Codestyle): add new codestyle checks for pointers and range loops (#19841)
* chore(Apps/Codestyle): add new codestyle checks for pointers and range loops

* revert a typo
2024-09-03 13:02:38 -03:00
sudlud
c929b95172 fix(Conf): sync default values with core defaults (#19708)
fix(Conf): sync values with core defaults
2024-09-03 08:02:28 -03:00
Kitzunu
9af86553c5 chore(Core/Misc): update floor and ceil to std (#19837) 2024-09-03 08:01:00 -03:00
Kitzunu
de2bcbdabf refactor(Core/Misc): Acore::StringFormat to fmt format (#19838)
refactor(Core/Utilities): Acore::StringFormat to fmt format

* closes https://github.com/azerothcore/azerothcore-wotlk/issues/10356
2024-09-03 07:59:37 -03:00
Andrew
0954e314a0 fix(Scripts/BlackTemple): Fix Zerevor not casting Dampen Magic OOC (#19768)
* fix(Scripts/BlackTemple): Fix Zerevor not casting Dampen Magic OOC

* Update boss_illidari_council.cpp

* recast every 1min

* implement the recast checks

* Update CreatureAI.h

* Update boss_illidari_council.cpp

* Update boss_illidari_council.cpp

* fix ooc cast

* Update boss_illidari_council.cpp

* always respect the 60s lock

* Update boss_illidari_council.cpp

* Update boss_illidari_council.cpp
2024-09-02 20:44:34 -03:00
Benjamin Jackson
0158fa3e9e fix(Core/Handlers): Don't allow data to be sent while not grouped. (#19852)
Init.

https: //github.com/TrinityCore/TrinityCore/commit/f57647287af1f47a1c4a503cde654d6ff8f4261c

Co-authored-by: Shauren <shauren.trinity@gmail.com>
2024-09-02 15:22:01 -03:00
Jelle Meeus
0504c7f9de fix(Core/GameObject): fixup allow use of Mage portal if caster is offline and still in group (#19853)
* fix portals

* fixup! fix portals

* fixup! fixup! fix portals
2024-09-02 14:00:15 -03:00
Jelle Meeus
e1abc72a25 fix(Core/Spell): warrior stances proccing darkmoon card vengeance damage (#19796)
add spellinfocorrection
2024-09-01 20:58:03 -03:00
Saqra1
62b825f8bd fix(Core/Movement): Don't move for change in orientation only (#19687)
Changing only the orientation of a unit also flags it as if it were
moving, which causes spells to be interrupted.
2024-09-01 20:57:17 -03:00
Jelle Meeus
5d4c85143c fix(Core/GameObject): Allow use of Mage portal if caster is offline and still in group (#19797)
search group of user for ownerGUID
2024-09-01 20:56:05 -03:00
Benjamin Jackson
888aa00cfb fix(Core/Guild): Require repair rights in order to make use of guild repairs. (#19836)
* Init.

* Ensure only repair requests are screened.

* Adjust parentheses.
2024-09-01 00:48:13 -03:00
Kitzunu
5d31b9f98f refactor(Core/Item): Add helpers (#19828) 2024-08-31 19:38:50 -03:00
Benjamin Jackson
f88812443d refactor(Core): Correct typo. (#19830)
Init.
2024-08-31 17:38:03 -03:00
Walter Pagani
3b45e90e41 fix(Scripts/ICC): NPC Muradin Dialogues (#18931)
Co-authored-by: Meji <alvaro.megias@outlook.com>
Co-authored-by: 天鹿 <18535853+PkllonG@users.noreply.github.com>
2024-08-31 17:34:56 -03:00
Carriola-wotlk
9ae19e5429 fix(DB/Item): Feathermoon Headdress has the wrong stats (#19814)
* fix(DB/Item): Feathermoon Headdress has the wrong stats

* ITEM_MOD_SPELL_DAMAGE_DONE deprecated check removed
2024-08-31 12:22:18 -03:00
Grimdhex
5ab142af93 fix(Core/AI): remove an unused variable in ScriptedAI (#19816)
fix(Core/AI): remove an unused variable
2024-08-31 11:05:18 -03:00
Benjamin Jackson
8874953862 fix(Core/CharmInfo): Respect charm spell indices when adding to action bar. (#19811)
Init.
2024-08-31 10:36:57 -03:00
ianmeesters
a83cd03bfb feat(Core/Player): add OnCalculateTalentsPoints hook (#19749)
* playerTalentsHook

* oeps :#

* :#

* does this work?

* make reference

---------

Co-authored-by: Amy Fang <amy@cavemail.ddns.net>
2024-08-30 09:06:07 -03:00
Gultask
8852f0c74c feat(Core/SmartScripts): Implement Scripted Spawn System (#19499)
* prespawn2

* pfta

* Update rev_1717715555182000500.sql

* Update rev_1717715555182000500.sql

* Update rev_1717715555182000500.sql

* Update rev_1717715555182000500.sql

* Update rev_1717715555182000500.sql

* Update rev_1717715555182000500.sql
2024-08-28 08:18:02 -03:00
Grimdhex
2f85097413 docs(Core): improve several functions documentation (#19677)
* initial release

* fix reviews

* fix some typo and add new documetations for MotionMaster

* new update and fix the cli-codestyle

* fix typo

* fix reviews
2024-08-28 08:17:24 -03:00
Anton Popovichenko
9144031ed9 fix(Core/Pool): Fix degradation of pools over time (#19750) 2024-08-28 08:14:08 -03:00
Benjamin Jackson
b595586bf0 refactor(Core/SpellMgr): Remove nested ifs for binary evaluation. (#19762)
* Init.

Co-Authored-By: Anton Popovichenko <walkline.ua@gmail.com>

* Whitespace.

* Tiny nitpick.

Co-Authored-By: Anton Popovichenko <walkline.ua@gmail.com>

* Tiny nitpick.*

Today Bench learns the difference between break and continue.

Co-Authored-By: Anton Popovichenko <walkline.ua@gmail.com>

* Parentheses warnings.

* Apply suggestion.

Co-Authored-By: Anton Popovichenko <walkline.ua@gmail.com>

---------

Co-authored-by: Anton Popovichenko <walkline.ua@gmail.com>
2024-08-28 08:13:42 -03:00
Benjamin Jackson
5ffbfdd5d6 fix(Core/Creature): Fix grace period for can attack check. (#19763)
Init.
2024-08-28 08:13:06 -03:00
Benjamin Jackson
8f335bbc2b fix(Core/SpellMgr): Remove binary attribute from Drain Soul. (#19760)
Init.
2024-08-27 15:17:54 -03:00
Andrew
83f8871c31 refactor(Core/BossAI): Improve the ScheduleHealthCheck() code (#19743)
* refactor(Core/BossAI): Improve the ScheduleHealthCheck() code

* Update ScriptedCreature.cpp

---------

Co-authored-by: sudlud <sudlud@users.noreply.github.com>
2024-08-26 14:44:05 -03:00
Tereneckla
f2ed6f791b fix (Core/Unit): add AutoRpeatSpell delay to Auto Shot as well (#19603)
Update Unit.cpp
2024-08-26 07:20:23 -03:00
Saqra1
68402b6d91 fix(Core/Spell): Reset cd on some channeled spells (#19696)
If a spell is both channeled and has SPELL_ATTR0_COOLDOWN_ON_EVENT
attribute (only rituals) is channeled for its full duration, it goes on
an infinite cooldown. The client needs to be notified when the ritual
ends without being completed.
2024-08-25 23:43:01 -03:00
Kitzunu
1bfcc0e469 fix(Core/BG): Fix fmt issue for bg sent notifications (#19718)
* closes https://github.com/azerothcore/azerothcore-wotlk/issues/19559
2024-08-25 19:22:37 -03:00
Andrew
c5399509e6 refactor(Scripts/TempleOfAhnQiraj): Clean up Cthun script (#19736)
* refactor(Scripts/TempleOfAhnQiraj): Clean up Cthun script

* Update boss_cthun.cpp

* Update boss_cthun.cpp
2024-08-25 16:46:24 -03:00
Grimdhex
643362d697 refactor(Core/Object): adds consistency in the use of type object check (#19671) 2024-08-25 09:57:37 -03:00
Grimdhex
61f3a631c3 fix(Server): remove double blank lines at the end of several files (#19735) 2024-08-25 07:21:14 -03:00
sudlud
30a790117b fix(Core/WorldSocketMgr): sync default Network.OutUBuff with worldser… (#19702)
* fix(Core/WorldSocketMgr): sync default Network.OutUBuff with worldserver.conf.dist

* Update WorldSocketMgr.cpp
2024-08-23 06:38:00 +02:00
Tereneckla
3419f0246b fix (Core/Spells) partially revert #19529 (#19703)
Update Spell.cpp
2024-08-22 20:36:39 -03:00
Andrew
c0b6eae0e1 fix(Core/Spells): Fix movement impairment auras not being removed (#19684) 2024-08-22 15:09:43 -03:00
Kitzunu
eb410d6ab2 refactor(Core/Battleground): rewrite SpiritOfCompetitionEvent() (#19675)
* Use DoForAllPlayers

* Change to void - we don't need to return a value

* Better readability
2024-08-22 19:24:08 +02:00