Commit Graph

405 Commits

Author SHA1 Message Date
Letic92
4199cb8ce0 (Scripts/Ahnkahet): Fixed problem gathering GUIDS from bosses. (#18689) 2024-04-09 16:09:55 -03:00
chaosua
4e95c9e006 (Instance/Culling of Stratholme/Trial of Crusader) removed duplicated gossip_menus, fixed hardcoded texts (#18516)
* (Instance/Culling of Stratholme) removed duplicated gossip_menus, fixed hardcoded texts

* Update culling_of_stratholme.sql

* Update culling_of_stratholme.sql

* (Instance/TrialOfTheCrusader) fixed hardcoded text from Jaraxxus text line
boss_twin_valkyr: removed unnececarry random txt line select (already exist groupid 6 id 0 and 1 in creature_text)
added ruRU locale for Acidmaw and Dreadscale GroupID 2

* move sqls

* Update culling_of_stratholme.sql

* Update data/sql/updates/pending_db_world/culling_of_stratholme.sql

Co-authored-by: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>

* Update culling_of_stratholme.sql

* update naming of variables to better understand the sequence of events

* Change locale attribute to Locale

I'm not 100% sure, but since in Linux, uppercase and lowercase letters represent different values, I think that's why it doesn't pass the tests. In Windows nothing happens, but in Linux there are 2 different attributes.

* strange MySQL in Linux

* Update trial_of_crusader.sql

* updated sequence of txt lines with cityman before Malganis appear according to @Trinitycore enum RPEventLines2
combine all SQL in 1 file

---------

Co-authored-by: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>
Co-authored-by: Walter Pagani <paganiwalter@gmail.com>
2024-03-24 16:47:34 +01:00
Andrew
6df652a8dd fix(Core/Creature): Prevent combat movement disabled creatures from r… (#18428)
* fix(Core/Creature): Prevent combat movement disabled creatures from repositioning if target moves within model boundary

* fixbuild

* Apply suggestions from code review
2024-02-27 10:11:39 -03:00
Nathan Handley
df33a57b78 feat(Core/Unit): New helper IsClass and script hook OnPlayerIsClass (#18243)
* Class Comparison Logic Encapsulation - Parity

* Add Context to IsClass

* Add Unit IsClass script hook

* Replace additional getClass with IsClass

* Update CanUseItem to replace getClass with IsClass

* Add separate context for pet vs ability

* Change Create to Init since not all referenced contexts are creation

* Align spacing in ClassContext

* Drop context on LFGManager max power

* Update IsClass context that wraps around Missle Barrage

* Rename context for swapping weapons

* Be more specific than CLASS_CONTEXT_TALENT

* Remove duplicate context

* Moved IsClass Hook to Player

* Removed unused parameter in virtual base function

* Added maybe_unused to IsClass virtual in order to compile

To match the override signature, the virtual base needs to include the parameter in question, so using [maybe_unused] to signal to the compiler to allow it

* Remove extra blank line

* Add ABILITY_REACTIVE context

* Add context for PET_CHARM

* Remove explicit nullopt check per review

* Code Readability - Change if to if else in pet

Due to the return pattern, this doesn't change functionality in any way

* Add OnPlayer to disambiguate

---------

Co-authored-by: NathanHandley <nathanhandley@protonmail.com>
2024-02-10 12:25:00 -03:00
sudlud
186cb58a0f fix(Scripts/Dalaran): Update Toy Shop Toy Plane behaviour based on sniffs (#18239)
* fix(Scripts/Dalaran): Update Toy Shop Toy Plane behaviour based on sniffs

* update comments and waypoints for smoother movement

* move initalization to Reset() function
2024-02-03 15:11:36 +01:00
Anton Popovichenko
423b676802 fix(Scripts/IcecrownCitadel): Fix Sindragosa respawn (#18179)
Fix Sindragosa respawn
2024-01-16 08:37:05 -03:00
daobashun
bd296db80c fix(Scripts/IcecrownCitadel): Lich King Whispers uses localized languages (#18125) 2024-01-14 11:09:04 -03:00
IntelligentQuantum
4ec284577e chore(Scripts/Northrend): remove useless includes (#18061) 2023-12-25 02:15:56 -03:00
Andrew
54fab715a5 refactor(Scripts/UtgardeKeep): Clean up unused variables (#17985) 2023-12-11 04:31:24 -03:00
Tristan 'Natrist' Cormier
ac676f87ab chore(Core/Player): remove unused AnticheatSetSkipOnePacketForASH() function (#17947) 2023-12-09 01:09:52 +01:00
pedrohfm9
df5d618130 fix(Script/Stormpeaks) fix quest 12862 and 13060 When All Else Fails (#17916)
* fix(DB/Creature): Grunda Bronzewing is now mounted

Grunda Bronzewing is now mounted

* Update Fix-Grunda Bronzewing in Honor Hold is not riding on a golden gryphon.sql

Grunda Bronzewing is now mounted

* Rename Fix-Grunda Bronzewing in Honor Hold is not riding on a golden gryphon.sql to Fix-Grunda.sql

Grunda Bronzewing is now mounted

* Delete Fix-Grunda.sql

* Create fix_quest_12862_13060.sql

* Update zone_storm_peaks.cpp

* Update zone_storm_peaks.cpp

* Update zone_storm_peaks.cpp

* Update zone_storm_peaks.cpp

* Update zone_storm_peaks.cpp

* clean up redundancy

* Update fix_quest_12862_13060.sql

* Update zone_storm_peaks.cpp

* Update src/server/scripts/Northrend/zone_storm_peaks.cpp

* Update zone_storm_peaks.cpp

* fix_quest_12862_13060.sql

* delay spell cast by 1 sec

* Update zone_storm_peaks.cpp

---------

Co-authored-by: Skjalf <47818697+Nyeriah@users.noreply.github.com>
2023-12-03 13:11:28 -03:00
Winfidonarleyan
eb1ecc38a5 feat(Core/Scripting): move all script objects to separated files (#17860)
* feat(Core/Scripts): move all script objects to separated files

* Apply 5bfeabde81

* try gcc build

* again
2023-12-02 21:13:20 +01:00
Kitzunu
5bfeabde81 chore(Core/Misc): rename spellInfo pointers (#17914)
* Rename all
2023-12-02 06:03:15 -03:00
pedrohfm9
c02cccb87c fix(Scripts/SholazarBasin) update the code to ensure the vehicle catches fire (#17833)
* fix(DB/Creature): Grunda Bronzewing is now mounted

Grunda Bronzewing is now mounted

* Update Fix-Grunda Bronzewing in Honor Hold is not riding on a golden gryphon.sql

Grunda Bronzewing is now mounted

* Rename Fix-Grunda Bronzewing in Honor Hold is not riding on a golden gryphon.sql to Fix-Grunda.sql

Grunda Bronzewing is now mounted

* Delete Fix-Grunda.sql

* Update zone_sholazar_basin.cpp

* Update zone_sholazar_basin.cpp
2023-11-23 22:51:14 +01:00
qwe900
e8ccda12e4 fix(Scripts/ICC/Sindragosa) Airphase should not be forced after 50s if already in p2 (under 35%) (#17722)
* Update boss_sindragosa.cpp

* Update boss_sindragosa.cpp
2023-11-20 13:48:45 +01:00
Winfidonarleyan
e90d7a2f92 chore(Core/Misc): sort includes (#17776)
* chore(Cleanup): sort includes

* fix build

* fix build again
2023-11-18 17:51:26 +01:00
Andrew
055e2dc5ab refactor(Scripts/AhnKahet): Move Ancient Nerubian Device script to SAI (#17734) 2023-11-16 13:58:23 -03:00
KJack
3d20f8902b feat(Core/Instance): InstanceScript: create Remove functions (#17702)
InstanceScript: create `Remove` helper functions
2023-11-14 08:13:28 -03:00
Kitzunu
bbadc32bea Revert Visibility Notifier changes (#17682)
* Revert "fix(Core/Grid): Implement missing GridUnload setting (#17569)"

This reverts commit 79b39f9655.

* Revert "fix(Core/Grid): Address bugs and performance issues introduced by visibility notifier implementation (#17480)"

This reverts commit 60e27511c5.

* Revert "fix(Core): GridCleanUpDelay Log (#17436)"

This reverts commit 90b16ca065.

* Revert "feat(Core/Grids): Implement visibility notifier (#15919)"

This reverts commit 2779833768.
2023-11-12 00:48:49 +01:00
Kitzunu
f757e93da5 refactor(Core/Misc): Make DeathState enum class (#17607) 2023-10-28 10:54:03 +02:00
KJack
632b55faa5 fix (Scripts/ICC): Make Valithria starting health dynamic, fix broken channeling spell (#17586)
* Make Valithria starting health dynamic based on actual max health

* Fix Risen Archmage broken spell channel and combat log spam
2023-10-25 18:53:00 -03:00
Andrew
41dba1affb fix(Scripts/ObsidianSanctum): Fix Tenebron respawning (#17576)
fix(Scripts/ObsidianSanctum): Fix Shadron respawning
2023-10-25 06:14:09 -03:00
AG
60e27511c5 fix(Core/Grid): Address bugs and performance issues introduced by visibility notifier implementation (#17480)
* Bug fixes

- Corrected std::chrono from seconds to milliseconds
- Got rid of leftover code that caused objects to not show up on time

* Removed logic to set gameobject as active

- More alignement with TC.
- Reduces CPU usage drastically

* Revert back to using time_t instead of std chrono

* Invoke SetNoCreate() method to reduce CPU usage drastically

* Remove setActive from static and motion transports

* Fix performance issues

* Added SetFarVisible to WG and some dungeon scripts

- Also removed setActive(true) from creatures in Wintergrasp. As for gameobjects they are set to active upon being damaged/destroyed and removed from active on rebuild (reset)

* Removed comments related to VISIBILITY_COMPENSATION

* Fix log

* Deleted unused files + corrected a check

* Added missing header

* Removed unused parameter

* Removed another unsued parameter

* Changed vector to set for i_visibleNow

- Changed vector to set for i_visibleNow in VisibleNotifer
- Adjusted HaveAtClient to accept Object*
- Adjusted SendUpdateToPlayer to send createobject packet only if not known to client
2023-10-23 05:37:11 -03:00
Andrew
69418ab936 fix(Scripts/Ulduar): Don't treat Algalon respawns as if they were the… (#17562)
* fix(Scripts/Ulduar): Don't treat Algalon respawns as if they were the first pull

* Update boss_algalon_the_observer.cpp
2023-10-22 15:12:30 +02:00
avarishd
228f6635c0 fix(Core/Scripts): ScriptEffect Frog Kiss (#17482) 2023-10-21 09:15:20 -03:00
Skjalf
970c579547 fix(Scripts/Ulduar): Respawn Algalon on wipes (#17344) 2023-09-25 08:07:30 -03:00
Dan
189818e781 fix(Scripts/Ulduar): update Winter Jormungar and Snow Mound creature script (#17054)
* initial

* add auras

* spacing
2023-09-05 06:39:44 -03:00
Francesco Borzì
eaa6487fc2 refactor(Scripts): remove unused imports (#17097) 2023-08-27 22:25:22 -03:00
Anton Popovichenko
f4658a1df2 fix(Core/Scripts): Fix scripts where LoadObjectData can leave arrays boundaries. (#17070)
* fix(Core/Scripts): Fix scripts where LoadObjectData can leave arrays boundaries.

* Fix build
2023-08-25 09:15:07 -03:00
Anton Popovichenko
1a1a320ea1 fix(Scripts/Dragonblight): Fix crash from Wintergarde Gryphon. (#17032)
fix(Vehicle): Fix crash on ExitVehicle from Wintergarde Gryphon.
2023-08-19 22:30:39 +02:00
Roddan
e08ceb3d8d fix(Script/Quest): Doing Your Duty (#16923)
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2023-08-06 18:17:38 +02:00
UltraNix
c3acf75618 fix(Core/Spells): Taunt always set proper target while channelling sp… (#13948)
* fix(Core/Spells): Taunt always set proper target while channelling spells.

Fixes #13841

* Update.

* Update.
2023-08-06 03:16:05 +02:00
Kitzunu
34080692cb fix(Scripts/Ionar): Remove nature damage immunity (#16586) 2023-06-27 19:37:25 -03:00
pedrohfm9
3c401ad4ad fix(Scripts/HallsOfReflection): Improve Halls of Reflection Events (Horde) (#16165)
* fix(DB/Creature): Grunda Bronzewing is now mounted

Grunda Bronzewing is now mounted

* Update Fix-Grunda Bronzewing in Honor Hold is not riding on a golden gryphon.sql

Grunda Bronzewing is now mounted

* Rename Fix-Grunda Bronzewing in Honor Hold is not riding on a golden gryphon.sql to Fix-Grunda.sql

Grunda Bronzewing is now mounted

* Delete Fix-Grunda.sql

* Create Fix-NPCs_Halls_Off_Reflection.sql

* Fix-events_Halls_of_Reflection(HORDE)

* Rename Fix-NPCs_Halls_Off_Reflection.sql to Fix-NPCs_Halls_of_Reflection.sql

* Rename halls_of_reflection.cpp to fix halls_of_reflection.cpp

* Rename halls_of_reflection.h to fix halls_of_reflection.h

* Rename instance_halls_of_reflection.cpp to fix instance_halls_of_reflection.cpp

* Update fix halls_of_reflection.h

* Update and rename fix halls_of_reflection.cpp to halls_of_reflection.cpp

* Update and rename fix instance_halls_of_reflection.cpp to instance_halls_of_reflection.cpp

* Update instance_halls_of_reflection.cpp

* Update instance_halls_of_reflection.cpp

* Update instance_halls_of_reflection.cpp

* Update and rename fix halls_of_reflection.h to halls_of_reflection.h

* Update instance_halls_of_reflection.cpp

* Update halls_of_reflection.h

* Update Fix-NPCs_Halls_of_Reflection.sql

* Update halls_of_reflection.cpp

* Update halls_of_reflection.cpp

* Update halls_of_reflection.cpp

* Update halls_of_reflection.cpp

* Update halls_of_reflection.cpp

* Update halls_of_reflection.cpp

* Update halls_of_reflection.cpp

* Update halls_of_reflection.cpp

* Update halls_of_reflection.cpp

* Update instance_halls_of_reflection.cpp

* Update halls_of_reflection.h

* Update instance_halls_of_reflection.cpp

* Update halls_of_reflection.cpp

* Update halls_of_reflection.cpp

* Update halls_of_reflection.cpp

* Update halls_of_reflection.cpp

* Update halls_of_reflection.cpp

* Update halls_of_reflection.cpp

* Update Fix-NPCs_Halls_of_Reflection.sql

* Update halls_of_reflection.cpp

* Update halls_of_reflection.cpp

* Update and rename Fix-NPCs_Halls_of_Reflection.sql to Fix_NPCs_Halls_of_Reflection.sql

* Update halls_of_reflection.cpp

* Update halls_of_reflection.cpp

* Update Fix_NPCs_Halls_of_Reflection.sql

* Update Fix_NPCs_Halls_of_Reflection.sql

* Update Fix_NPCs_Halls_of_Reflection.sql

* Update Fix_NPCs_Halls_of_Reflection.sql

* Update Fix_NPCs_Halls_of_Reflection.sql

* Update Fix_NPCs_Halls_of_Reflection.sql

* Update Fix_NPCs_Halls_of_Reflection.sql

* Update src/server/scripts/Northrend/FrozenHalls/HallsOfReflection/instance_halls_of_reflection.cpp

* Update src/server/scripts/Northrend/FrozenHalls/HallsOfReflection/instance_halls_of_reflection.cpp

* Update src/server/scripts/Northrend/FrozenHalls/HallsOfReflection/instance_halls_of_reflection.cpp

* Apply suggestions from code review

* Update src/server/scripts/Northrend/FrozenHalls/HallsOfReflection/instance_halls_of_reflection.cpp

* Update src/server/scripts/Northrend/FrozenHalls/HallsOfReflection/instance_halls_of_reflection.cpp

---------
2023-05-13 15:25:53 -03:00
Grimgravy
09c40a8cd3 fix(Scripts/VioletHold): Activation Crystals (#13176)
* fix(Scripts/Activation Crystals): Instance The Violet Hold

* update

* Update violet_hold.cpp
2023-05-13 14:48:26 -03:00
daobashun
fa59b30184 fix(Scripts/IcecrownCitadel): Tirion Fordring attacks the Lich King empty-handed (#15823)
* Fixed Tirion Fordring's final stage attacking the Lich King empty-handed

* Tirion Fordring's uses text in BroadcastText to speak

* Code format changes

* Add data to the data table

* Update rev_1680658371591699800.sql

Change from INSERT to INSERT/INSERT

* Update and rename boss_the_lich_king.cpp to boss_the_lich_king.cpp的

Remove useless comments

* Rename boss_the_lich_king.cpp的 to boss_the_lich_king.cpp

The input method caused an unexpected rename

* Delete the extra rows

* Update boss_the_lich_king.cpp

Delete references that can be omitted
2023-04-26 23:04:37 -03:00
天鹿
df77b5f4f7 chore(core): cleanup code p3 (#16073)
* Update MMapMgr.cpp

* Update UpdateFetcher.cpp

* Update AuctionHouseMgr.cpp

* Update AuctionHouseMgr.h

* Update BattlegroundAV.cpp

* Update ChannelMgr.cpp

* Update ThreatMgr.h

* Update Player.h

* Update PlayerSettings.cpp

* Update ObjectMgr.cpp

* Update Guild.cpp

* Update Guild.h

* Update Map.cpp

* Update World.cpp

* Update boss_nefarian.cpp

* Update boss_prince_malchezaar.cpp

* Update boss_venoxis.cpp

* Update zone_elwynn_forest.cpp

* Update zulfarrak.cpp

* Update boss_novos.cpp
2023-04-24 08:13:07 -03:00
Eddy Vega
953b9aa8b7 fix(Scripts/Naxxramas): Improve Gothik's minions (#15979)
init
2023-04-21 15:03:04 -03:00
M'Dic
8aa2a2ac0f chore (core): Clean up (#15977)
* chore (core): Clean up

* Update SmartScript.cpp

* more clean up

* Update boss_xt002.cpp
2023-04-16 21:04:56 -04:00
avarishd
421f0644cd fix(Script/Ahnkahet): Jedoga Shadowseeke sacrifice (#15153)
* fix(Script/Instance): Jedoga Shadowseeke sacrifice

* build

* std::chrono
2023-04-09 15:57:04 -03:00
avarishd
619c9384d4 fix(Script/ToC5): Remove hardcoded text(s) and some minor adjustments. (#15046)
* remove hardcode + fix db incorrect duplicates

* cs

* cs2

* dual wield google translate (fix zhCN locale)

* doxygen todo

* ///
2023-04-09 15:54:33 -03:00
Skjalf
c9973f3a80 fix(Scripts/IcecrownCitadel): Fix Svalna crash (#15862) 2023-04-07 12:57:52 -03:00
Skjalf
e2cfb5c5a9 fix(Scripts/IcecrownCitadel): Fix Putricide crash (#15846) 2023-04-06 18:19:46 -03:00
Skjalf
67dd96e502 fix(Scripts/IcecrownCitadel): Fix Sindragosa's icewall poping up prem… (#15836)
fix(Scripts/IcecrownCitadel): Fix Sindragosa's icewall poping up prematurely
2023-04-05 16:36:18 -03:00
Skjalf
caf54517bf fix(Scripts/IcecrownCitadel): Fix possible crash if bosses engage off… (#15832)
fix(Scripts/IcecrownCitadel): Fix possible crash if bosses engage offline players
2023-04-05 13:40:21 -03:00
Skjalf
28c770a517 fix(Scripts/IcecrownCitadel): Prevent Sindragosa's landing trigger fr… (#15814)
fix(Scripts/IcecrownCitadel): Prevent Sindragosa's landing trigger from firing during combat
2023-04-04 08:34:30 -03:00
Skjalf
572a7ea60d feat(Scripts/IcecrownCitadel): Allow game masters to skip boss checks (#15810) 2023-04-03 23:29:51 -03:00
Skjalf
ea1eed7362 fix(Scripts/IcecrownCitadel): Script Sindragosa's respawn/waypoints (#15792) 2023-04-03 00:07:10 -03:00
avarishd
a8a3c4ed10 fix(Scripts/VioletHold): Remove hardcoded text and add some of the missing gossips. (#15058)
* Remove hardcode and add some of the missing gossip.

* cs

* {}

* ///
2023-04-02 15:37:21 -03:00
qwe900
c8c042d326 fix(Scripts/IcecrownCitadel): Fixing last issue on Nerubs in ICC (#15651)
now they fight after landing
2023-03-29 19:54:46 -03:00