Commit Graph

169 Commits

Author SHA1 Message Date
Francesco Borzì
cb7e28df05 refactor(src/server/game/*): remove unused imports (big part 1) (#20310) 2024-10-27 10:25:40 +01:00
Francesco Borzì
5a96ce283d refactor(Scripts): remove unused imports (#20086) 2024-09-29 13:20:21 +02:00
Kitzunu
386aea03ee chore(Core/Misc): Some cleanup (#19970)
* remove weird blanks

* update if

* ) ) to ))

* missed some ) )

* now switch

* .
2024-09-21 19:34:31 +02:00
Benjamin Jackson
1edac37ac3 refactor(Core): Make more use of helpers. (#19835)
* Init.

* Reword.

* Update codestyle script.

Co-Authored-By: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* Add gameobject type ID check, reorder checks.

* Add helper/codestyle check for unit type.

* `IsUnit()` -> `IsCreature()`

* Add `IsUnit()` method.

* Use type mask.

https: //github.com/TrinityCore/TrinityCore/commit/cc71da35b5dc74abf71f8691161525a23d870bb5
Co-Authored-By: Giacomo Pozzoni <giacomopoz@gmail.com>
Co-Authored-By: Ovahlord <18347559+Ovahlord@users.noreply.github.com>

* Replace instances of `isType` with `IsUnit`.

---------

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
Co-authored-by: Ovahlord <18347559+Ovahlord@users.noreply.github.com>
2024-09-03 14:41:31 -03:00
Grimdhex
643362d697 refactor(Core/Object): adds consistency in the use of type object check (#19671) 2024-08-25 09:57:37 -03:00
Grimdhex
61f3a631c3 fix(Server): remove double blank lines at the end of several files (#19735) 2024-08-25 07:21:14 -03:00
Benjamin Jackson
c8be582f81 fix(Scripts): Rewrite Level 70 Elite Tauren Chieftain. (#19546)
* Init.

* Despawn music doodad.

* Add conditions behind events invoking performances.

* Update music doodad intervals.

55639.

* Add condition for BRD performance.

Ensures that manual performance and event performance do not overlap.

* Add scripting for Shattrath Saul.

* Add scripts for Silvermoon band members.

All verified in Cata Classic 55639.

* Whoops.

* Styling, initial Blastbolt scripting.

I don't know how to handle the roadies yet. Ugh.

* Whoops.

* Bad event param.

* Remove drumset respawn from action list.

* Update Shattrath Saul's Perry Gatner scripting.

* Ugh.

Hate SAI.
2024-08-13 11:56:43 -03:00
Kitzunu
e4df159f5c refactor(Core/Chat): Move SendNotification to ChatHander (#19491)
* refactor(Core/Chat): Move SendNotification to ChatHander

* Update Battleground.cpp

* fix build

* Update src/server/game/Chat/Chat.h
2024-08-10 11:39:46 -03:00
Francesco Borzì
e592fdd248 refactor(Scripts/misc): remove unused imports (#19458) 2024-07-22 16:20:41 -03:00
Kitzunu
332446b8aa fix(Scripts/ChatLogger): Differentiate addon whisper from player whisper (#19441)
* fix(Scripts/ChatLogger): Differentiate addon whisper from player whisper

* closes https://github.com/azerothcore/azerothcore-wotlk/issues/19439
* closes https://github.com/azerothcore/azerothcore-wotlk/issues/17570

* fix build
2024-07-19 15:26:34 +02:00
Kitzunu
486cbb3970 fix(Scripts/ChatLog): Whoopsies (#19430) 2024-07-18 19:31:12 -03:00
Kitzunu
ab52e1f164 chore(Scripts/ChatLog): Cleanup the code (#19411)
* chore(Scripts/ChatLog): Cleanup the code

* Update chat_log.cpp

* remove more redundant code
2024-07-18 22:46:01 +02:00
avarishd
f510e122a0 fix(Script/Quest): Protecting Our Own (#19247)
* fix(Core/Spells): Gor'drek's Ointment

* Update spell_item.cpp

* ;
2024-07-17 13:19:48 +02:00
Kitzunu
275b8b5d7f chore(Scripts/ServerMail): Cleanup the code (#19412)
* chore(Scripts/ServerMail): Cleanup the code

* try to fix build error

* okay we resort to the AIs
2024-07-17 01:33:26 +02:00
Dinkledork
01f063e242 fix(Scripts/World): Emerald Dragons no longer have 0% health events (#18893)
Events happen at 75, 50 or 25 percent health and should not include 0%.
2024-06-29 06:13:14 -03:00
Jelle Meeus
e3da4e4986 refactor(Scripts/World): Spell Scripts registry macros (#19224)
* boss_emerald_dragons spell:spell_dream_fog_sleep

* boss_emerald_dragons spell:spell_mark_of_nature
2024-06-29 06:06:59 -03:00
Walter Pagani
77be5bb19d fix(Spells/SpellInfoCorrections) Remove friendly mask on goblins (#18912)
Co-authored-by: Jelle Meeus <sogladev@gmail.com>
2024-06-29 00:28:29 -03:00
Andrew
cfcb5d5bd7 fix(Scripts/NPC): Fix arcanite dragonling attacking non flagged players (#19039) 2024-06-10 23:07:48 +02:00
Anton Popovichenko
f792b0d708 feat(Core/Scripts): Optimize PlayerScripts by calling only overridden/implemented functions. (#18672)
* feat(Core/Scripts): Optimize PlayerScripts by calling only overridden/implemented functions.

* Fix codestyle.

* Fix typo

* PLAYERHOOK_END is not a hook

* Address code review feedback.

Co-authored-by: Winfidonarleyan <dowlandtop@yandex.com>

* Codestyle fixes

* Fix typo



Co-authored-by: PkllonG

---------

Co-authored-by: Winfidonarleyan <dowlandtop@yandex.com>
2024-04-11 17:08:30 -03:00
Andrew
6df652a8dd fix(Core/Creature): Prevent combat movement disabled creatures from r… (#18428)
* fix(Core/Creature): Prevent combat movement disabled creatures from repositioning if target moves within model boundary

* fixbuild

* Apply suggestions from code review
2024-02-27 10:11:39 -03:00
Andrew
413cde96dd refactor(Scripts/Areatrigger): Move Scholazar Waygate script to SAI (#18054)
* refactor(Scripts/Areatrigger): Move Scholazar Waygate script to SAI

* Update rev_1703449890835634600.sql
2024-01-01 14:01:16 +01:00
Andrew
d83d623792 chore(Scripts/World): Remove unused legacy scripts (#18048) 2023-12-24 08:04:37 -03:00
attacksnack
b0ebaf4c96 fix(Scripts/Spells): Fix Ritual of Souls with Improved Healthstone 2023-12-23 23:29:34 -03:00
Winfidonarleyan
eb1ecc38a5 feat(Core/Scripting): move all script objects to separated files (#17860)
* feat(Core/Scripts): move all script objects to separated files

* Apply 5bfeabde81

* try gcc build

* again
2023-12-02 21:13:20 +01:00
Winfidonarleyan
e90d7a2f92 chore(Core/Misc): sort includes (#17776)
* chore(Cleanup): sort includes

* fix build

* fix build again
2023-11-18 17:51:26 +01:00
Andrew
a5b5278929 refactor(Scripts/World): Clean up script files (#17728)
* refactor(Scripts/World): Clean up script files

* Update boss_azuregos.cpp
2023-11-16 14:00:42 -03:00
Kitzunu
f757e93da5 refactor(Core/Misc): Make DeathState enum class (#17607) 2023-10-28 10:54:03 +02:00
avarishd
5aca484574 fix(Core/Scripts): Venomhide Hatchling improvements (#17454) 2023-10-10 20:25:26 -03:00
avarishd
96d0675624 fix(DB/SAI): Cuergo's Gold improvements (#17462)
* fix(DB/SAI):  Cuergo's Gold improvements

* Actionlist

* zzz
2023-10-10 10:36:04 -03:00
Kitzunu
66066f508b fix(Scripts/Chat): Fix chat logger (#17102)
* fix(Scripts/Chat): Fix chat logger

* Update chat_log.cpp

* Update worldserver.conf.dist

* Update chat_log.cpp

* fix build

* oopsie

* fix clang
2023-09-16 08:17:42 +02:00
Francesco Borzì
5d01b700fd refactor(Core): remove unused imports (#17094) 2023-08-28 13:39:43 +02:00
Roddan
e08ceb3d8d fix(Script/Quest): Doing Your Duty (#16923)
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2023-08-06 18:17:38 +02:00
Grimgravy
c3c6ce9d7a fix(DB/Quest): improve A Dip in the Moonwell (#15259)
* fix(DB/Quest): improve A Dip in the Moonwell

* Add Npc Steam Tonk

* Update rev_1677930037418943000.sql

* Atualizar o rev_1677930037418943000.sql
2023-08-06 03:16:19 +02:00
Foereaper
cef0d6f652 fix(Scripts/World): Fix XP disable NPC script (#16828)
* Fix XP disable NPC script

* Re-add money logic

* Remove unintended whitespace
2023-07-31 09:18:27 -03:00
UltraNix
e1f869e756 fix(Core/Spells): Set Crashin' Thrashin' Robot duration to 3 min. (#15342)
* fix(Core/Spells): Set Crashin' Thrashin' Robot duration to 3 min.

Fixes #15220

* Update.

* missing sql.

* buildfix.

* Update src/server/scripts/World/npcs_special.cpp

---------

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2023-07-27 09:05:30 -03:00
Samsequel
3d00fb7948 fix(Script/Professions): Unlearn alchemy profession mastery at 325 (#16810) 2023-07-26 08:48:00 -03:00
KJack
2a6bb85540 fix(Scripts/Quest): Make quest "Triage" (6622/6624) completable (#16335)
* Resolves issue where patients were dying extremely quickly during the quest.

- updates other parameters to make the quest more Blizz-like and completable

* Correct starting patient count for Horde

* Correctly handle starting patient count for both factions.

* Whitespace removal

* Un-Pythonese variable name, slightly improve initial patient count call

* Match WotLK Classic timing for patient deaths
2023-06-01 08:38:52 -03:00
KJack
cafb8e3cfb fix(Scripts/Npc) Experience Eliminator only asks pertinent questions (#16310)
* Experience Eliminator will only ask you pertinent questions.

* Add brackets per AC code standards.
2023-05-27 23:07:40 -03:00
avarishd
8c9b4f1fb6 fix(DB/SAI): Port On Nethery Wing visuals from Trinity. (#15806)
* fix(DB/SAI): Port On Nethery Wing visuals from Trinity.

/TrinityCore/TrinityCore/issues/23905

Co-Authored-By: Dr-J <1444120+dr-j@users.noreply.github.com>

* increase SpellFocusObject from 90 to 150

* correct taxipath and add 4 spawns from TC

---------

Co-authored-by: Dr-J <1444120+dr-j@users.noreply.github.com>
2023-04-04 09:34:14 -03:00
UltraNix
213aaee42c fix(Scripts/Spells): Fixed Improved Healthstone not affecting Ritual … (#15588)
fix(Scripts/Spells): Fixed Improved Healthstone not affecting Ritual of Souls.

Fixes #15510
2023-03-29 00:31:36 -03:00
avarishd
d2c132772f fix(Script/Core): Remove hardcoded gossips in npc_taxi (#15052) 2023-03-17 17:38:25 +01:00
UltraNix
6a66b36a5d fix(Scripts/Creatures): Fixed some profession trainers. (#15349) 2023-03-13 08:18:44 -03:00
UltraNix
3f25a70934 fix(Scripts/Achievement): Fixed Flirt With Disaster achievement. Sourc… (#15352) 2023-03-12 15:56:23 -03:00
Gultask
8cbe63f110 chore(Core/Scripts): Use serverside spell instead of SummonCreature for Nether-wraith Beacon (#15285) 2023-03-05 17:32:04 -03:00
avarishd
1c23bca9cb fix(Scripts/WorldNPCs): npcs_special hardcode removal and fixes. (#15240) 2023-03-04 17:37:15 -03:00
Kitzunu
bd6034e1a9 refactor(Core/AI): Some more refactoring prep for Comat Threat system… (#15026)
Co-authored-by: Treeston <14020072+Treeston@users.noreply.github.com>
2023-02-13 21:39:40 +01:00
Kitzunu
f039836a2f chore(Core/Misc): Change all TODO to doxygen comment (#14966) 2023-02-12 10:05:34 -03:00
Skjalf
bf30c66ba4 feat(Core/GameObject): Expand IsSummonedBy() to GameObjects (#14789)
Co-authored-by: jackpoz <giacomopoz@gmail.com>
2023-01-29 09:44:33 -03:00
Skjalf
b4e3f1310b feat(Core/Unit): Add KillSelf overload (#14785)
Co-authored-by: jackpoz <giacomopoz@gmail.com>
2023-01-28 17:57:23 -03:00
UltraNix
6889ed4f2a fix(Core/Items): Players should dismount upon using Brazier of Dancin… (#14055)
* fix(Core/Items): Players should dismount upon using Brazier of Dancing Flames.

Fixes #10327

* Update.
2023-01-06 00:52:23 +01:00