[Warnings] Fix warnings

This commit is contained in:
Yunfan Li
2024-06-22 18:48:20 +08:00
parent ab9339dffa
commit 4636b6e5b6
2 changed files with 8 additions and 4 deletions

View File

@@ -196,12 +196,13 @@ ItemUsage ItemUsageValue::QueryItemUsageForEquip(ItemTemplate const* itemProto)
Item* oldItem = bot->GetItemByPos(dest);
//No item equiped
if (!oldItem)
if (!oldItem) {
if (shouldEquip)
return ITEM_USAGE_EQUIP;
else {
return ITEM_USAGE_BAD_EQUIP;
}
}
ItemTemplate const* oldItemProto = oldItem->GetTemplate();
float oldScore = PlayerbotFactory::CalculateItemScore(oldItemProto->ItemId, bot);
@@ -215,12 +216,13 @@ ItemUsage ItemUsageValue::QueryItemUsageForEquip(ItemTemplate const* itemProto)
}
// Bigger quiver
if (itemProto->Class == ITEM_CLASS_QUIVER)
if (!oldItem || oldItemProto->ContainerSlots < itemProto->ContainerSlots)
if (itemProto->Class == ITEM_CLASS_QUIVER) {
if (!oldItem || oldItemProto->ContainerSlots < itemProto->ContainerSlots) {
return ITEM_USAGE_EQUIP;
else {
} else {
return ITEM_USAGE_NONE;
}
}
bool existingShouldEquip = true;
if (oldItemProto->Class == ITEM_CLASS_WEAPON && !sRandomItemMgr->CanEquipWeapon(bot->getClass(), oldItemProto))