From 4636b6e5b6325ec113c9b2e060009cd61286d21a Mon Sep 17 00:00:00 2001 From: Yunfan Li Date: Sat, 22 Jun 2024 18:48:20 +0800 Subject: [PATCH] [Warnings] Fix warnings --- src/PlayerbotAI.cpp | 2 ++ src/strategy/values/ItemUsageValue.cpp | 10 ++++++---- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/src/PlayerbotAI.cpp b/src/PlayerbotAI.cpp index 5ff7fd7d..310cc3ad 100644 --- a/src/PlayerbotAI.cpp +++ b/src/PlayerbotAI.cpp @@ -960,6 +960,8 @@ void PlayerbotAI::ChangeEngine(BotState type) case BOT_STATE_DEAD: // LOG_DEBUG("playerbots", "=== {} DEAD ===", bot->GetName().c_str()); break; + default: + break; } } } diff --git a/src/strategy/values/ItemUsageValue.cpp b/src/strategy/values/ItemUsageValue.cpp index ad4deb03..88d7e007 100644 --- a/src/strategy/values/ItemUsageValue.cpp +++ b/src/strategy/values/ItemUsageValue.cpp @@ -196,12 +196,13 @@ ItemUsage ItemUsageValue::QueryItemUsageForEquip(ItemTemplate const* itemProto) Item* oldItem = bot->GetItemByPos(dest); //No item equiped - if (!oldItem) + if (!oldItem) { if (shouldEquip) return ITEM_USAGE_EQUIP; else { return ITEM_USAGE_BAD_EQUIP; } + } ItemTemplate const* oldItemProto = oldItem->GetTemplate(); float oldScore = PlayerbotFactory::CalculateItemScore(oldItemProto->ItemId, bot); @@ -215,12 +216,13 @@ ItemUsage ItemUsageValue::QueryItemUsageForEquip(ItemTemplate const* itemProto) } // Bigger quiver - if (itemProto->Class == ITEM_CLASS_QUIVER) - if (!oldItem || oldItemProto->ContainerSlots < itemProto->ContainerSlots) + if (itemProto->Class == ITEM_CLASS_QUIVER) { + if (!oldItem || oldItemProto->ContainerSlots < itemProto->ContainerSlots) { return ITEM_USAGE_EQUIP; - else { + } else { return ITEM_USAGE_NONE; } + } bool existingShouldEquip = true; if (oldItemProto->Class == ITEM_CLASS_WEAPON && !sRandomItemMgr->CanEquipWeapon(bot->getClass(), oldItemProto))